Add support for Microsoft.Data.SqlClient 7.x.x#8346
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79b170fdca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-03-20 14:33:55 Comparing candidate commit adea202 in PR branch Found 4 performance improvements and 7 performance regressions! Performance is the same for 256 metrics, 21 unstable metrics.
|
79b170f to
703bca8
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8346) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (69ms) : 67, 71
master - mean (70ms) : 66, 73
section Bailout
This PR (8346) - mean (73ms) : 72, 74
master - mean (73ms) : 72, 74
section CallTarget+Inlining+NGEN
This PR (8346) - mean (1,044ms) : 1004, 1083
master - mean (1,051ms) : 995, 1106
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (108ms) : 105, 111
master - mean (107ms) : 104, 111
section Bailout
This PR (8346) - mean (108ms) : 106, 110
master - mean (109ms) : 107, 110
section CallTarget+Inlining+NGEN
This PR (8346) - mean (728ms) : 706, 750
master - mean (730ms) : 711, 750
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (96ms) : 94, 98
master - mean (96ms) : 93, 99
section Bailout
This PR (8346) - mean (96ms) : 94, 98
master - mean (96ms) : 94, 98
section CallTarget+Inlining+NGEN
This PR (8346) - mean (703ms) : 658, 748
master - mean (709ms) : 668, 751
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (94ms) : 91, 97
master - mean (94ms) : 92, 97
section Bailout
This PR (8346) - mean (96ms) : 94, 98
master - mean (95ms) : 93, 97
section CallTarget+Inlining+NGEN
This PR (8346) - mean (638ms) : 615, 661
master - mean (641ms) : 615, 667
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (195ms) : 191, 199
master - mean (196ms) : 191, 201
section Bailout
This PR (8346) - mean (198ms) : 195, 200
master - mean (198ms) : 194, 201
section CallTarget+Inlining+NGEN
This PR (8346) - mean (1,159ms) : 1105, 1212
master - mean (1,148ms) : 1097, 1199
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (279ms) : 273, 284
master - mean (277ms) : 273, 282
section Bailout
This PR (8346) - mean (281ms) : 274, 288
master - mean (279ms) : 274, 284
section CallTarget+Inlining+NGEN
This PR (8346) - mean (903ms) : 869, 936
master - mean (903ms) : 876, 929
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (272ms) : 266, 278
master - mean (272ms) : 266, 277
section Bailout
This PR (8346) - mean (273ms) : 267, 280
master - mean (271ms) : 267, 275
section CallTarget+Inlining+NGEN
This PR (8346) - mean (940ms) : 915, 965
master - mean (936ms) : 909, 963
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8346) - mean (272ms) : 263, 281
master - mean (271ms) : 263, 278
section Bailout
This PR (8346) - mean (272ms) : 266, 277
master - mean (271ms) : 266, 275
section CallTarget+Inlining+NGEN
This PR (8346) - mean (841ms) : 813, 868
master - mean (835ms) : 814, 855
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
703bca8 to
adea202
Compare
Summary of changes
Adds support for Microsoft.Data.SqlClient 7.x.x
Reason for change
We want to support the latest packages
Implementation details
.\tracer\build.ps1 CompileManagedSrc.\tracer\build.ps1 GeneratePackageVersions -IncludePackages Microsoft.Data.SqlClient --skipTest coverage
This is the test