ServiceNameSource for inferred proxy#8309
Conversation
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 29 occurrences of : + _dd.svc_src: aws-apigateway
1 occurrences of : + _dd.svc_src: azure-apim
|
BenchmarksBenchmark execution time: 2026-03-16 13:57:01 Comparing candidate commit 8d580b3 in PR branch Found 5 performance improvements and 6 performance regressions! Performance is the same for 167 metrics, 14 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8309) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (76ms) : 74, 78
master - mean (76ms) : 73, 78
section Bailout
This PR (8309) - mean (81ms) : 78, 83
master - mean (79ms) : 77, 82
section CallTarget+Inlining+NGEN
This PR (8309) - mean (1,099ms) : 1059, 1139
master - mean (1,103ms) : 1057, 1149
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (120ms) : 116, 125
master - mean (118ms) : 115, 122
section Bailout
This PR (8309) - mean (121ms) : 119, 124
master - mean (120ms) : 116, 123
section CallTarget+Inlining+NGEN
This PR (8309) - mean (767ms) : 738, 797
master - mean (763ms) : 741, 785
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (105ms) : 102, 108
master - mean (104ms) : 100, 107
section Bailout
This PR (8309) - mean (107ms) : 104, 111
master - mean (105ms) : 102, 109
section CallTarget+Inlining+NGEN
This PR (8309) - mean (756ms) : 716, 795
master - mean (748ms) : 709, 786
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (105ms) : 101, 109
master - mean (103ms) : 100, 106
section Bailout
This PR (8309) - mean (107ms) : 105, 110
master - mean (104ms) : 103, 106
section CallTarget+Inlining+NGEN
This PR (8309) - mean (693ms) : 660, 726
master - mean (693ms) : 662, 723
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (197ms) : 190, 204
master - mean (194ms) : 190, 199
section Bailout
This PR (8309) - mean (199ms) : 194, 204
master - mean (199ms) : 195, 202
section CallTarget+Inlining+NGEN
This PR (8309) - mean (1,168ms) : 1098, 1238
master - mean (1,157ms) : 1102, 1213
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (282ms) : 273, 290
master - mean (280ms) : 273, 287
section Bailout
This PR (8309) - mean (283ms) : 277, 290
master - mean (280ms) : 274, 286
section CallTarget+Inlining+NGEN
This PR (8309) - mean (913ms) : 879, 948
master - mean (907ms) : 881, 933
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (275ms) : 267, 283
master - mean (272ms) : 266, 277
section Bailout
This PR (8309) - mean (275ms) : 267, 282
master - mean (272ms) : 268, 277
section CallTarget+Inlining+NGEN
This PR (8309) - mean (944ms) : 904, 984
master - mean (948ms) : 908, 987
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8309) - mean (273ms) : 266, 280
master - mean (271ms) : 266, 277
section Bailout
This PR (8309) - mean (272ms) : 268, 276
master - mean (273ms) : 267, 280
section CallTarget+Inlining+NGEN
This PR (8309) - mean (849ms) : 813, 885
master - mean (853ms) : 811, 896
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Pass explicit
serviceNameSourcefor inferred proxy span factories so_dd.svc_srccorrectly identifies the integration that set the service name.Reason for change
Per the service name source RFC, integration-driven service overrides must set
_dd.svc_srcto the integration name. The proxy factories were passingserviceNamewithoutserviceNameSource, leaving the tag unset.Implementation details
AwsApiGatewaySpanFactory: passesserviceNameSource: "aws-apigateway"AzureApiManagementSpanFactory: passesserviceNameSource: "azure-apim"Test coverage
Updated 30 snapshot files to include the new
_dd.svc_srctag on inferred proxy spans.Other details
Part of the
_dd.svc_srcRFC implementation. Manual instrumentation source ("m") is handled in a separate PR.