Improve HttpClient and WebClient sample to test all public API methods#830
Merged
Conversation
zacharycmontoya
added
area:tests
lucaspimentel
left a comment
lucaspimentel
left a comment
Member
There was a problem hiding this comment.
The methods we instrument in WebRequest ( GetResponse() and GetResponseAsync() ) are public APIs. Are we sure the new tests call both of those methods? Should we have tests that call them directly?
Contributor
Author
Good idea. I've implemented that in commit 1e0df4b |
…ttpClientDriver and WebClientDriver samples
…tDriver, removing Samples.HttpMessageHandler
…st.GetResponse and WebRequest.GetResponseAsync which are public methods (and are the methods we directly instrument)
zacharycmontoya
force-pushed
the
zach/tests/http-clients
branch
from
August 5, 2020 00:46
bb56a9d to
60a83a5
Compare
lucaspimentel
approved these changes
Aug 5, 2020
kevingosse
approved these changes
Aug 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
xxxAsyncmethods in the HttpClient public APIDownloadxxxandUploadxxxmethods in the WebClient public API and executingGetResponseandGetResponseAsyncmethods in the WebRequest public API@DataDog/apm-dotnet