Only allow creating hotfix branches from a tag#8297
Merged
Conversation
andrewlock
added
the
area:builds
bouwkast
reviewed
Mar 12, 2026
| steps: | ||
| - name: Verify running from a tag | ||
| run: | | ||
| if [[ "${{ github.ref }}" != refs/tags/* ]]; then |
Collaborator
There was a problem hiding this comment.
Just remembered, I think we are supposed to make the github.ref an ENV_VAR like in this PR #7599
Member
Author
There was a problem hiding this comment.
Oh, well remembered... I actually think it's fine, seeing as this isn't triggered automatically by an action like the one fixed in that PR (that one is triggered on PR close, so is fundamentally user controlled, this one can only be manually triggered). If it was an issue, I'm pretty sure they would have flagged our release workflows too 🙂
I mean, I'm making excuses not to make changes, maybe I should just do it 😂
NachoEchevarria
approved these changes
Mar 13, 2026
andrewlock
force-pushed
the
andrew/only-hotfix-from-tags
branch
from
March 16, 2026 10:12
29c9eb2 to
3d78450
Compare
BenchmarksBenchmark execution time: 2026-03-16 10:54:08 Comparing candidate commit 3d78450 in PR branch Found 9 performance improvements and 4 performance regressions! Performance is the same for 157 metrics, 22 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472
scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Ensures you're creating a hotfix branch from a tag
Reason for change
The "correct" usage is to create a hotfix from a previous normal release, or from a previous hotfix. The easy way to enforce that is to ensure you create from a tag
Implementation details
Check the reference passed in, like we do for other workflows
Test coverage
Tested it here and it failed (as expected).