Increase endpoint telemetry wait timeout#8294
Conversation
Co-authored-by: NachoEchevarria <[email protected]>
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
BenchmarksBenchmark execution time: 2026-03-24 10:35:47 Comparing candidate commit feba0ce in PR branch Found 9 performance improvements and 7 performance regressions! Performance is the same for 256 metrics, 16 unstable metrics.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8294) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (69ms) : 67, 70
master - mean (69ms) : 66, 71
section Bailout
This PR (8294) - mean (73ms) : 72, 74
master - mean (73ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8294) - mean (1,044ms) : 994, 1094
master - mean (1,046ms) : 977, 1115
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (108ms) : 105, 110
master - mean (107ms) : 104, 110
section Bailout
This PR (8294) - mean (108ms) : 106, 110
master - mean (108ms) : 106, 110
section CallTarget+Inlining+NGEN
This PR (8294) - mean (771ms) : 754, 788
master - mean (769ms) : 751, 788
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (95ms) : 93, 97
master - mean (94ms) : 92, 97
section Bailout
This PR (8294) - mean (95ms) : 94, 97
master - mean (96ms) : 94, 97
section CallTarget+Inlining+NGEN
This PR (8294) - mean (759ms) : 742, 775
master - mean (751ms) : 730, 771
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (94ms) : 91, 97
master - mean (93ms) : 91, 95
section Bailout
This PR (8294) - mean (95ms) : 94, 97
master - mean (95ms) : 93, 96
section CallTarget+Inlining+NGEN
This PR (8294) - mean (668ms) : 648, 688
master - mean (655ms) : 636, 674
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (192ms) : 189, 196
master - mean (194ms) : 190, 198
section Bailout
This PR (8294) - mean (197ms) : 193, 201
master - mean (196ms) : 193, 199
section CallTarget+Inlining+NGEN
This PR (8294) - mean (1,168ms) : 1093, 1243
master - mean (1,153ms) : 1094, 1212
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (276ms) : 272, 281
master - mean (276ms) : 271, 280
section Bailout
This PR (8294) - mean (277ms) : 273, 281
master - mean (276ms) : 271, 281
section CallTarget+Inlining+NGEN
This PR (8294) - mean (944ms) : 920, 968
master - mean (937ms) : 913, 961
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (270ms) : 266, 274
master - mean (270ms) : 264, 276
section Bailout
This PR (8294) - mean (270ms) : 267, 273
master - mean (272ms) : 263, 280
section CallTarget+Inlining+NGEN
This PR (8294) - mean (967ms) : 946, 987
master - mean (966ms) : 936, 995
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8294) - mean (268ms) : 264, 273
master - mean (268ms) : 262, 273
section Bailout
This PR (8294) - mean (270ms) : 265, 274
master - mean (268ms) : 264, 271
section CallTarget+Inlining+NGEN
This PR (8294) - mean (850ms) : 832, 867
master - mean (848ms) : 825, 870
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Reason for change
WaitForLatestTelemetryAsyncdefaults to a 5-second timeout inMockTracerAgent.Implementation details
tracer/test/Datadog.Trace.Security.IntegrationTests/ApiSecurity/AspNetCoreEndpoints.cs:WaitForLatestTelemetryAsynccall inTestEndpointsCollection()to passtimeoutInMilliseconds: 30000.AspNetCore5EndpointsApmTracingDisabled), so all relevant endpoint collection tests now use the increased timeout.Test coverage
dotnet test tracer/test/Datadog.Trace.Security.IntegrationTests/Datadog.Trace.Security.IntegrationTests.csproj --filter "FullyQualifiedName~ApiSecurity.AspNetCore5EndpointsApmTracingDisabled.TestEndpointsCollection"10.0.100fromglobal.json, but only SDK8.0.412is installed.Formattool, butdotnet formatfailed for the same SDK reason.Other details
PR by Bits - View session in Datadog
Comment @DataDog to request changes