Remote configuration tests and performance improvements#8237
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
RcmSubscriptionManagerandRemoteConfigurationPathRemoteConfigurationPathReason for change
RemoteConfigurationPathis running aRegexon every file listed in the remote config response (which happens every 5s), but it's a simple pattern that can be easily directly implementedImplementation details
RcmSubscriptionManagerRemoteConfigurationPathcovering changes in this PRTest coverage
Unit tests in this PR cover compatibility with the existing implementation.
Simple benchmarking for the regex improvements:
Benchmarking code
Other details
https://datadoghq.atlassian.net/browse/LANGPLAT-940
All part of the Remote Config perf stack