Skip to content

[Config Registry] Fix source generators: downgrade System.text.json version#7944

Merged
anna-git merged 1 commit into
masterfrom
anna/fix-source-generator-json-issue
Dec 10, 2025
Merged

[Config Registry] Fix source generators: downgrade System.text.json version#7944
anna-git merged 1 commit into
masterfrom
anna/fix-source-generator-json-issue

Conversation

@anna-git

@anna-git anna-git commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

Due to this Rider issue , the IDE doesn't index source generated files using the last version of the package properly which considerably degrades the dev experience. And following the merge of this PR, we now have the issue:
image

It still builds but Rider doesn't see the generated sources and generates errors and doesn't autocompletes or index anything.

Reason for change

Downgrade the package version to fix the dev experience.

Implementation details

Test coverage

Other details

@anna-git
anna-git marked this pull request as ready for review December 10, 2025 17:45
@anna-git
anna-git requested a review from a team as a code owner December 10, 2025 17:45
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Dec 10, 2025

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7944) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration76.72 ± (76.95 - 77.89) ms75.42 ± (75.43 - 76.30) ms-1.7%✅
.NET Framework 4.8 - Bailout
duration79.34 ± (79.43 - 80.42) ms81.82 ± (81.55 - 82.44) ms+3.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1092.34 ± (1091.54 - 1103.58) ms1079.84 ± (1083.05 - 1092.20) ms-1.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms23.03 ± (22.95 - 23.12) ms22.95 ± (22.88 - 23.03) ms-0.3%✅
process.time_to_main_ms87.42 ± (86.91 - 87.93) ms87.70 ± (87.26 - 88.15) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.92) MB10.92 ± (10.92 - 10.93) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.79 ± (22.72 - 22.86) ms23.09 ± (23.02 - 23.16) ms+1.3%✅⬆️
process.time_to_main_ms87.78 ± (87.37 - 88.19) ms90.18 ± (89.75 - 90.61) ms+2.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.97 ± (10.96 - 10.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms222.96 ± (221.56 - 224.35) ms226.19 ± (224.54 - 227.85) ms+1.5%✅⬆️
process.time_to_main_ms512.34 ± (510.68 - 513.99) ms515.48 ± (513.92 - 517.05) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.09 ± (48.07 - 48.11) MB48.09 ± (48.07 - 48.11) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.67 ± (21.60 - 21.74) ms21.93 ± (21.84 - 22.02) ms+1.2%✅⬆️
process.time_to_main_ms75.79 ± (75.42 - 76.16) ms77.00 ± (76.63 - 77.36) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.64 ± (10.63 - 10.64) MB10.66 ± (10.66 - 10.66) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.74 ± (21.67 - 21.80) ms21.67 ± (21.60 - 21.75) ms-0.3%✅
process.time_to_main_ms77.30 ± (76.94 - 77.66) ms76.95 ± (76.62 - 77.29) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.69 ± (10.69 - 10.69) MB10.69 ± (10.69 - 10.69) MB+0.0%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.49 ± (211.79 - 215.19) ms212.59 ± (211.42 - 213.76) ms-0.4%✅
process.time_to_main_ms476.15 ± (474.54 - 477.76) ms477.41 ± (476.05 - 478.78) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.42 ± (48.40 - 48.45) MB48.49 ± (48.47 - 48.51) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms20.15 ± (20.08 - 20.23) ms19.83 ± (19.76 - 19.91) ms-1.6%✅
process.time_to_main_ms75.86 ± (75.48 - 76.24) ms75.53 ± (75.13 - 75.93) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.67) MB7.66 ± (7.66 - 7.67) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.99 ± (19.91 - 20.07) ms20.02 ± (19.94 - 20.10) ms+0.2%✅⬆️
process.time_to_main_ms76.46 ± (76.03 - 76.89) ms77.25 ± (76.84 - 77.65) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.73) MB7.74 ± (7.73 - 7.75) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms191.94 ± (190.87 - 193.01) ms193.85 ± (192.84 - 194.86) ms+1.0%✅⬆️
process.time_to_main_ms458.57 ± (457.27 - 459.88) ms459.12 ± (457.89 - 460.34) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.48 ± (36.44 - 36.52) MB36.50 ± (36.46 - 36.54) MB+0.0%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration196.48 ± (196.34 - 197.28) ms196.94 ± (196.78 - 197.69) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration199.16 ± (198.78 - 199.62) ms199.87 ± (199.75 - 200.66) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1131.57 ± (1135.47 - 1145.28) ms1123.40 ± (1125.38 - 1133.53) ms-0.7%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms192.89 ± (192.45 - 193.33) ms189.92 ± (189.50 - 190.34) ms-1.5%✅
process.time_to_main_ms82.56 ± (82.31 - 82.82) ms81.31 ± (81.03 - 81.59) ms-1.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.07 ± (16.05 - 16.09) MB16.01 ± (15.98 - 16.03) MB-0.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms193.00 ± (192.56 - 193.44) ms189.51 ± (189.10 - 189.92) ms-1.8%✅
process.time_to_main_ms84.09 ± (83.82 - 84.36) ms82.55 ± (82.36 - 82.74) ms-1.8%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.10) MB16.09 ± (16.06 - 16.12) MB+0.1%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)20 ± (20 - 21)-0.5%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms400.39 ± (397.98 - 402.81) ms398.27 ± (396.08 - 400.46) ms-0.5%✅
process.time_to_main_ms483.70 ± (482.77 - 484.62) ms482.68 ± (481.83 - 483.53) ms-0.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.82 ± (58.70 - 58.93) MB58.84 ± (58.73 - 58.96) MB+0.0%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (29 - 30)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms196.84 ± (196.42 - 197.27) ms194.56 ± (194.10 - 195.03) ms-1.2%✅
process.time_to_main_ms71.06 ± (70.85 - 71.26) ms70.53 ± (70.33 - 70.72) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.27 ± (16.24 - 16.29) MB16.34 ± (16.29 - 16.39) MB+0.4%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.8%✅
.NET 6 - Bailout
process.internal_duration_ms196.19 ± (195.78 - 196.60) ms193.18 ± (192.78 - 193.57) ms-1.5%✅
process.time_to_main_ms72.07 ± (71.83 - 72.32) ms71.43 ± (71.27 - 71.59) ms-0.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.36 ± (16.33 - 16.39) MB16.17 ± (16.03 - 16.31) MB-1.1%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-1.8%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.05 ± (409.30 - 412.81) ms417.79 ± (415.59 - 419.98) ms+1.6%✅⬆️
process.time_to_main_ms450.65 ± (450.00 - 451.31) ms451.80 ± (451.01 - 452.59) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.44 ± (59.34 - 59.54) MB59.46 ± (59.37 - 59.55) MB+0.0%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 30)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms192.69 ± (192.25 - 193.13) ms192.80 ± (192.37 - 193.23) ms+0.1%✅⬆️
process.time_to_main_ms69.85 ± (69.63 - 70.06) ms70.09 ± (69.87 - 70.30) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.67 ± (11.65 - 11.69) MB11.70 ± (11.68 - 11.72) MB+0.3%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.6%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms191.47 ± (191.09 - 191.86) ms191.48 ± (191.05 - 191.92) ms+0.0%✅⬆️
process.time_to_main_ms70.81 ± (70.65 - 70.98) ms70.88 ± (70.73 - 71.02) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.74 ± (11.71 - 11.77) MB11.78 ± (11.75 - 11.80) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms370.92 ± (369.50 - 372.34) ms369.12 ± (367.78 - 370.46) ms-0.5%✅
process.time_to_main_ms435.01 ± (434.36 - 435.65) ms435.19 ± (434.42 - 435.96) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.99 ± (47.96 - 48.02) MB48.00 ± (47.98 - 48.03) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.6%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (76ms)  : 69, 82
    master - mean (77ms)  : 70, 85

    section Bailout
    This PR (7944) - mean (82ms)  : 76, 88
    master - mean (80ms)  : 72, 87

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (1,088ms)  : 1021, 1155
    master - mean (1,098ms)  : 1006, 1189
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (118ms)  : 110, 126
    master - mean (118ms)  : 109, 128

    section Bailout
    This PR (7944) - mean (121ms)  : 112, 129
    master - mean (118ms)  : 109, 127

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (788ms)  : 734, 843
    master - mean (777ms)  : 729, 824
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (106ms)  : 99, 114
    master - mean (105ms)  : 97, 113

    section Bailout
    This PR (7944) - mean (106ms)  : 99, 113
    master - mean (106ms)  : 100, 113

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (722ms)  : 687, 758
    master - mean (719ms)  : 669, 770
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (104ms)  : 95, 113
    master - mean (105ms)  : 97, 112

    section Bailout
    This PR (7944) - mean (106ms)  : 99, 113
    master - mean (105ms)  : 96, 115

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (697ms)  : 662, 733
    master - mean (684ms)  : 642, 726
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (197ms)  : 191, 203
    master - mean (197ms)  : 190, 203

    section Bailout
    This PR (7944) - mean (200ms)  : 196, 205
    master - mean (199ms)  : 195, 203

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (1,129ms)  : 1070, 1188
    master - mean (1,140ms)  : 1067, 1213
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (279ms)  : 272, 287
    master - mean (284ms)  : 275, 293

    section Bailout
    This PR (7944) - mean (280ms)  : 275, 285
    master - mean (285ms)  : 276, 294

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (914ms)  : 866, 961
    master - mean (922ms)  : 868, 977
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (273ms)  : 266, 280
    master - mean (277ms)  : 268, 285

    section Bailout
    This PR (7944) - mean (273ms)  : 266, 281
    master - mean (276ms)  : 271, 282

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (903ms)  : 865, 942
    master - mean (894ms)  : 862, 926
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7944) - mean (273ms)  : 266, 279
    master - mean (273ms)  : 264, 282

    section Bailout
    This PR (7944) - mean (272ms)  : 266, 278
    master - mean (272ms)  : 266, 278

    section CallTarget+Inlining+NGEN
    This PR (7944) - mean (836ms)  : 811, 861
    master - mean (835ms)  : 806, 865
Loading

andrewlock
andrewlock approved these changes Dec 10, 2025
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Did you try with the 10.0 GA version of system.text.json btw?

@anna-git

anna-git commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Nice! Did you try with the 10.0 GA version of system.text.json btw?

yes I tried with 10+ versions and it started working only from under 9...

@anna-git
anna-git enabled auto-merge (squash) December 10, 2025 18:55
@anna-git
anna-git merged commit cc8129b into master Dec 10, 2025
151 checks passed
@anna-git
anna-git deleted the anna/fix-source-generator-json-issue branch December 10, 2025 18:59
@github-actions github-actions Bot added this to the vNext-v3 milestone Dec 10, 2025
@andrewlock andrewlock mentioned this pull request Apr 22, 2026
Merged
andrewlock added a commit that referenced this pull request Apr 29, 2026
@andrewlock
Update System.Text.Json to latest in source generators project (#8497)
94f75bc 
## Summary of changes

Update System.Text.Json to latest in source generators project

## Reason for change

In #7944 we downgraded the version of System.Text.Json due to a [bug in
Rider](https://youtrack.jetbrains.com/projects/RIDER/issues/RIDER-132634/Source-Generated-files-missing-when-using-System.Text.Json),
which caused the IDE doesn't index source generated files using the last
version of the package properly, causing invalid missing values:

<img width="2148" height="980" alt="image"
src="https://github.com/user-attachments/assets/5c113a18-9126-4a57-9cda-eb1168a41876"
/>

The issue is marked as fixed, and I can't reproduce it locally any more,
so we should be safe to update

<img width="695" height="235" alt="image"
src="https://github.com/user-attachments/assets/7a1392bb-751f-46a6-b2e5-bfca27eff0ad"
/>

## Implementation details

Bummp the System.Text.Json value to latest

## Test coverage

Tested the impact locally, and everything else is covered by CI

## Other details

Supersedes #7900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:configuration

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anna-git @andrewlock @bouwkast