Bump .NET Tracer version to 1.18.2#793
Conversation
zacharycmontoya
added
the
area:builds
| VALUE "FileVersion", "1.18.1.0" | ||
| VALUE "FileVersion", "1.18.2.0" | ||
| VALUE "InternalName", "Datadog.Trace.ClrProfiler.Native.DLL" | ||
| VALUE "LegalCopyright", "Copyright (C) 2017-2019" |
There was a problem hiding this comment.
Unrelated, but this should say Copyright 2018 Datadog, Inc. to match NOTICE.
There was a problem hiding this comment.
We have <Copyright>Datadog, Inc. 2017-2020</Copyright> in src/Directory.Build.props. Should we consolidate to this one across the three files, or Copyright 2018 Datadog, Inc as you're suggesting?
There was a problem hiding this comment.
Oh, I didn't mean for you to spend time on this. The 2019 just caught my eye. But since we're here 😄, the Apache license says all the way at the bottom that we should use
Copyright [yyyy] [name of copyright owner]
We should ask the open source team, but I'm guessing we should probably change them all to match that.
There was a problem hiding this comment.
This one in Resource.rc doesn't mention the company name, and the one you pointed out in Directory.Build.props doesn't have the word "Copyright" (which I think required by copyright law in the USA, but it's © elsewhere).
3 participants
Affected files:
@DataDog/apm-dotnet