Skip to content

Add data-streams-monitoring to CODEOWNERS file#7915

Merged
robcarlan-datadog merged 2 commits into
masterfrom
rob.carlan/DSMON-1159/add-codeowners
Dec 8, 2025
Merged

Add data-streams-monitoring to CODEOWNERS file#7915
robcarlan-datadog merged 2 commits into
masterfrom
rob.carlan/DSMON-1159/add-codeowners

Conversation

@robcarlan-datadog

@robcarlan-datadog robcarlan-datadog commented Dec 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

Adds DSM to relevant files in CODEOWNERS

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 5, 2025
@robcarlan-datadog
robcarlan-datadog marked this pull request as ready for review December 5, 2025 21:39
@robcarlan-datadog
robcarlan-datadog requested a review from a team as a code owner December 5, 2025 21:39
@pr-commenter

pr-commenter Bot commented Dec 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7915 compared to master:

  • 4 benchmarks are slower, with geometric mean 1.276
  • 2 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.9μs 58.1ns 308ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 14μs 73.8ns 369ns 0 0 0 5.71 KB
master StartStopWithChild net472 22.6μs 114ns 534ns 1.05 0.419 0.105 6.01 KB
#7915 StartStopWithChild net6.0 10.7μs 60.4ns 391ns 0 0 0 5.5 KB
#7915 StartStopWithChild netcoreapp3.1 13.6μs 71ns 369ns 0 0 0 5.71 KB
#7915 StartStopWithChild net472 22.4μs 83.2ns 300ns 0.917 0.344 0 6 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 1.27ms 508ns 1.97μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.37ms 479ns 1.79μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.72ms 792ns 2.74μs 0 0 0 3.26 KB
#7915 WriteAndFlushEnrichedTraces net6.0 1.27ms 1.15μs 4.43μs 0 0 0 2.7 KB
#7915 WriteAndFlushEnrichedTraces netcoreapp3.1 1.4ms 201ns 751ns 0 0 0 2.7 KB
#7915 WriteAndFlushEnrichedTraces net472 1.71ms 177ns 638ns 0 0 0 3.26 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.11μs 4.88ns 18.2ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.4μs 7.96ns 55.1ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.02μs 0.618ns 2.39ns 0.193 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.23μs 37ns 181ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 8.85μs 45.5ns 208ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.73μs 4.7ns 18.2ns 0.734 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 321ns 0.214ns 0.828ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 406ns 2.14ns 10.5ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 295ns 0.0247ns 0.0925ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.31μs 30.5ns 122ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.94μs 38ns 152ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.7μs 1.87ns 7.22ns 0.572 0 0 3.8 KB
#7915 AllCycleSimpleBody net6.0 1.1μs 6.17ns 39ns 0 0 0 1.22 KB
#7915 AllCycleSimpleBody netcoreapp3.1 1.38μs 7.69ns 48ns 0 0 0 1.2 KB
#7915 AllCycleSimpleBody net472 1μs 0.245ns 0.949ns 0.192 0 0 1.23 KB
#7915 AllCycleMoreComplexBody net6.0 7.18μs 36.2ns 166ns 0 0 0 4.72 KB
#7915 AllCycleMoreComplexBody netcoreapp3.1 9.13μs 31.7ns 123ns 0 0 0 4.62 KB
#7915 AllCycleMoreComplexBody net472 7.74μs 4.25ns 16.5ns 0.738 0 0 4.74 KB
#7915 ObjectExtractorSimpleBody net6.0 322ns 1.59ns 7.11ns 0 0 0 280 B
#7915 ObjectExtractorSimpleBody netcoreapp3.1 392ns 2.21ns 13.4ns 0 0 0 272 B
#7915 ObjectExtractorSimpleBody net472 295ns 0.0373ns 0.135ns 0.0446 0 0 281 B
#7915 ObjectExtractorMoreComplexBody net6.0 6.28μs 30.2ns 117ns 0 0 0 3.78 KB
#7915 ObjectExtractorMoreComplexBody netcoreapp3.1 7.87μs 39.4ns 181ns 0 0 0 3.69 KB
#7915 ObjectExtractorMoreComplexBody net472 6.72μs 3.93ns 15.2ns 0.57 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.5μs 50.7ns 190ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98.6μs 139ns 539ns 0 0 0 32.4 KB
master EncodeArgs net472 110μs 20.2ns 78.4ns 4.94 0 0 32.5 KB
master EncodeLegacyArgs net6.0 145μs 26.7ns 103ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 195μs 14ns 52.4ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 264μs 21.9ns 84.7ns 0 0 0 2.14 KB
#7915 EncodeArgs net6.0 76.4μs 119ns 460ns 0 0 0 32.4 KB
#7915 EncodeArgs netcoreapp3.1 98.6μs 137ns 532ns 0 0 0 32.4 KB
#7915 EncodeArgs net472 108μs 25.1ns 94ns 4.87 0 0 32.5 KB
#7915 EncodeLegacyArgs net6.0 143μs 13.3ns 49.7ns 0 0 0 2.14 KB
#7915 EncodeLegacyArgs netcoreapp3.1 198μs 149ns 575ns 0 0 0 2.14 KB
#7915 EncodeLegacyArgs net472 263μs 33.4ns 129ns 0 0 0 2.14 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 426μs 1.66μs 6.22μs 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 628μs 20.9μs 209μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 501μs 608ns 2.35μs 0 0 0 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 310μs 1.49μs 5.77μs 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 360μs 3.71μs 36.2μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 369μs 413ns 1.55μs 0 0 0 0 b
#7915 RunWafRealisticBenchmark net6.0 433μs 2.13μs 8.8μs 0 0 0 4.55 KB
#7915 RunWafRealisticBenchmark netcoreapp3.1 483μs 3.52μs 34.3μs 0 0 0 4.48 KB
#7915 RunWafRealisticBenchmark net472 499μs 411ns 1.48μs 0 0 0 0 b
#7915 RunWafRealisticBenchmarkWithAttack net6.0 317μs 1.56μs 6.61μs 0 0 0 2.24 KB
#7915 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 339μs 1.46μs 5.45μs 0 0 0 2.22 KB
#7915 RunWafRealisticBenchmarkWithAttack net472 373μs 607ns 2.35μs 0 0 0 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 More allocations ⚠️

More allocations ⚠️ in #7915

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 18.97 KB 27.71 KB 8.74 KB 46.09%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 83.4μs 95.6ns 331ns 0 0 0 18.97 KB
master SendRequest netcoreapp3.1 98.1μs 430ns 2.91μs 0 0 0 21.18 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#7915 SendRequest net6.0 84.1μs 99.7ns 359ns 0 0 0 27.71 KB
#7915 SendRequest netcoreapp3.1 98.2μs 515ns 2.47μs 0 0 0 21.18 KB
#7915 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7915

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑netcoreapp3.1 1.685 1,657,900.00 2,793,100.00
Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice‑netcoreapp3.1 1.120 3,886,100.00 4,352,900.00

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 2.03ms 1.16μs 4.18μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 3.89ms 1.77μs 6.63μs 0 0 0 640.05 KB
master OriginalCharSlice net472 2.62ms 603ns 2.26μs 0 0 0 638.98 KB
master OptimizedCharSlice net6.0 1.36ms 633ns 2.37μs 0 0 0 0 b
master OptimizedCharSlice netcoreapp3.1 1.66ms 5.17μs 33.9μs 0 0 0 0 b
master OptimizedCharSlice net472 1.89ms 759ns 2.94μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 1.06ms 979ns 3.79μs 0 0 0 0 b
master OptimizedCharSliceWithPool netcoreapp3.1 1.86ms 1.67μs 6.46μs 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.14ms 977ns 3.78μs 0 0 0 0 b
#7915 OriginalCharSlice net6.0 1.94ms 717ns 2.68μs 0 0 0 640 KB
#7915 OriginalCharSlice netcoreapp3.1 4.35ms 5.12μs 19.1μs 0 0 0 640.05 KB
#7915 OriginalCharSlice net472 2.69ms 707ns 2.65μs 0 0 0 638.98 KB
#7915 OptimizedCharSlice net6.0 1.4ms 531ns 2.06μs 0 0 0 0 b
#7915 OptimizedCharSlice netcoreapp3.1 2.79ms 643ns 2.41μs 0 0 0 0 b
#7915 OptimizedCharSlice net472 1.92ms 442ns 1.66μs 0 0 0 0 b
#7915 OptimizedCharSliceWithPool net6.0 1.06ms 1.25μs 4.83μs 0 0 0 0 b
#7915 OptimizedCharSliceWithPool netcoreapp3.1 1.86ms 2.02μs 7.83μs 0 0 0 0 b
#7915 OptimizedCharSliceWithPool net472 1.13ms 662ns 2.56μs 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7915

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.180 953,798.96 1,125,746.67

More allocations ⚠️ in #7915

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.55 KB 56.36 KB 803 B 1.45%

Fewer allocations 🎉 in #7915

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 43.27 KB 41.99 KB -1.28 KB -2.96%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 727μs 3.51μs 14.5μs 0 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 801μs 3.49μs 12.6μs 0 0 0 43.27 KB
master WriteAndFlushEnrichedTraces net472 960μs 4.53μs 17.5μs 5.21 0 0 55.55 KB
#7915 WriteAndFlushEnrichedTraces net6.0 779μs 3.63μs 14.5μs 0 0 0 41.65 KB
#7915 WriteAndFlushEnrichedTraces netcoreapp3.1 773μs 617ns 2.14μs 0 0 0 41.99 KB
#7915 WriteAndFlushEnrichedTraces net472 1.13ms 5.2μs 20.8μs 8.33 4.17 0 56.36 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 2.12ns 7.92ns 0 0 0 968 B
master ExecuteNonQuery netcoreapp3.1 2.54μs 7.12ns 27.6ns 0 0 0 960 B
master ExecuteNonQuery net472 2.85μs 1.57ns 5.86ns 0.143 0 0 931 B
#7915 ExecuteNonQuery net6.0 1.9μs 5.83ns 21.8ns 0 0 0 968 B
#7915 ExecuteNonQuery netcoreapp3.1 2.75μs 2.35ns 9.09ns 0 0 0 960 B
#7915 ExecuteNonQuery net472 2.84μs 2.57ns 9.94ns 0.142 0 0 931 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.71μs 8.21ns 32.8ns 0 0 0 952 B
master CallElasticsearch netcoreapp3.1 2.21μs 9.66ns 37.4ns 0 0 0 968 B
master CallElasticsearch net472 3.4μs 3.84ns 14.9ns 0.136 0 0 955 B
master CallElasticsearchAsync net6.0 1.69μs 8.7ns 38.9ns 0 0 0 928 B
master CallElasticsearchAsync netcoreapp3.1 2.49μs 9.09ns 32.8ns 0 0 0 1.02 KB
master CallElasticsearchAsync net472 3.54μs 5.85ns 22.7ns 0.159 0 0 1.01 KB
#7915 CallElasticsearch net6.0 1.75μs 8.43ns 33.7ns 0 0 0 952 B
#7915 CallElasticsearch netcoreapp3.1 2.25μs 7.82ns 29.2ns 0 0 0 968 B
#7915 CallElasticsearch net472 3.33μs 5.61ns 21.7ns 0.147 0 0 955 B
#7915 CallElasticsearchAsync net6.0 1.71μs 0.521ns 1.88ns 0 0 0 928 B
#7915 CallElasticsearchAsync netcoreapp3.1 2.45μs 8.9ns 34.5ns 0 0 0 1.02 KB
#7915 CallElasticsearchAsync net472 3.46μs 3.26ns 12.6ns 0.157 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.85μs 1ns 3.61ns 0 0 0 896 B
master ExecuteAsync netcoreapp3.1 2.45μs 4.56ns 17.7ns 0 0 0 896 B
master ExecuteAsync net472 2.53μs 2.68ns 10.4ns 0.127 0 0 859 B
#7915 ExecuteAsync net6.0 1.94μs 2.56ns 9.59ns 0 0 0 896 B
#7915 ExecuteAsync netcoreapp3.1 2.32μs 8.72ns 33.8ns 0 0 0 896 B
#7915 ExecuteAsync net472 2.57μs 3.32ns 12.8ns 0.129 0 0 858 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.05μs 12.6ns 48.7ns 0 0 0 2.29 KB
master SendAsync netcoreapp3.1 8.29μs 15.1ns 58.3ns 0 0 0 2.83 KB
master SendAsync net472 12.3μs 6.37ns 24.7ns 0.431 0 0 3.08 KB
#7915 SendAsync net6.0 7.12μs 5.29ns 20.5ns 0 0 0 2.29 KB
#7915 SendAsync netcoreapp3.1 8.41μs 23.9ns 92.7ns 0 0 0 2.83 KB
#7915 SendAsync net472 12.4μs 5.85ns 22.7ns 0.431 0 0 3.08 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7915

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 248.25 KB 271.69 KB 23.44 KB 9.44%

Fewer allocations 🎉 in #7915

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 272.65 KB 257.8 KB -14.85 KB -5.45%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45.3μs 235ns 1.08μs 0 0 0 42.51 KB
master StringConcatBenchmark netcoreapp3.1 49.7μs 282ns 1.99μs 0 0 0 42.54 KB
master StringConcatBenchmark net472 57μs 299ns 1.49μs 0 0 0 49.15 KB
master StringConcatAspectBenchmark net6.0 476μs 1.66μs 8.8μs 0 0 0 272.65 KB
master StringConcatAspectBenchmark netcoreapp3.1 434μs 6.43μs 63.7μs 0 0 0 248.25 KB
master StringConcatAspectBenchmark net472 396μs 1.31μs 4.72μs 0 0 0 270.34 KB
#7915 StringConcatBenchmark net6.0 44.5μs 195ns 1.15μs 0 0 0 42.51 KB
#7915 StringConcatBenchmark netcoreapp3.1 49.6μs 270ns 1.89μs 0 0 0 42.54 KB
#7915 StringConcatBenchmark net472 56.2μs 290ns 1.36μs 0 0 0 49.15 KB
#7915 StringConcatAspectBenchmark net6.0 483μs 1.87μs 7.46μs 0 0 0 257.8 KB
#7915 StringConcatAspectBenchmark netcoreapp3.1 497μs 2.51μs 11.5μs 0 0 0 271.69 KB
#7915 StringConcatAspectBenchmark net472 395μs 1.58μs 5.69μs 0 0 0 270.34 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 13.8ns 64.9ns 0 0 0 1.69 KB
master EnrichedLog netcoreapp3.1 3.63μs 1.96ns 7.59ns 0 0 0 1.7 KB
master EnrichedLog net472 3.77μs 4.73ns 18.3ns 0.245 0 0 1.6 KB
#7915 EnrichedLog net6.0 2.71μs 3.02ns 11.3ns 0 0 0 1.69 KB
#7915 EnrichedLog netcoreapp3.1 3.58μs 17.2ns 72.9ns 0 0 0 1.7 KB
#7915 EnrichedLog net472 3.95μs 3.11ns 11.7ns 0.237 0 0 1.6 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 134μs 723ns 3.96μs 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 138μs 704ns 3.15μs 0 0 0 4.31 KB
master EnrichedLog net472 168μs 779ns 3.48μs 0 0 0 4.51 KB
#7915 EnrichedLog net6.0 122μs 150ns 580ns 0 0 0 4.31 KB
#7915 EnrichedLog netcoreapp3.1 127μs 231ns 863ns 0 0 0 4.31 KB
#7915 EnrichedLog net472 167μs 116ns 450ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.05μs 5.03ns 19.5ns 0 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 6.89μs 18.8ns 67.9ns 0 0 0 2.26 KB
master EnrichedLog net472 7.59μs 5.38ns 20.1ns 0.302 0 0 2.05 KB
#7915 EnrichedLog net6.0 5.1μs 6.27ns 24.3ns 0 0 0 2.24 KB
#7915 EnrichedLog netcoreapp3.1 6.88μs 27.5ns 106ns 0 0 0 2.26 KB
#7915 EnrichedLog net472 7.56μs 4.09ns 15.3ns 0.304 0 0 2.05 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.87μs 10.4ns 61.6ns 0 0 0 1.12 KB
master SendReceive netcoreapp3.1 2.59μs 11.2ns 43.3ns 0 0 0 1.14 KB
master SendReceive net472 2.82μs 2.14ns 8.03ns 0.169 0 0 1.12 KB
#7915 SendReceive net6.0 2.05μs 1.96ns 7.57ns 0 0 0 1.12 KB
#7915 SendReceive netcoreapp3.1 2.46μs 12.2ns 57.4ns 0 0 0 1.14 KB
#7915 SendReceive net472 2.85μs 0.793ns 3.07ns 0.171 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.28μs 6.24ns 24.2ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.77μs 10.2ns 38.3ns 0 0 0 1.63 KB
master EnrichedLog net472 6.58μs 6.82ns 26.4ns 0.296 0 0 2.03 KB
#7915 EnrichedLog net6.0 4.28μs 12.9ns 50.1ns 0 0 0 1.58 KB
#7915 EnrichedLog netcoreapp3.1 5.49μs 16.7ns 64.6ns 0 0 0 1.63 KB
#7915 EnrichedLog net472 6.56μs 11.2ns 41.9ns 0.295 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7915

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.189 1,112.88 1,323.38

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 773ns 3.83ns 15.8ns 0 0 0 520 B
master StartFinishSpan netcoreapp3.1 963ns 5.18ns 26.4ns 0 0 0 520 B
master StartFinishSpan net472 908ns 0.376ns 1.41ns 0.082 0 0 522 B
master StartFinishScope net6.0 887ns 4.55ns 20.9ns 0 0 0 640 B
master StartFinishScope netcoreapp3.1 1.17μs 4.97ns 19.2ns 0 0 0 640 B
master StartFinishScope net472 1.11μs 0.318ns 1.19ns 0.0949 0 0 602 B
master StartFinishTwoScopes net6.0 1.81μs 1.91ns 7.13ns 0 0 0 1.19 KB
master StartFinishTwoScopes netcoreapp3.1 2.29μs 3.38ns 13.1ns 0 0 0 1.19 KB
master StartFinishTwoScopes net472 2.18μs 0.462ns 1.66ns 0.163 0 0 1.08 KB
#7915 StartFinishSpan net6.0 769ns 3.69ns 14.8ns 0 0 0 520 B
#7915 StartFinishSpan netcoreapp3.1 959ns 0.511ns 1.84ns 0 0 0 520 B
#7915 StartFinishSpan net472 900ns 0.0268ns 0.0967ns 0.0813 0 0 522 B
#7915 StartFinishScope net6.0 898ns 4.81ns 25ns 0 0 0 640 B
#7915 StartFinishScope netcoreapp3.1 1.14μs 5.71ns 24.2ns 0 0 0 640 B
#7915 StartFinishScope net472 1.32μs 1.25ns 4.86ns 0.0931 0 0 602 B
#7915 StartFinishTwoScopes net6.0 1.8μs 1.65ns 6.38ns 0 0 0 1.19 KB
#7915 StartFinishTwoScopes netcoreapp3.1 2.22μs 8.36ns 32.4ns 0 0 0 1.19 KB
#7915 StartFinishTwoScopes net472 2.23μs 1.76ns 6.83ns 0.167 0 0 1.08 KB
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.07μs 5.19ns 21.4ns 0 0 0 640 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 7.31ns 36.6ns 0 0 0 640 B
master RunOnMethodBegin net472 1.45μs 0.578ns 2.24ns 0.0945 0 0 602 B
#7915 RunOnMethodBegin net6.0 1.04μs 5.2ns 22ns 0 0 0 640 B
#7915 RunOnMethodBegin netcoreapp3.1 1.38μs 6.9ns 29.3ns 0 0 0 640 B
#7915 RunOnMethodBegin net472 1.51μs 1.26ns 4.89ns 0.0911 0 0 602 B

lucaspimentel
lucaspimentel reviewed Dec 5, 2025
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
lucaspimentel
lucaspimentel reviewed Dec 5, 2025
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
bouwkast
bouwkast approved these changes Dec 8, 2025
View reviewed changes

@bouwkast bouwkast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

Wondering if we should remove @DataDog/apm-idm-dotnet from the ones that are owned by DSM, but no harm/push really probably something to think about in the future.

@robcarlan-datadog
robcarlan-datadog merged commit 24ae76f into master Dec 8, 2025
98 of 101 checks passed
@robcarlan-datadog
robcarlan-datadog deleted the rob.carlan/DSMON-1159/add-codeowners branch December 8, 2025 19:26
@github-actions github-actions Bot added this to the vNext-v3 milestone Dec 8, 2025
@bouwkast bouwkast mentioned this pull request Jul 7, 2026
Merged
bouwkast added a commit that referenced this pull request Jul 9, 2026
@bouwkast
Update CODEOWNERS to remove IDM from DSM and expand DSM ownership (#…
52d001e 
…8870)

## Summary of changes

Follow up of #7915 to
remove IDM from the now DSM-owned files.
Additionally tacked on some other files that are DSM-specific to include
them as owners, mainly in the manual instrumentation API. I left SDK as
owner as well in those however.

## Reason for change

Was noted as something we may want to do and as we are following up on
test flake owners having more accurate ownership for tests is beneficial

## Implementation details



## Test coverage

## Other details
<!-- Fixes #{issue} -->

Unsure if we want `@DataDog/apm-sdk-capabilities-dotnet` as the first
owner for the new ones for the manual, just following the existing way.
Also fine if we just want to scope to removing IDM from the DSM
ownership

#incident-57303

<!--  ⚠️ Note:

Where possible, please obtain 2 approvals prior to merging. Unless
CODEOWNERS specifies otherwise, for external teams it is typically best
to have one review from a team member, and one review from apm-dotnet.
Trivial changes do not require 2 reviews.

MergeQueue is NOT enabled in this repository. If you have write access
to the repo, the PR has 1-2 approvals (see above), and all of the
required checks have passed, you can use the Squash and Merge button to
merge the PR. If you don't have write access, or you need help, reach
out in the #apm-dotnet channel in Slack.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@robcarlan-datadog @lucaspimentel @bouwkast