Adds support for 'x-datadog-origin' http header#781
Merged
Conversation
kevingosse
reviewed
Jul 3, 2020
zacharycmontoya
approved these changes
Jul 8, 2020
zacharycmontoya
left a comment
zacharycmontoya
left a comment
Contributor
There was a problem hiding this comment.
Re-approving just to re-inforce that all of my concerns were answered. Thanks for following up on my feedback!
- Enable Extractor to parse the header and store it in the span context. - Enable Injector to inject the span context origin property to propagate the value. - Sets the '_dd.origin' tag to a new span if the span context has the origin value and if is the root span of a trace. - New constant values for the http header and the span tag. - Unit tests for Extract, Inject and setting the tag in the root span.
- Changing the SpanContext Origin property to internal. - Moving the Origin set tag block to the DecorateRootSpan method. - Removing the ToList() and the double enumeration from the SpanContextPropagator.
- Adds the Origin header logic to SpanContextPropagatorHelpers. - Changed the unit tests for SpanContextPropagatorHelpers to consider the new origin header. - Fixes the OriginHeader_InjectFromChildSpan test.
…ng a new internal ctor for the origin header.
tonyredondo
force-pushed
the
tony/dd-origin-header
branch
from
July 8, 2020 18:48
bbf2c82 to
eb60087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_dd.origintag to a new span if the span context has the origin value and if is the root span of a trace.These changes were required to correctly support Datadog Synthetics.