Improve span validation for automatic instrumentation of outbound HTTP calls#780
Merged
Conversation
… http.url tags on parent spans
zacharycmontoya
added
type:bug
area:automatic-instrumentation
…strumentation spans generated. Modify the CreateOutboundHttpScope to relax the instrumentation name for the Http de-duplication logic.
…by using the static string.Equals method and specifically checkingthe integrationName argument. Additionally, calculate the httpUrl only once.
Co-authored-by: Lucas Pimentel-Ordyna <[email protected]>
…ent to understand if the HTTP span was automatically generated. Also, save the result of UriHelpers.CleanUri call so it is only called once.
…rumentation for HTTP spans. Additionally, modify our unit tests to catch this regression next time.
lucaspimentel
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
Datadog.Trace.ClrProfiler.ScopeFactory.CreateOutboundHttpScopehelper method, used by both theWebRequestintegration and theHttpMessageHandlerintegration, in the following ways:NullReferenceExceptionto occur in the methodHttpMessageHandlerobjects) will only consider spans created by automatic instrumentation, not custom spans@DataDog/apm-dotnet