Add diagnostic logs at startup#769
Conversation
- Add diagnostic logs to the native part
3b3e6d3 to
114d6a7
Compare
| } | ||
| if (FAILED(hr)) { | ||
| Warn("Failed to attach profiler: unable to set event mask."); | ||
| Warn("DATADOG TRACER DIAGNOSTICS - Failed to attach profiler: unable to set event mask."); |
There was a problem hiding this comment.
I'm not sure what qualifies for DATADOG TRACER DIAGNOSTICS, but do the above domain-neutral logs need this message prefix or no?
There was a problem hiding this comment.
As I understand it, DATADOG TRACER DIAGNOSTICS should be used for stuff that causes the instrumentation to fail. The domain-neutral logs does not necessarily indicate an error condition.
| } | ||
| } | ||
|
|
||
| internal async Task WriteDiagnosticLog() |
There was a problem hiding this comment.
In Azure App Services we may initialize the Tracer to send to one port for the trace-agent and one port for dogstatsd, and then update it later after using the filesystem to record which ports we were able to open for those processes. Perhaps this WriteDiagnosticLog method should be included in the TracingProcessManager.SubscribeToTraceAgentPortOverride and TracingProcessManager.SubscribeToDogStatsDPortOverride callbacks, if that won't be too noisy.
There was a problem hiding this comment.
The issue is that we're supposed to have only one "DATADOG TRACER CONFIGURATION" log. I'll leave it as is for now.
zacharycmontoya
left a comment
zacharycmontoya
left a comment
There was a problem hiding this comment.
LGTM, left a couple of small comments
3 participants
No description provided.