Read SmokeTest process output asynchronously#768
Merged
Conversation
kevingosse
suggested changes
Jun 24, 2020
| process.BeginOutputReadLine(); | ||
| process.BeginErrorReadLine(); | ||
|
|
||
| var ranToCompletion = process.WaitForExit(MaxTestRunMilliseconds) && outputWaitHandle.WaitOne() && errorWaitHandle.WaitOne(); |
Contributor
There was a problem hiding this comment.
Those waits should have a timeout as well
| var standardOutput = outputBuffer.ToString(); | ||
| var standardError = errorBuffer.ToString(); | ||
|
|
||
| if (AssumeSuccessOnTimeout && !ranToCompletion) |
Contributor
There was a problem hiding this comment.
You can merge the two blocks
if (!ranToCompletion)
{
Killprocess();
if (AssumeSuccessOnTimeout)
{
Assert(...);
}
else
{
Output.WriteLine;
throw new TimeoutException(...);
}
}
kevingosse
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional small improvements:
@DataDog/apm-dotnet