Remove instance of DateTimeOffset in Span.Finish#763
Merged
Conversation
kevingosse
requested review from
colin-higgins,
lucaspimentel and
zacharycmontoya
June 22, 2020 17:01
lucaspimentel
added
the
type:performance
It looks like creating a DateTimeOffset because of the number of internal checks. We only need the Timespan in that codepath.
kevingosse
force-pushed
the
kevin/timestamp
branch
from
June 24, 2020 16:30
c1dcf2d to
67bdc25
Compare
zacharycmontoya
approved these changes
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like creating a DateTimeOffset because of the number of internal checks. We only need the Timespan in that codepath.
Benchmark: