Remove NuGet package dependencies from Datadog.Trace and Datadog.Trace.ClrProfiler.Managed#761
Merged
Conversation
zacharycmontoya
added
the
status:do-not-merge
4 tasks
zacharycmontoya
force-pushed
the
zach/trace/remove-external-dependencies
branch
from
July 31, 2020 22:29
83b6b59 to
1364e90
Compare
zacharycmontoya
marked this pull request as ready for review
July 31, 2020 22:31
zacharycmontoya
added
dependencies
lucaspimentel
approved these changes
Aug 3, 2020
lucaspimentel
left a comment
lucaspimentel
left a comment
Member
There was a problem hiding this comment.
Left some non-blocking comments. LGTM otherwise.
…ices.RuntimeInformation.dll. This work also removes the need for the Microsoft.Win32.Registry NuGet package
…ckage, which was needed for the dynamic keyword
… .NET Framework version, though it includes the full (4-part) FileVersion for .NET Framework 4.x versions, which is good enough.
… or equal to the min value 528040 as "4.8"
zacharycmontoya
force-pushed
the
zach/trace/remove-external-dependencies
branch
from
August 5, 2020 00:39
9c5a9e8 to
850e928
Compare
lucaspimentel
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Microsoft.CSharpNuGet package reference. This was only necessary for using thedynamickeyword, so those have been refactored to objects that use our existingObjectExtensionsmethodsSystem.Runtime.InteropServices.RuntimeInformationNuGet package reference. This is responsible for the additionalSystem.Runtime.InteropServices.RuntimeInformation.dllon all platforms. It is built-in fornetstandard2.0so the logic that uses the new API's was ifdef'd out of the .NET Framework build targets.Microsoft.Win32.RegistryNuGet package reference. This was no longer needed after refactoring ofFrameworkDescriptioncode.@DataDog/apm-dotnet