Fix Microsoft.Extensions.Telemetry logging integration in 9.3.0#6773
Fix Microsoft.Extensions.Telemetry logging integration in 9.3.0#6773andrewlock merged 3 commits intomasterfrom
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6773) - mean (69ms) : 66, 72
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6773) - mean (1,004ms) : 979, 1029
. : milestone, 1004,
master - mean (1,024ms) : 958, 1090
. : milestone, 1024,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6773) - mean (102ms) : 99, 105
. : milestone, 102,
master - mean (105ms) : 101, 110
. : milestone, 105,
section CallTarget+Inlining+NGEN
This PR (6773) - mean (681ms) : 664, 698
. : milestone, 681,
master - mean (699ms) : 644, 755
. : milestone, 699,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6773) - mean (89ms) : 87, 91
. : milestone, 89,
master - mean (90ms) : 87, 93
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (6773) - mean (639ms) : 624, 654
. : milestone, 639,
master - mean (645ms) : 623, 667
. : milestone, 645,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6773) - mean (190ms) : 186, 195
. : milestone, 190,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6773) - mean (1,105ms) : 1075, 1134
. : milestone, 1105,
master - mean (1,113ms) : 1070, 1155
. : milestone, 1113,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6773) - mean (269ms) : 266, 273
. : milestone, 269,
master - mean (269ms) : 266, 273
. : milestone, 269,
section CallTarget+Inlining+NGEN
This PR (6773) - mean (873ms) : 843, 904
. : milestone, 873,
master - mean (877ms) : 843, 911
. : milestone, 877,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6773) - mean (263ms) : 259, 266
. : milestone, 263,
master - mean (261ms) : 257, 266
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (6773) - mean (858ms) : 821, 895
. : milestone, 858,
master - mean (861ms) : 827, 895
. : milestone, 861,
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
bouwkast
left a comment
There was a problem hiding this comment.
This looks fine, but I think the ILogger may have changed as well as tests are failing here
Hmm maybe not, it is |
a5345a7 to
42cad7d
Compare
bouwkast
left a comment
There was a problem hiding this comment.
LGTM
I did download the NuGet just to see that yes they do update the assembly version inline with the NuGet Version which is nice.
| IntegrationName = LoggerIntegrationCommon.IntegrationName)] | ||
| [Browsable(false)] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public class ExtendedLoggerFactoryConstructorIntegration_8xx |
There was a problem hiding this comment.
Kinda 8xx but kinda 8xx_920 :)
There was a problem hiding this comment.
Kinda 8xx but kinda 8xx_920 :)
Yeah, I considered that and thought meh 😅
Yeah, same! 😄 Just in case you're not aware @bouwkast , there's also the "Open in NuGet Package Explorer" link on the sidebar. From there you can explore the nuget packages and check the dll versions etc without needing to explictly download it 🙂 (though in practice it downloads it in the browser, so not strictly true 😄) |
Well TIL |
Benchmarks Report for tracer 🐌Benchmarks for #6773 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.145 | 404.51 | 463.00 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 404ns | 0.113ns | 0.437ns | 0.00813 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 602ns | 0.583ns | 2.18ns | 0.00768 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 621ns | 0.138ns | 0.533ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 500ns | 0.0864ns | 0.323ns | 0.00978 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 666ns | 0.256ns | 0.958ns | 0.00945 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 878ns | 0.443ns | 1.71ns | 0.104 | 0 | 0 | 658 B |
| #6773 | StartFinishSpan |
net6.0 | 463ns | 0.0633ns | 0.228ns | 0.0081 | 0 | 0 | 576 B |
| #6773 | StartFinishSpan |
netcoreapp3.1 | 628ns | 0.254ns | 0.952ns | 0.00754 | 0 | 0 | 576 B |
| #6773 | StartFinishSpan |
net472 | 677ns | 0.498ns | 1.86ns | 0.0915 | 0 | 0 | 578 B |
| #6773 | StartFinishScope |
net6.0 | 546ns | 0.141ns | 0.547ns | 0.00977 | 0 | 0 | 696 B |
| #6773 | StartFinishScope |
netcoreapp3.1 | 679ns | 0.226ns | 0.781ns | 0.00927 | 0 | 0 | 696 B |
| #6773 | StartFinishScope |
net472 | 848ns | 0.234ns | 0.904ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 601ns | 0.221ns | 0.827ns | 0.00956 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 933ns | 0.478ns | 1.79ns | 0.00934 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.08μs | 0.294ns | 1.14ns | 0.104 | 0 | 0 | 658 B |
| #6773 | RunOnMethodBegin |
net6.0 | 658ns | 0.418ns | 1.56ns | 0.00958 | 0 | 0 | 696 B |
| #6773 | RunOnMethodBegin |
netcoreapp3.1 | 891ns | 0.493ns | 1.78ns | 0.00904 | 0 | 0 | 696 B |
| #6773 | RunOnMethodBegin |
net472 | 1.18μs | 0.411ns | 1.59ns | 0.104 | 0 | 0 | 658 B |
## Summary of changes Fixes the Microsoft.Extensions.Telemetry integration for 9.3.0 ## Reason for change 9.3.0 [introduced a new optional parameter](dotnet/extensions#5574) to a public method we instrument, breaking our integration ## Implementation details Add instrumentation for the new signature ## Test coverage This is the test - if everything passes, we're good ## Other details Identified in #6732
## Summary of changes Fixes the Microsoft.Extensions.Telemetry integration for 9.3.0 ## Reason for change 9.3.0 [introduced a new optional parameter](dotnet/extensions#5574) to a public method we instrument, breaking our integration ## Implementation details Add instrumentation for the new signature ## Test coverage This is the test - if everything passes, we're good ## Other details Identified in #6732
Summary of changes
Fixes the Microsoft.Extensions.Telemetry integration for 9.3.0
Reason for change
9.3.0 introduced a new optional parameter to a public method we instrument, breaking our integration
Implementation details
Add instrumentation for the new signature
Test coverage
This is the test - if everything passes, we're good
Other details
Identified in #6732