Skip to content

[ASM] Fix NullReferenceException on HttpTransport get_StatusCode#6602

Merged
e-n-0 merged 4 commits into
masterfrom
flavien/asm/httpcontext-statuscode-nre
Feb 6, 2025
Merged

[ASM] Fix NullReferenceException on HttpTransport get_StatusCode#6602
e-n-0 merged 4 commits into
masterfrom
flavien/asm/httpcontext-statuscode-nre

Conversation

@e-n-0

@e-n-0 e-n-0 commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

Handle the errors when trying to access the StatusCode of the HttpResponse from the Context.

Reason for change

Errors in telemetry identified by these stacktraces:

System.NullReferenceException
   at Microsoft.AspNetCore.Http.DefaultHttpResponse.get_StatusCode()
   at Datadog.Trace.AppSec.Coordinator.SecurityCoordinator.RunWaf(Dictionary`2 args, Boolean lastWafCall, Boolean runWithEphemeral, Boolean isRasp)

A ObjectDisposedException and a NullReferenceException can happen in concurrent access to the HttpContext.
This situation of race condition can happen while the request is finished while async jobs still run in the background and the waf for RASP is run.

The HttpContext can be disposed from different manner by the user. You can find more information in this PR.

Implementation details

  • The getter for the StatusCode has been changed so it could return a int? if an exception has been triggered.
  • The method ShouldAnalyzeSchema() is already working with a null StatusCode.

@e-n-0
e-n-0 changed the base branch from flavien/asm/httpcontext-items-nullreference to master January 28, 2025 14:36
@e-n-0
e-n-0 changed the base branch from master to flavien/asm/httpcontext-items-nullreference January 28, 2025 14:37
@e-n-0
e-n-0 force-pushed the flavien/asm/httpcontext-statuscode-nre branch from df5f3bb to 14b5e2c Compare January 28, 2025 14:51
@datadog-ddstaging

datadog-ddstaging Bot commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: flavien/asm/httpcontext-statuscode-nre
Commit report: ba936b9
Test service: dd-trace-dotnet

✅ 0 Failed, 248121 Passed, 2421 Skipped, 19h 4m 20.67s Total Time

@andrewlock

andrewlock commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6602) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (70ms)  : 65, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6602) - mean (992ms)  : 969, 1014
     .   : milestone, 992,
    master - mean (991ms)  : 973, 1009
     .   : milestone, 991,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6602) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6602) - mean (670ms)  : 654, 685
     .   : milestone, 670,
    master - mean (670ms)  : 654, 686
     .   : milestone, 670,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6602) - mean (90ms)  : 88, 91
     .   : milestone, 90,
    master - mean (90ms)  : 88, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6602) - mean (624ms)  : 605, 644
     .   : milestone, 624,
    master - mean (633ms)  : 614, 651
     .   : milestone, 633,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6602) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6602) - mean (1,100ms)  : 1077, 1124
     .   : milestone, 1100,
    master - mean (1,100ms)  : 1071, 1130
     .   : milestone, 1100,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6602) - mean (269ms)  : 266, 273
     .   : milestone, 269,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6602) - mean (861ms)  : 831, 891
     .   : milestone, 861,
    master - mean (862ms)  : 829, 894
     .   : milestone, 862,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6602) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (261ms)  : 257, 266
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6602) - mean (839ms)  : 813, 866
     .   : milestone, 839,
    master - mean (846ms)  : 817, 875
     .   : milestone, 846,
Loading

@andrewlock

andrewlock commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6602 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.187
  • 3 benchmarks are slower, with geometric mean 1.220
  • 1 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6602

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.344 140.41 188.78
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.187 165.77 196.80
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.138 276,278.98 314,449.82

Faster 🎉 in #6602

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 1.187 4,306.18 3,628.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 205μs 90.1ns 349ns 2.66 0 0 188.88 KB
master AllCycleSimpleBody netcoreapp3.1 303μs 170ns 658ns 2.69 0 0 196.21 KB
master AllCycleSimpleBody net472 269μs 175ns 678ns 35.8 2.01 0 226.09 KB
master AllCycleMoreComplexBody net6.0 210μs 75.4ns 292ns 2.74 0 0 192.38 KB
master AllCycleMoreComplexBody netcoreapp3.1 319μs 90.1ns 337ns 2.7 0 0 199.62 KB
master AllCycleMoreComplexBody net472 276μs 178ns 690ns 36.4 2.06 0 229.6 KB
master ObjectExtractorSimpleBody net6.0 140ns 0.135ns 0.504ns 0.00398 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 196ns 0.155ns 0.599ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 166ns 0.0964ns 0.348ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.97μs 1.93ns 7.2ns 0.0536 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.91μs 1.93ns 7.24ns 0.0488 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 4.31μs 2.94ns 11.4ns 0.603 0.00646 0 3.8 KB
#6602 AllCycleSimpleBody net6.0 202μs 164ns 634ns 2.63 0 0 188.88 KB
#6602 AllCycleSimpleBody netcoreapp3.1 310μs 161ns 602ns 2.63 0 0 196.21 KB
#6602 AllCycleSimpleBody net472 272μs 334ns 1.29μs 35.8 2.03 0 226.09 KB
#6602 AllCycleMoreComplexBody net6.0 212μs 54.2ns 203ns 2.76 0 0 192.39 KB
#6602 AllCycleMoreComplexBody netcoreapp3.1 316μs 118ns 443ns 2.7 0 0 199.62 KB
#6602 AllCycleMoreComplexBody net472 314μs 757ns 2.93μs 36.4 2.07 0 229.6 KB
#6602 ObjectExtractorSimpleBody net6.0 189ns 0.0782ns 0.303ns 0.00394 0 0 280 B
#6602 ObjectExtractorSimpleBody netcoreapp3.1 202ns 0.412ns 1.59ns 0.0037 0 0 272 B
#6602 ObjectExtractorSimpleBody net472 197ns 0.286ns 1.03ns 0.0446 0 0 281 B
#6602 ObjectExtractorMoreComplexBody net6.0 2.93μs 1.22ns 4.74ns 0.0533 0 0 3.78 KB
#6602 ObjectExtractorMoreComplexBody netcoreapp3.1 3.74μs 2.38ns 8.6ns 0.0508 0 0 3.69 KB
#6602 ObjectExtractorMoreComplexBody net472 3.63μs 2.3ns 8.93ns 0.603 0.00548 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 36.3μs 15.6ns 58.4ns 0.455 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54μs 22.1ns 85.8ns 0.432 0 0 32.4 KB
master EncodeArgs net472 66.4μs 30ns 112ns 5.14 0.0663 0 32.5 KB
master EncodeLegacyArgs net6.0 77.5μs 42.7ns 165ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 108μs 386ns 1.49μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 153μs 76.5ns 286ns 0.306 0 0 2.15 KB
#6602 EncodeArgs net6.0 38.7μs 15.2ns 56.9ns 0.46 0 0 32.4 KB
#6602 EncodeArgs netcoreapp3.1 54.3μs 15.9ns 61.7ns 0.434 0 0 32.4 KB
#6602 EncodeArgs net472 66.2μs 47.6ns 184ns 5.16 0.0658 0 32.5 KB
#6602 EncodeLegacyArgs net6.0 74.6μs 85.1ns 330ns 0 0 0 2.14 KB
#6602 EncodeLegacyArgs netcoreapp3.1 105μs 116ns 448ns 0 0 0 2.14 KB
#6602 EncodeLegacyArgs net472 152μs 126ns 487ns 0.306 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 178μs 29ns 108ns 0 0 0 2.54 KB
master RunWafRealisticBenchmark netcoreapp3.1 185μs 85ns 329ns 0 0 0 2.49 KB
master RunWafRealisticBenchmark net472 200μs 88.6ns 343ns 0.4 0 0 2.55 KB
master RunWafRealisticBenchmarkWithAttack net6.0 117μs 81ns 314ns 0 0 0 1.57 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 123μs 96ns 359ns 0 0 0 1.55 KB
master RunWafRealisticBenchmarkWithAttack net472 131μs 33.2ns 124ns 0.197 0 0 1.58 KB
#6602 RunWafRealisticBenchmark net6.0 177μs 104ns 402ns 0 0 0 2.54 KB
#6602 RunWafRealisticBenchmark netcoreapp3.1 187μs 338ns 1.31μs 0 0 0 2.49 KB
#6602 RunWafRealisticBenchmark net472 199μs 68.2ns 255ns 0.397 0 0 2.55 KB
#6602 RunWafRealisticBenchmarkWithAttack net6.0 116μs 193ns 749ns 0 0 0 1.57 KB
#6602 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 123μs 125ns 486ns 0 0 0 1.55 KB
#6602 RunWafRealisticBenchmarkWithAttack net472 133μs 80.2ns 310ns 0.198 0 0 1.58 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6602

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 253.93 KB 264.02 KB 10.1 KB 3.98%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 254.5 KB 255.9 KB 1.4 KB 0.55%

Fewer allocations 🎉 in #6602

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 59.81 KB 59.18 KB -632 B -1.06%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 58.9μs 682ns 6.82μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 62.3μs 805ns 7.97μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.3μs 57.6ns 208ns 0 0 0 59.81 KB
master StringConcatAspectBenchmark net6.0 308μs 1.42μs 8.06μs 0 0 0 253.93 KB
master StringConcatAspectBenchmark netcoreapp3.1 348μs 1.63μs 9.64μs 0 0 0 254.5 KB
master StringConcatAspectBenchmark net472 281μs 4.84μs 46.9μs 0 0 0 278.53 KB
#6602 StringConcatBenchmark net6.0 59.9μs 764ns 7.52μs 0 0 0 43.44 KB
#6602 StringConcatBenchmark netcoreapp3.1 53.3μs 237ns 820ns 0 0 0 42.64 KB
#6602 StringConcatBenchmark net472 36.9μs 99.7ns 359ns 0 0 0 59.18 KB
#6602 StringConcatAspectBenchmark net6.0 314μs 1.78μs 12.3μs 0 0 0 264.02 KB
#6602 StringConcatAspectBenchmark netcoreapp3.1 351μs 1.76μs 9.5μs 0 0 0 255.9 KB
#6602 StringConcatAspectBenchmark net472 271μs 5.36μs 51.9μs 0 0 0 278.53 KB

@andrewlock

andrewlock commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6602 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.140
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.85μs 45.1ns 337ns 0.0163 0.00815 0 5.62 KB
master StartStopWithChild netcoreapp3.1 10μs 54.8ns 310ns 0.0303 0.0151 0.00505 5.8 KB
master StartStopWithChild net472 16.5μs 38.3ns 148ns 1.04 0.308 0.0999 6.21 KB
#6602 StartStopWithChild net6.0 7.88μs 43.7ns 276ns 0.0158 0.00789 0 5.61 KB
#6602 StartStopWithChild netcoreapp3.1 9.83μs 53.8ns 318ns 0.0189 0.00944 0 5.81 KB
#6602 StartStopWithChild net472 16.3μs 40ns 155ns 1.04 0.309 0.0977 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 475μs 245ns 916ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 287ns 1.11μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 856μs 484ns 1.87μs 0.428 0 0 3.3 KB
#6602 WriteAndFlushEnrichedTraces net6.0 472μs 199ns 743ns 0 0 0 2.7 KB
#6602 WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 293ns 1.14μs 0 0 0 2.7 KB
#6602 WriteAndFlushEnrichedTraces net472 854μs 793ns 3.07μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 130μs 319ns 1.24μs 0.192 0 0 14.47 KB
master SendRequest netcoreapp3.1 145μs 377ns 1.46μs 0.219 0 0 17.27 KB
master SendRequest net472 0.0105ns 0.00278ns 0.0108ns 0 0 0 0 b
#6602 SendRequest net6.0 129μs 337ns 1.3μs 0.142 0 0 14.47 KB
#6602 SendRequest netcoreapp3.1 147μs 144ns 540ns 0.218 0 0 17.27 KB
#6602 SendRequest net472 0.00475ns 0.00258ns 0.01ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 600μs 3.28μs 24.4μs 0.563 0 0 41.81 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 2.85μs 10.3μs 0.319 0 0 41.79 KB
master WriteAndFlushEnrichedTraces net472 834μs 3.56μs 13.8μs 8.12 2.44 0.406 53.31 KB
#6602 WriteAndFlushEnrichedTraces net6.0 582μs 3.02μs 15.1μs 0.558 0 0 41.65 KB
#6602 WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.81μs 26.6μs 0.434 0 0 41.77 KB
#6602 WriteAndFlushEnrichedTraces net472 853μs 4.1μs 15.9μs 8.28 2.48 0.414 53.34 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.37μs 0.953ns 3.69ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 1.22ns 4.58ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 1.41ns 5.47ns 0.157 0.00105 0 987 B
#6602 ExecuteNonQuery net6.0 1.42μs 1.57ns 6.09ns 0.0142 0 0 1.02 KB
#6602 ExecuteNonQuery netcoreapp3.1 1.72μs 1.19ns 4.47ns 0.0139 0 0 1.02 KB
#6602 ExecuteNonQuery net472 2.09μs 2.43ns 9.09ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.31μs 0.643ns 2.49ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.6μs 0.568ns 1.97ns 0.0137 0 0 976 B
master CallElasticsearch net472 2.54μs 1.46ns 5.45ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 1.1ns 4.12ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 2.41ns 9.32ns 0.0143 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 1.05ns 4.08ns 0.166 0 0 1.05 KB
#6602 CallElasticsearch net6.0 1.23μs 0.874ns 3.27ns 0.0136 0 0 976 B
#6602 CallElasticsearch netcoreapp3.1 1.53μs 0.483ns 1.74ns 0.0131 0 0 976 B
#6602 CallElasticsearch net472 2.59μs 2.53ns 9.8ns 0.158 0 0 995 B
#6602 CallElasticsearchAsync net6.0 1.24μs 0.572ns 2.14ns 0.0131 0 0 952 B
#6602 CallElasticsearchAsync netcoreapp3.1 1.57μs 0.679ns 2.54ns 0.0142 0 0 1.02 KB
#6602 CallElasticsearchAsync net472 2.71μs 1.2ns 4.63ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.505ns 1.96ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 2.77ns 10.7ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.84μs 1.14ns 4.41ns 0.145 0 0 915 B
#6602 ExecuteAsync net6.0 1.31μs 0.685ns 2.56ns 0.0132 0 0 952 B
#6602 ExecuteAsync netcoreapp3.1 1.64μs 0.549ns 2.05ns 0.0123 0 0 952 B
#6602 ExecuteAsync net472 1.79μs 1.18ns 4.56ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.49μs 1.54ns 5.95ns 0.0313 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.28μs 2.26ns 8.74ns 0.0368 0 0 2.85 KB
master SendAsync net472 7.46μs 2.72ns 10.5ns 0.495 0 0 3.12 KB
#6602 SendAsync net6.0 4.34μs 3.4ns 12.2ns 0.0327 0 0 2.31 KB
#6602 SendAsync netcoreapp3.1 5.23μs 2.14ns 8.02ns 0.0367 0 0 2.85 KB
#6602 SendAsync net472 7.42μs 2.09ns 7.82ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.46μs 0.439ns 1.58ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.21μs 1.26ns 4.87ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.57μs 0.817ns 2.95ns 0.249 0 0 1.57 KB
#6602 EnrichedLog net6.0 1.48μs 0.78ns 3.02ns 0.0231 0 0 1.64 KB
#6602 EnrichedLog netcoreapp3.1 2.21μs 1.03ns 3.97ns 0.022 0 0 1.64 KB
#6602 EnrichedLog net472 2.5μs 0.664ns 2.39ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 85.4ns 331ns 0.0554 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 69.9ns 252ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 98.1ns 380ns 0.678 0.226 0 4.46 KB
#6602 EnrichedLog net6.0 112μs 124ns 479ns 0.056 0 0 4.28 KB
#6602 EnrichedLog netcoreapp3.1 116μs 164ns 635ns 0 0 0 4.28 KB
#6602 EnrichedLog net472 150μs 75.9ns 294ns 0.676 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.98μs 1.34ns 5.19ns 0.0314 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.22μs 1.64ns 5.91ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.95μs 1.28ns 4.96ns 0.32 0 0 2.02 KB
#6602 EnrichedLog net6.0 3.03μs 1.54ns 5.75ns 0.0303 0 0 2.2 KB
#6602 EnrichedLog netcoreapp3.1 4.26μs 0.89ns 3.21ns 0.0297 0 0 2.2 KB
#6602 EnrichedLog net472 4.93μs 1.19ns 4.61ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.88ns 3.41ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.7μs 1.02ns 3.94ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.13μs 1.8ns 6.97ns 0.183 0 0 1.16 KB
#6602 SendReceive net6.0 1.51μs 7.25ns 28.1ns 0.0158 0 0 1.14 KB
#6602 SendReceive netcoreapp3.1 1.8μs 0.608ns 2.27ns 0.0152 0 0 1.14 KB
#6602 SendReceive net472 2.07μs 1.25ns 4.84ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 0.689ns 2.67ns 0.0211 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.81μs 1.78ns 6.65ns 0.0209 0 0 1.65 KB
master EnrichedLog net472 4.5μs 3.1ns 12ns 0.323 0 0 2.04 KB
#6602 EnrichedLog net6.0 2.76μs 0.796ns 2.98ns 0.022 0 0 1.6 KB
#6602 EnrichedLog netcoreapp3.1 3.83μs 1.45ns 5.42ns 0.0212 0 0 1.65 KB
#6602 EnrichedLog net472 4.36μs 2.59ns 10ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6602

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.144 403.70 461.68
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.117 480.69 537.08

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 404ns 0.446ns 1.73ns 0.00813 0 0 576 B
master StartFinishSpan netcoreapp3.1 553ns 0.558ns 2.16ns 0.00771 0 0 576 B
master StartFinishSpan net472 583ns 0.701ns 2.71ns 0.0918 0 0 578 B
master StartFinishScope net6.0 481ns 0.471ns 1.82ns 0.0098 0 0 696 B
master StartFinishScope netcoreapp3.1 786ns 0.929ns 3.6ns 0.00952 0 0 696 B
master StartFinishScope net472 776ns 1.2ns 4.63ns 0.104 0 0 658 B
#6602 StartFinishSpan net6.0 462ns 0.261ns 1.01ns 0.00802 0 0 576 B
#6602 StartFinishSpan netcoreapp3.1 562ns 0.487ns 1.89ns 0.00755 0 0 576 B
#6602 StartFinishSpan net472 639ns 0.231ns 0.864ns 0.0917 0 0 578 B
#6602 StartFinishScope net6.0 537ns 0.116ns 0.419ns 0.00982 0 0 696 B
#6602 StartFinishScope netcoreapp3.1 782ns 0.758ns 2.94ns 0.00935 0 0 696 B
#6602 StartFinishScope net472 824ns 2.14ns 8.29ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6602

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.159 592.23 686.39

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 592ns 0.54ns 2.09ns 0.00974 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 901ns 1.51ns 5.86ns 0.00942 0 0 696 B
master RunOnMethodBegin net472 1.11μs 1.36ns 5.28ns 0.104 0 0 658 B
#6602 RunOnMethodBegin net6.0 686ns 0.25ns 0.934ns 0.00989 0 0 696 B
#6602 RunOnMethodBegin netcoreapp3.1 935ns 0.349ns 1.3ns 0.00919 0 0 696 B
#6602 RunOnMethodBegin net472 1.09μs 0.436ns 1.63ns 0.104 0 0 658 B

@e-n-0
e-n-0 marked this pull request as ready for review January 29, 2025 14:33
@e-n-0
e-n-0 requested a review from a team as a code owner January 29, 2025 14:33
@e-n-0
e-n-0 force-pushed the flavien/asm/httpcontext-items-nullreference branch from e0cfc66 to 1f4749b Compare January 29, 2025 14:38
@e-n-0
e-n-0 force-pushed the flavien/asm/httpcontext-statuscode-nre branch from 14b5e2c to 6b8d61b Compare January 29, 2025 14:42
@e-n-0
e-n-0 changed the base branch from flavien/asm/httpcontext-items-nullreference to master January 29, 2025 14:43
@e-n-0 e-n-0 self-assigned this Jan 29, 2025
NachoEchevarria
NachoEchevarria approved these changes Jan 29, 2025
View reviewed changes

@NachoEchevarria NachoEchevarria left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@e-n-0
e-n-0 force-pushed the flavien/asm/httpcontext-statuscode-nre branch from b309883 to b03bf16 Compare February 3, 2025 10:33
robertpi
robertpi reviewed Feb 5, 2025
View reviewed changes
Comment thread tracer/src/Datadog.Trace/AppSec/Coordinator/SecurityCoordinator.Core.cs Outdated
@robertpi

robertpi commented Feb 5, 2025

Copy link
Copy Markdown
Member

Any tests for this?

@e-n-0
e-n-0 force-pushed the flavien/asm/httpcontext-statuscode-nre branch from b03bf16 to d1e7f01 Compare February 5, 2025 16:28
@e-n-0

e-n-0 commented Feb 5, 2025

Copy link
Copy Markdown
Member Author

Tests added with d1e7f01 @robertpi 😄 Thanks

@e-n-0
e-n-0 merged commit 819d718 into master Feb 6, 2025
@e-n-0
e-n-0 deleted the flavien/asm/httpcontext-statuscode-nre branch February 6, 2025 10:44
@github-actions github-actions Bot added this to the vNext-v3 milestone Feb 6, 2025
chojomok pushed a commit that referenced this pull request Jul 15, 2025
@e-n-0 @chojomok
[ASM] Fix NullReferenceException on HttpTransport get_StatusCode (#6602)
c9ddd41 
## Summary of changes

Handle the errors when trying to access the `StatusCode` of the
`HttpResponse` from the Context.

## Reason for change

Errors in telemetry identified by these stacktraces:

```
System.NullReferenceException
   at Microsoft.AspNetCore.Http.DefaultHttpResponse.get_StatusCode()
   at Datadog.Trace.AppSec.Coordinator.SecurityCoordinator.RunWaf(Dictionary`2 args, Boolean lastWafCall, Boolean runWithEphemeral, Boolean isRasp)
```

A `ObjectDisposedException` and a `NullReferenceException` can happen in
concurrent access to the `HttpContext`.
This situation of race condition can happen while the request is
finished while async jobs still run in the background and the waf for
RASP is run.

The HttpContext can be disposed from different manner by the user. You
can find more information in this
[PR](#6529).

## Implementation details

- The getter for the `StatusCode` has been changed so it could return a
`int?` if an exception has been triggered.
- The method `ShouldAnalyzeSchema()` is already working with a null
`StatusCode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertpi robertpi robertpi left review comments
@andrewlock andrewlock andrewlock left review comments
@anna-git anna-git anna-git approved these changes
@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

@e-n-0 e-n-0

Labels

area:asm identified-by:telemetry

Projects

None yet

Milestone

3.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@e-n-0 @andrewlock @robertpi @anna-git @NachoEchevarria