Actually include child processes when requested during a memory dump in tests - part 2 :D #6537
Merged
Merged
Conversation
kevingosse
approved these changes
Jan 13, 2025
Datadog ReportBranch report: ✅ 0 Failed, 239016 Passed, 1965 Skipped, 18h 35m 3.03s Total Time |
Member
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6537) - mean (68ms) : 66, 71
. : milestone, 68,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6537) - mean (978ms) : 953, 1004
. : milestone, 978,
master - mean (979ms) : 948, 1010
. : milestone, 979,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6537) - mean (107ms) : 105, 109
. : milestone, 107,
master - mean (107ms) : 105, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6537) - mean (677ms) : 660, 695
. : milestone, 677,
master - mean (678ms) : 664, 693
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6537) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6537) - mean (628ms) : 611, 644
. : milestone, 628,
master - mean (635ms) : 620, 649
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6537) - mean (193ms) : 189, 198
. : milestone, 193,
master - mean (194ms) : 190, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6537) - mean (1,101ms) : 1059, 1142
. : milestone, 1101,
master - mean (1,103ms) : 1066, 1140
. : milestone, 1103,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6537) - mean (279ms) : 276, 282
. : milestone, 279,
master - mean (277ms) : 274, 281
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6537) - mean (871ms) : 844, 898
. : milestone, 871,
master - mean (870ms) : 843, 897
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6537) - mean (266ms) : 263, 270
. : milestone, 266,
master - mean (267ms) : 263, 271
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6537) - mean (845ms) : 807, 883
. : milestone, 845,
master - mean (852ms) : 825, 878
. : milestone, 852,
|
lucaspimentel
approved these changes
Jan 13, 2025
lucaspimentel
left a comment
lucaspimentel
left a comment
Member
There was a problem hiding this comment.
Third time is the charm.
tonyredondo
force-pushed
the
tony/actually-dump-children-2
branch
from
January 13, 2025 22:35
d204334 to
c8de0dd
Compare
chojomok
pushed a commit
that referenced
this pull request
Jul 15, 2025
…in tests - part 2 :D (#6537) ## Summary of changes Fix "dump child processes" not working ## Reason for change #6401 added the ability to say "dump the child processes too", except we didn't wire up the parameter. #6520 tried to fix it, but was missing another call. ## Implementation details Wire up the parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix "dump child processes" not working
Reason for change
#6401 added the ability to say "dump the child processes too", except we didn't wire up the parameter.
#6520 tried to fix it, but was missing another call.
Implementation details
Wire up the parameter