[CI Visibility] Use same number of execution in EFD tests#6416
Merged
Conversation
github-actions
Bot
added
area:tests
andrewlock
approved these changes
Dec 10, 2024
Datadog ReportBranch report: ✅ 0 Failed, 463942 Passed, 2877 Skipped, 19h 1m 31.2s Total Time |
Member
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6416) - mean (69ms) : 66, 73
. : milestone, 69,
master - mean (69ms) : 65, 73
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6416) - mean (983ms) : 961, 1005
. : milestone, 983,
master - mean (981ms) : 960, 1003
. : milestone, 981,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6416) - mean (109ms) : 106, 112
. : milestone, 109,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6416) - mean (681ms) : 666, 696
. : milestone, 681,
master - mean (679ms) : 666, 692
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6416) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6416) - mean (633ms) : 617, 648
. : milestone, 633,
master - mean (634ms) : 620, 649
. : milestone, 634,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6416) - mean (191ms) : 187, 196
. : milestone, 191,
master - mean (191ms) : 187, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6416) - mean (1,092ms) : 1064, 1119
. : milestone, 1092,
master - mean (1,093ms) : 1065, 1121
. : milestone, 1093,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6416) - mean (278ms) : 272, 284
. : milestone, 278,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6416) - mean (875ms) : 847, 903
. : milestone, 875,
master - mean (870ms) : 847, 893
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6416) - mean (267ms) : 262, 272
. : milestone, 267,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6416) - mean (853ms) : 822, 884
. : milestone, 853,
master - mean (850ms) : 818, 882
. : milestone, 850,
|
Member
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6416) (11.102M) : 0, 11102166
master (11.262M) : 0, 11261987
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6416) (7.234M) : 0, 7233816
master (7.252M) : 0, 7252121
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.492M) : 0, 7491512
section Manual
master (11.082M) : 0, 11081514
section Manual + Automatic
This PR (6416) (6.587M) : 0, 6587017
master (6.511M) : 0, 6511339
section DD_TRACE_ENABLED=0
master (10.305M) : 0, 10305041
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6416) (9.529M) : 0, 9529139
master (9.633M) : 0, 9633274
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6416) (6.472M) : 0, 6472430
master (6.436M) : 0, 6436394
section Trace stats
master (6.676M) : 0, 6676124
section Manual
master (9.575M) : 0, 9575331
section Manual + Automatic
This PR (6416) (6.046M) : 0, 6045678
master (5.718M) : 0, 5718155
section DD_TRACE_ENABLED=0
master (8.573M) : 0, 8572716
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6416) (10.388M) : 0, 10387609
master (9.876M) : 0, 9876001
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6416) (6.432M) : 0, 6431928
master (6.512M) : 0, 6511943
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.089M) : 0, 7089152
section Manual
master (10.204M) : 0, 10203572
section Manual + Automatic
This PR (6416) (5.571M) : crit ,0, 5570961
master (6.050M) : 0, 6050240
section DD_TRACE_ENABLED=0
master (9.471M) : 0, 9471285
|
veerbia
pushed a commit
that referenced
this pull request
Dec 16, 2024
## Summary of changes EFD changes the number of execution of a tests depending on the duration of that test. With this PR we use the same number of execution no matter the duration of the execution. ## Reason for change Our CI is unstable. Ticket: SDTEST-1313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
EFD changes the number of execution of a tests depending on the duration of that test. With this PR we use the same number of execution no matter the duration of the execution.
Reason for change
Our CI is unstable.
Ticket: SDTEST-1313