Skip to content

Report failures to update GitHub as build errors in Azure Devops#6407

Merged
andrewlock merged 4 commits into
masterfrom
andrew/ci/fail-github-updater-if-there-is-actually-an-error
Dec 6, 2024
Merged

Report failures to update GitHub as build errors in Azure Devops#6407
andrewlock merged 4 commits into
masterfrom
andrew/ci/fail-github-updater-if-there-is-actually-an-error

Conversation

@andrewlock

@andrewlock andrewlock commented Dec 6, 2024

Copy link
Copy Markdown
Member

Summary of changes

Try to make the github status updater show when it has failed to update GitHub

Reason for change

Currently you have to read the logs to even notice that it failed. With this change the error is flagged, but it doesn't actually stop the stage executing. But at least it's more obvious why Github didn't update if that happens

image

Implementation details

Curl twiddling. Added a --fail-with-body equivalent (not available in old curl)

Test coverage

Did a manual test to make sure it handles failures. This is the test for success

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 6, 2024
@andrewlock
andrewlock requested a review from a team as a code owner December 6, 2024 14:04
@andrewlock

andrewlock commented Dec 6, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6407) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (70ms)  : 64, 76
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6407) - mean (982ms)  : 951, 1014
     .   : milestone, 982,
    master - mean (983ms)  : 951, 1016
     .   : milestone, 983,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6407) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6407) - mean (680ms)  : 664, 696
     .   : milestone, 680,
    master - mean (683ms)  : 668, 698
     .   : milestone, 683,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6407) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 89, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6407) - mean (632ms)  : 620, 644
     .   : milestone, 632,
    master - mean (630ms)  : 611, 649
     .   : milestone, 630,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6407) - mean (190ms)  : 186, 195
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6407) - mean (1,092ms)  : 1064, 1121
     .   : milestone, 1092,
    master - mean (1,093ms)  : 1061, 1124
     .   : milestone, 1093,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6407) - mean (276ms)  : 271, 282
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6407) - mean (868ms)  : 836, 900
     .   : milestone, 868,
    master - mean (872ms)  : 833, 911
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6407) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6407) - mean (848ms)  : 811, 885
     .   : milestone, 848,
    master - mean (850ms)  : 814, 886
     .   : milestone, 850,
Loading

@datadog-ddstaging

datadog-ddstaging Bot commented Dec 6, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/fail-github-updater-if-there-is-actually-an-error
Commit report: cd39a05
Test service: dd-trace-dotnet

✅ 0 Failed, 450444 Passed, 2719 Skipped, 19h 19m 51.5s Total Time

@andrewlock

andrewlock commented Dec 6, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6407 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.160
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.09μs 46.3ns 334ns 0.0158 0.0079 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10μs 48.3ns 199ns 0.0195 0.00976 0 5.8 KB
master StartStopWithChild net472 16.6μs 62.8ns 243ns 1.07 0.339 0.0969 6.21 KB
#6407 StartStopWithChild net6.0 8.19μs 46.3ns 314ns 0.0211 0.00845 0 5.61 KB
#6407 StartStopWithChild netcoreapp3.1 10.1μs 56ns 331ns 0.0198 0.00989 0 5.8 KB
#6407 StartStopWithChild net472 16.2μs 37.1ns 139ns 1.05 0.317 0.0974 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 496μs 388ns 1.5μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 419ns 1.62μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 848μs 643ns 2.49μs 0.422 0 0 3.3 KB
#6407 WriteAndFlushEnrichedTraces net6.0 477μs 386ns 1.45μs 0 0 0 2.7 KB
#6407 WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 631ns 2.45μs 0 0 0 2.7 KB
#6407 WriteAndFlushEnrichedTraces net472 843μs 680ns 2.63μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 146μs 819ns 6.75μs 0.151 0 0 14.47 KB
master SendRequest netcoreapp3.1 168μs 964ns 7.15μs 0.165 0 0 17.27 KB
master SendRequest net472 0.00238ns 0.000945ns 0.00353ns 0 0 0 0 b
#6407 SendRequest net6.0 149μs 932ns 9.04μs 0.143 0 0 14.47 KB
#6407 SendRequest netcoreapp3.1 168μs 977ns 8.41μs 0.158 0 0 17.27 KB
#6407 SendRequest net472 0.00269ns 0.000915ns 0.00354ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 549μs 2.26μs 8.74μs 0.543 0 0 41.55 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.61μs 19.5μs 0.324 0 0 41.8 KB
master WriteAndFlushEnrichedTraces net472 824μs 2.3μs 8.91μs 8.12 2.44 0.406 53.26 KB
#6407 WriteAndFlushEnrichedTraces net6.0 558μs 2.95μs 14.7μs 0.573 0 0 41.66 KB
#6407 WriteAndFlushEnrichedTraces netcoreapp3.1 687μs 3.79μs 22.1μs 0.334 0 0 41.73 KB
#6407 WriteAndFlushEnrichedTraces net472 858μs 3.51μs 13.6μs 8.27 2.3 0.46 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6407

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.146 1,403.33 1,224.98

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.4μs 0.745ns 2.79ns 0.0147 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.72μs 1.38ns 5.35ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.12μs 1.28ns 4.78ns 0.156 0.00106 0 987 B
#6407 ExecuteNonQuery net6.0 1.23μs 1.15ns 4.32ns 0.014 0 0 1.02 KB
#6407 ExecuteNonQuery netcoreapp3.1 1.86μs 1.21ns 4.68ns 0.013 0 0 1.02 KB
#6407 ExecuteNonQuery net472 2.09μs 3.97ns 14.8ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.837ns 3.13ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.42μs 0.727ns 2.82ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.53μs 1.28ns 4.6ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.33μs 0.632ns 2.36ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 0.747ns 2.79ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.67μs 0.92ns 3.32ns 0.166 0 0 1.05 KB
#6407 CallElasticsearch net6.0 1.2μs 0.561ns 2.1ns 0.0139 0 0 976 B
#6407 CallElasticsearch netcoreapp3.1 1.56μs 0.605ns 2.34ns 0.0131 0 0 976 B
#6407 CallElasticsearch net472 2.63μs 3.08ns 11.9ns 0.157 0 0 995 B
#6407 CallElasticsearchAsync net6.0 1.29μs 0.44ns 1.59ns 0.0136 0 0 952 B
#6407 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.705ns 2.73ns 0.0132 0 0 1.02 KB
#6407 CallElasticsearchAsync net472 2.67μs 2.03ns 7.86ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.22μs 4.77ns 18.5ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.58μs 1.09ns 3.77ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.9μs 1.06ns 3.95ns 0.145 0 0 915 B
#6407 ExecuteAsync net6.0 1.26μs 0.285ns 1.06ns 0.0134 0 0 952 B
#6407 ExecuteAsync netcoreapp3.1 1.61μs 1ns 3.88ns 0.013 0 0 952 B
#6407 ExecuteAsync net472 1.85μs 0.654ns 2.45ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.34μs 1.9ns 7.36ns 0.0328 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.35μs 5.25ns 20.3ns 0.0375 0 0 2.85 KB
master SendAsync net472 7.34μs 2.35ns 9.1ns 0.495 0 0 3.12 KB
#6407 SendAsync net6.0 4.3μs 2.05ns 7.39ns 0.0325 0 0 2.31 KB
#6407 SendAsync netcoreapp3.1 5.35μs 1.95ns 7.04ns 0.0374 0 0 2.85 KB
#6407 SendAsync net472 7.4μs 1.35ns 5.24ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.53μs 0.541ns 1.95ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.14μs 1.04ns 4.02ns 0.0226 0 0 1.64 KB
master EnrichedLog net472 2.57μs 1.66ns 6.44ns 0.25 0 0 1.57 KB
#6407 EnrichedLog net6.0 1.51μs 0.87ns 3.25ns 0.0233 0 0 1.64 KB
#6407 EnrichedLog netcoreapp3.1 2.29μs 0.997ns 3.73ns 0.0217 0 0 1.64 KB
#6407 EnrichedLog net472 2.54μs 1.37ns 5.3ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 121μs 156ns 602ns 0.0605 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 124μs 176ns 659ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 166ns 644ns 0.681 0.227 0 4.46 KB
#6407 EnrichedLog net6.0 121μs 113ns 438ns 0 0 0 4.28 KB
#6407 EnrichedLog netcoreapp3.1 123μs 218ns 844ns 0 0 0 4.28 KB
#6407 EnrichedLog net472 153μs 205ns 796ns 0.683 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 0.921ns 3.57ns 0.0301 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 0.971ns 3.76ns 0.0287 0 0 2.2 KB
master EnrichedLog net472 4.83μs 0.88ns 3.41ns 0.319 0 0 2.02 KB
#6407 EnrichedLog net6.0 3.03μs 0.969ns 3.75ns 0.0313 0 0 2.2 KB
#6407 EnrichedLog netcoreapp3.1 4.37μs 1.09ns 3.94ns 0.0284 0 0 2.2 KB
#6407 EnrichedLog net472 4.89μs 1.28ns 4.94ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 0.811ns 3.14ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 0.628ns 2.18ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.19μs 0.943ns 3.53ns 0.184 0 0 1.16 KB
#6407 SendReceive net6.0 1.4μs 3.33ns 12.9ns 0.0158 0 0 1.14 KB
#6407 SendReceive netcoreapp3.1 1.79μs 0.798ns 3.09ns 0.0152 0 0 1.14 KB
#6407 SendReceive net472 2.14μs 0.812ns 2.93ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.72μs 0.814ns 3.05ns 0.023 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.78μs 2.66ns 9.23ns 0.0208 0 0 1.65 KB
master EnrichedLog net472 4.5μs 3.25ns 12.6ns 0.323 0 0 2.04 KB
#6407 EnrichedLog net6.0 2.64μs 0.627ns 2.26ns 0.0225 0 0 1.6 KB
#6407 EnrichedLog netcoreapp3.1 3.77μs 1.63ns 6.31ns 0.0227 0 0 1.65 KB
#6407 EnrichedLog net472 4.42μs 4.29ns 16.6ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6407

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.174 470.93 401.13

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 471ns 0.297ns 1.15ns 0.00796 0 0 576 B
master StartFinishSpan netcoreapp3.1 630ns 1.5ns 5.82ns 0.00779 0 0 576 B
master StartFinishSpan net472 694ns 0.325ns 1.26ns 0.0917 0 0 578 B
master StartFinishScope net6.0 512ns 0.245ns 0.916ns 0.00971 0 0 696 B
master StartFinishScope netcoreapp3.1 744ns 0.659ns 2.46ns 0.00945 0 0 696 B
master StartFinishScope net472 903ns 0.884ns 3.43ns 0.104 0 0 658 B
#6407 StartFinishSpan net6.0 401ns 0.189ns 0.73ns 0.00809 0 0 576 B
#6407 StartFinishSpan netcoreapp3.1 621ns 0.509ns 1.84ns 0.00779 0 0 576 B
#6407 StartFinishSpan net472 692ns 0.42ns 1.63ns 0.0916 0 0 578 B
#6407 StartFinishScope net6.0 563ns 0.19ns 0.735ns 0.00984 0 0 696 B
#6407 StartFinishScope netcoreapp3.1 770ns 0.718ns 2.69ns 0.00903 0 0 696 B
#6407 StartFinishScope net472 891ns 0.83ns 3.22ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 705ns 0.299ns 1.16ns 0.00956 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 912ns 0.844ns 3.27ns 0.00964 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.618ns 2.39ns 0.104 0 0 658 B
#6407 RunOnMethodBegin net6.0 722ns 0.365ns 1.41ns 0.00957 0 0 696 B
#6407 RunOnMethodBegin netcoreapp3.1 891ns 0.815ns 3.05ns 0.00928 0 0 696 B
#6407 RunOnMethodBegin net472 1.12μs 0.469ns 1.82ns 0.104 0 0 658 B

@andrewlock

andrewlock commented Dec 6, 2024

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6407) (11.116M)   : 0, 11116413
    master (11.222M)   : 0, 11222377
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6407) (7.327M)   : 0, 7327345
    master (7.295M)   : 0, 7295198
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.617M)   : 0, 7617239

    section Manual
    master (11.103M)   : 0, 11103312

    section Manual + Automatic
    This PR (6407) (6.770M)   : 0, 6770160
    master (6.800M)   : 0, 6800354

    section DD_TRACE_ENABLED=0
    master (10.297M)   : 0, 10296599
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6407) (9.435M)   : 0, 9435018
    master (9.664M)   : 0, 9663556
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6407) (6.403M)   : 0, 6402868
    master (6.370M)   : 0, 6370167

    section Trace stats
    master (6.651M)   : 0, 6651347

    section Manual
    master (9.507M)   : 0, 9507020

    section Manual + Automatic
    This PR (6407) (5.982M)   : 0, 5981601
    master (5.958M)   : 0, 5958068

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8805671
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6407) (9.943M)   : 0, 9943393
    master (9.923M)   : 0, 9923158
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6407) (6.447M)   : 0, 6447291
    master (6.497M)   : 0, 6497176
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.136M)   : 0, 7135726

    section Manual
    master (10.002M)   : 0, 10001926

    section Manual + Automatic
    This PR (6407) (5.910M)   : 0, 5909672
    master (5.814M)   : 0, 5814052

    section DD_TRACE_ENABLED=0
    master (9.150M)   : 0, 9150488
Loading

@andrewlock
andrewlock merged commit 41614dd into master Dec 6, 2024
@andrewlock
andrewlock deleted the andrew/ci/fail-github-updater-if-there-is-actually-an-error branch December 6, 2024 17:13
@github-actions github-actions Bot added this to the vNext-v3 milestone Dec 6, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
@andrewlock @veerbia
Report failures to update GitHub as build errors in Azure Devops (#6407)
ec65c33 
## Summary of changes

Try to make the github status updater show when it has failed to update
GitHub

## Reason for change

Currently you have to read the logs to even notice that it failed. With
this change the error is flagged, but it doesn't actually stop the stage
executing. But at least it's more obvious why Github didn't update if
that happens


![image](https://github.com/user-attachments/assets/e246dc1e-ebc0-473d-a344-f0fc194209c0)


## Implementation details

Curl twiddling. Added a `--fail-with-body` equivalent (not available in
old curl)

## Test coverage

[Did a manual
test](https://dev.azure.com/datadoghq/dd-trace-dotnet/_build/results?buildId=169554&view=logs&j=566fcd0b-f504-55d6-728b-d26f0accf189&t=69bb809e-fbe8-5455-a3da-5a168e4e5c11)
to make sure it handles failures. This is the test for success
@andrewlock andrewlock mentioned this pull request Dec 17, 2024
Merged
andrewlock added a commit that referenced this pull request Dec 17, 2024
@andrewlock
Fix the no-op pipeline (#6449)
0b82c1e 
## Summary of changes

Fix broken github status action

## Reason for change

The github status upload is broken, because we're not splitting on `;`
as expected

## Implementation details

Add missing `export IFS=";"`, accidentally deleted in #6407

## Test coverage

This is the test

## Other details

Currently blocking #6445
chojomok pushed a commit that referenced this pull request Jul 15, 2025
@andrewlock @chojomok
Fix the no-op pipeline (#6449)
9e5b9b8 
## Summary of changes

Fix broken github status action

## Reason for change

The github status upload is broken, because we're not splitting on `;`
as expected

## Implementation details

Add missing `export IFS=";"`, accidentally deleted in #6407

## Test coverage

This is the test

## Other details

Currently blocking #6445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @kevingosse