Skip to content

Removing MetaStruct Check from TestDirectoryListingLeak#6404

Merged
link04 merged 6 commits into
masterfrom
maximo/removing-MetaStruct-from-TestDirectoryListingLeak
Dec 5, 2024
Merged

Removing MetaStruct Check from TestDirectoryListingLeak#6404
link04 merged 6 commits into
masterfrom
maximo/removing-MetaStruct-from-TestDirectoryListingLeak

Conversation

@link04

@link04 link04 commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

Same as #6395 this test is part of the same family and I just noticed it also sometimes flakes without the expected snapshot.

@link04
link04 requested a review from a team as a code owner December 5, 2024 15:01
@github-actions

github-actions Bot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

-    },
-    MetaStruct: {
-      iast:

@github-actions github-actions Bot added the area:tests unit tests, integration tests label Dec 5, 2024
andrewlock
andrewlock approved these changes Dec 5, 2024
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread tracer/test/Datadog.Trace.Security.IntegrationTests/IAST/AspNetCore5IastTests.cs
newFixture.SetOutput(Output);

var datetimeOffset = DateTimeOffset.UtcNow; // Catch vulnerability at the startup of the app
await TryStartApp(newFixture);

@andrewlock andrewlock Dec 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder, should the default be to set new MockTracerAgent.AgentConfiguration { SpanMetaStructs = false } - I feel like we're just waiting for some more flake somewhere else otherwise 😄

@link04 link04 Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question 💀, so far these two seem to be the tests where we // Catch vulnerability at the startup of the app hence why this flake is happening(we missed that test in the last PR), if we do see another flake I'll have to check if ASM wants to do a change and where. cc @e-n-0

@datadog-ddstaging

datadog-ddstaging Bot commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: maximo/removing-MetaStruct-from-TestDirectoryListingLeak
Commit report: 3c56f60
Test service: dd-trace-dotnet

✅ 0 Failed, 452859 Passed, 2747 Skipped, 20h 12m 31.18s Total Time

@andrewlock

andrewlock commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6404) - mean (71ms)  : 63, 78
     .   : milestone, 71,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6404) - mean (985ms)  : 960, 1010
     .   : milestone, 985,
    master - mean (975ms)  : 946, 1004
     .   : milestone, 975,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6404) - mean (108ms)  : 105, 112
     .   : milestone, 108,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6404) - mean (677ms)  : 663, 691
     .   : milestone, 677,
    master - mean (680ms)  : 667, 693
     .   : milestone, 680,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6404) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6404) - mean (629ms)  : 616, 642
     .   : milestone, 629,
    master - mean (632ms)  : 615, 649
     .   : milestone, 632,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6404) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6404) - mean (1,097ms)  : 1062, 1132
     .   : milestone, 1097,
    master - mean (1,091ms)  : 1060, 1122
     .   : milestone, 1091,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6404) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6404) - mean (868ms)  : 841, 895
     .   : milestone, 868,
    master - mean (867ms)  : 844, 890
     .   : milestone, 867,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6404) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (267ms)  : 262, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6404) - mean (842ms)  : 809, 875
     .   : milestone, 842,
    master - mean (849ms)  : 822, 876
     .   : milestone, 849,
Loading

@andrewlock

andrewlock commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6404 compared to master:

  • All benchmarks have the same speed
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 217μs 145ns 522ns 2.87 0 0 205.48 KB
master AllCycleSimpleBody netcoreapp3.1 310μs 236ns 881ns 2.79 0 0 212.92 KB
master AllCycleSimpleBody net472 280μs 505ns 1.89μs 38.1 2.94 0 240.1 KB
master AllCycleMoreComplexBody net6.0 222μs 91.8ns 318ns 2.89 0 0 208.98 KB
master AllCycleMoreComplexBody netcoreapp3.1 327μs 129ns 499ns 2.95 0 0 216.34 KB
master AllCycleMoreComplexBody net472 288μs 299ns 1.16μs 38.7 2.87 0 243.61 KB
master ObjectExtractorSimpleBody net6.0 136ns 0.112ns 0.433ns 0.00391 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 200ns 0.138ns 0.518ns 0.00372 0 0 272 B
master ObjectExtractorSimpleBody net472 212ns 0.256ns 0.993ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.95μs 1.66ns 6.19ns 0.0532 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.02μs 1.65ns 6.16ns 0.0502 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 4.19μs 3.45ns 13.4ns 0.603 0.0063 0 3.8 KB
#6404 AllCycleSimpleBody net6.0 219μs 120ns 449ns 2.84 0.109 0 205.48 KB
#6404 AllCycleSimpleBody netcoreapp3.1 323μs 117ns 422ns 2.86 0 0 212.92 KB
#6404 AllCycleSimpleBody net472 285μs 589ns 2.28μs 38.1 2.85 0 240.1 KB
#6404 AllCycleMoreComplexBody net6.0 223μs 124ns 480ns 2.98 0 0 208.98 KB
#6404 AllCycleMoreComplexBody netcoreapp3.1 326μs 184ns 664ns 2.94 0 0 216.34 KB
#6404 AllCycleMoreComplexBody net472 289μs 490ns 1.9μs 38.6 2.87 0 243.61 KB
#6404 ObjectExtractorSimpleBody net6.0 143ns 0.158ns 0.612ns 0.00391 0 0 280 B
#6404 ObjectExtractorSimpleBody netcoreapp3.1 203ns 0.15ns 0.56ns 0.00379 0 0 272 B
#6404 ObjectExtractorSimpleBody net472 212ns 0.229ns 0.887ns 0.0446 0 0 281 B
#6404 ObjectExtractorMoreComplexBody net6.0 2.99μs 1.53ns 5.73ns 0.0536 0 0 3.78 KB
#6404 ObjectExtractorMoreComplexBody netcoreapp3.1 3.95μs 3.25ns 12.6ns 0.0513 0 0 3.69 KB
#6404 ObjectExtractorMoreComplexBody net472 4.24μs 3.94ns 15.2ns 0.603 0.00639 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 38μs 16.8ns 62.8ns 0.454 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54.5μs 26.2ns 101ns 0.435 0 0 32.4 KB
master EncodeArgs net472 67.5μs 45.1ns 169ns 5.15 0.0673 0 32.5 KB
master EncodeLegacyArgs net6.0 74.6μs 391ns 2.03μs 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 105μs 103ns 399ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 155μs 74.3ns 278ns 0.31 0 0 2.15 KB
#6404 EncodeArgs net6.0 36.5μs 15.9ns 59.6ns 0.456 0 0 32.4 KB
#6404 EncodeArgs netcoreapp3.1 54.1μs 20.6ns 79.6ns 0.431 0 0 32.4 KB
#6404 EncodeArgs net472 68.3μs 53.4ns 207ns 5.15 0.0682 0 32.5 KB
#6404 EncodeLegacyArgs net6.0 69.6μs 50ns 194ns 0.0348 0 0 2.14 KB
#6404 EncodeLegacyArgs netcoreapp3.1 106μs 433ns 1.68μs 0 0 0 2.14 KB
#6404 EncodeLegacyArgs net472 155μs 76.2ns 295ns 0.312 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 182μs 91.4ns 342ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 194μs 168ns 651ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 209μs 97.4ns 377ns 0.313 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 77.9ns 302ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 124ns 479ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 139μs 61.9ns 240ns 0.209 0 0 1.49 KB
#6404 RunWafRealisticBenchmark net6.0 183μs 153ns 591ns 0 0 0 2.44 KB
#6404 RunWafRealisticBenchmark netcoreapp3.1 197μs 454ns 1.76μs 0 0 0 2.39 KB
#6404 RunWafRealisticBenchmark net472 210μs 149ns 577ns 0.314 0 0 2.46 KB
#6404 RunWafRealisticBenchmarkWithAttack net6.0 122μs 75.5ns 272ns 0 0 0 1.47 KB
#6404 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 251ns 971ns 0 0 0 1.46 KB
#6404 RunWafRealisticBenchmarkWithAttack net472 140μs 100ns 376ns 0.21 0 0 1.48 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6404

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 58.65 KB 62.02 KB 3.38 KB 5.76%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 253.21 KB 264.8 KB 11.59 KB 4.58%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 61.3μs 688ns 6.84μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 56.1μs 270ns 1.15μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.9μs 112ns 386ns 0 0 0 58.65 KB
master StringConcatAspectBenchmark net6.0 286μs 4.78μs 47.4μs 0 0 0 253.43 KB
master StringConcatAspectBenchmark netcoreapp3.1 307μs 5.41μs 53μs 0 0 0 253.21 KB
master StringConcatAspectBenchmark net472 292μs 5.79μs 56.2μs 0 0 0 278.53 KB
#6404 StringConcatBenchmark net6.0 63.4μs 835ns 8.35μs 0 0 0 43.44 KB
#6404 StringConcatBenchmark netcoreapp3.1 55μs 300ns 1.8μs 0 0 0 42.64 KB
#6404 StringConcatBenchmark net472 37.3μs 85.4ns 296ns 0 0 0 62.02 KB
#6404 StringConcatAspectBenchmark net6.0 317μs 1.56μs 9.77μs 0 0 0 254.56 KB
#6404 StringConcatAspectBenchmark netcoreapp3.1 363μs 2.01μs 17.5μs 0 0 0 264.8 KB
#6404 StringConcatAspectBenchmark net472 295μs 6.12μs 59.3μs 0 0 0 278.53 KB

@andrewlock

andrewlock commented Dec 5, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6404 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.149
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.11μs 46.2ns 330ns 0.0206 0.00822 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 52.7ns 253ns 0.0199 0.00997 0 5.8 KB
master StartStopWithChild net472 16.1μs 62.4ns 242ns 1.05 0.324 0.105 6.21 KB
#6404 StartStopWithChild net6.0 7.86μs 42.6ns 286ns 0.0164 0.00819 0 5.61 KB
#6404 StartStopWithChild netcoreapp3.1 10.1μs 55.3ns 332ns 0.0148 0.00494 0 5.8 KB
#6404 StartStopWithChild net472 16.2μs 48.1ns 186ns 1.05 0.323 0.103 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 512μs 207ns 803ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 540ns 2.09μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 867μs 522ns 1.95μs 0.431 0 0 3.3 KB
#6404 WriteAndFlushEnrichedTraces net6.0 483μs 383ns 1.48μs 0 0 0 2.7 KB
#6404 WriteAndFlushEnrichedTraces netcoreapp3.1 649μs 639ns 2.48μs 0 0 0 2.7 KB
#6404 WriteAndFlushEnrichedTraces net472 846μs 643ns 2.49μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 152μs 889ns 8.48μs 0.151 0 0 14.47 KB
master SendRequest netcoreapp3.1 168μs 986ns 9.66μs 0.163 0 0 17.27 KB
master SendRequest net472 0.00269ns 0.000968ns 0.00375ns 0 0 0 0 b
#6404 SendRequest net6.0 150μs 874ns 8.01μs 0.146 0 0 14.47 KB
#6404 SendRequest netcoreapp3.1 169μs 972ns 8.14μs 0.193 0 0 17.27 KB
#6404 SendRequest net472 3.5E‑05ns 3.5E‑05ns 0.000126ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 546μs 1.93μs 6.97μs 0.543 0 0 41.49 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 3.01μs 13.1μs 0.324 0 0 41.93 KB
master WriteAndFlushEnrichedTraces net472 846μs 4.16μs 19.1μs 8.33 2.5 0.417 53.29 KB
#6404 WriteAndFlushEnrichedTraces net6.0 579μs 3.04μs 15.5μs 0.556 0 0 41.69 KB
#6404 WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.74μs 22.1μs 0.316 0 0 41.88 KB
#6404 WriteAndFlushEnrichedTraces net472 857μs 3.72μs 14.4μs 8.5 2.55 0.425 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.26μs 1.47ns 5.68ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.07ns 4ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 2.12ns 8.22ns 0.157 0.00103 0 987 B
#6404 ExecuteNonQuery net6.0 1.31μs 0.865ns 3.35ns 0.0144 0 0 1.02 KB
#6404 ExecuteNonQuery netcoreapp3.1 1.77μs 1.78ns 6.89ns 0.0134 0 0 1.02 KB
#6404 ExecuteNonQuery net472 2.07μs 2.91ns 11.3ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.28μs 0.545ns 2.04ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 1.75ns 6.78ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.62μs 2.27ns 8.79ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 0.392ns 1.47ns 0.0129 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 1.16ns 4.34ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.68μs 1.45ns 5.62ns 0.166 0 0 1.05 KB
#6404 CallElasticsearch net6.0 1.23μs 0.829ns 3.1ns 0.0136 0 0 976 B
#6404 CallElasticsearch netcoreapp3.1 1.54μs 0.648ns 2.51ns 0.0131 0 0 976 B
#6404 CallElasticsearch net472 2.47μs 2.16ns 8.35ns 0.157 0 0 995 B
#6404 CallElasticsearchAsync net6.0 1.32μs 0.49ns 1.83ns 0.0134 0 0 952 B
#6404 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.391ns 1.41ns 0.0139 0 0 1.02 KB
#6404 CallElasticsearchAsync net472 2.66μs 1.8ns 6.97ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.727ns 2.72ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.673ns 2.43ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.82μs 0.461ns 1.73ns 0.145 0 0 915 B
#6404 ExecuteAsync net6.0 1.29μs 0.962ns 3.6ns 0.0129 0 0 952 B
#6404 ExecuteAsync netcoreapp3.1 1.59μs 0.35ns 1.26ns 0.013 0 0 952 B
#6404 ExecuteAsync net472 1.83μs 0.335ns 1.21ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.6μs 3.96ns 13.7ns 0.0323 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.26μs 2.08ns 8.06ns 0.0395 0 0 2.85 KB
master SendAsync net472 7.36μs 1.75ns 6.79ns 0.493 0 0 3.12 KB
#6404 SendAsync net6.0 4.35μs 1.47ns 5.71ns 0.0327 0 0 2.31 KB
#6404 SendAsync netcoreapp3.1 5.15μs 2.84ns 10.6ns 0.0389 0 0 2.85 KB
#6404 SendAsync net472 7.33μs 1.32ns 5.12ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.57μs 1.12ns 4.19ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.27μs 0.74ns 2.67ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.68μs 1.48ns 5.71ns 0.249 0 0 1.57 KB
#6404 EnrichedLog net6.0 1.46μs 0.791ns 2.96ns 0.0228 0 0 1.64 KB
#6404 EnrichedLog netcoreapp3.1 2.28μs 0.824ns 3.19ns 0.022 0 0 1.64 KB
#6404 EnrichedLog net472 2.54μs 1.63ns 6.3ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 120μs 122ns 474ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 101ns 390ns 0.062 0 0 4.28 KB
master EnrichedLog net472 153μs 82.1ns 307ns 0.689 0.23 0 4.46 KB
#6404 EnrichedLog net6.0 121μs 153ns 593ns 0 0 0 4.28 KB
#6404 EnrichedLog netcoreapp3.1 122μs 176ns 682ns 0.0612 0 0 4.28 KB
#6404 EnrichedLog net472 152μs 115ns 446ns 0.683 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.03μs 0.858ns 3.32ns 0.0304 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.21μs 1.92ns 7.43ns 0.0292 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.37ns 5.3ns 0.32 0 0 2.02 KB
#6404 EnrichedLog net6.0 3.06μs 1.09ns 4.24ns 0.0305 0 0 2.2 KB
#6404 EnrichedLog netcoreapp3.1 4.14μs 2.36ns 9.13ns 0.029 0 0 2.2 KB
#6404 EnrichedLog net472 5μs 2.2ns 8.53ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.45μs 1.63ns 6.32ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 0.828ns 3.21ns 0.0159 0 0 1.14 KB
master SendReceive net472 2.1μs 1.75ns 6.79ns 0.183 0 0 1.16 KB
#6404 SendReceive net6.0 1.42μs 0.997ns 3.86ns 0.0157 0 0 1.14 KB
#6404 SendReceive netcoreapp3.1 1.87μs 1.6ns 6.21ns 0.015 0 0 1.14 KB
#6404 SendReceive net472 2.19μs 1.98ns 7.39ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 1.38ns 5.35ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 1.3ns 4.87ns 0.0215 0 0 1.65 KB
master EnrichedLog net472 4.49μs 3.15ns 12.2ns 0.322 0 0 2.04 KB
#6404 EnrichedLog net6.0 2.74μs 0.698ns 2.61ns 0.0217 0 0 1.6 KB
#6404 EnrichedLog netcoreapp3.1 3.9μs 0.904ns 3.26ns 0.0215 0 0 1.65 KB
#6404 EnrichedLog net472 4.45μs 3.96ns 15.3ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6404

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.149 636.90 554.43

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 394ns 0.665ns 2.58ns 0.00808 0 0 576 B
master StartFinishSpan netcoreapp3.1 607ns 1.15ns 4.44ns 0.00778 0 0 576 B
master StartFinishSpan net472 629ns 1.58ns 6.1ns 0.0916 0 0 578 B
master StartFinishScope net6.0 636ns 1.09ns 4.24ns 0.00957 0 0 696 B
master StartFinishScope netcoreapp3.1 689ns 1.02ns 3.97ns 0.00941 0 0 696 B
master StartFinishScope net472 901ns 3.72ns 14.4ns 0.104 0 0 658 B
#6404 StartFinishSpan net6.0 395ns 0.459ns 1.78ns 0.00804 0 0 576 B
#6404 StartFinishSpan netcoreapp3.1 560ns 0.858ns 3.32ns 0.00773 0 0 576 B
#6404 StartFinishSpan net472 610ns 2.31ns 8.95ns 0.0917 0 0 578 B
#6404 StartFinishScope net6.0 554ns 0.899ns 3.48ns 0.00974 0 0 696 B
#6404 StartFinishScope netcoreapp3.1 759ns 1.4ns 5.42ns 0.00951 0 0 696 B
#6404 StartFinishScope net472 905ns 1.71ns 6.6ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 648ns 1.7ns 6.6ns 0.00959 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 946ns 3.99ns 15.4ns 0.00904 0 0 696 B
master RunOnMethodBegin net472 1.12μs 1.06ns 3.95ns 0.104 0 0 658 B
#6404 RunOnMethodBegin net6.0 633ns 0.669ns 2.59ns 0.00982 0 0 696 B
#6404 RunOnMethodBegin netcoreapp3.1 1μs 0.466ns 1.74ns 0.0091 0 0 696 B
#6404 RunOnMethodBegin net472 1.11μs 0.977ns 3.79ns 0.104 0 0 658 B

@link04
link04 merged commit af0bf3e into master Dec 5, 2024
@link04
link04 deleted the maximo/removing-MetaStruct-from-TestDirectoryListingLeak branch December 5, 2024 20:57
@github-actions github-actions Bot added this to the vNext-v3 milestone Dec 5, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
@link04 @veerbia
Removing MetaStruct Check from TestDirectoryListingLeak (#6404)
ee3ad4b 
## Summary of changes
Same as #6395 this test
is part of the same family and I just noticed it also sometimes flakes
without the expected snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@link04 @andrewlock @e-n-0