Use the signature builder in more places by kevingosse · Pull Request #6384 · DataDog/dd-trace-dotnet

kevingosse · 2024-12-03T11:45:48Z

Summary of changes

Use the signature builder in FaultTolerantRewriter

Reason for change

Cleaner code

andrewlock · 2024-12-03T12:23:28Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6384) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6384) - mean (979ms)  : 951, 1007
     .   : milestone, 979,
    master - mean (977ms)  : 957, 996
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6384) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6384) - mean (679ms)  : 667, 691
     .   : milestone, 679,
    master - mean (677ms)  : 661, 692
     .   : milestone, 677,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6384) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 89, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6384) - mean (635ms)  : 620, 649
     .   : milestone, 635,
    master - mean (634ms)  : 616, 652
     .   : milestone, 634,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6384) - mean (191ms)  : 186, 195
     .   : milestone, 191,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6384) - mean (1,093ms)  : 1065, 1121
     .   : milestone, 1093,
    master - mean (1,090ms)  : 1059, 1121
     .   : milestone, 1090,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6384) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6384) - mean (871ms)  : 846, 896
     .   : milestone, 871,
    master - mean (870ms)  : 839, 901
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6384) - mean (266ms)  : 260, 271
     .   : milestone, 266,
    master - mean (266ms)  : 260, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6384) - mean (848ms)  : 821, 876
     .   : milestone, 848,
    master - mean (849ms)  : 812, 887
     .   : milestone, 849,

datadog-ddstaging · 2024-12-03T13:21:30Z

Datadog Report

Branch report: 12-03-use_the_builder_in_more_places
Commit report: 30bb4fc
Test service: dd-trace-dotnet

✅ 0 Failed, 458035 Passed, 3573 Skipped, 33h 3m 11.34s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

TestSessionTimeoutVulnerability - Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsRestartedSampleIastEnabled - Last Failure

Expand for error

 Results do not match.
 Differences:
 Received: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.received.txt
 Verified: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: session_timeout,
 ...

TestSessionTimeoutVulnerability - Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsRestartedSampleIastEnabled - Last Failure

Expand for error

 Results do not match.
 Differences:
 Received: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.received.txt
 Verified: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: session_timeout,
 ...

GreenMatan

Thanks! :)

andrewlock · 2024-12-04T03:45:15Z

Benchmarks Report for tracer 🐌

Benchmarks for #6384 compared to master:

1 benchmarks are faster, with geometric mean 1.128
1 benchmarks are slower, with geometric mean 1.161
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.11μs	46.2ns	339ns	0.0204	0.00817	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	55.7ns	370ns	0.0242	0.0145	0.00483	5.8 KB
master	`StartStopWithChild`	net472	16.1μs	54.7ns	212ns	1.04	0.295	0.104	6.21 KB
#6384	`StartStopWithChild`	net6.0	7.94μs	44.4ns	304ns	0.0226	0.00753	0	5.61 KB
#6384	`StartStopWithChild`	netcoreapp3.1	9.92μs	51.9ns	264ns	0.0147	0.0049	0	5.81 KB
#6384	`StartStopWithChild`	net472	16μs	35.6ns	138ns	1.06	0.338	0.11	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	494μs	221ns	796ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	351ns	1.36μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	849μs	299ns	1.16μs	0.425	3.3 KB
#6384	`WriteAndFlushEnrichedTraces`	net6.0	474μs	398ns	1.54μs	0	2.7 KB
#6384	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	215ns	775ns	0	2.7 KB
#6384	`WriteAndFlushEnrichedTraces`	net472	836μs	336ns	1.3μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	147μs	845ns	7.36μs	0.142	14.47 KB
master	`SendRequest`	netcoreapp3.1	160μs	769ns	5.04μs	0.156	17.27 KB
master	`SendRequest`	net472	0.000368ns	0.000204ns	0.000763ns	0	0 b
#6384	`SendRequest`	net6.0	146μs	837ns	6.48μs	0.142	14.47 KB
#6384	`SendRequest`	netcoreapp3.1	164μs	880ns	4.66μs	0.168	17.27 KB
#6384	`SendRequest`	net472	9.88E‑05ns	9.88E‑05ns	0.00037ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	561μs	2.23μs	8.02μs	0.571	0	0	41.72 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	720μs	4.04μs	25.5μs	0.351	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	859μs	3.3μs	12.3μs	8.45	2.53	0.422	53.27 KB
#6384	`WriteAndFlushEnrichedTraces`	net6.0	566μs	2.33μs	8.71μs	0.553	0	0	41.6 KB
#6384	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	3.34μs	14.2μs	0.338	0	0	41.78 KB
#6384	`WriteAndFlushEnrichedTraces`	net472	885μs	4.41μs	19.7μs	8.36	2.64	0.44	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	0.902ns	3.49ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.8μs	2.42ns	9.36ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2μs	4.01ns	15.5ns	0.156	0.00101	987 B
#6384	`ExecuteNonQuery`	net6.0	1.29μs	1.76ns	6.82ns	0.0141	0	1.02 KB
#6384	`ExecuteNonQuery`	netcoreapp3.1	1.82μs	1.24ns	4.64ns	0.0136	0	1.02 KB
#6384	`ExecuteNonQuery`	net472	2.08μs	2.42ns	9.37ns	0.157	0.00105	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.21μs	0.54ns	2.02ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.89ns	3.45ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.62μs	1.55ns	5.6ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.29μs	0.947ns	3.54ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.49ns	5.78ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	1.49ns	5.57ns	0.167	1.05 KB
#6384	`CallElasticsearch`	net6.0	1.32μs	0.629ns	2.35ns	0.0133	976 B
#6384	`CallElasticsearch`	netcoreapp3.1	1.63μs	0.599ns	2.24ns	0.0129	976 B
#6384	`CallElasticsearch`	net472	2.5μs	1.86ns	7.2ns	0.157	995 B
#6384	`CallElasticsearchAsync`	net6.0	1.34μs	0.501ns	1.87ns	0.0132	952 B
#6384	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.699ns	2.71ns	0.0138	1.02 KB
#6384	`CallElasticsearchAsync`	net472	2.66μs	1.91ns	7.15ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.44μs	0.812ns	3.04ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	1.83ns	6.84ns	0.013	952 B
master	`ExecuteAsync`	net472	1.91μs	0.65ns	2.43ns	0.145	915 B
#6384	`ExecuteAsync`	net6.0	1.31μs	0.38ns	1.47ns	0.0131	952 B
#6384	`ExecuteAsync`	netcoreapp3.1	1.62μs	1.03ns	4ns	0.013	952 B
#6384	`ExecuteAsync`	net472	1.83μs	0.405ns	1.52ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.42μs	1.75ns	6.77ns	0.0332	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.28μs	1.7ns	6.57ns	0.0397	2.85 KB
master	`SendAsync`	net472	7.27μs	2.01ns	7.79ns	0.494	3.12 KB
#6384	`SendAsync`	net6.0	4.43μs	1.67ns	6.24ns	0.0311	2.31 KB
#6384	`SendAsync`	netcoreapp3.1	5.56μs	1.18ns	4.43ns	0.0365	2.85 KB
#6384	`SendAsync`	net472	7.33μs	1.44ns	5.39ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.47μs	0.613ns	2.37ns	0.0235	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	5.23ns	20.3ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.76μs	2.64ns	10.2ns	0.249	1.57 KB
#6384	`EnrichedLog`	net6.0	1.49μs	0.722ns	2.7ns	0.023	1.64 KB
#6384	`EnrichedLog`	netcoreapp3.1	2.27μs	6.69ns	25.9ns	0.0224	1.64 KB
#6384	`EnrichedLog`	net472	2.8μs	3.25ns	12.6ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	166ns	642ns	0.0598	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	99.7ns	359ns	0.0627	0	4.28 KB
master	`EnrichedLog`	net472	152μs	60.7ns	235ns	0.686	0.229	4.46 KB
#6384	`EnrichedLog`	net6.0	120μs	172ns	664ns	0.0597	0	4.28 KB
#6384	`EnrichedLog`	netcoreapp3.1	124μs	68.3ns	256ns	0	0	4.28 KB
#6384	`EnrichedLog`	net472	153μs	223ns	864ns	0.685	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.04μs	1.37ns	5.32ns	0.0302	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.26μs	1.24ns	4.64ns	0.0297	2.2 KB
master	`EnrichedLog`	net472	4.93μs	1.71ns	6.61ns	0.32	2.02 KB
#6384	`EnrichedLog`	net6.0	2.97μs	1.23ns	4.76ns	0.0298	2.2 KB
#6384	`EnrichedLog`	netcoreapp3.1	4.09μs	2.66ns	10.3ns	0.0307	2.2 KB
#6384	`EnrichedLog`	net472	4.87μs	0.983ns	3.68ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.25μs	0.349ns	1.35ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.82μs	0.984ns	3.81ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.07μs	0.763ns	2.86ns	0.183	1.16 KB
#6384	`SendReceive`	net6.0	1.32μs	0.436ns	1.69ns	0.0157	1.14 KB
#6384	`SendReceive`	netcoreapp3.1	1.72μs	0.841ns	3.15ns	0.0154	1.14 KB
#6384	`SendReceive`	net472	2.13μs	0.936ns	3.37ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.69μs	1.31ns	5.06ns	0.0216	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.97μs	1.25ns	4.69ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.39μs	2.49ns	9.64ns	0.322	2.04 KB
#6384	`EnrichedLog`	net6.0	2.72μs	1.11ns	4.15ns	0.0217	1.6 KB
#6384	`EnrichedLog`	netcoreapp3.1	3.95μs	1.42ns	5.51ns	0.0217	1.65 KB
#6384	`EnrichedLog`	net472	4.44μs	3.3ns	12.8ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6384

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.161	491.24	570.10

Faster 🎉 in #6384

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.128	913.80	810.22

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	396ns	0.85ns	3.29ns	0.00808	576 B
master	`StartFinishSpan`	netcoreapp3.1	589ns	0.507ns	1.83ns	0.00793	576 B
master	`StartFinishSpan`	net472	728ns	1.46ns	5.66ns	0.0917	578 B
master	`StartFinishScope`	net6.0	490ns	0.582ns	2.25ns	0.00976	696 B
master	`StartFinishScope`	netcoreapp3.1	663ns	1.32ns	5.1ns	0.00915	696 B
master	`StartFinishScope`	net472	914ns	2.22ns	8.58ns	0.104	658 B
#6384	`StartFinishSpan`	net6.0	392ns	0.628ns	2.35ns	0.00808	576 B
#6384	`StartFinishSpan`	netcoreapp3.1	556ns	0.362ns	1.35ns	0.00769	576 B
#6384	`StartFinishSpan`	net472	682ns	0.682ns	2.46ns	0.0915	578 B
#6384	`StartFinishScope`	net6.0	570ns	0.86ns	3.33ns	0.00979	696 B
#6384	`StartFinishScope`	netcoreapp3.1	668ns	0.651ns	2.35ns	0.00942	696 B
#6384	`StartFinishScope`	net472	809ns	1.95ns	7.56ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	687ns	1.32ns	5.13ns	0.00957	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	903ns	1.55ns	5.98ns	0.00936	696 B
master	`RunOnMethodBegin`	net472	1.07μs	2ns	7.75ns	0.104	658 B
#6384	`RunOnMethodBegin`	net6.0	664ns	0.768ns	2.97ns	0.00985	696 B
#6384	`RunOnMethodBegin`	netcoreapp3.1	942ns	1.51ns	5.86ns	0.00938	696 B
#6384	`RunOnMethodBegin`	net472	1.13μs	2.31ns	8.93ns	0.104	658 B

andrewlock · 2024-12-04T11:14:18Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6384) (11.231M)   : 0, 11231339
    master (11.163M)   : 0, 11163279
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6384) (7.257M)   : 0, 7257465
    master (7.379M)   : 0, 7378518
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.698M)   : 0, 7697685

    section Manual
    master (11.208M)   : 0, 11207970

    section Manual + Automatic
    This PR (6384) (6.707M)   : 0, 6707051
    master (6.848M)   : 0, 6847878

    section DD_TRACE_ENABLED=0
    master (10.300M)   : 0, 10300258

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6384) (9.435M)   : 0, 9434656
    master (9.614M)   : 0, 9613662
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6384) (6.405M)   : 0, 6405017
    master (6.420M)   : 0, 6420484

    section Trace stats
    master (6.620M)   : 0, 6620303

    section Manual
    master (9.598M)   : 0, 9598372

    section Manual + Automatic
    This PR (6384) (6.026M)   : 0, 6025567
    master (5.968M)   : 0, 5968390

    section DD_TRACE_ENABLED=0
    master (8.911M)   : 0, 8911128

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6384) (10.003M)   : 0, 10003416
    master (9.949M)   : 0, 9949075
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6384) (6.498M)   : 0, 6497835
    master (6.538M)   : 0, 6537814
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.075M)   : 0, 7075474

    section Manual
    master (9.758M)   : 0, 9757921

    section Manual + Automatic
    This PR (6384) (6.233M)   : 0, 6232613
    master (6.151M)   : 0, 6151047

    section DD_TRACE_ENABLED=0
    master (9.404M)   : 0, 9403695

## Summary of changes Use the signature builder in FaultTolerantRewriter ## Reason for change Cleaner code

Introduce a SignatureBuilder to build signatures of arbitrary size

8dbfbb3

kevingosse changed the title ~~Use the builder in more places~~ Use the signature builder in more places Dec 3, 2024

kevingosse marked this pull request as ready for review December 3, 2024 11:46

kevingosse requested a review from a team as a code owner December 3, 2024 11:46

kevingosse added the area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) label Dec 3, 2024

andrewlock approved these changes Dec 3, 2024

View reviewed changes

Update CMakeList

8af8ff9

kevingosse force-pushed the 12-03-use_the_builder_in_more_places branch from 2bd9b03 to c61b5bb Compare December 3, 2024 13:49

GreenMatan approved these changes Dec 3, 2024

View reviewed changes

Kevin Gosse added 2 commits December 3, 2024 16:48

Fix initialization issues

68c938b

Use the builder in more places

e8e1755

kevingosse force-pushed the 12-03-use_the_builder_in_more_places branch from c61b5bb to e8e1755 Compare December 3, 2024 15:49

Base automatically changed from 12-03-introduce_a_signaturebuilder_to_build_signatures_of_arbitrary_size to master December 4, 2024 12:22

kevingosse requested a review from a team as a code owner December 4, 2024 12:22

Merge branch 'master' into 12-03-use_the_builder_in_more_places

30bb4fc

kevingosse merged commit b433853 into master Dec 5, 2024

kevingosse deleted the 12-03-use_the_builder_in_more_places branch December 5, 2024 09:44

github-actions Bot added this to the vNext-v3 milestone Dec 5, 2024

veerbia pushed a commit that referenced this pull request Dec 16, 2024

Use the signature builder in more places (#6384)

52a4381

## Summary of changes Use the signature builder in FaultTolerantRewriter ## Reason for change Cleaner code

andrewlock added the type:refactor label Dec 18, 2024

Uh oh!

Conversation

kevingosse commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Uh oh!

andrewlock commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

datadog-ddstaging Bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

New Flaky Tests (2)

Uh oh!

GreenMatan left a comment

Choose a reason for hiding this comment

Uh oh!

andrewlock commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6384

Faster 🎉 in #6384

Raw results

Raw results

Uh oh!

andrewlock commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throughput/Crank Report ⚡

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kevingosse commented Dec 3, 2024 •

edited

Loading

andrewlock commented Dec 3, 2024 •

edited

Loading

datadog-ddstaging Bot commented Dec 3, 2024 •

edited

Loading

andrewlock commented Dec 4, 2024 •

edited

Loading

andrewlock commented Dec 4, 2024 •

edited

Loading