Skip to content

Update npgsql to support 9.x.x#6350

Merged
andrewlock merged 2 commits into
masterfrom
andrew/npgsql-9
Nov 27, 2024
Merged

Update npgsql to support 9.x.x#6350
andrewlock merged 2 commits into
masterfrom
andrew/npgsql-9

Conversation

@andrewlock

@andrewlock andrewlock commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

Update npgsql support to 9.x.x

Reason for change

The new version was released recently and we want to support new versions

Implementation details

  • Add 9.x to the support matrix
  • Update integrations to support 9.x.
  • Remove unsupported TFMs from the test matrix (9.x.x only support .NET 6+)
  • 🙏 🤞

Test coverage

We were starting to test a lot of different npgsql versions which seems a little unnecessary, but multiplies to a lot of permutations. I removed 5.x.x and 7.x.x from our regular testing when adding 9.x.x, as we still have the same coverage and don't have any version-specific integrations for npgsql

https://datadoghq.atlassian.net/browse/AIDM-496

@andrewlock andrewlock added type:enhancement Improvement to an existing feature area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) labels Nov 25, 2024
@andrewlock
andrewlock requested review from a team as code owners November 25, 2024 17:36
@datadog-ddstaging

datadog-ddstaging Bot commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/npgsql-9
Commit report: 32316bf
Test service: dd-trace-dotnet

✅ 0 Failed, 458327 Passed, 3606 Skipped, 32h 37m 15.22s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.EnumerateAssemblyReferencesTest - Last Failure

    Expand for error 
     Expected no errors in smoke test: ptrace(ATTACH, 8812) FAILED Operation not permitted
 
 Expected: True
 Actual:   False

@andrewlock

andrewlock commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6350) - mean (72ms)  : 69, 74
     .   : milestone, 72,
    master - mean (72ms)  : 63, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6350) - mean (998ms)  : 961, 1035
     .   : milestone, 998,
    master - mean (990ms)  : 964, 1016
     .   : milestone, 990,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6350) - mean (114ms)  : 109, 119
     .   : milestone, 114,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6350) - mean (700ms)  : 654, 746
     .   : milestone, 700,
    master - mean (682ms)  : 667, 698
     .   : milestone, 682,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6350) - mean (101ms)  : 96, 106
     .   : milestone, 101,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6350) - mean (677ms)  : crit, 644, 711
     .   : crit, milestone, 677,
    master - mean (637ms)  : 623, 651
     .   : milestone, 637,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6350) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6350) - mean (1,097ms)  : 1067, 1127
     .   : milestone, 1097,
    master - mean (1,096ms)  : 1060, 1132
     .   : milestone, 1096,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6350) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6350) - mean (869ms)  : 838, 899
     .   : milestone, 869,
    master - mean (873ms)  : 844, 903
     .   : milestone, 873,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6350) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6350) - mean (855ms)  : 822, 887
     .   : milestone, 855,
    master - mean (862ms)  : 829, 895
     .   : milestone, 862,
Loading

@andrewlock

andrewlock commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6350) (11.094M)   : 0, 11093532
    master (11.197M)   : 0, 11196771
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6350) (7.349M)   : 0, 7349342
    master (7.320M)   : 0, 7319784
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.655M)   : 0, 7655437

    section Manual
    master (11.345M)   : 0, 11344859

    section Manual + Automatic
    This PR (6350) (6.762M)   : 0, 6762000
    master (6.798M)   : 0, 6797771

    section DD_TRACE_ENABLED=0
    master (10.337M)   : 0, 10337260
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6350) (9.338M)   : 0, 9338136
    master (9.583M)   : 0, 9583474
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6350) (6.445M)   : 0, 6444584
    master (6.519M)   : 0, 6519184

    section Trace stats
    master (6.620M)   : 0, 6620122

    section Manual
    master (9.722M)   : 0, 9721705

    section Manual + Automatic
    This PR (6350) (5.954M)   : 0, 5954160
    master (5.807M)   : 0, 5806681

    section DD_TRACE_ENABLED=0
    master (8.803M)   : 0, 8802601
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6350) (9.215M)   : 0, 9214531
    master (9.012M)   : 0, 9012435
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6350) (6.060M)   : 0, 6059643
    master (6.143M)   : 0, 6143202
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.618M)   : 0, 6618365

    section Manual
    master (9.211M)   : 0, 9210933

    section Manual + Automatic
    This PR (6350) (5.684M)   : 0, 5684328
    master (5.404M)   : 0, 5404124

    section DD_TRACE_ENABLED=0
    master (8.529M)   : 0, 8528937
Loading

@andrewlock

andrewlock commented Nov 26, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6350 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.310
  • 1 benchmarks are slower, with geometric mean 1.132
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.18μs 46.4ns 341ns 0.0159 0.00794 0 5.62 KB
master StartStopWithChild netcoreapp3.1 9.69μs 49.6ns 314ns 0.0147 0.0049 0 5.8 KB
master StartStopWithChild net472 16.1μs 62.7ns 243ns 1.03 0.302 0.0954 6.2 KB
#6350 StartStopWithChild net6.0 7.78μs 43.4ns 298ns 0.0158 0.00792 0 5.61 KB
#6350 StartStopWithChild netcoreapp3.1 10μs 55.9ns 383ns 0.024 0.00959 0 5.81 KB
#6350 StartStopWithChild net472 16.1μs 57ns 221ns 1.05 0.309 0.103 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 508μs 359ns 1.39μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 452ns 1.69μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 854μs 574ns 2.22μs 0.425 0 0 3.3 KB
#6350 WriteAndFlushEnrichedTraces net6.0 494μs 702ns 2.72μs 0 0 0 2.7 KB
#6350 WriteAndFlushEnrichedTraces netcoreapp3.1 671μs 223ns 836ns 0 0 0 2.7 KB
#6350 WriteAndFlushEnrichedTraces net472 853μs 428ns 1.6μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 149μs 868ns 7.36μs 0.146 0 0 14.47 KB
master SendRequest netcoreapp3.1 169μs 977ns 7.94μs 0.157 0 0 17.27 KB
master SendRequest net472 0.000162ns 0.000103ns 0.000385ns 0 0 0 0 b
#6350 SendRequest net6.0 151μs 859ns 7.83μs 0.145 0 0 14.47 KB
#6350 SendRequest netcoreapp3.1 167μs 957ns 7.95μs 0.157 0 0 17.27 KB
#6350 SendRequest net472 9E‑05ns 9E‑05ns 0.000337ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6350

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.310 880,177.48 671,742.45 bimodal

More allocations ⚠️ in #6350

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.09 KB 41.81 KB 716 B 1.74%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 583μs 2.93μs 13.8μs 0.568 0 0 41.58 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 875μs 7.28μs 72.8μs 0.46 0 0 41.09 KB
master WriteAndFlushEnrichedTraces net472 890μs 4.29μs 16.6μs 8.42 2.66 0.443 53.28 KB
#6350 WriteAndFlushEnrichedTraces net6.0 561μs 2.54μs 12.2μs 0.541 0 0 41.5 KB
#6350 WriteAndFlushEnrichedTraces netcoreapp3.1 674μs 3.33μs 13.7μs 0.332 0 0 41.81 KB
#6350 WriteAndFlushEnrichedTraces net472 856μs 3.01μs 11.7μs 8.08 2.55 0.425 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.4μs 1.46ns 5.64ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 1.47ns 5.68ns 0.014 0 0 1.02 KB
master ExecuteNonQuery net472 2.07μs 2.28ns 8.51ns 0.156 0.00105 0 987 B
#6350 ExecuteNonQuery net6.0 1.36μs 0.984ns 3.81ns 0.0143 0 0 1.02 KB
#6350 ExecuteNonQuery netcoreapp3.1 1.78μs 1.7ns 6.37ns 0.0133 0 0 1.02 KB
#6350 ExecuteNonQuery net472 2.08μs 1.74ns 6.02ns 0.156 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.863ns 3.11ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 1.01ns 3.78ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.6μs 1.79ns 6.7ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.26μs 0.576ns 2.16ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.55μs 1.15ns 4.29ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.6μs 1.84ns 7.12ns 0.166 0 0 1.05 KB
#6350 CallElasticsearch net6.0 1.2μs 0.559ns 2.16ns 0.0139 0 0 976 B
#6350 CallElasticsearch netcoreapp3.1 1.62μs 1.44ns 5.57ns 0.0128 0 0 976 B
#6350 CallElasticsearch net472 2.64μs 1.79ns 6.69ns 0.157 0 0 995 B
#6350 CallElasticsearchAsync net6.0 1.21μs 0.65ns 2.43ns 0.0134 0 0 952 B
#6350 CallElasticsearchAsync netcoreapp3.1 1.61μs 2.48ns 9.29ns 0.0137 0 0 1.02 KB
#6350 CallElasticsearchAsync net472 2.57μs 1.36ns 5.26ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 1.42ns 5.5ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 2.4ns 9.3ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.86μs 1.75ns 6.79ns 0.145 0 0 915 B
#6350 ExecuteAsync net6.0 1.36μs 0.816ns 3.16ns 0.013 0 0 952 B
#6350 ExecuteAsync netcoreapp3.1 1.71μs 1.7ns 6.37ns 0.0128 0 0 952 B
#6350 ExecuteAsync net472 1.85μs 0.713ns 2.76ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.44μs 1.25ns 4.69ns 0.0331 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.33μs 2.03ns 7.61ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.26μs 4.4ns 17ns 0.494 0 0 3.12 KB
#6350 SendAsync net6.0 4.48μs 3.15ns 12.2ns 0.0305 0 0 2.31 KB
#6350 SendAsync netcoreapp3.1 5.27μs 2.11ns 8.18ns 0.0367 0 0 2.85 KB
#6350 SendAsync net472 7.34μs 4.53ns 17.5ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 0.662ns 2.56ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.29μs 1.68ns 6.27ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.69μs 1.45ns 5.21ns 0.248 0 0 1.57 KB
#6350 EnrichedLog net6.0 1.52μs 2.97ns 11.1ns 0.0231 0 0 1.64 KB
#6350 EnrichedLog netcoreapp3.1 2.19μs 10.5ns 44.7ns 0.0227 0 0 1.64 KB
#6350 EnrichedLog net472 2.57μs 1.28ns 4.77ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 107ns 402ns 0.06 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 265ns 1.03μs 0.0616 0 0 4.28 KB
master EnrichedLog net472 150μs 92.7ns 359ns 0.681 0.227 0 4.46 KB
#6350 EnrichedLog net6.0 117μs 94ns 352ns 0 0 0 4.28 KB
#6350 EnrichedLog netcoreapp3.1 123μs 246ns 952ns 0.062 0 0 4.28 KB
#6350 EnrichedLog net472 152μs 165ns 640ns 0.69 0.23 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.18μs 0.925ns 3.58ns 0.0303 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 1.14ns 4.26ns 0.0289 0 0 2.2 KB
master EnrichedLog net472 4.92μs 2.6ns 10.1ns 0.319 0 0 2.02 KB
#6350 EnrichedLog net6.0 3.15μs 1.58ns 6.12ns 0.03 0 0 2.2 KB
#6350 EnrichedLog netcoreapp3.1 4.23μs 5.99ns 23.2ns 0.0295 0 0 2.2 KB
#6350 EnrichedLog net472 5.15μs 2.04ns 7.89ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.918ns 3.55ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.81μs 1.02ns 3.81ns 0.0154 0 0 1.14 KB
master SendReceive net472 2.16μs 2.07ns 8.02ns 0.183 0 0 1.16 KB
#6350 SendReceive net6.0 1.43μs 0.882ns 3.42ns 0.0157 0 0 1.14 KB
#6350 SendReceive netcoreapp3.1 1.82μs 0.744ns 2.88ns 0.0155 0 0 1.14 KB
#6350 SendReceive net472 2.16μs 1.01ns 3.9ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 1.09ns 4.23ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.92μs 4.6ns 17.8ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.48μs 4.04ns 15.7ns 0.324 0 0 2.04 KB
#6350 EnrichedLog net6.0 2.74μs 0.913ns 3.42ns 0.022 0 0 1.6 KB
#6350 EnrichedLog netcoreapp3.1 3.89μs 5.31ns 19.9ns 0.0212 0 0 1.65 KB
#6350 EnrichedLog net472 4.56μs 3.24ns 12.6ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6350

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.132 555.50 628.90

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 396ns 0.589ns 2.28ns 0.00818 0 0 576 B
master StartFinishSpan netcoreapp3.1 555ns 0.724ns 2.8ns 0.00794 0 0 576 B
master StartFinishSpan net472 645ns 1.15ns 4.46ns 0.0918 0 0 578 B
master StartFinishScope net6.0 473ns 0.591ns 2.29ns 0.00986 0 0 696 B
master StartFinishScope netcoreapp3.1 712ns 1.16ns 4.5ns 0.00917 0 0 696 B
master StartFinishScope net472 864ns 1.31ns 5.08ns 0.104 0 0 658 B
#6350 StartFinishSpan net6.0 418ns 0.371ns 1.44ns 0.00809 0 0 576 B
#6350 StartFinishSpan netcoreapp3.1 627ns 1.39ns 5.37ns 0.00774 0 0 576 B
#6350 StartFinishSpan net472 625ns 2.07ns 8.03ns 0.0918 0 0 578 B
#6350 StartFinishScope net6.0 487ns 0.548ns 2.05ns 0.0097 0 0 696 B
#6350 StartFinishScope netcoreapp3.1 760ns 1.37ns 5.29ns 0.0093 0 0 696 B
#6350 StartFinishScope net472 852ns 2.06ns 7.97ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 670ns 1.46ns 5.65ns 0.00976 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 960ns 1.89ns 7.31ns 0.00919 0 0 696 B
master RunOnMethodBegin net472 1.08μs 2.47ns 9.59ns 0.104 0 0 658 B
#6350 RunOnMethodBegin net6.0 634ns 0.758ns 2.93ns 0.00992 0 0 696 B
#6350 RunOnMethodBegin netcoreapp3.1 909ns 1.34ns 5.19ns 0.00947 0 0 696 B
#6350 RunOnMethodBegin net472 1.13μs 1.46ns 5.64ns 0.104 0 0 658 B

@andrewlock
andrewlock merged commit befcf1d into master Nov 27, 2024
@andrewlock
andrewlock deleted the andrew/npgsql-9 branch November 27, 2024 10:18
@github-actions github-actions Bot added this to the vNext-v3 milestone Nov 27, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
@andrewlock @veerbia
Update npgsql to support 9.x.x (#6350)
5693c23 
## Summary of changes

Update npgsql support to 9.x.x

## Reason for change

The new version was released recently and we want to support new
versions

## Implementation details

- Add 9.x to the support matrix
- Update integrations to support 9.x.
- Remove unsupported TFMs from the test matrix (9.x.x only support .NET
6+)
- 🙏 🤞 

## Test coverage

We were starting to test a _lot_ of different npgsql versions which
seems a little unnecessary, but multiplies to a lot of permutations. I
removed 5.x.x and 7.x.x from our regular testing when adding 9.x.x, as
we still have the same coverage and don't have any version-specific
integrations for npgsql

https://datadoghq.atlassian.net/browse/AIDM-496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
+1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) type:enhancement Improvement to an existing feature

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @kevingosse