Skip to content

Fix typo in smoke test#6300

Merged
andrewlock merged 1 commit into
masterfrom
andrew/ci/fix-broken-smoke-test
Nov 20, 2024
Merged

Fix typo in smoke test#6300
andrewlock merged 1 commit into
masterfrom
andrew/ci/fix-broken-smoke-test

Conversation

@andrewlock

Copy link
Copy Markdown
Member

Summary of changes

Fix using incorrect TFM in smoke test

Reason for change

Typo

Implementation details

Fix the typo

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Nov 18, 2024
@andrewlock
andrewlock requested a review from a team as a code owner November 18, 2024 15:36
@datadog-ddstaging

datadog-ddstaging Bot commented Nov 18, 2024

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/fix-broken-smoke-test
Commit report: 8c02277
Test service: dd-trace-dotnet

✅ 0 Failed, 450428 Passed, 2750 Skipped, 19h 11m 45.37s Total Time

@andrewlock

andrewlock commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6300) - mean (71ms)  : 65, 78
     .   : milestone, 71,
    master - mean (72ms)  : 64, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6300) - mean (1,111ms)  : 1090, 1131
     .   : milestone, 1111,
    master - mean (1,107ms)  : 1085, 1128
     .   : milestone, 1107,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6300) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6300) - mean (768ms)  : 748, 789
     .   : milestone, 768,
    master - mean (771ms)  : 757, 785
     .   : milestone, 771,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6300) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6300) - mean (720ms)  : 705, 734
     .   : milestone, 720,
    master - mean (726ms)  : 707, 745
     .   : milestone, 726,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6300) - mean (192ms)  : 187, 196
     .   : milestone, 192,
    master - mean (191ms)  : 186, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6300) - mean (1,213ms)  : 1185, 1242
     .   : milestone, 1213,
    master - mean (1,213ms)  : 1190, 1236
     .   : milestone, 1213,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6300) - mean (278ms)  : 273, 282
     .   : milestone, 278,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6300) - mean (952ms)  : 930, 973
     .   : milestone, 952,
    master - mean (948ms)  : 929, 967
     .   : milestone, 948,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6300) - mean (268ms)  : 263, 273
     .   : milestone, 268,
    master - mean (265ms)  : 261, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6300) - mean (926ms)  : 908, 943
     .   : milestone, 926,
    master - mean (931ms)  : 913, 950
     .   : milestone, 931,

Loading

@andrewlock

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6300) (11.203M)   : 0, 11202606
    master (11.088M)   : 0, 11087997
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6300) (7.339M)   : 0, 7338876
    master (7.189M)   : 0, 7189433
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.540M)   : 0, 7540032

    section Manual
    master (10.979M)   : 0, 10978609

    section Manual + Automatic
    This PR (6300) (6.750M)   : 0, 6750048
    master (6.705M)   : 0, 6704874

    section DD_TRACE_ENABLED=0
    master (10.210M)   : 0, 10210338

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6300) (9.502M)   : 0, 9502324
    master (9.281M)   : 0, 9280802
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6300) (6.323M)   : 0, 6322844
    master (6.361M)   : 0, 6360955

    section Trace stats
    master (6.592M)   : 0, 6591771

    section Manual
    master (9.244M)   : 0, 9244472

    section Manual + Automatic
    This PR (6300) (5.868M)   : 0, 5868017
    master (5.916M)   : 0, 5915508

    section DD_TRACE_ENABLED=0
    master (8.775M)   : 0, 8774768

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6300) (9.446M)   : 0, 9446273
    master (9.738M)   : 0, 9737778
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6300) (5.760M)   : crit ,0, 5759657
    master (6.366M)   : 0, 6366399
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.991M)   : 0, 6990849

    section Manual
    master (9.876M)   : 0, 9876192

    section Manual + Automatic
    This PR (6300) (5.590M)   : 0, 5589504
    master (5.693M)   : 0, 5692584

    section DD_TRACE_ENABLED=0
    master (9.017M)   : 0, 9017039

Loading

@andrewlock

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6300 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.133
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.83μs 40.8ns 238ns 0.0195 0.00781 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.4μs 55.8ns 306ns 0.0203 0.0102 0 5.8 KB
master StartStopWithChild net472 16.3μs 29.6ns 111ns 1.04 0.307 0.097 6.21 KB
#6300 StartStopWithChild net6.0 7.86μs 43.4ns 257ns 0.0117 0.00389 0 5.61 KB
#6300 StartStopWithChild netcoreapp3.1 10.2μs 56.2ns 360ns 0.0205 0.0102 0 5.8 KB
#6300 StartStopWithChild net472 16.4μs 51.4ns 199ns 1.04 0.3 0.0973 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 490μs 357ns 1.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 209ns 782ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 866μs 374ns 1.45μs 0.428 0 0 3.3 KB
#6300 WriteAndFlushEnrichedTraces net6.0 487μs 316ns 1.18μs 0 0 0 2.7 KB
#6300 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.32μs 5.11μs 0 0 0 2.7 KB
#6300 WriteAndFlushEnrichedTraces net472 869μs 538ns 2.01μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 201μs 1.17μs 10.6μs 0.197 0 0 18.73 KB
master SendRequest netcoreapp3.1 225μs 1.3μs 11.6μs 0.21 0 0 20.89 KB
master SendRequest net472 0.00045ns 0.00029ns 0.00108ns 0 0 0 0 b
#6300 SendRequest net6.0 197μs 1.14μs 9.64μs 0.197 0 0 18.73 KB
#6300 SendRequest netcoreapp3.1 221μs 1.28μs 11.1μs 0.21 0 0 20.89 KB
#6300 SendRequest net472 0.00227ns 0.000791ns 0.00296ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 589μs 3.35μs 23.5μs 0.584 0 0 41.67 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 3.56μs 18.5μs 0.334 0 0 41.64 KB
master WriteAndFlushEnrichedTraces net472 868μs 3.04μs 11.8μs 8.25 2.6 0.434 53.31 KB
#6300 WriteAndFlushEnrichedTraces net6.0 574μs 2.94μs 13.5μs 0.573 0 0 41.68 KB
#6300 WriteAndFlushEnrichedTraces netcoreapp3.1 684μs 3.1μs 17μs 0.34 0 0 41.74 KB
#6300 WriteAndFlushEnrichedTraces net472 887μs 3.94μs 15.2μs 8.36 2.64 0.44 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.2μs 0.821ns 3.07ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.6ns 5.78ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 1.23ns 4.61ns 0.156 0.00106 0 987 B
#6300 ExecuteNonQuery net6.0 1.23μs 0.946ns 3.67ns 0.0142 0 0 1.02 KB
#6300 ExecuteNonQuery netcoreapp3.1 1.77μs 2.11ns 8.15ns 0.0134 0 0 1.02 KB
#6300 ExecuteNonQuery net472 2.1μs 1.88ns 6.79ns 0.157 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 0.724ns 2.8ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.808ns 3.02ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.63μs 2.53ns 9.46ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.22μs 0.701ns 2.72ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 1.1ns 4.27ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.57μs 2.01ns 7.77ns 0.166 0 0 1.05 KB
#6300 CallElasticsearch net6.0 1.13μs 0.66ns 2.47ns 0.0135 0 0 976 B
#6300 CallElasticsearch netcoreapp3.1 1.59μs 0.677ns 2.62ns 0.0128 0 0 976 B
#6300 CallElasticsearch net472 2.6μs 3.11ns 11.6ns 0.157 0 0 995 B
#6300 CallElasticsearchAsync net6.0 1.3μs 2.94ns 11.4ns 0.013 0 0 952 B
#6300 CallElasticsearchAsync netcoreapp3.1 1.67μs 0.723ns 2.8ns 0.0133 0 0 1.02 KB
#6300 CallElasticsearchAsync net472 2.66μs 2.13ns 8.25ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.33μs 0.442ns 1.59ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.69μs 0.699ns 2.61ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.81μs 0.357ns 1.33ns 0.145 0 0 915 B
#6300 ExecuteAsync net6.0 1.32μs 0.813ns 3.04ns 0.0132 0 0 952 B
#6300 ExecuteAsync netcoreapp3.1 1.64μs 0.826ns 3.09ns 0.0131 0 0 952 B
#6300 ExecuteAsync net472 1.85μs 2.4ns 8.98ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 1.05ns 4.06ns 0.0324 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.32μs 2.12ns 8.22ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.32μs 1.83ns 7.09ns 0.494 0 0 3.12 KB
#6300 SendAsync net6.0 4.46μs 1.39ns 5.22ns 0.0331 0 0 2.31 KB
#6300 SendAsync netcoreapp3.1 5.42μs 2.56ns 9.91ns 0.038 0 0 2.85 KB
#6300 SendAsync net472 7.34μs 2.91ns 11.3ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 1.14ns 4.25ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.15μs 1.58ns 5.93ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.54μs 1.37ns 5.29ns 0.249 0 0 1.57 KB
#6300 EnrichedLog net6.0 1.51μs 0.667ns 2.5ns 0.0234 0 0 1.64 KB
#6300 EnrichedLog netcoreapp3.1 2.26μs 1.77ns 6.62ns 0.0216 0 0 1.64 KB
#6300 EnrichedLog net472 2.48μs 0.843ns 3.26ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 121μs 115ns 446ns 0.0608 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 92.9ns 360ns 0.0621 0 0 4.28 KB
master EnrichedLog net472 151μs 143ns 553ns 0.678 0.226 0 4.46 KB
#6300 EnrichedLog net6.0 120μs 162ns 629ns 0.0598 0 0 4.28 KB
#6300 EnrichedLog netcoreapp3.1 124μs 133ns 515ns 0 0 0 4.28 KB
#6300 EnrichedLog net472 152μs 127ns 494ns 0.684 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.06μs 1.23ns 4.62ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.17μs 1.15ns 4.32ns 0.0292 0 0 2.2 KB
master EnrichedLog net472 4.95μs 1.38ns 5.35ns 0.319 0 0 2.02 KB
#6300 EnrichedLog net6.0 2.96μs 1.15ns 4.29ns 0.0296 0 0 2.2 KB
#6300 EnrichedLog netcoreapp3.1 4.2μs 1.37ns 5.32ns 0.0294 0 0 2.2 KB
#6300 EnrichedLog net472 5.03μs 1.37ns 5.14ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 1.32ns 5.1ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.69μs 1.8ns 6.96ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.05μs 2.4ns 8.97ns 0.183 0 0 1.16 KB
#6300 SendReceive net6.0 1.4μs 1.07ns 4.14ns 0.0161 0 0 1.14 KB
#6300 SendReceive netcoreapp3.1 1.79μs 1.3ns 5.03ns 0.0153 0 0 1.14 KB
#6300 SendReceive net472 2.01μs 1.2ns 4.48ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 1.2ns 4.64ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.92μs 1.89ns 7.31ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.43μs 1.58ns 6.12ns 0.322 0 0 2.04 KB
#6300 EnrichedLog net6.0 2.8μs 0.662ns 2.39ns 0.0224 0 0 1.6 KB
#6300 EnrichedLog netcoreapp3.1 3.95μs 2.06ns 7.71ns 0.0216 0 0 1.65 KB
#6300 EnrichedLog net472 4.43μs 4.2ns 16.3ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6300

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.150 408.89 470.26
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.125 659.19 741.65
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.125 476.53 536.01

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 409ns 0.383ns 1.49ns 0.00797 0 0 576 B
master StartFinishSpan netcoreapp3.1 606ns 0.632ns 2.37ns 0.00759 0 0 576 B
master StartFinishSpan net472 637ns 0.714ns 2.76ns 0.0916 0 0 578 B
master StartFinishScope net6.0 477ns 0.337ns 1.31ns 0.00975 0 0 696 B
master StartFinishScope netcoreapp3.1 659ns 0.415ns 1.55ns 0.00931 0 0 696 B
master StartFinishScope net472 874ns 1.53ns 5.93ns 0.104 0 0 658 B
#6300 StartFinishSpan net6.0 470ns 0.155ns 0.56ns 0.00806 0 0 576 B
#6300 StartFinishSpan netcoreapp3.1 657ns 0.529ns 2.05ns 0.00757 0 0 576 B
#6300 StartFinishSpan net472 609ns 0.492ns 1.91ns 0.0915 0 0 578 B
#6300 StartFinishScope net6.0 536ns 0.361ns 1.35ns 0.00976 0 0 696 B
#6300 StartFinishScope netcoreapp3.1 741ns 0.83ns 3.1ns 0.00916 0 0 696 B
#6300 StartFinishScope net472 930ns 0.978ns 3.79ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 637ns 0.705ns 2.73ns 0.00964 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 926ns 1.02ns 3.83ns 0.00937 0 0 696 B
master RunOnMethodBegin net472 1.11μs 0.658ns 2.55ns 0.104 0 0 658 B
#6300 RunOnMethodBegin net6.0 632ns 0.741ns 2.67ns 0.00982 0 0 696 B
#6300 RunOnMethodBegin netcoreapp3.1 896ns 0.693ns 2.69ns 0.00933 0 0 696 B
#6300 RunOnMethodBegin net472 1.15μs 1.06ns 4.12ns 0.104 0 0 658 B

@andrewlock
andrewlock force-pushed the andrew/ci/fix-broken-smoke-test branch from 5c322eb to 8c02277 Compare November 20, 2024 13:33
@andrewlock
andrewlock merged commit fb95b3e into master Nov 20, 2024
@andrewlock
andrewlock deleted the andrew/ci/fix-broken-smoke-test branch November 20, 2024 17:39
@github-actions github-actions Bot added this to the vNext-v3 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants