Fix typo in smoke test#6300
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 450428 Passed, 2750 Skipped, 19h 11m 45.37s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6300) - mean (71ms) : 65, 78
. : milestone, 71,
master - mean (72ms) : 64, 80
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6300) - mean (1,111ms) : 1090, 1131
. : milestone, 1111,
master - mean (1,107ms) : 1085, 1128
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6300) - mean (109ms) : 107, 111
. : milestone, 109,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6300) - mean (768ms) : 748, 789
. : milestone, 768,
master - mean (771ms) : 757, 785
. : milestone, 771,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6300) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 93
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6300) - mean (720ms) : 705, 734
. : milestone, 720,
master - mean (726ms) : 707, 745
. : milestone, 726,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6300) - mean (192ms) : 187, 196
. : milestone, 192,
master - mean (191ms) : 186, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6300) - mean (1,213ms) : 1185, 1242
. : milestone, 1213,
master - mean (1,213ms) : 1190, 1236
. : milestone, 1213,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6300) - mean (278ms) : 273, 282
. : milestone, 278,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6300) - mean (952ms) : 930, 973
. : milestone, 952,
master - mean (948ms) : 929, 967
. : milestone, 948,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6300) - mean (268ms) : 263, 273
. : milestone, 268,
master - mean (265ms) : 261, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6300) - mean (926ms) : 908, 943
. : milestone, 926,
master - mean (931ms) : 913, 950
. : milestone, 931,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6300) (11.203M) : 0, 11202606
master (11.088M) : 0, 11087997
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6300) (7.339M) : 0, 7338876
master (7.189M) : 0, 7189433
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.540M) : 0, 7540032
section Manual
master (10.979M) : 0, 10978609
section Manual + Automatic
This PR (6300) (6.750M) : 0, 6750048
master (6.705M) : 0, 6704874
section DD_TRACE_ENABLED=0
master (10.210M) : 0, 10210338
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6300) (9.502M) : 0, 9502324
master (9.281M) : 0, 9280802
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6300) (6.323M) : 0, 6322844
master (6.361M) : 0, 6360955
section Trace stats
master (6.592M) : 0, 6591771
section Manual
master (9.244M) : 0, 9244472
section Manual + Automatic
This PR (6300) (5.868M) : 0, 5868017
master (5.916M) : 0, 5915508
section DD_TRACE_ENABLED=0
master (8.775M) : 0, 8774768
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6300) (9.446M) : 0, 9446273
master (9.738M) : 0, 9737778
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6300) (5.760M) : crit ,0, 5759657
master (6.366M) : 0, 6366399
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.991M) : 0, 6990849
section Manual
master (9.876M) : 0, 9876192
section Manual + Automatic
This PR (6300) (5.590M) : 0, 5589504
master (5.693M) : 0, 5692584
section DD_TRACE_ENABLED=0
master (9.017M) : 0, 9017039
|
Benchmarks Report for tracer 🐌Benchmarks for #6300 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.150 | 408.89 | 470.26 | |
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.125 | 659.19 | 741.65 | |
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.125 | 476.53 | 536.01 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 409ns | 0.383ns | 1.49ns | 0.00797 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 606ns | 0.632ns | 2.37ns | 0.00759 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 637ns | 0.714ns | 2.76ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 477ns | 0.337ns | 1.31ns | 0.00975 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 659ns | 0.415ns | 1.55ns | 0.00931 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 874ns | 1.53ns | 5.93ns | 0.104 | 0 | 0 | 658 B |
| #6300 | StartFinishSpan |
net6.0 | 470ns | 0.155ns | 0.56ns | 0.00806 | 0 | 0 | 576 B |
| #6300 | StartFinishSpan |
netcoreapp3.1 | 657ns | 0.529ns | 2.05ns | 0.00757 | 0 | 0 | 576 B |
| #6300 | StartFinishSpan |
net472 | 609ns | 0.492ns | 1.91ns | 0.0915 | 0 | 0 | 578 B |
| #6300 | StartFinishScope |
net6.0 | 536ns | 0.361ns | 1.35ns | 0.00976 | 0 | 0 | 696 B |
| #6300 | StartFinishScope |
netcoreapp3.1 | 741ns | 0.83ns | 3.1ns | 0.00916 | 0 | 0 | 696 B |
| #6300 | StartFinishScope |
net472 | 930ns | 0.978ns | 3.79ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 637ns | 0.705ns | 2.73ns | 0.00964 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 926ns | 1.02ns | 3.83ns | 0.00937 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.11μs | 0.658ns | 2.55ns | 0.104 | 0 | 0 | 658 B |
| #6300 | RunOnMethodBegin |
net6.0 | 632ns | 0.741ns | 2.67ns | 0.00982 | 0 | 0 | 696 B |
| #6300 | RunOnMethodBegin |
netcoreapp3.1 | 896ns | 0.693ns | 2.69ns | 0.00933 | 0 | 0 | 696 B |
| #6300 | RunOnMethodBegin |
net472 | 1.15μs | 1.06ns | 4.12ns | 0.104 | 0 | 0 | 658 B |
5c322eb to
8c02277
Compare
Summary of changes
Fix using incorrect TFM in smoke test
Reason for change
Typo
Implementation details
Fix the typo