Skip to content

[Profiler] Clean up profiler code#6291

Merged
gleocadie merged 6 commits into
masterfrom
gleocadie/clean-up-profiler-code
Dec 2, 2024
Merged

[Profiler] Clean up profiler code#6291
gleocadie merged 6 commits into
masterfrom
gleocadie/clean-up-profiler-code

Conversation

@gleocadie

@gleocadie gleocadie commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary of changes

Clean up

Reason for change

Winter is coming and need to clean up the code a bit.

Implementation details

  • Implement a LogOnce
  • Implement an efficient LogGcEvent
  • Remove the WCF demos stuffs

Test coverage

current tests. No change in behavior.

Other details

@github-actions github-actions Bot added the area:profiler Issues related to the continous-profiler label Nov 14, 2024
@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch from b70b8c9 to a0211e3 Compare November 14, 2024 22:34
@datadog-ddstaging

datadog-ddstaging Bot commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: gleocadie/clean-up-profiler-code
Commit report: f827fd3
Test service: dd-trace-dotnet

✅ 0 Failed, 454492 Passed, 3218 Skipped, 21h 2m 58.32s Total Time
⌛ 5 Performance Regressions

⌛ Performance Regressions vs Default Branch (5)

  • Profiler_contention - scenarios 2.5s (+229.22ms, +10%) - Details
  • Profiler_contention_cpu_walltime - scenarios 2.51s (+208.02ms, +9%) - Details
  • Profiler_walltime - scenarios 3.59s (+269.15ms, +8%) - Details
  • Profiler_contention - scenarios 2.62s (+328.04ms, +14%) - Details
  • Profiler_contention_cpu_walltime - scenarios 2.71s (+392.14ms, +17%) - Details

@andrewlock

andrewlock commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6291) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6291) - mean (986ms)  : 961, 1011
     .   : milestone, 986,
    master - mean (983ms)  : 961, 1004
     .   : milestone, 983,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6291) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6291) - mean (684ms)  : 669, 698
     .   : milestone, 684,
    master - mean (685ms)  : 671, 699
     .   : milestone, 685,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6291) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6291) - mean (637ms)  : 623, 650
     .   : milestone, 637,
    master - mean (638ms)  : 620, 656
     .   : milestone, 638,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6291) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6291) - mean (1,096ms)  : 1060, 1131
     .   : milestone, 1096,
    master - mean (1,091ms)  : 1066, 1117
     .   : milestone, 1091,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6291) - mean (277ms)  : 271, 284
     .   : milestone, 277,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6291) - mean (879ms)  : 847, 910
     .   : milestone, 879,
    master - mean (875ms)  : 848, 902
     .   : milestone, 875,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6291) - mean (268ms)  : 263, 272
     .   : milestone, 268,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6291) - mean (859ms)  : 823, 895
     .   : milestone, 859,
    master - mean (857ms)  : 822, 892
     .   : milestone, 857,
Loading

@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch 2 times, most recently from c5fd5dc to 3a5cef0 Compare November 15, 2024 08:28
@andrewlock

andrewlock commented Nov 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6291 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.119
  • 1 benchmarks are slower, with geometric mean 1.171
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.78μs 42.5ns 240ns 0.0153 0.00763 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 54.5ns 308ns 0.0198 0.00988 0 5.8 KB
master StartStopWithChild net472 16.2μs 36.4ns 141ns 1.04 0.305 0.104 6.21 KB
#6291 StartStopWithChild net6.0 8.15μs 44.5ns 271ns 0.0118 0.00393 0 5.61 KB
#6291 StartStopWithChild netcoreapp3.1 10.1μs 54.6ns 327ns 0.0249 0.00995 0 5.8 KB
#6291 StartStopWithChild net472 16.4μs 58.4ns 226ns 1.03 0.305 0.0963 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 484μs 202ns 729ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 662μs 256ns 992ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 854μs 501ns 1.87μs 0.428 0 0 3.3 KB
#6291 WriteAndFlushEnrichedTraces net6.0 478μs 408ns 1.58μs 0 0 0 2.7 KB
#6291 WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 438ns 1.7μs 0 0 0 2.7 KB
#6291 WriteAndFlushEnrichedTraces net472 854μs 965ns 3.74μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 149μs 850ns 6.47μs 0.168 0 0 14.47 KB
master SendRequest netcoreapp3.1 163μs 881ns 5.71μs 0.165 0 0 17.27 KB
master SendRequest net472 0.00132ns 0.000695ns 0.0026ns 0 0 0 0 b
#6291 SendRequest net6.0 152μs 859ns 7.96μs 0.141 0 0 14.47 KB
#6291 SendRequest netcoreapp3.1 167μs 953ns 7.13μs 0.181 0 0 17.27 KB
#6291 SendRequest net472 0.0014ns 0.000578ns 0.00224ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 558μs 2.02μs 7μs 0.573 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.49μs 17.1μs 0.338 0 0 41.82 KB
master WriteAndFlushEnrichedTraces net472 847μs 4.16μs 17.7μs 8.13 2.57 0.428 53.29 KB
#6291 WriteAndFlushEnrichedTraces net6.0 582μs 2.81μs 11.6μs 0.571 0 0 41.69 KB
#6291 WriteAndFlushEnrichedTraces netcoreapp3.1 707μs 3.77μs 22μs 0.355 0 0 41.84 KB
#6291 WriteAndFlushEnrichedTraces net472 867μs 4.34μs 18.4μs 8.75 2.5 0.417 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.23μs 0.817ns 2.94ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 2.84ns 9.85ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.16μs 1.99ns 7.71ns 0.157 0.00108 0 987 B
#6291 ExecuteNonQuery net6.0 1.24μs 1.06ns 4.09ns 0.0142 0 0 1.02 KB
#6291 ExecuteNonQuery netcoreapp3.1 1.86μs 2.52ns 9.75ns 0.014 0 0 1.02 KB
#6291 ExecuteNonQuery net472 2.16μs 1.72ns 6.45ns 0.156 0.00109 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.683ns 2.56ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.47μs 0.638ns 2.39ns 0.0127 0 0 976 B
master CallElasticsearch net472 2.5μs 1.38ns 5.14ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.41μs 4.89ns 19ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.75μs 0.81ns 2.92ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.7μs 1.69ns 6.32ns 0.167 0 0 1.05 KB
#6291 CallElasticsearch net6.0 1.28μs 0.451ns 1.69ns 0.0136 0 0 976 B
#6291 CallElasticsearch netcoreapp3.1 1.53μs 4.09ns 15.8ns 0.0127 0 0 976 B
#6291 CallElasticsearch net472 2.53μs 2.72ns 10.6ns 0.158 0 0 995 B
#6291 CallElasticsearchAsync net6.0 1.33μs 0.418ns 1.56ns 0.0133 0 0 952 B
#6291 CallElasticsearchAsync netcoreapp3.1 1.67μs 0.631ns 2.36ns 0.0134 0 0 1.02 KB
#6291 CallElasticsearchAsync net472 2.62μs 1.4ns 5.42ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.28μs 0.408ns 1.53ns 0.0135 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 0.646ns 2.5ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.86μs 1.25ns 4.84ns 0.144 0 0 915 B
#6291 ExecuteAsync net6.0 1.27μs 2.17ns 8.12ns 0.0132 0 0 952 B
#6291 ExecuteAsync netcoreapp3.1 1.61μs 0.723ns 2.8ns 0.0129 0 0 952 B
#6291 ExecuteAsync net472 1.82μs 0.384ns 1.44ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.35μs 2.07ns 8.01ns 0.0327 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.38μs 3.19ns 11.9ns 0.0375 0 0 2.85 KB
master SendAsync net472 7.33μs 1.78ns 6.9ns 0.494 0 0 3.12 KB
#6291 SendAsync net6.0 4.15μs 2.07ns 7.74ns 0.0312 0 0 2.31 KB
#6291 SendAsync netcoreapp3.1 5.26μs 2.09ns 7.83ns 0.0368 0 0 2.85 KB
#6291 SendAsync net472 7.32μs 2.74ns 10.2ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.57μs 0.551ns 1.99ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.31μs 1.37ns 4.94ns 0.0216 0 0 1.64 KB
master EnrichedLog net472 2.56μs 1.45ns 5.62ns 0.249 0 0 1.57 KB
#6291 EnrichedLog net6.0 1.5μs 0.981ns 3.67ns 0.0233 0 0 1.64 KB
#6291 EnrichedLog netcoreapp3.1 2.3μs 0.853ns 3.3ns 0.0218 0 0 1.64 KB
#6291 EnrichedLog net472 2.58μs 0.767ns 2.77ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 120μs 114ns 440ns 0.0602 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 156ns 584ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 267ns 1.03μs 0.673 0.224 0 4.46 KB
#6291 EnrichedLog net6.0 118μs 190ns 737ns 0.0588 0 0 4.28 KB
#6291 EnrichedLog netcoreapp3.1 125μs 274ns 1.06μs 0 0 0 4.28 KB
#6291 EnrichedLog net472 151μs 127ns 493ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.12μs 0.905ns 3.5ns 0.0311 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.38μs 1.46ns 5.45ns 0.0306 0 0 2.2 KB
master EnrichedLog net472 4.88μs 1.47ns 5.69ns 0.319 0 0 2.02 KB
#6291 EnrichedLog net6.0 3.18μs 0.91ns 3.53ns 0.0302 0 0 2.2 KB
#6291 EnrichedLog netcoreapp3.1 4.2μs 2.9ns 11.2ns 0.0293 0 0 2.2 KB
#6291 EnrichedLog net472 4.87μs 1.35ns 5.07ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.558ns 2.16ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.72μs 0.984ns 3.81ns 0.0147 0 0 1.14 KB
master SendReceive net472 2.1μs 1.87ns 7.25ns 0.183 0 0 1.16 KB
#6291 SendReceive net6.0 1.33μs 1.68ns 6.51ns 0.0158 0 0 1.14 KB
#6291 SendReceive netcoreapp3.1 1.73μs 0.816ns 3.16ns 0.0155 0 0 1.14 KB
#6291 SendReceive net472 2.07μs 1.54ns 5.98ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 0.924ns 3.58ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.87μs 1.35ns 5.21ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.36μs 1.97ns 7.38ns 0.323 0 0 2.04 KB
#6291 EnrichedLog net6.0 2.83μs 1.07ns 4.15ns 0.0227 0 0 1.6 KB
#6291 EnrichedLog netcoreapp3.1 4μs 1.65ns 5.95ns 0.0217 0 0 1.65 KB
#6291 EnrichedLog net472 4.41μs 2.79ns 10.8ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6291

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.171 585.16 685.36

Faster 🎉 in #6291

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.119 448.68 401.05

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 447ns 0.985ns 3.81ns 0.00811 0 0 576 B
master StartFinishSpan netcoreapp3.1 581ns 1.33ns 4.98ns 0.00753 0 0 576 B
master StartFinishSpan net472 585ns 0.801ns 3.1ns 0.0917 0 0 578 B
master StartFinishScope net6.0 476ns 0.665ns 2.58ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 729ns 1.21ns 4.38ns 0.00953 0 0 696 B
master StartFinishScope net472 860ns 2.31ns 8.94ns 0.104 0 0 658 B
#6291 StartFinishSpan net6.0 401ns 0.412ns 1.59ns 0.00804 0 0 576 B
#6291 StartFinishSpan netcoreapp3.1 552ns 0.265ns 0.992ns 0.00769 0 0 576 B
#6291 StartFinishSpan net472 685ns 0.275ns 1.07ns 0.0918 0 0 578 B
#6291 StartFinishScope net6.0 501ns 0.249ns 0.931ns 0.00983 0 0 696 B
#6291 StartFinishScope netcoreapp3.1 721ns 0.33ns 1.23ns 0.00937 0 0 696 B
#6291 StartFinishScope net472 862ns 0.487ns 1.89ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 602ns 1.3ns 5.03ns 0.00969 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 895ns 2.22ns 8.32ns 0.00956 0 0 696 B
master RunOnMethodBegin net472 1.13μs 2.37ns 9.18ns 0.104 0 0 658 B
#6291 RunOnMethodBegin net6.0 596ns 0.294ns 1.1ns 0.00991 0 0 696 B
#6291 RunOnMethodBegin netcoreapp3.1 905ns 2.78ns 10.8ns 0.00941 0 0 696 B
#6291 RunOnMethodBegin net472 1.17μs 0.586ns 2.27ns 0.104 0 0 658 B

@andrewlock

andrewlock commented Nov 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6291) (11.027M)   : 0, 11026751
    master (11.038M)   : 0, 11037856
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6291) (7.175M)   : 0, 7174690
    master (7.290M)   : 0, 7290054
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.562M)   : 0, 7561734

    section Manual
    master (11.036M)   : 0, 11035836

    section Manual + Automatic
    This PR (6291) (6.688M)   : 0, 6688268
    master (6.689M)   : 0, 6689266

    section DD_TRACE_ENABLED=0
    master (10.220M)   : 0, 10219721
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6291) (9.549M)   : 0, 9548819
    master (9.546M)   : 0, 9546165
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6291) (6.501M)   : 0, 6500605
    master (6.394M)   : 0, 6393817

    section Trace stats
    master (6.660M)   : 0, 6660181

    section Manual
    master (9.408M)   : 0, 9407542

    section Manual + Automatic
    This PR (6291) (6.101M)   : 0, 6100679
    master (5.960M)   : 0, 5959995

    section DD_TRACE_ENABLED=0
    master (8.863M)   : 0, 8862796
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6291) (10.159M)   : 0, 10159323
    master (9.789M)   : 0, 9789389
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6291) (6.499M)   : 0, 6498811
    master (6.248M)   : 0, 6248234
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.983M)   : 0, 6982636

    section Manual
    master (9.781M)   : 0, 9781004

    section Manual + Automatic
    This PR (6291) (6.135M)   : 0, 6135325
    master (5.788M)   : 0, 5787625

    section DD_TRACE_ENABLED=0
    master (9.053M)   : 0, 9053347
Loading

@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch from 3a5cef0 to 6e16ca1 Compare November 20, 2024 17:36
@gleocadie gleocadie changed the title [Profiler] Gleocadie/clean up profiler code [Profiler] Clean up profiler code Nov 20, 2024
@gleocadie
gleocadie marked this pull request as ready for review November 20, 2024 17:37
@gleocadie
gleocadie requested a review from a team as a code owner November 20, 2024 17:37
@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch from 6e16ca1 to f794310 Compare November 20, 2024 17:37
@gleocadie
gleocadie requested a review from a team as a code owner November 22, 2024 07:53
chrisnas
chrisnas approved these changes Nov 22, 2024
View reviewed changes

@chrisnas chrisnas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/CorProfilerCallback.cpp Outdated
@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch 2 times, most recently from 254d802 to 1db1780 Compare November 26, 2024 11:31
@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch from 1db1780 to 2ef8605 Compare December 2, 2024 15:29
@gleocadie
gleocadie force-pushed the gleocadie/clean-up-profiler-code branch from 2ef8605 to f827fd3 Compare December 2, 2024 15:56
@gleocadie
gleocadie merged commit 0e4dcac into master Dec 2, 2024
@gleocadie
gleocadie deleted the gleocadie/clean-up-profiler-code branch December 2, 2024 20:06
@github-actions github-actions Bot added this to the vNext-v3 milestone Dec 2, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
@gleocadie @veerbia
[Profiler] Clean up profiler code (#6291)
e997cb3 
- Implement a `LogOnce`
- Implement an efficient `LogGcEvent`
- Remove the WCF demos stuffs
@andrewlock andrewlock added the type:cleanup Minor code clean up label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisnas chrisnas chrisnas approved these changes

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler type:cleanup Minor code clean up

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gleocadie @andrewlock @chrisnas