[ASM] Update WAF v1.21.0 Ruleset 1.13.3 by NachoEchevarria · Pull Request #6287 · DataDog/dd-trace-dotnet

NachoEchevarria · 2024-11-14T14:18:30Z

Summary of changes

This PR updates the WAF to its latest version:
https://github.com/DataDog/libddwaf/releases/tag/1.21.0

The default ruleset has been also updated to version 1.13.3
https://github.com/DataDog/appsec-event-rules/releases/tag/1.13.3

Reason for change

Implementation details

Test coverage

Other details

github-actions · 2024-11-14T14:19:25Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

-        "_dd.appsec.event_rules.version": "1.13.2",
-        "_dd.appsec.waf.version": "1.20.1",
+        "_dd.appsec.event_rules.version": "1.13.3",
+        "_dd.appsec.waf.version": "1.21.0",

2 occurrences of :

-        "_dd.appsec.event_rules.loaded": 158.0,
+        "_dd.appsec.event_rules.loaded": 159.0,

1 occurrences of :

-        "_dd.appsec.waf.version": "1.20.1",
[...]
+        "_dd.appsec.waf.version": "1.21.0",

26 occurrences of :

-      _dd.appsec.event_rules.version: 1.13.2,
+      _dd.appsec.event_rules.version: 1.13.3,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.13.2,
+      _dd.appsec.event_rules.version: 1.13.3,
[...]
-      _dd.appsec.waf.version: 1.20.1,
+      _dd.appsec.waf.version: 1.21.0,

1 occurrences of :

-      _dd.appsec.event_rules.loaded: 158.0,
+      _dd.appsec.event_rules.loaded: 159.0,

1 occurrences of :

-      _dd.appsec.waf.version: 1.20.1,
+      _dd.appsec.waf.version: 1.21.0,

6 occurrences of :

-      _dd.appsec.event_rules.version: 1.13.2,
-      _dd.appsec.waf.version: 1.20.1,
+      _dd.appsec.event_rules.version: 1.13.3,
+      _dd.appsec.waf.version: 1.21.0,
[...]
-      _dd.appsec.event_rules.loaded: 158.0,
+      _dd.appsec.event_rules.loaded: 159.0,

datadog-ddstaging · 2024-11-14T14:42:08Z

Datadog Report

Branch report: nacho/UpdateWAFv1.21.0
Commit report: 4f0aa4d
Test service: dd-trace-dotnet

❌ 6 Failed (0 Known Flaky), 449628 Passed, 2749 Skipped, 19h 48m 19.86s Total Time

❌ Failed Tests (6)

This report shows up to 5 failed tests.

AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

andrewlock · 2024-11-14T14:49:48Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6287) - mean (72ms)  : 64, 79
     .   : milestone, 72,
    master - mean (72ms)  : 63, 81
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6287) - mean (1,106ms)  : 1086, 1125
     .   : milestone, 1106,
    master - mean (1,107ms)  : 1082, 1132
     .   : milestone, 1107,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6287) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6287) - mean (767ms)  : 748, 786
     .   : milestone, 767,
    master - mean (770ms)  : 753, 786
     .   : milestone, 770,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6287) - mean (92ms)  : 90, 93
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6287) - mean (719ms)  : 704, 734
     .   : milestone, 719,
    master - mean (725ms)  : 709, 741
     .   : milestone, 725,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6287) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 185, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6287) - mean (1,210ms)  : 1186, 1235
     .   : milestone, 1210,
    master - mean (1,213ms)  : 1190, 1237
     .   : milestone, 1213,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6287) - mean (276ms)  : 270, 281
     .   : milestone, 276,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6287) - mean (939ms)  : 924, 954
     .   : milestone, 939,
    master - mean (945ms)  : 929, 960
     .   : milestone, 945,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6287) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6287) - mean (922ms)  : 904, 940
     .   : milestone, 922,
    master - mean (930ms)  : 907, 952
     .   : milestone, 930,

andrewlock · 2024-11-14T20:24:07Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6287) (11.027M)   : 0, 11026656
    master (11.207M)   : 0, 11207454
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6287) (7.218M)   : 0, 7218304
    master (7.213M)   : 0, 7213054
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.646M)   : 0, 7646289

    section Manual
    master (11.210M)   : 0, 11209987

    section Manual + Automatic
    This PR (6287) (6.626M)   : 0, 6626278
    master (6.787M)   : 0, 6786812

    section DD_TRACE_ENABLED=0
    master (10.192M)   : 0, 10192322

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6287) (9.475M)   : 0, 9475191
    master (9.557M)   : 0, 9557430
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6287) (6.457M)   : 0, 6457142
    master (6.335M)   : 0, 6335118

    section Trace stats
    master (6.713M)   : 0, 6713489

    section Manual
    master (9.597M)   : 0, 9597235

    section Manual + Automatic
    This PR (6287) (5.928M)   : 0, 5928393
    master (5.989M)   : 0, 5988836

    section DD_TRACE_ENABLED=0
    master (8.804M)   : 0, 8803524

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6287) (9.378M)   : 0, 9377936
    master (9.893M)   : 0, 9892862
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6287) (6.122M)   : 0, 6121571
    master (6.418M)   : 0, 6418372
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.033M)   : 0, 7032568

    section Manual
    master (9.706M)   : 0, 9706262

    section Manual + Automatic
    This PR (6287) (5.646M)   : 0, 5645505
    master (5.752M)   : 0, 5752126

    section DD_TRACE_ENABLED=0
    master (9.107M)   : 0, 9107420

andrewlock · 2024-11-15T22:19:49Z

Benchmarks Report for tracer 🐌

Benchmarks for #6287 compared to master:

1 benchmarks are faster, with geometric mean 1.145
1 benchmarks are slower, with geometric mean 1.197
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.06μs	44.9ns	287ns	0.0163	0.00817	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	55.2ns	322ns	0.0204	0.0102	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	62ns	240ns	1.05	0.318	0.114	6.22 KB
#6287	`StartStopWithChild`	net6.0	7.9μs	44.2ns	293ns	0.0157	0.00784	0	5.61 KB
#6287	`StartStopWithChild`	netcoreapp3.1	10.2μs	58.2ns	454ns	0.0147	0.00491	0	5.8 KB
#6287	`StartStopWithChild`	net472	16.3μs	44.6ns	173ns	1.05	0.317	0.106	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	511μs	331ns	1.28μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	495ns	1.92μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	862μs	402ns	1.56μs	0.428	3.3 KB
#6287	`WriteAndFlushEnrichedTraces`	net6.0	498μs	304ns	1.18μs	0	2.7 KB
#6287	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	641μs	320ns	1.24μs	0	2.7 KB
#6287	`WriteAndFlushEnrichedTraces`	net472	876μs	664ns	2.39μs	0.437	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	200μs	1.13μs	8.63μs	0.194	18.73 KB
master	`SendRequest`	netcoreapp3.1	222μs	1.29μs	11.2μs	0.209	20.89 KB
master	`SendRequest`	net472	9.3E‑07ns	9.3E‑07ns	3.22E‑06ns	0	0 b
#6287	`SendRequest`	net6.0	200μs	1.12μs	10μs	0.193	18.73 KB
#6287	`SendRequest`	netcoreapp3.1	221μs	1.25μs	8.82μs	0.22	20.89 KB
#6287	`SendRequest`	net472	0.000863ns	0.000472ns	0.0017ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	564μs	2.19μs	8.49μs	0.556	0	0	41.59 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	3.03μs	12.1μs	0.355	0	0	41.94 KB
master	`WriteAndFlushEnrichedTraces`	net472	857μs	3.34μs	13μs	8.25	2.6	0.434	53.3 KB
#6287	`WriteAndFlushEnrichedTraces`	net6.0	588μs	2.82μs	11.6μs	0.563	0	0	41.71 KB
#6287	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	691μs	2.77μs	10μs	0.343	0	0	41.74 KB
#6287	`WriteAndFlushEnrichedTraces`	net472	844μs	3.21μs	12.4μs	8.45	2.53	0.422	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.28μs	1.93ns	7.49ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.86μs	0.697ns	2.61ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	2.44ns	9.46ns	0.156	0.00105	987 B
#6287	`ExecuteNonQuery`	net6.0	1.41μs	1.18ns	4.4ns	0.0142	0	1.02 KB
#6287	`ExecuteNonQuery`	netcoreapp3.1	1.8μs	1.6ns	6.19ns	0.0135	0	1.02 KB
#6287	`ExecuteNonQuery`	net472	2.01μs	1.43ns	5.54ns	0.156	0.00101	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.24μs	0.547ns	2.04ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.436ns	1.63ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.45μs	1.73ns	6.68ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.25μs	0.611ns	2.29ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.304ns	1.1ns	0.0143	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	1ns	3.75ns	0.166	1.05 KB
#6287	`CallElasticsearch`	net6.0	1.27μs	1.25ns	4.67ns	0.0137	976 B
#6287	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.609ns	2.28ns	0.0133	976 B
#6287	`CallElasticsearch`	net472	2.48μs	1.35ns	5.24ns	0.158	995 B
#6287	`CallElasticsearchAsync`	net6.0	1.25μs	0.468ns	1.75ns	0.0131	952 B
#6287	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.858ns	3.21ns	0.0136	1.02 KB
#6287	`CallElasticsearchAsync`	net472	2.57μs	0.887ns	3.44ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.33μs	0.622ns	2.41ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.802ns	2.78ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.87μs	0.696ns	2.6ns	0.145	915 B
#6287	`ExecuteAsync`	net6.0	1.24μs	0.627ns	2.26ns	0.0137	952 B
#6287	`ExecuteAsync`	netcoreapp3.1	1.66μs	1.86ns	6.95ns	0.0132	952 B
#6287	`ExecuteAsync`	net472	1.84μs	0.432ns	1.62ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.65μs	12.1ns	46.7ns	0.0317	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.19μs	1.71ns	6.64ns	0.0392	2.85 KB
master	`SendAsync`	net472	7.41μs	1.13ns	4.38ns	0.495	3.12 KB
#6287	`SendAsync`	net6.0	4.39μs	1.78ns	6.9ns	0.0333	2.31 KB
#6287	`SendAsync`	netcoreapp3.1	5.27μs	3.08ns	11.1ns	0.037	2.85 KB
#6287	`SendAsync`	net472	7.3μs	1.96ns	7.61ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	0.696ns	2.7ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	0.916ns	3.55ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.44μs	1.09ns	4.09ns	0.249	1.57 KB
#6287	`EnrichedLog`	net6.0	1.46μs	0.711ns	2.66ns	0.0226	1.64 KB
#6287	`EnrichedLog`	netcoreapp3.1	2.33μs	0.723ns	2.61ns	0.0222	1.64 KB
#6287	`EnrichedLog`	net472	2.55μs	2.33ns	9.01ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	69.8ns	261ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	195ns	756ns	0.0625	0	4.28 KB
master	`EnrichedLog`	net472	152μs	97.6ns	365ns	0.682	0.227	4.46 KB
#6287	`EnrichedLog`	net6.0	120μs	74.2ns	287ns	0.0597	0	4.28 KB
#6287	`EnrichedLog`	netcoreapp3.1	123μs	97.6ns	378ns	0	0	4.28 KB
#6287	`EnrichedLog`	net472	151μs	113ns	422ns	0.683	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.87μs	0.804ns	3.01ns	0.0301	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.12μs	1.51ns	5.66ns	0.0288	2.2 KB
master	`EnrichedLog`	net472	5.05μs	1.24ns	4.63ns	0.319	2.02 KB
#6287	`EnrichedLog`	net6.0	3.08μs	0.893ns	3.46ns	0.0309	2.2 KB
#6287	`EnrichedLog`	netcoreapp3.1	4.18μs	1.51ns	5.86ns	0.0292	2.2 KB
#6287	`EnrichedLog`	net472	4.82μs	1.2ns	4.5ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.39μs	0.645ns	2.5ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.74μs	0.55ns	2.06ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.06μs	0.378ns	1.36ns	0.183	1.16 KB
#6287	`SendReceive`	net6.0	1.36μs	1.09ns	4.08ns	0.0165	1.14 KB
#6287	`SendReceive`	netcoreapp3.1	1.76μs	0.97ns	3.63ns	0.0151	1.14 KB
#6287	`SendReceive`	net472	2.02μs	0.544ns	2.04ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	0.874ns	3.27ns	0.0222	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4μs	2.93ns	11.3ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	4.39μs	2.15ns	8.05ns	0.324	2.04 KB
#6287	`EnrichedLog`	net6.0	2.7μs	1.03ns	4.01ns	0.0216	1.6 KB
#6287	`EnrichedLog`	netcoreapp3.1	4.02μs	2.41ns	9.33ns	0.0221	1.65 KB
#6287	`EnrichedLog`	net472	4.54μs	1.91ns	7.39ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6287

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.197	404.97	484.89

Faster 🎉 in #6287

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.145	566.96	495.15

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	405ns	0.283ns	1.1ns	0.00804	576 B
master	`StartFinishSpan`	netcoreapp3.1	544ns	0.659ns	2.55ns	0.00758	576 B
master	`StartFinishSpan`	net472	648ns	0.852ns	3.3ns	0.0917	578 B
master	`StartFinishScope`	net6.0	567ns	0.41ns	1.59ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	768ns	0.827ns	3.2ns	0.00937	696 B
master	`StartFinishScope`	net472	895ns	0.915ns	3.54ns	0.104	658 B
#6287	`StartFinishSpan`	net6.0	485ns	0.272ns	1.05ns	0.00802	576 B
#6287	`StartFinishSpan`	netcoreapp3.1	564ns	0.531ns	2.06ns	0.00764	576 B
#6287	`StartFinishSpan`	net472	707ns	1.2ns	4.63ns	0.0918	578 B
#6287	`StartFinishScope`	net6.0	495ns	0.298ns	1.11ns	0.00967	696 B
#6287	`StartFinishScope`	netcoreapp3.1	734ns	0.587ns	2.27ns	0.00963	696 B
#6287	`StartFinishScope`	net472	870ns	0.653ns	2.53ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	648ns	0.872ns	3.26ns	0.00984	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	913ns	1.11ns	4.29ns	0.00921	696 B
master	`RunOnMethodBegin`	net472	1.18μs	1.56ns	6.06ns	0.104	658 B
#6287	`RunOnMethodBegin`	net6.0	659ns	0.572ns	2.21ns	0.00987	696 B
#6287	`RunOnMethodBegin`	netcoreapp3.1	981ns	0.944ns	3.66ns	0.00939	696 B
#6287	`RunOnMethodBegin`	net472	1.11μs	1.34ns	5.17ns	0.104	658 B

NachoEchevarria · 2024-11-21T09:26:51Z

Thanks for you reviews!

NachoEchevarria added 2 commits November 14, 2024 12:54

Update WAF version

b1c4112

Remove not needed

272aff4

github-actions Bot added the area:asm label Nov 14, 2024

Update ruleset

43098bd

NachoEchevarria changed the title ~~[ASM] Update WAF v1.21.0~~ [ASM] Update WAF v1.21.0 Ruleset 1.13.3 Nov 15, 2024

NachoEchevarria added 3 commits November 15, 2024 15:31

Fix rules number in smoke tests. Remove not needed test.

1a0a0ae

Fix unit test

21e2390

Update rule number in snapshots

4f0aa4d

anna-git approved these changes Nov 18, 2024

View reviewed changes

NachoEchevarria added the area:asm-waf-update label Nov 18, 2024

lucaspimentel approved these changes Nov 20, 2024

View reviewed changes

NachoEchevarria marked this pull request as ready for review November 21, 2024 09:26

NachoEchevarria requested review from a team as code owners November 21, 2024 09:26

NachoEchevarria merged commit 7826d35 into master Nov 21, 2024

NachoEchevarria deleted the nacho/UpdateWAFv1.21.0 branch November 21, 2024 09:27

github-actions Bot added this to the vNext-v3 milestone Nov 21, 2024

NachoEchevarria mentioned this pull request Dec 11, 2024

[ASM] RASP: Command injection vulnerability implementation #6323

Merged

Uh oh!

Conversation

NachoEchevarria commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

github-actions Bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Snapshots difference summary

Uh oh!

datadog-ddstaging Bot commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

❌ Failed Tests (6)

Uh oh!

andrewlock commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throughput/Crank Report ⚡

Uh oh!

andrewlock commented Nov 15, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6287

Faster 🎉 in #6287

Raw results

Raw results

Uh oh!

NachoEchevarria commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NachoEchevarria commented Nov 14, 2024 •

edited

Loading

github-actions Bot commented Nov 14, 2024 •

edited

Loading

datadog-ddstaging Bot commented Nov 14, 2024 •

edited

Loading

andrewlock commented Nov 14, 2024 •

edited

Loading

andrewlock commented Nov 14, 2024 •

edited

Loading