Fix flake in Ngen ManualInstrumentationTests#6214
Merged
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 365496 Passed, 2105 Skipped, 14h 35m 11.42s Total Time |
kevingosse
approved these changes
Oct 29, 2024
tonyredondo
approved these changes
Oct 29, 2024
Member
Author
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6214) - mean (71ms) : 67, 75
. : milestone, 71,
master - mean (70ms) : 68, 73
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6214) - mean (1,116ms) : 1096, 1136
. : milestone, 1116,
master - mean (1,115ms) : 1089, 1141
. : milestone, 1115,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6214) - mean (110ms) : 106, 114
. : milestone, 110,
master - mean (110ms) : 107, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6214) - mean (776ms) : 757, 795
. : milestone, 776,
master - mean (779ms) : 761, 797
. : milestone, 779,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6214) - mean (94ms) : 89, 98
. : milestone, 94,
master - mean (93ms) : 90, 95
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6214) - mean (733ms) : 715, 752
. : milestone, 733,
master - mean (732ms) : 717, 747
. : milestone, 732,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6214) - mean (191ms) : 188, 194
. : milestone, 191,
master - mean (190ms) : 187, 192
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6214) - mean (1,203ms) : 1177, 1229
. : milestone, 1203,
master - mean (1,203ms) : 1179, 1227
. : milestone, 1203,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6214) - mean (276ms) : 271, 281
. : milestone, 276,
master - mean (275ms) : 270, 280
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6214) - mean (942ms) : 924, 960
. : milestone, 942,
master - mean (947ms) : 927, 967
. : milestone, 947,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6214) - mean (264ms) : 260, 269
. : milestone, 264,
master - mean (264ms) : 261, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (6214) - mean (930ms) : 912, 948
. : milestone, 930,
master - mean (928ms) : 909, 948
. : milestone, 928,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Try to make sure the new Ngen tests don't flake
Reason for change
#6184 added some new tests which use NGEN. Those tests seem to be flaky (on x86 particularly). AFAICT it's a timeout issue with the
ngen.exeexecution, not an issue with the underlying implementation.Implementation details
ngen display- it was only added for debugging, and seems to take a long timeTest coverage
This is the test