Support Hot Chocolate v14#6180
Conversation
22729f6 to
a65ce0e
Compare
|
Hello, thank you for the contribution ! We're gonna have a look at the code, but just to answer your questions about MacOS development:
did you try to open the full
ARM-based macbook shouldn't be an issue. We have a little bit of doc here about that, you should use |
5f9faf5 to
23d55ef
Compare
|
@vandonr Thanks for the feedback :) I was able to get the tests to run. |
|
@vandonr bump :) |
|
Thanks for the contribution! Overall it looks really good
So, what we can do though is cherry-pick your commits onto one of our own branches and make a PR on your behalf. Sorry for these limitations, it is something that we are aware of and are attempting to improve. |
|
That's fine for me :) Can I assist in any way? For example by squashing my commits? |
|
@tobias-tengler Squashing them down would be great thanks! |
32cc877 to
8236267
Compare
Update Hot Chocolate Auto Instrumentation Bump versions Manually check in snapshots Cleanup Update test Rename current snapshots to .Pre_14_0_0 Check in new snapshots
8236267 to
26f3515
Compare
|
ok thanks, sorry to have kept you waiting like that, we don't get external contributions very often, we had to sync internally :) |
|
Closed in favor of: #6248 |
## Summary of changes Hot Chocolate v14 was released recently: [NuGet](https://www.nuget.org/packages/HotChocolate.AspNetCore/14.0.0) This new version doesn't work with the existing integration ## Reason for change ## Implementation details picked up work from an external contributor (@tobias-tengler in #6180) tried to reduce a bit the amount of diff by reusing more existing code ## Test coverage integration test runs on new version ## Other details <!-- Fixes #{issue} --> <!--⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. --> --------- Co-authored-by: Andrew Lock <[email protected]> Co-authored-by: Tobias Tengler <[email protected]>
## Summary of changes Hot Chocolate v14 was released recently: [NuGet](https://www.nuget.org/packages/HotChocolate.AspNetCore/14.0.0) This new version doesn't work with the existing integration ## Reason for change ## Implementation details picked up work from an external contributor (@tobias-tengler in #6180) tried to reduce a bit the amount of diff by reusing more existing code ## Test coverage integration test runs on new version ## Other details <!-- Fixes #{issue} --> <!--⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. --> --------- Co-authored-by: Andrew Lock <[email protected]> Co-authored-by: Tobias Tengler <[email protected]>
3 participants
Hot Chocolate v14 was released last week: NuGet
We attempted to update today, but noticed that the DataDog integration no longer worked.
This PR updates the Tracer auto-instrumentation to support Hot Chocolate v14.