Skip to content

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic (#6159 => v2)#6178

Merged
bouwkast merged 1 commit into
release/2.xfrom
andrew/omerr/fix-sourcelink-azure-devops-dev-urls
Oct 22, 2024
Merged

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic (#6159 => v2)#6178
bouwkast merged 1 commit into
release/2.xfrom
andrew/omerr/fix-sourcelink-azure-devops-dev-urls

Conversation

@andrewlock

@andrewlock andrewlock commented Oct 22, 2024 •
edited by lucaspimentel
Loading

Copy link
Copy Markdown
Member

Summary of changes

Fixes #6146

2.x backport of #6159

Reason for change

Customer reported an issue where the tracer reports incorrect git.repository_url as a result of this bug.

Test coverage

Add a new test case.

@OmerRaviv @andrewlock
Add support for the "new" dev.azure.com style URLs in SourceLink URL …
2374ddd 
…parsing logic (#6159)

## Summary of changes

Fixes #6146

## Reason for change
Customer reported an issue where the tracer reports incorrect
`git.repository_url` as a result of this bug.


## Test coverage
Add a new test case.
@andrewlock
andrewlock requested review from a team as code owners October 22, 2024 16:49
@andrewlock andrewlock added type:bug area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) labels Oct 22, 2024
OmerRaviv
OmerRaviv approved these changes Oct 22, 2024
View reviewed changes

@OmerRaviv OmerRaviv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks brilliant ;)

@datadog-ddstaging

datadog-ddstaging Bot commented Oct 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/omerr/fix-sourcelink-azure-devops-dev-urls
Commit report: 2374ddd
Test service: dd-trace-dotnet

✅ 0 Failed, 351505 Passed, 1809 Skipped, 14h 38m 35.67s Total Time

@lucaspimentel lucaspimentel mentioned this pull request Oct 22, 2024
Merged
@andrewlock

andrewlock commented Oct 22, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6178) - mean (74ms)  : 64, 84
     .   : milestone, 74,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6178) - mean (1,028ms)  : 1002, 1054
     .   : milestone, 1028,
    master - mean (1,112ms)  : 1091, 1133
     .   : milestone, 1112,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6178) - mean (111ms)  : 107, 115
     .   : milestone, 111,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6178) - mean (704ms)  : 682, 725
     .   : milestone, 704,
    master - mean (773ms)  : 757, 788
     .   : milestone, 773,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6178) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6178) - mean (665ms)  : 640, 691
     .   : milestone, 665,
    master - mean (728ms)  : 717, 738
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6178) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6178) - mean (1,110ms)  : 1095, 1126
     .   : milestone, 1110,
    master - mean (1,205ms)  : 1179, 1230
     .   : milestone, 1205,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6178) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6178) - mean (874ms)  : 851, 897
     .   : milestone, 874,
    master - mean (942ms)  : 922, 963
     .   : milestone, 942,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6178) - mean (266ms)  : 260, 271
     .   : milestone, 266,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6178) - mean (859ms)  : 837, 881
     .   : milestone, 859,
    master - mean (929ms)  : 910, 949
     .   : milestone, 929,
Loading

@bouwkast
bouwkast merged commit 4397347 into release/2.x Oct 22, 2024
@bouwkast
bouwkast deleted the andrew/omerr/fix-sourcelink-azure-devops-dev-urls branch October 22, 2024 20:01
@github-actions github-actions Bot added this to the vNext-v2 milestone Oct 22, 2024
@andrewlock andrewlock added type:backport Feature backport to old version identified-by:customer labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes
@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees

No one assigned

Labels

area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) identified-by:customer type:backport Feature backport to old version type:bug

Projects

None yet

Milestone

2.60.0

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewlock @OmerRaviv @lucaspimentel @bouwkast