Skip to content

Rejit NGEN/R2R inliners in cascade#6165

Draft
tonyredondo wants to merge 4 commits into
masterfrom
tony/rejit-ngen-inlinees-in-cascade
Draft

Rejit NGEN/R2R inliners in cascade#6165
tonyredondo wants to merge 4 commits into
masterfrom
tony/rejit-ngen-inlinees-in-cascade

Conversation

@tonyredondo

@tonyredondo tonyredondo commented Oct 18, 2024

Copy link
Copy Markdown
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@datadog-ddstaging

datadog-ddstaging Bot commented Oct 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: tony/rejit-ngen-inlinees-in-cascade
Commit report: c55f026
Test service: dd-trace-dotnet

❌ 538 Failed (1 Known Flaky), 367107 Passed, 2735 Skipped, 27h 11m 21.01s Total Time

❌ Failed Tests (538)

This report shows up to 5 failed tests.

  • WebRequest20Tests.SubmitsTracesV0 - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
     Expected collection to contain at least 45 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 20: {{TraceId: 17230099660437532535, SpanId: 12312820952462972361, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 11585401359340291279, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 4862617258144869410, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 17760091171412348632, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 7674495963152427914, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 3125969966078135340, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 2699421423524152310, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 17436056926979120816, Name: http.request, Resource: GET localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 13934835550029033453, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 7336323002981635848, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 14388996330012317286, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 2789692857304635802, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 848199702202191386, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 347633347011169315, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 15860714518074763166, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 18026880555779138122, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 4801209760033438974, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 421456495146843628, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 6367531244756536593, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 17230099660437532535, SpanId: 17435698312019150054, Name: http.request, Resource: POST localhost:52833/?/, Service: Samples.WebRequest.NetFramework20-http-client}}.

  • WebRequest20Tests.SubmitsTracesV0 - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
     Expected collection to contain at least 45 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 20: {{TraceId: 1993925066046811692, SpanId: 17522792888352631208, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 3874056559256372812, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 752286746873647085, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 10211410634715973355, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 9636161335198290498, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 5319243855084761088, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 9775813761288111643, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 18113295915717258107, Name: http.request, Resource: GET localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 11667590713926285233, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 12590288027026174168, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 2182397833951132537, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 1134969161754215295, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 455325468166256278, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 12068874884327786563, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 3281807777336416648, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 13492740025873134671, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 2583996502760963814, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 18122455030978086736, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 11173944722521843419, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}, {TraceId: 1993925066046811692, SpanId: 1740961613649764382, Name: http.request, Resource: POST localhost:52488/?/, Service: Samples.WebRequest.NetFramework20-http-client}}.

  • WebRequest20Tests.SubmitsTracesV1 - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
     Expected collection to contain at least 45 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 20: {{TraceId: 8054578283299722440, SpanId: 15996055877341916874, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 1033875560879936063, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 14946534715163057333, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 8075158220442553698, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 12446180850076778252, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 873313216830478354, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 3507685776238215755, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 9451587929223174130, Name: http.client.request, Resource: GET localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 4938313244611652576, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 10482749085974560168, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 12402388644344055972, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 7294424303811139292, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 4083522547456780095, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 8953419291498388939, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 853641941671342944, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 8065962422915524330, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 3266663720414572532, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 6208564800184231734, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 16701110972294285039, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 8054578283299722440, SpanId: 8268231265685025298, Name: http.client.request, Resource: POST localhost:52504/?/, Service: Samples.WebRequest.NetFramework20}}.

  • WebRequest20Tests.SubmitsTracesV1 - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
     Expected collection to contain at least 45 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 20: {{TraceId: 11007459983225520617, SpanId: 6421766945062143245, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 17088802065379355027, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 1203460289250382495, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 12599500102452429445, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 856515226641852282, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 5575698610642325332, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 6735080496242556101, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 402584959483972343, Name: http.client.request, Resource: GET localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 17784743367873111016, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 15286942805098325641, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 9175136879177196285, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 14297320866778891414, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 18414006366033994723, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 8677103861707551388, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 6332401696782265104, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 9399720956912094083, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 1206821186949501395, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 12686692849800140382, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 9637019139325027306, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}, {TraceId: 11007459983225520617, SpanId: 6967773933406032170, Name: http.client.request, Resource: POST localhost:52854/?/, Service: Samples.WebRequest.NetFramework20}}.

  • SqlCommand20Tests.SubmitsTracesV0 - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet - Details

    Expand for error 
     Expected collection to contain at least 28 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 9: {{TraceId: 9791221359624467450, SpanId: 1394405296406428842, Name: sync, Resource: SqlCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 6400778960007844400, Name: command, Resource: SqlCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 6959772279783042714, Name: sync, Resource: DbCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 7815170904694927195, Name: command, Resource: DbCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 266420817988905534, Name: sync, Resource: IDbCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 1433759498780393942, Name: command, Resource: IDbCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 13449848329662327783, Name: sync, Resource: TCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 5622879205820447149, Name: command, Resource: TCommand20, Service: Samples.SqlServer.NetFramework20}, {TraceId: 9791221359624467450, SpanId: 8411418634132305409, Name: RunAllAsync, Resource: RunAllAsync, Service: Samples.SqlServer.NetFramework20}}.

@andrewlock

andrewlock commented Oct 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6165) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (71ms)  : 68, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6165) - mean (1,114ms)  : 1097, 1132
     .   : milestone, 1114,
    master - mean (1,120ms)  : 1092, 1149
     .   : milestone, 1120,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6165) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (109ms)  : 107, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6165) - mean (858ms)  : crit, 846, 869
     .   : crit, milestone, 858,
    master - mean (776ms)  : 757, 795
     .   : milestone, 776,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6165) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6165) - mean (812ms)  : crit, 797, 826
     .   : crit, milestone, 812,
    master - mean (728ms)  : 710, 746
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6165) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6165) - mean (1,205ms)  : 1184, 1226
     .   : milestone, 1205,
    master - mean (1,193ms)  : 1168, 1218
     .   : milestone, 1193,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6165) - mean (275ms)  : 271, 279
     .   : milestone, 275,
    master - mean (275ms)  : 270, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6165) - mean (1,034ms)  : crit, 1017, 1050
     .   : crit, milestone, 1034,
    master - mean (943ms)  : 924, 961
     .   : milestone, 943,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6165) - mean (264ms)  : 260, 267
     .   : milestone, 264,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6165) - mean (1,015ms)  : crit, 998, 1032
     .   : crit, milestone, 1015,
    master - mean (923ms)  : 907, 938
     .   : milestone, 923,
Loading

@andrewlock

andrewlock commented Oct 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6165 compared to master:

  • All benchmarks have the same speed
  • 2 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 73.1μs 67.2ns 251ns 0.0737 0 0 6 KB
master AllCycleSimpleBody netcoreapp3.1 64.7μs 162ns 628ns 0.0957 0 0 6.95 KB
master AllCycleSimpleBody net472 49.3μs 182ns 706ns 1.32 0 0 8.34 KB
master AllCycleMoreComplexBody net6.0 79.4μs 67.9ns 263ns 0.119 0 0 9.51 KB
master AllCycleMoreComplexBody netcoreapp3.1 71.5μs 82.9ns 310ns 0.143 0 0 10.37 KB
master AllCycleMoreComplexBody net472 56.8μs 126ns 489ns 1.86 0.0282 0 11.85 KB
master ObjectExtractorSimpleBody net6.0 144ns 0.177ns 0.637ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 199ns 0.147ns 0.548ns 0.0038 0 0 272 B
master ObjectExtractorSimpleBody net472 173ns 0.31ns 1.2ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.24μs 2.65ns 9.93ns 0.0533 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.1μs 3.92ns 15.2ns 0.0508 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.87μs 4.52ns 16.9ns 0.602 0.00578 0 3.8 KB
#6165 AllCycleSimpleBody net6.0 73.6μs 112ns 435ns 0.0719 0 0 6.01 KB
#6165 AllCycleSimpleBody netcoreapp3.1 63.2μs 107ns 415ns 0.095 0 0 6.95 KB
#6165 AllCycleSimpleBody net472 48.6μs 57.9ns 224ns 1.3 0 0 8.33 KB
#6165 AllCycleMoreComplexBody net6.0 77.9μs 75ns 291ns 0.118 0 0 9.51 KB
#6165 AllCycleMoreComplexBody netcoreapp3.1 69.3μs 68.8ns 267ns 0.138 0 0 10.37 KB
#6165 AllCycleMoreComplexBody net472 54.1μs 119ns 459ns 1.87 0.0271 0 11.85 KB
#6165 ObjectExtractorSimpleBody net6.0 140ns 0.127ns 0.494ns 0.00392 0 0 280 B
#6165 ObjectExtractorSimpleBody netcoreapp3.1 204ns 0.667ns 2.58ns 0.00369 0 0 272 B
#6165 ObjectExtractorSimpleBody net472 167ns 0.228ns 0.79ns 0.0446 0 0 281 B
#6165 ObjectExtractorMoreComplexBody net6.0 2.99μs 1.64ns 6.14ns 0.0527 0 0 3.78 KB
#6165 ObjectExtractorMoreComplexBody netcoreapp3.1 3.92μs 2.33ns 8.72ns 0.0513 0 0 3.69 KB
#6165 ObjectExtractorMoreComplexBody net472 3.78μs 2.06ns 7.69ns 0.602 0.00762 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37.6μs 24.5ns 91.7ns 0.449 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 55.1μs 36.9ns 143ns 0.439 0 0 32.4 KB
master EncodeArgs net472 69μs 80.1ns 310ns 5.14 0.0667 0 32.5 KB
master EncodeLegacyArgs net6.0 77.6μs 48.8ns 183ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 106μs 462ns 1.79μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 154μs 112ns 433ns 0.306 0 0 2.15 KB
#6165 EncodeArgs net6.0 37.6μs 21.5ns 80.4ns 0.449 0 0 32.4 KB
#6165 EncodeArgs netcoreapp3.1 55.1μs 17.9ns 69.2ns 0.439 0 0 32.4 KB
#6165 EncodeArgs net472 66.9μs 57.3ns 222ns 5.14 0.0672 0 32.5 KB
#6165 EncodeLegacyArgs net6.0 76.5μs 412ns 2.33μs 0 0 0 2.14 KB
#6165 EncodeLegacyArgs netcoreapp3.1 108μs 412ns 1.6μs 0 0 0 2.14 KB
#6165 EncodeLegacyArgs net472 155μs 95.4ns 369ns 0.308 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 188μs 342ns 1.33μs 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 197μs 146ns 566ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 211μs 189ns 732ns 0.314 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 126μs 75.8ns 293ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 212ns 822ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 142μs 155ns 600ns 0.209 0 0 1.49 KB
#6165 RunWafRealisticBenchmark net6.0 185μs 123ns 476ns 0 0 0 2.44 KB
#6165 RunWafRealisticBenchmark netcoreapp3.1 197μs 97.5ns 352ns 0 0 0 2.39 KB
#6165 RunWafRealisticBenchmark net472 212μs 164ns 634ns 0.317 0 0 2.46 KB
#6165 RunWafRealisticBenchmarkWithAttack net6.0 124μs 165ns 641ns 0 0 0 1.47 KB
#6165 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 94.5ns 353ns 0 0 0 1.46 KB
#6165 RunWafRealisticBenchmarkWithAttack net472 141μs 69.7ns 270ns 0.212 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6165

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 58.41 KB 60.41 KB 2 KB 3.42%

Fewer allocations 🎉 in #6165

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 254.48 KB 251.89 KB -2.59 KB -1.02%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 265.39 KB 253.65 KB -11.74 KB -4.43%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 63.1μs 1.48μs 14.4μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 61.7μs 742ns 7.42μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.5μs 179ns 669ns 0 0 0 58.41 KB
master StringConcatAspectBenchmark net6.0 328μs 1.78μs 10.4μs 0 0 0 265.39 KB
master StringConcatAspectBenchmark netcoreapp3.1 355μs 1.94μs 12.7μs 0 0 0 254.48 KB
master StringConcatAspectBenchmark net472 291μs 6.53μs 63.4μs 0 0 0 278.53 KB
#6165 StringConcatBenchmark net6.0 61.9μs 748ns 7.33μs 0 0 0 43.44 KB
#6165 StringConcatBenchmark netcoreapp3.1 62.2μs 986ns 9.61μs 0 0 0 42.64 KB
#6165 StringConcatBenchmark net472 37.4μs 104ns 390ns 0 0 0 60.41 KB
#6165 StringConcatAspectBenchmark net6.0 300μs 1.66μs 9.66μs 0 0 0 253.65 KB
#6165 StringConcatAspectBenchmark netcoreapp3.1 333μs 1.7μs 10.7μs 0 0 0 251.89 KB
#6165 StringConcatAspectBenchmark net472 275μs 4.46μs 43.4μs 0 0 0 278.53 KB

@andrewlock

andrewlock commented Oct 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6165) (11.042M)   : 0, 11042014
    master (11.141M)   : 0, 11140719
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6165) (7.187M)   : 0, 7186588
    master (7.280M)   : 0, 7279870
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.669M)   : 0, 7668885

    section Manual
    master (11.075M)   : 0, 11074558

    section Manual + Automatic
    This PR (6165) (6.767M)   : 0, 6767370
    master (6.727M)   : 0, 6727438

    section DD_TRACE_ENABLED=0
    master (10.143M)   : 0, 10143410
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6165) (9.410M)   : 0, 9410018
    master (9.575M)   : 0, 9575114
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6165) (6.457M)   : 0, 6456763
    master (6.573M)   : 0, 6573227

    section Trace stats
    master (6.889M)   : 0, 6888898

    section Manual
    master (9.554M)   : 0, 9554430

    section Manual + Automatic
    This PR (6165) (6.076M)   : 0, 6075820
    master (6.223M)   : 0, 6222792

    section DD_TRACE_ENABLED=0
    master (8.834M)   : 0, 8833554
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6165) (9.836M)   : 0, 9836001
    master (10.041M)   : 0, 10040592
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6165) (6.500M)   : 0, 6499784
    master (6.448M)   : 0, 6447976
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.067M)   : 0, 7067450

    section Manual
    master (9.677M)   : 0, 9676828

    section Manual + Automatic
    This PR (6165) (6.072M)   : 0, 6071813
    master (6.140M)   : 0, 6140399

    section DD_TRACE_ENABLED=0
    master (9.137M)   : 0, 9137058
Loading

@andrewlock

andrewlock commented Oct 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6165 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.146
  • 1 benchmarks are slower, with geometric mean 1.142
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.73μs 43.6ns 296ns 0.016 0.00799 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.86μs 48.1ns 204ns 0.0192 0.00959 0 5.62 KB
master StartStopWithChild net472 16.2μs 74.6ns 299ns 1.02 0.309 0.0975 6.06 KB
#6165 StartStopWithChild net6.0 7.88μs 44ns 285ns 0.0194 0.00777 0 5.42 KB
#6165 StartStopWithChild netcoreapp3.1 10.1μs 56.4ns 348ns 0.0191 0.00954 0 5.62 KB
#6165 StartStopWithChild net472 16.1μs 44.4ns 166ns 1.01 0.295 0.0983 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 517μs 218ns 817ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 343ns 1.33μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 840μs 533ns 2.06μs 0.419 0 0 3.3 KB
#6165 WriteAndFlushEnrichedTraces net6.0 479μs 214ns 800ns 0 0 0 2.7 KB
#6165 WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 204ns 791ns 0 0 0 2.7 KB
#6165 WriteAndFlushEnrichedTraces net472 845μs 702ns 2.72μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 201μs 1.14μs 9.58μs 0.231 0 0 18.45 KB
master SendRequest netcoreapp3.1 223μs 1.3μs 11.7μs 0.216 0 0 20.61 KB
master SendRequest net472 0.000962ns 0.000263ns 0.00095ns 0 0 0 0 b
#6165 SendRequest net6.0 200μs 1.16μs 10.5μs 0.197 0 0 18.45 KB
#6165 SendRequest netcoreapp3.1 221μs 1.1μs 5.14μs 0.211 0 0 20.61 KB
#6165 SendRequest net472 0.000217ns 0.000217ns 0.000839ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 550μs 1.47μs 5.11μs 0.566 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 2.66μs 9.94μs 0.343 0 0 41.93 KB
master WriteAndFlushEnrichedTraces net472 862μs 3.49μs 13.5μs 8.45 2.53 0.422 53.31 KB
#6165 WriteAndFlushEnrichedTraces net6.0 569μs 3.04μs 16.9μs 0.558 0 0 41.78 KB
#6165 WriteAndFlushEnrichedTraces netcoreapp3.1 679μs 3.14μs 12.6μs 0.347 0 0 41.76 KB
#6165 WriteAndFlushEnrichedTraces net472 874μs 3.97μs 15.4μs 8.81 2.52 0.419 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.38μs 1.32ns 5.11ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.74μs 0.944ns 3.66ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.1μs 2.18ns 8.42ns 0.157 0 0 987 B
#6165 ExecuteNonQuery net6.0 1.29μs 0.891ns 3.33ns 0.0142 0 0 1.02 KB
#6165 ExecuteNonQuery netcoreapp3.1 1.78μs 1.11ns 4.16ns 0.0135 0 0 1.02 KB
#6165 ExecuteNonQuery net472 2.16μs 2.82ns 10.9ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.16μs 0.43ns 1.61ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.53μs 0.598ns 2.07ns 0.0137 0 0 976 B
master CallElasticsearch net472 2.56μs 2.04ns 7.89ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.45μs 0.481ns 1.8ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.783ns 2.93ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 0.885ns 3.31ns 0.166 0 0 1.05 KB
#6165 CallElasticsearch net6.0 1.08μs 3.11ns 12ns 0.0135 0 0 976 B
#6165 CallElasticsearch netcoreapp3.1 1.51μs 0.868ns 3.36ns 0.0129 0 0 976 B
#6165 CallElasticsearch net472 2.52μs 2.86ns 11.1ns 0.157 0 0 995 B
#6165 CallElasticsearchAsync net6.0 1.34μs 0.563ns 2.03ns 0.0133 0 0 952 B
#6165 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.593ns 2.06ns 0.0133 0 0 1.02 KB
#6165 CallElasticsearchAsync net472 2.46μs 2.96ns 11.5ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.26μs 0.698ns 2.7ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.63μs 0.913ns 3.54ns 0.0123 0 0 952 B
master ExecuteAsync net472 1.78μs 0.679ns 2.63ns 0.145 0 0 915 B
#6165 ExecuteAsync net6.0 1.26μs 0.693ns 2.59ns 0.0131 0 0 952 B
#6165 ExecuteAsync netcoreapp3.1 1.61μs 0.529ns 1.91ns 0.0128 0 0 952 B
#6165 ExecuteAsync net472 1.8μs 1.15ns 4.29ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.25μs 1.25ns 4.83ns 0.0297 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.15μs 3.64ns 14.1ns 0.0361 0 0 2.76 KB
master SendAsync net472 7.82μs 1.25ns 4.68ns 0.497 0 0 3.15 KB
#6165 SendAsync net6.0 4.16μs 3.68ns 14.2ns 0.0313 0 0 2.22 KB
#6165 SendAsync netcoreapp3.1 5.15μs 1.34ns 4.85ns 0.0361 0 0 2.76 KB
#6165 SendAsync net472 7.84μs 1.25ns 4.68ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6165

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.146 1,645.10 1,435.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.65μs 1.65ns 6.4ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.11μs 0.716ns 2.68ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.68μs 1.33ns 5.17ns 0.249 0 0 1.57 KB
#6165 EnrichedLog net6.0 1.44μs 1.11ns 4.31ns 0.023 0 0 1.64 KB
#6165 EnrichedLog netcoreapp3.1 2.25μs 1.13ns 4.22ns 0.0225 0 0 1.64 KB
#6165 EnrichedLog net472 2.55μs 1.46ns 5.47ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 153ns 594ns 0.0579 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 191ns 741ns 0 0 0 4.28 KB
master EnrichedLog net472 149μs 120ns 466ns 0.674 0.225 0 4.46 KB
#6165 EnrichedLog net6.0 116μs 215ns 832ns 0.058 0 0 4.28 KB
#6165 EnrichedLog netcoreapp3.1 121μs 191ns 741ns 0 0 0 4.28 KB
#6165 EnrichedLog net472 151μs 116ns 449ns 0.679 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.08μs 0.781ns 3.03ns 0.031 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.16μs 1.1ns 4.25ns 0.0291 0 0 2.2 KB
master EnrichedLog net472 4.75μs 2.05ns 7.95ns 0.321 0 0 2.02 KB
#6165 EnrichedLog net6.0 3.03μs 1.89ns 7.33ns 0.0311 0 0 2.2 KB
#6165 EnrichedLog netcoreapp3.1 4.22μs 1.38ns 5.15ns 0.0295 0 0 2.2 KB
#6165 EnrichedLog net472 4.86μs 7.21ns 27.9ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 1.24ns 4.82ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.7μs 0.574ns 2.15ns 0.0146 0 0 1.14 KB
master SendReceive net472 2.29μs 0.971ns 3.63ns 0.183 0.00115 0 1.16 KB
#6165 SendReceive net6.0 1.3μs 0.78ns 3.02ns 0.0162 0 0 1.14 KB
#6165 SendReceive netcoreapp3.1 1.74μs 0.794ns 2.97ns 0.0157 0 0 1.14 KB
#6165 SendReceive net472 2.22μs 5.24ns 20.3ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 1ns 3.88ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.99μs 1.67ns 6.47ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.47μs 1.07ns 4.14ns 0.322 0 0 2.04 KB
#6165 EnrichedLog net6.0 2.84μs 1.1ns 4.26ns 0.0227 0 0 1.6 KB
#6165 EnrichedLog netcoreapp3.1 3.89μs 1.82ns 7.03ns 0.0213 0 0 1.65 KB
#6165 EnrichedLog net472 4.32μs 4.25ns 16.5ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6165

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.142 476.13 543.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 420ns 0.237ns 0.917ns 0.00806 0 0 576 B
master StartFinishSpan netcoreapp3.1 612ns 0.556ns 2.08ns 0.00786 0 0 576 B
master StartFinishSpan net472 706ns 0.537ns 2.08ns 0.0918 0 0 578 B
master StartFinishScope net6.0 476ns 0.391ns 1.52ns 0.00976 0 0 696 B
master StartFinishScope netcoreapp3.1 700ns 0.817ns 3.16ns 0.00963 0 0 696 B
master StartFinishScope net472 846ns 0.938ns 3.63ns 0.104 0 0 658 B
#6165 StartFinishSpan net6.0 399ns 0.16ns 0.62ns 0.00811 0 0 576 B
#6165 StartFinishSpan netcoreapp3.1 625ns 0.458ns 1.77ns 0.00752 0 0 576 B
#6165 StartFinishSpan net472 706ns 1.09ns 4.23ns 0.0918 0 0 578 B
#6165 StartFinishScope net6.0 544ns 0.289ns 1.12ns 0.00984 0 0 696 B
#6165 StartFinishScope netcoreapp3.1 725ns 0.385ns 1.44ns 0.00906 0 0 696 B
#6165 StartFinishScope net472 903ns 0.495ns 1.79ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 587ns 0.62ns 2.4ns 0.00967 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 880ns 0.765ns 2.86ns 0.0092 0 0 696 B
master RunOnMethodBegin net472 1.17μs 1.09ns 4.21ns 0.105 0 0 658 B
#6165 RunOnMethodBegin net6.0 582ns 0.259ns 0.933ns 0.00964 0 0 696 B
#6165 RunOnMethodBegin netcoreapp3.1 947ns 0.557ns 2.08ns 0.00949 0 0 696 B
#6165 RunOnMethodBegin net472 1.13μs 0.172ns 0.644ns 0.104 0 0 658 B

@andrewlock andrewlock mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonyredondo @andrewlock