Skip to content

Fix .sln project ordering#6156

Merged
andrewlock merged 1 commit into
masterfrom
steven/fix-sln
Oct 16, 2024
Merged

Fix .sln project ordering#6156
andrewlock merged 1 commit into
masterfrom
steven/fix-sln

Conversation

@bouwkast

@bouwkast bouwkast commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

Summary of changes

Visual Studio sln stuff main one is to get the Samples.AWS.EventBridge to show up correctly.

Reason for change

sln was messed up causing stuff to not show up where you'd expect

Implementation details

Drag drop and save

Test coverage

Other recent sample projects changes too in the sln but 🤷

Other details

@bouwkast
bouwkast requested a review from a team as a code owner October 15, 2024 19:33
@bouwkast bouwkast changed the title Fixes the solution as projects were mis-ordered Fix .sln project ordering Oct 15, 2024
@datadog-ddstaging

datadog-ddstaging Bot commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: steven/fix-sln
Commit report: b9f3652
Test service: dd-trace-dotnet

✅ 0 Failed, 368179 Passed, 2099 Skipped, 15h 8m 23.39s Total Time

@andrewlock

andrewlock commented Oct 15, 2024

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6156) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (71ms)  : 68, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6156) - mean (1,114ms)  : 1093, 1136
     .   : milestone, 1114,
    master - mean (1,129ms)  : 1105, 1153
     .   : milestone, 1129,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6156) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (112ms)  : 108, 116
     .   : milestone, 112,

    section CallTarget+Inlining+NGEN
    This PR (6156) - mean (773ms)  : 757, 788
     .   : milestone, 773,
    master - mean (791ms)  : 767, 815
     .   : milestone, 791,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6156) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (95ms)  : 92, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (6156) - mean (730ms)  : 714, 745
     .   : milestone, 730,
    master - mean (749ms)  : 732, 765
     .   : milestone, 749,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6156) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6156) - mean (1,201ms)  : 1177, 1225
     .   : milestone, 1201,
    master - mean (1,205ms)  : 1156, 1255
     .   : milestone, 1205,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6156) - mean (278ms)  : 272, 283
     .   : milestone, 278,
    master - mean (277ms)  : 271, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6156) - mean (942ms)  : 923, 961
     .   : milestone, 942,
    master - mean (947ms)  : 930, 964
     .   : milestone, 947,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6156) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (266ms)  : 260, 272
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6156) - mean (932ms)  : 910, 954
     .   : milestone, 932,
    master - mean (929ms)  : 907, 950
     .   : milestone, 929,
Loading

@andrewlock

andrewlock commented Oct 15, 2024

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6156) (11.077M)   : 0, 11077481
    master (10.879M)   : 0, 10878586
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6156) (7.248M)   : 0, 7248008
    master (7.360M)   : 0, 7359645
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.759M)   : 0, 7758687

    section Manual
    master (11.183M)   : 0, 11183363

    section Manual + Automatic
    This PR (6156) (6.682M)   : 0, 6682073
    master (6.756M)   : 0, 6755648

    section DD_TRACE_ENABLED=0
    master (10.216M)   : 0, 10216257
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6156) (9.732M)   : 0, 9731768
    master (9.604M)   : 0, 9604295
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6156) (6.574M)   : 0, 6573938
    master (6.653M)   : 0, 6652975

    section Trace stats
    master (6.966M)   : 0, 6966327

    section Manual
    master (9.484M)   : 0, 9484205

    section Manual + Automatic
    This PR (6156) (6.007M)   : 0, 6006988
    master (5.968M)   : 0, 5968075

    section DD_TRACE_ENABLED=0
    master (8.908M)   : 0, 8907937
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6156) (9.971M)   : 0, 9970967
    master (10.287M)   : 0, 10286765
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6156) (6.612M)   : 0, 6611565
    master (6.541M)   : 0, 6541131
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.268M)   : 0, 7268357

    section Manual
    master (10.078M)   : 0, 10077965

    section Manual + Automatic
    This PR (6156) (5.879M)   : crit ,0, 5879220
    master (6.224M)   : 0, 6223558

    section DD_TRACE_ENABLED=0
    master (9.403M)   : 0, 9402673
Loading

@andrewlock

andrewlock commented Oct 15, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6156 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.158
  • 2 benchmarks are slower, with geometric mean 1.133
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.82μs 44ns 299ns 0.012 0.004 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10.3μs 53.4ns 262ns 0.0204 0.0102 0 5.62 KB
master StartStopWithChild net472 16.8μs 78.5ns 294ns 1.02 0.314 0.0992 6.05 KB
#6156 StartStopWithChild net6.0 7.76μs 44.2ns 312ns 0.0147 0.00735 0 5.43 KB
#6156 StartStopWithChild netcoreapp3.1 10.1μs 33.4ns 116ns 0.0198 0.00991 0 5.62 KB
#6156 StartStopWithChild net472 16.6μs 66.7ns 258ns 1.02 0.312 0.0928 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 478μs 370ns 1.43μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 632μs 247ns 958ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 837μs 465ns 1.74μs 0.414 0 0 3.3 KB
#6156 WriteAndFlushEnrichedTraces net6.0 494μs 721ns 2.79μs 0 0 0 2.7 KB
#6156 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 422ns 1.63μs 0 0 0 2.7 KB
#6156 WriteAndFlushEnrichedTraces net472 841μs 420ns 1.57μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 198μs 1.13μs 8.05μs 0.201 0 0 18.45 KB
master SendRequest netcoreapp3.1 221μs 1.27μs 10.4μs 0.226 0 0 20.61 KB
master SendRequest net472 0.00118ns 0.000357ns 0.00138ns 0 0 0 0 b
#6156 SendRequest net6.0 203μs 1.18μs 11μs 0.203 0 0 18.45 KB
#6156 SendRequest netcoreapp3.1 226μs 1.31μs 11.5μs 0.225 0 0 20.61 KB
#6156 SendRequest net472 0.00121ns 0.000624ns 0.00233ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 556μs 1.96μs 7.06μs 0.563 0 0 41.58 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 691μs 3.73μs 21.7μs 0.338 0 0 41.84 KB
master WriteAndFlushEnrichedTraces net472 875μs 4.42μs 21.2μs 8.25 2.6 0.434 53.26 KB
#6156 WriteAndFlushEnrichedTraces net6.0 581μs 3.07μs 15μs 0.59 0 0 41.59 KB
#6156 WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 3.68μs 18.4μs 0.331 0 0 41.88 KB
#6156 WriteAndFlushEnrichedTraces net472 894μs 4.47μs 21μs 8.42 2.66 0.443 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.25μs 1.12ns 4.33ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 5.22ns 20.2ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 2.26ns 8.75ns 0.156 0 0 987 B
#6156 ExecuteNonQuery net6.0 1.25μs 0.751ns 2.91ns 0.0144 0 0 1.02 KB
#6156 ExecuteNonQuery netcoreapp3.1 1.76μs 1.53ns 5.94ns 0.0133 0 0 1.02 KB
#6156 ExecuteNonQuery net472 2.15μs 1.79ns 6.95ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.775ns 3ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.59μs 0.987ns 3.69ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.61μs 2.97ns 11.5ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 1.07ns 4ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 2.06ns 7.71ns 0.0134 0 0 1.02 KB
master CallElasticsearchAsync net472 2.7μs 2.24ns 8.67ns 0.167 0 0 1.05 KB
#6156 CallElasticsearch net6.0 1.32μs 0.619ns 2.23ns 0.0138 0 0 976 B
#6156 CallElasticsearch netcoreapp3.1 1.54μs 1.46ns 5.66ns 0.0131 0 0 976 B
#6156 CallElasticsearch net472 2.71μs 2.23ns 8.35ns 0.158 0 0 995 B
#6156 CallElasticsearchAsync net6.0 1.32μs 1.25ns 4.86ns 0.0132 0 0 952 B
#6156 CallElasticsearchAsync netcoreapp3.1 1.63μs 2.26ns 8.76ns 0.0139 0 0 1.02 KB
#6156 CallElasticsearchAsync net472 2.7μs 2.76ns 10.3ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.16μs 1.13ns 4.23ns 0.0129 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.54μs 1.27ns 4.92ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.75μs 1.04ns 4.03ns 0.145 0 0 915 B
#6156 ExecuteAsync net6.0 1.26μs 1.22ns 4.74ns 0.0134 0 0 952 B
#6156 ExecuteAsync netcoreapp3.1 1.68μs 1.62ns 6.27ns 0.0126 0 0 952 B
#6156 ExecuteAsync net472 1.75μs 1.13ns 4.36ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.23μs 7.28ns 28.2ns 0.0296 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.05μs 2.33ns 9.04ns 0.0353 0 0 2.76 KB
master SendAsync net472 7.83μs 4.58ns 16.5ns 0.497 0 0 3.15 KB
#6156 SendAsync net6.0 4.18μs 4.12ns 15.4ns 0.0294 0 0 2.22 KB
#6156 SendAsync netcoreapp3.1 5.14μs 4.93ns 19.1ns 0.0364 0 0 2.76 KB
#6156 SendAsync net472 7.71μs 6.17ns 23.9ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.55μs 0.729ns 2.73ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.23μs 1.16ns 4.32ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.62μs 1.12ns 4.18ns 0.249 0 0 1.57 KB
#6156 EnrichedLog net6.0 1.47μs 0.432ns 1.56ns 0.023 0 0 1.64 KB
#6156 EnrichedLog netcoreapp3.1 2.12μs 2.06ns 7.72ns 0.0223 0 0 1.64 KB
#6156 EnrichedLog net472 2.57μs 1.7ns 6.59ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 173ns 670ns 0.0596 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 181ns 654ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 251ns 971ns 0.696 0.232 0 4.46 KB
#6156 EnrichedLog net6.0 117μs 174ns 673ns 0 0 0 4.28 KB
#6156 EnrichedLog netcoreapp3.1 123μs 202ns 781ns 0 0 0 4.28 KB
#6156 EnrichedLog net472 154μs 124ns 480ns 0.689 0.23 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 1.88ns 7.27ns 0.0313 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.36μs 2.24ns 8.69ns 0.0284 0 0 2.2 KB
master EnrichedLog net472 4.9μs 1.77ns 6.87ns 0.32 0 0 2.02 KB
#6156 EnrichedLog net6.0 3.14μs 1.43ns 5.55ns 0.031 0 0 2.2 KB
#6156 EnrichedLog netcoreapp3.1 4.27μs 1.82ns 7.05ns 0.0299 0 0 2.2 KB
#6156 EnrichedLog net472 5.08μs 2.51ns 9.72ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 1.09ns 4.22ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.82μs 0.785ns 3.04ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.18μs 1.15ns 4.46ns 0.183 0.00109 0 1.16 KB
#6156 SendReceive net6.0 1.34μs 0.691ns 2.68ns 0.016 0 0 1.14 KB
#6156 SendReceive netcoreapp3.1 1.77μs 1.09ns 4.23ns 0.015 0 0 1.14 KB
#6156 SendReceive net472 1.99μs 0.925ns 3.58ns 0.183 0.000989 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.69μs 2.07ns 8ns 0.0228 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 2.79ns 10.8ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.58μs 3.92ns 15.2ns 0.322 0 0 2.04 KB
#6156 EnrichedLog net6.0 2.67μs 1.57ns 6.07ns 0.0214 0 0 1.6 KB
#6156 EnrichedLog netcoreapp3.1 3.97μs 2.31ns 8.94ns 0.0218 0 0 1.65 KB
#6156 EnrichedLog net472 4.54μs 1.94ns 7.25ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6156

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.142 492.96 562.82
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.124 553.48 621.93

Faster 🎉 in #6156

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.158 472.34 407.86

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 472ns 0.174ns 0.627ns 0.00806 0 0 576 B
master StartFinishSpan netcoreapp3.1 564ns 3.08ns 17.4ns 0.00801 0 0 576 B
master StartFinishSpan net472 669ns 0.432ns 1.62ns 0.0917 0 0 578 B
master StartFinishScope net6.0 493ns 0.295ns 1.14ns 0.00979 0 0 696 B
master StartFinishScope netcoreapp3.1 761ns 0.506ns 1.89ns 0.00927 0 0 696 B
master StartFinishScope net472 846ns 0.634ns 2.37ns 0.104 0 0 658 B
#6156 StartFinishSpan net6.0 408ns 0.377ns 1.46ns 0.0082 0 0 576 B
#6156 StartFinishSpan netcoreapp3.1 622ns 0.332ns 1.24ns 0.00768 0 0 576 B
#6156 StartFinishSpan net472 670ns 0.477ns 1.72ns 0.0918 0 0 578 B
#6156 StartFinishScope net6.0 563ns 0.156ns 0.563ns 0.00974 0 0 696 B
#6156 StartFinishScope netcoreapp3.1 686ns 1.36ns 5.28ns 0.00939 0 0 696 B
#6156 StartFinishScope net472 935ns 0.887ns 3.2ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 593ns 0.179ns 0.669ns 0.00985 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 928ns 0.44ns 1.65ns 0.00933 0 0 696 B
master RunOnMethodBegin net472 1.18μs 1.69ns 6.55ns 0.105 0 0 658 B
#6156 RunOnMethodBegin net6.0 649ns 0.268ns 1ns 0.00987 0 0 696 B
#6156 RunOnMethodBegin netcoreapp3.1 949ns 0.962ns 3.72ns 0.00909 0 0 696 B
#6156 RunOnMethodBegin net472 1.12μs 0.966ns 3.61ns 0.104 0 0 658 B

@andrewlock

andrewlock commented Oct 16, 2024

Copy link
Copy Markdown
Member

Merging before you get conflicts 😅

@andrewlock
andrewlock merged commit aca7810 into master Oct 16, 2024
@andrewlock
andrewlock deleted the steven/fix-sln branch October 16, 2024 08:32
@github-actions github-actions Bot added this to the vNext-v3 milestone Oct 16, 2024
@bouwkast

bouwkast commented Oct 16, 2024

Copy link
Copy Markdown
Collaborator Author

Merging before you get conflicts 😅

Thanks! The build wasn't finished by the time I had to go

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@link04 link04 link04 approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bouwkast @andrewlock @lucaspimentel @link04