[CI Visibility] Add extra tags to GitHub Action pull_requests runs#6141
Merged
Conversation
anmarchenko
approved these changes
Oct 10, 2024
juan-fernandez
approved these changes
Oct 10, 2024
Member
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6141) - mean (70ms) : 67, 72
. : milestone, 70,
master - mean (70ms) : 68, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6141) - mean (1,108ms) : 1086, 1129
. : milestone, 1108,
master - mean (1,107ms) : 1085, 1130
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6141) - mean (109ms) : 106, 112
. : milestone, 109,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6141) - mean (764ms) : 748, 780
. : milestone, 764,
master - mean (776ms) : 760, 793
. : milestone, 776,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6141) - mean (92ms) : 89, 94
. : milestone, 92,
master - mean (92ms) : 89, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6141) - mean (720ms) : 706, 735
. : milestone, 720,
master - mean (725ms) : 704, 746
. : milestone, 725,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6141) - mean (189ms) : 186, 192
. : milestone, 189,
master - mean (190ms) : 186, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6141) - mean (1,195ms) : 1171, 1220
. : milestone, 1195,
master - mean (1,197ms) : 1178, 1216
. : milestone, 1197,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6141) - mean (274ms) : 270, 278
. : milestone, 274,
master - mean (275ms) : 269, 280
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6141) - mean (937ms) : 919, 954
. : milestone, 937,
master - mean (944ms) : 929, 960
. : milestone, 944,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6141) - mean (263ms) : 259, 267
. : milestone, 263,
master - mean (263ms) : 259, 267
. : milestone, 263,
section CallTarget+Inlining+NGEN
This PR (6141) - mean (919ms) : 903, 935
. : milestone, 919,
master - mean (924ms) : 903, 945
. : milestone, 924,
|
Member
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6141) (11.051M) : 0, 11051052
master (11.054M) : 0, 11053601
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6141) (7.304M) : 0, 7303853
master (7.274M) : 0, 7273547
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.691M) : 0, 7690810
section Manual
master (11.191M) : 0, 11190813
section Manual + Automatic
This PR (6141) (6.811M) : 0, 6811104
master (6.756M) : 0, 6756165
section DD_TRACE_ENABLED=0
master (10.360M) : 0, 10359548
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6141) (9.559M) : 0, 9558578
master (9.692M) : 0, 9691658
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6141) (6.492M) : 0, 6491694
master (6.618M) : 0, 6618117
section Trace stats
master (6.859M) : 0, 6858865
section Manual
master (9.606M) : 0, 9605568
section Manual + Automatic
This PR (6141) (6.168M) : 0, 6167607
master (6.060M) : 0, 6060279
section DD_TRACE_ENABLED=0
master (8.844M) : 0, 8844116
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6141) (10.047M) : 0, 10047475
master (10.072M) : 0, 10072153
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6141) (6.614M) : 0, 6614432
master (6.626M) : 0, 6625828
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.349M) : 0, 7349157
section Manual
master (9.952M) : 0, 9952004
section Manual + Automatic
This PR (6141) (5.989M) : 0, 5988671
master (6.100M) : 0, 6100436
section DD_TRACE_ENABLED=0
master (9.337M) : 0, 9337357
|
Member
Benchmarks Report for tracer 🐌Benchmarks for #6141 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.155 | 641.88 | 741.11 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 642ns | 0.474ns | 1.83ns | 0.00966 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 902ns | 2.87ns | 11.1ns | 0.00945 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.15μs | 1.34ns | 5.18ns | 0.104 | 0 | 0 | 658 B |
| #6141 | RunOnMethodBegin |
net6.0 | 741ns | 0.394ns | 1.53ns | 0.00968 | 0 | 0 | 696 B |
| #6141 | RunOnMethodBegin |
netcoreapp3.1 | 976ns | 1.01ns | 3.79ns | 0.0093 | 0 | 0 | 696 B |
| #6141 | RunOnMethodBegin |
net472 | 1.21μs | 0.884ns | 3.43ns | 0.104 | 0 | 0 | 658 B |
andrewlock
approved these changes
Oct 10, 2024
| [CIEnvironmentValues.Constants.GitHubEventPath] = jsonFile, | ||
| })); | ||
|
|
||
| reloadEnvironmentData?.Invoke(githubEnvVars, null); |
Member
There was a problem hiding this comment.
tiny nit: probably better to use ! instead of ? here as reloadEnvironmentData should never be null unless the test is broken, right?
Member
Author
There was a problem hiding this comment.
in both cases the test will fail :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds a couple of CI extra tags when running in GitHub Actions following the ticket: https://datadoghq.atlassian.net/browse/SDTEST-524
Reason for change
Test visibility .NET implementation is missing these extra tags.
Implementation details
GITHUB_BASE_REFenvironment variable.Test coverage
Other details