Fix crashes on .NET Core 2.1 CI#6139
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 376237 Passed, 2144 Skipped, 25h 18m 35.38s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6139) - mean (70ms) : 67, 72
. : milestone, 70,
master - mean (71ms) : 68, 73
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6139) - mean (1,107ms) : 1089, 1125
. : milestone, 1107,
master - mean (1,122ms) : 1101, 1143
. : milestone, 1122,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6139) - mean (109ms) : 106, 111
. : milestone, 109,
master - mean (110ms) : 107, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6139) - mean (769ms) : 752, 785
. : milestone, 769,
master - mean (780ms) : 765, 794
. : milestone, 780,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6139) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (93ms) : 90, 95
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6139) - mean (721ms) : 704, 739
. : milestone, 721,
master - mean (734ms) : 711, 757
. : milestone, 734,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6139) - mean (194ms) : 188, 199
. : milestone, 194,
master - mean (192ms) : 187, 196
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6139) - mean (1,222ms) : 1191, 1252
. : milestone, 1222,
master - mean (1,211ms) : 1180, 1241
. : milestone, 1211,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6139) - mean (277ms) : 272, 281
. : milestone, 277,
master - mean (282ms) : 275, 288
. : milestone, 282,
section CallTarget+Inlining+NGEN
This PR (6139) - mean (949ms) : 932, 967
. : milestone, 949,
master - mean (959ms) : 931, 986
. : milestone, 959,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6139) - mean (266ms) : 262, 271
. : milestone, 266,
master - mean (268ms) : 262, 274
. : milestone, 268,
section CallTarget+Inlining+NGEN
This PR (6139) - mean (940ms) : 917, 964
. : milestone, 940,
master - mean (938ms) : 913, 963
. : milestone, 938,
|
Benchmarks Report for tracer 🐌Benchmarks for #6139 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.212 | 567.74 | 688.04 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.140 | 450.31 | 395.05 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 450ns | 0.229ns | 0.888ns | 0.00813 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 600ns | 0.559ns | 2.17ns | 0.00776 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 569ns | 0.614ns | 2.3ns | 0.0918 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 548ns | 0.14ns | 0.524ns | 0.00967 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 713ns | 0.631ns | 2.44ns | 0.0096 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 851ns | 0.274ns | 0.987ns | 0.104 | 0 | 0 | 658 B |
| #6139 | StartFinishSpan |
net6.0 | 395ns | 0.14ns | 0.543ns | 0.00817 | 0 | 0 | 576 B |
| #6139 | StartFinishSpan |
netcoreapp3.1 | 598ns | 0.655ns | 2.54ns | 0.00811 | 0 | 0 | 576 B |
| #6139 | StartFinishSpan |
net472 | 688ns | 0.183ns | 0.659ns | 0.0916 | 0 | 0 | 578 B |
| #6139 | StartFinishScope |
net6.0 | 503ns | 0.161ns | 0.624ns | 0.00986 | 0 | 0 | 696 B |
| #6139 | StartFinishScope |
netcoreapp3.1 | 750ns | 0.407ns | 1.47ns | 0.00945 | 0 | 0 | 696 B |
| #6139 | StartFinishScope |
net472 | 845ns | 0.533ns | 2.06ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 701ns | 0.286ns | 1.11ns | 0.00981 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 921ns | 0.593ns | 2.14ns | 0.00925 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.14μs | 0.715ns | 2.48ns | 0.104 | 0 | 0 | 658 B |
| #6139 | RunOnMethodBegin |
net6.0 | 661ns | 0.478ns | 1.79ns | 0.00963 | 0 | 0 | 696 B |
| #6139 | RunOnMethodBegin |
netcoreapp3.1 | 964ns | 0.546ns | 2.12ns | 0.00944 | 0 | 0 | 696 B |
| #6139 | RunOnMethodBegin |
net472 | 1.12μs | 0.362ns | 1.35ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6139) (11.095M) : 0, 11095404
master (11.344M) : 0, 11344379
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6139) (7.257M) : 0, 7257043
master (7.340M) : 0, 7340365
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.618M) : 0, 7618179
section Manual
master (11.039M) : 0, 11038685
section Manual + Automatic
This PR (6139) (6.709M) : 0, 6709413
master (6.819M) : 0, 6819224
section DD_TRACE_ENABLED=0
master (10.251M) : 0, 10251329
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6139) (9.537M) : 0, 9537436
master (9.660M) : 0, 9660433
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6139) (6.557M) : 0, 6556881
master (6.381M) : 0, 6381024
section Trace stats
master (6.831M) : 0, 6831310
section Manual
master (9.445M) : 0, 9445116
section Manual + Automatic
This PR (6139) (6.032M) : 0, 6031657
master (6.057M) : 0, 6057131
section DD_TRACE_ENABLED=0
master (8.749M) : 0, 8749042
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6139) (10.385M) : 0, 10385310
master (10.049M) : 0, 10048596
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6139) (6.874M) : 0, 6874412
master (6.564M) : 0, 6564217
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.367M) : 0, 7366652
section Manual
master (9.968M) : 0, 9967634
section Manual + Automatic
This PR (6139) (6.360M) : 0, 6360183
master (6.038M) : 0, 6038370
section DD_TRACE_ENABLED=0
master (9.434M) : 0, 9434242
|
Summary of changes
Fix failing .NET Core 2.1 Windows integration tests
Reason for change
The .NET Core 2.1 Windows Integration tests are failing
Implementation details
After merging #6117 (to fix a weird issue in the .NET 6 windows integration tests related to procdump), we started getting failures in .NET Core 2.1. This is almost certainly a bug in the runtime, and as it's a CI-only issue, trivially fixing by not setting the variable
Test coverage
Ran a full test here and all ok