Skip to content

Build against macos-13 as macos-12 is going to be deprecated#6138

Merged
andrewlock merged 1 commit into
masterfrom
andrew/ci/build-against-macos-13
Oct 21, 2024
Merged

Build against macos-13 as macos-12 is going to be deprecated#6138
andrewlock merged 1 commit into
masterfrom
andrew/ci/build-against-macos-13

Conversation

@andrewlock

@andrewlock andrewlock commented Oct 9, 2024

Copy link
Copy Markdown
Member

Summary of changes

Changes CI to build using macos-13 instead of macos-12

Reason for change

Azure Devops are removing macos-12 images and will start running brownouts from November, so we have to update.

Implementation details

macos-12 -> macos-13

Test coverage

This is the test - I will also do a full installer tests run

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 9, 2024
@andrewlock
andrewlock requested review from a team as code owners October 9, 2024 18:44
@andrewlock
andrewlock force-pushed the andrew/ci/build-against-macos-13 branch from 07025e1 to 8ff0c25 Compare October 9, 2024 18:44
@datadog-ddstaging

datadog-ddstaging Bot commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/build-against-macos-13
Commit report: 11a8c53
Test service: dd-trace-dotnet

✅ 0 Failed, 366895 Passed, 2070 Skipped, 15h 3m 28.98s Total Time

@andrewlock

andrewlock commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6138) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6138) - mean (1,113ms)  : 1087, 1139
     .   : milestone, 1113,
    master - mean (1,115ms)  : 1086, 1144
     .   : milestone, 1115,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6138) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (110ms)  : 105, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6138) - mean (775ms)  : 764, 787
     .   : milestone, 775,
    master - mean (771ms)  : 753, 789
     .   : milestone, 771,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6138) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6138) - mean (737ms)  : 715, 758
     .   : milestone, 737,
    master - mean (727ms)  : 712, 742
     .   : milestone, 727,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6138) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (189ms)  : 185, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6138) - mean (1,195ms)  : 1164, 1226
     .   : milestone, 1195,
    master - mean (1,201ms)  : 1172, 1230
     .   : milestone, 1201,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6138) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (274ms)  : 269, 278
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (6138) - mean (940ms)  : 922, 958
     .   : milestone, 940,
    master - mean (938ms)  : 918, 958
     .   : milestone, 938,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6138) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6138) - mean (929ms)  : 908, 951
     .   : milestone, 929,
    master - mean (923ms)  : 905, 940
     .   : milestone, 923,
Loading

@andrewlock

andrewlock commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6138) (10.970M)   : 0, 10969762
    master (11.080M)   : 0, 11079748
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6138) (7.243M)   : 0, 7242599
    master (7.315M)   : 0, 7315317
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.620M)   : 0, 7620483

    section Manual
    master (10.953M)   : 0, 10953313

    section Manual + Automatic
    This PR (6138) (6.835M)   : 0, 6835112
    master (6.849M)   : 0, 6848847

    section DD_TRACE_ENABLED=0
    master (10.227M)   : 0, 10226857
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6138) (9.441M)   : 0, 9440797
    master (9.517M)   : 0, 9516897
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6138) (6.636M)   : 0, 6635884
    master (6.590M)   : 0, 6589925

    section Trace stats
    master (6.791M)   : 0, 6791127

    section Manual
    master (9.449M)   : 0, 9448954

    section Manual + Automatic
    This PR (6138) (6.166M)   : 0, 6165576
    master (6.064M)   : 0, 6064287

    section DD_TRACE_ENABLED=0
    master (8.906M)   : 0, 8906146
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6138) (10.021M)   : 0, 10021327
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6138) (6.527M)   : 0, 6526845
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Manual + Automatic
    This PR (6138) (5.967M)   : 0, 5967488
Loading

@andrewlock

andrewlock commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6138 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.148
  • 1 benchmarks are slower, with geometric mean 1.116
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.91μs 42.9ns 235ns 0.0114 0.00379 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.92μs 48.3ns 241ns 0.0151 0.00504 0 5.62 KB
master StartStopWithChild net472 16.6μs 57.2ns 221ns 1.03 0.32 0.0984 6.07 KB
#6138 StartStopWithChild net6.0 7.81μs 43.4ns 271ns 0.0194 0.00778 0 5.42 KB
#6138 StartStopWithChild netcoreapp3.1 10.1μs 55.3ns 323ns 0.0189 0.00946 0 5.62 KB
#6138 StartStopWithChild net472 16.9μs 80.9ns 313ns 1 0.291 0.0913 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 470μs 141ns 527ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 460ns 1.78μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 841μs 474ns 1.84μs 0.417 0 0 3.3 KB
#6138 WriteAndFlushEnrichedTraces net6.0 478μs 293ns 1.14μs 0 0 0 2.7 KB
#6138 WriteAndFlushEnrichedTraces netcoreapp3.1 635μs 210ns 787ns 0 0 0 2.7 KB
#6138 WriteAndFlushEnrichedTraces net472 845μs 2.29μs 8.87μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 195μs 1.13μs 9.01μs 0.152 0 0 18.45 KB
master SendRequest netcoreapp3.1 221μs 1.12μs 7.26μs 0.215 0 0 20.61 KB
master SendRequest net472 0.0003ns 0.0003ns 0.00108ns 0 0 0 0 b
#6138 SendRequest net6.0 201μs 1.13μs 7.83μs 0.196 0 0 18.45 KB
#6138 SendRequest netcoreapp3.1 218μs 1.13μs 7.97μs 0.206 0 0 20.61 KB
#6138 SendRequest net472 0.000939ns 0.000395ns 0.00148ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 570μs 2.48μs 9.26μs 0.566 0 0 41.82 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 1.97μs 7.11μs 0.331 0 0 41.8 KB
master WriteAndFlushEnrichedTraces net472 879μs 3.88μs 14.5μs 8.25 2.6 0.434 53.28 KB
#6138 WriteAndFlushEnrichedTraces net6.0 580μs 2.92μs 13.7μs 0.561 0 0 41.73 KB
#6138 WriteAndFlushEnrichedTraces netcoreapp3.1 679μs 3.29μs 16.8μs 0.338 0 0 41.84 KB
#6138 WriteAndFlushEnrichedTraces net472 885μs 3.5μs 13.5μs 8.25 2.6 0.434 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.26μs 0.68ns 2.54ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 0.85ns 3.29ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.14μs 1.57ns 5.87ns 0.156 0 0 987 B
#6138 ExecuteNonQuery net6.0 1.23μs 0.767ns 2.87ns 0.0142 0 0 1.02 KB
#6138 ExecuteNonQuery netcoreapp3.1 1.75μs 0.876ns 3.39ns 0.0131 0 0 1.02 KB
#6138 ExecuteNonQuery net472 2.16μs 1.19ns 4.44ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.795ns 2.97ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.52μs 0.371ns 1.44ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.46μs 2.4ns 9.29ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 1.05ns 3.92ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 0.434ns 1.62ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 1.77ns 6.63ns 0.166 0 0 1.05 KB
#6138 CallElasticsearch net6.0 1.17μs 0.625ns 2.34ns 0.0135 0 0 976 B
#6138 CallElasticsearch netcoreapp3.1 1.52μs 0.724ns 2.71ns 0.0128 0 0 976 B
#6138 CallElasticsearch net472 2.45μs 1.26ns 4.89ns 0.157 0 0 995 B
#6138 CallElasticsearchAsync net6.0 1.18μs 0.745ns 2.79ns 0.0135 0 0 952 B
#6138 CallElasticsearchAsync netcoreapp3.1 1.62μs 0.737ns 2.76ns 0.0138 0 0 1.02 KB
#6138 CallElasticsearchAsync net472 2.66μs 1.08ns 4.19ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.802ns 3ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 1.77ns 6.87ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.77μs 1.43ns 5.55ns 0.145 0 0 915 B
#6138 ExecuteAsync net6.0 1.26μs 0.403ns 1.51ns 0.0133 0 0 952 B
#6138 ExecuteAsync netcoreapp3.1 1.58μs 1.49ns 5.78ns 0.0127 0 0 952 B
#6138 ExecuteAsync net472 1.83μs 0.52ns 2.01ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.05μs 2.49ns 9.66ns 0.0305 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.02μs 7.35ns 28.5ns 0.0379 0 0 2.76 KB
master SendAsync net472 7.8μs 5.51ns 21.3ns 0.496 0 0 3.15 KB
#6138 SendAsync net6.0 4.23μs 2.44ns 9.47ns 0.0298 0 0 2.22 KB
#6138 SendAsync netcoreapp3.1 5.18μs 2.36ns 8.83ns 0.0364 0 0 2.76 KB
#6138 SendAsync net472 7.82μs 1.62ns 6.27ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6138

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.148 2,798.41 2,437.99

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.55μs 1.14ns 4.28ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.22μs 2.39ns 8.29ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.8μs 1.59ns 6.16ns 0.25 0 0 1.57 KB
#6138 EnrichedLog net6.0 1.57μs 0.566ns 2.12ns 0.0228 0 0 1.64 KB
#6138 EnrichedLog netcoreapp3.1 2.19μs 1.7ns 6.14ns 0.0221 0 0 1.64 KB
#6138 EnrichedLog net472 2.44μs 1.35ns 5.05ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 218ns 846ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 188ns 703ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 174ns 652ns 0.682 0.227 0 4.46 KB
#6138 EnrichedLog net6.0 117μs 111ns 431ns 0.0592 0 0 4.28 KB
#6138 EnrichedLog netcoreapp3.1 121μs 288ns 1.12μs 0 0 0 4.28 KB
#6138 EnrichedLog net472 152μs 160ns 621ns 0.684 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 1.03ns 3.97ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.12μs 1.81ns 6.51ns 0.0291 0 0 2.2 KB
master EnrichedLog net472 4.88μs 2.73ns 10.6ns 0.321 0 0 2.02 KB
#6138 EnrichedLog net6.0 3.11μs 0.864ns 3.35ns 0.0297 0 0 2.2 KB
#6138 EnrichedLog netcoreapp3.1 4.26μs 3.04ns 11.8ns 0.0298 0 0 2.2 KB
#6138 EnrichedLog net472 4.79μs 1.18ns 4.57ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.528ns 2.05ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 0.688ns 2.66ns 0.0158 0 0 1.14 KB
master SendReceive net472 2.1μs 1.24ns 4.79ns 0.183 0.00104 0 1.16 KB
#6138 SendReceive net6.0 1.42μs 0.851ns 3.29ns 0.0156 0 0 1.14 KB
#6138 SendReceive netcoreapp3.1 1.75μs 0.632ns 2.36ns 0.0157 0 0 1.14 KB
#6138 SendReceive net472 2.11μs 0.859ns 3.33ns 0.183 0.00106 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 3.25ns 12.6ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 1.57ns 6.1ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.37μs 2.2ns 8.24ns 0.323 0 0 2.04 KB
#6138 EnrichedLog net6.0 2.8μs 0.661ns 2.56ns 0.0224 0 0 1.6 KB
#6138 EnrichedLog netcoreapp3.1 3.87μs 1.55ns 5.81ns 0.0214 0 0 1.65 KB
#6138 EnrichedLog net472 4.38μs 1.95ns 7.55ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6138

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.116 486.97 543.32

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 424ns 0.206ns 0.796ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 592ns 0.537ns 2.08ns 0.00764 0 0 576 B
master StartFinishSpan net472 699ns 0.802ns 3.11ns 0.0915 0 0 578 B
master StartFinishScope net6.0 487ns 0.308ns 1.19ns 0.00978 0 0 696 B
master StartFinishScope netcoreapp3.1 759ns 1.24ns 4.47ns 0.00951 0 0 696 B
master StartFinishScope net472 880ns 0.891ns 3.45ns 0.104 0 0 658 B
#6138 StartFinishSpan net6.0 466ns 0.328ns 1.27ns 0.00805 0 0 576 B
#6138 StartFinishSpan netcoreapp3.1 545ns 0.416ns 1.61ns 0.00766 0 0 576 B
#6138 StartFinishSpan net472 758ns 1.36ns 5.25ns 0.0915 0 0 578 B
#6138 StartFinishScope net6.0 544ns 0.147ns 0.571ns 0.00978 0 0 696 B
#6138 StartFinishScope netcoreapp3.1 811ns 0.549ns 2.13ns 0.00937 0 0 696 B
#6138 StartFinishScope net472 941ns 0.659ns 2.55ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 711ns 0.29ns 1.12ns 0.00964 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 962ns 0.648ns 2.51ns 0.00947 0 0 696 B
master RunOnMethodBegin net472 1.19μs 1.16ns 4.48ns 0.104 0 0 658 B
#6138 RunOnMethodBegin net6.0 712ns 0.304ns 1.18ns 0.01 0 0 696 B
#6138 RunOnMethodBegin netcoreapp3.1 1μs 0.276ns 1.03ns 0.00948 0 0 696 B
#6138 RunOnMethodBegin net472 1.14μs 0.994ns 3.85ns 0.104 0 0 658 B

@andrewlock
andrewlock force-pushed the andrew/ci/build-against-macos-13 branch from 8ff0c25 to be163d2 Compare October 11, 2024 15:29
@andrewlock
andrewlock force-pushed the andrew/ci/build-against-macos-13 branch from be163d2 to 11a8c53 Compare October 15, 2024 08:02
tonyredondo
tonyredondo approved these changes Oct 16, 2024
View reviewed changes

@tonyredondo tonyredondo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andrewlock
andrewlock merged commit 966f1f7 into master Oct 21, 2024
@andrewlock
andrewlock deleted the andrew/ci/build-against-macos-13 branch October 21, 2024 08:12
@github-actions github-actions Bot added this to the vNext-v3 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @tonyredondo