Skip to content

Remove nuke JSON file#6126

Merged
andrewlock merged 2 commits into
masterfrom
anrew/remove-nuke-json-file
Oct 8, 2024
Merged

Remove nuke JSON file#6126
andrewlock merged 2 commits into
masterfrom
anrew/remove-nuke-json-file

Conversation

@andrewlock

@andrewlock andrewlock commented Oct 7, 2024

Copy link
Copy Markdown
Member

Summary of changes

Remove the build.schema.json file

Reason for change

It's annoying that it ends up in loads of PRs, and is only used for autocomplete

Implementation details

Delete the file from git

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 7, 2024
@andrewlock
andrewlock requested a review from a team as a code owner October 7, 2024 14:27
@datadog-ddstaging

datadog-ddstaging Bot commented Oct 7, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: anrew/remove-nuke-json-file
Commit report: e552be5
Test service: dd-trace-dotnet

✅ 0 Failed, 367791 Passed, 2090 Skipped, 15h 39m 34.24s Total Time

@andrewlock

andrewlock commented Oct 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6126) - mean (70ms)  : 69, 72
     .   : milestone, 70,
    master - mean (71ms)  : 68, 74
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6126) - mean (1,111ms)  : 1087, 1135
     .   : milestone, 1111,
    master - mean (1,109ms)  : 1084, 1134
     .   : milestone, 1109,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6126) - mean (110ms)  : 107, 112
     .   : milestone, 110,
    master - mean (109ms)  : 107, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6126) - mean (777ms)  : 759, 796
     .   : milestone, 777,
    master - mean (777ms)  : 762, 792
     .   : milestone, 777,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6126) - mean (94ms)  : 90, 98
     .   : milestone, 94,
    master - mean (93ms)  : 92, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6126) - mean (733ms)  : 711, 754
     .   : milestone, 733,
    master - mean (731ms)  : 716, 747
     .   : milestone, 731,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6126) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6126) - mean (1,198ms)  : 1178, 1218
     .   : milestone, 1198,
    master - mean (1,199ms)  : 1171, 1227
     .   : milestone, 1199,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6126) - mean (276ms)  : 270, 281
     .   : milestone, 276,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6126) - mean (937ms)  : 921, 954
     .   : milestone, 937,
    master - mean (939ms)  : 921, 957
     .   : milestone, 939,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6126) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6126) - mean (923ms)  : 907, 940
     .   : milestone, 923,
    master - mean (927ms)  : 908, 947
     .   : milestone, 927,
Loading

@andrewlock

andrewlock commented Oct 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6126 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.163
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.76μs 41.8ns 217ns 0.0202 0.00807 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.93μs 56.1ns 372ns 0.0187 0.00933 0 5.61 KB
master StartStopWithChild net472 16.3μs 64.5ns 250ns 1.03 0.312 0.0903 6.08 KB
#6126 StartStopWithChild net6.0 7.8μs 44.6ns 321ns 0.0195 0.00781 0 5.42 KB
#6126 StartStopWithChild netcoreapp3.1 9.99μs 55.3ns 345ns 0.015 0.00499 0 5.62 KB
#6126 StartStopWithChild net472 16.8μs 79.8ns 319ns 1.03 0.309 0.1 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 467μs 219ns 849ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 229ns 857ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 835μs 452ns 1.75μs 0.414 0 0 3.3 KB
#6126 WriteAndFlushEnrichedTraces net6.0 482μs 475ns 1.78μs 0 0 0 2.7 KB
#6126 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 290ns 1.12μs 0 0 0 2.7 KB
#6126 WriteAndFlushEnrichedTraces net472 835μs 1.01μs 3.93μs 0.411 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 193μs 1.04μs 5.82μs 0.191 0 0 18.45 KB
master SendRequest netcoreapp3.1 213μs 854ns 3.19μs 0.207 0 0 20.61 KB
master SendRequest net472 0.00144ns 0.000398ns 0.00154ns 0 0 0 0 b
#6126 SendRequest net6.0 197μs 1.14μs 9.73μs 0.193 0 0 18.45 KB
#6126 SendRequest netcoreapp3.1 215μs 1.14μs 6.05μs 0.219 0 0 20.61 KB
#6126 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6126

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.44 KB 41.69 KB 252 B 0.61%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 566μs 2.05μs 7.68μs 0.563 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 3.41μs 19μs 0.332 0 0 41.44 KB
master WriteAndFlushEnrichedTraces net472 852μs 2.91μs 10.5μs 8.08 2.55 0.425 53.32 KB
#6126 WriteAndFlushEnrichedTraces net6.0 565μs 2.48μs 9.59μs 0.595 0 0 41.67 KB
#6126 WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 3.5μs 16.4μs 0.329 0 0 41.69 KB
#6126 WriteAndFlushEnrichedTraces net472 857μs 3.48μs 13.5μs 8.39 2.52 0.419 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.26μs 0.591ns 2.29ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 1.73ns 6.71ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.06μs 1.61ns 6.24ns 0.156 0 0 987 B
#6126 ExecuteNonQuery net6.0 1.19μs 1.76ns 6.83ns 0.0145 0 0 1.02 KB
#6126 ExecuteNonQuery netcoreapp3.1 1.71μs 2.24ns 8.68ns 0.0138 0 0 1.02 KB
#6126 ExecuteNonQuery net472 2.07μs 1.23ns 4.74ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.627ns 2.43ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.51μs 0.75ns 2.91ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.4μs 0.999ns 3.87ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.25μs 0.663ns 2.57ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 1.18ns 4.24ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.46μs 1.37ns 5.13ns 0.167 0 0 1.05 KB
#6126 CallElasticsearch net6.0 1.28μs 0.919ns 3.56ns 0.0135 0 0 976 B
#6126 CallElasticsearch netcoreapp3.1 1.51μs 0.683ns 2.55ns 0.0128 0 0 976 B
#6126 CallElasticsearch net472 2.41μs 1.28ns 4.95ns 0.158 0 0 995 B
#6126 CallElasticsearchAsync net6.0 1.27μs 0.707ns 2.65ns 0.0132 0 0 952 B
#6126 CallElasticsearchAsync netcoreapp3.1 1.68μs 0.841ns 3.26ns 0.0135 0 0 1.02 KB
#6126 CallElasticsearchAsync net472 2.57μs 2.13ns 7.97ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.25μs 0.823ns 3.08ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.63μs 4.27ns 16.5ns 0.0122 0 0 952 B
master ExecuteAsync net472 1.73μs 0.72ns 2.79ns 0.145 0 0 915 B
#6126 ExecuteAsync net6.0 1.28μs 1.1ns 4.25ns 0.0133 0 0 952 B
#6126 ExecuteAsync netcoreapp3.1 1.55μs 1.2ns 4.64ns 0.0125 0 0 952 B
#6126 ExecuteAsync net472 1.76μs 1.66ns 6.41ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.16μs 3.67ns 13.7ns 0.0313 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.07μs 2.01ns 7.51ns 0.038 0 0 2.76 KB
master SendAsync net472 7.74μs 5.7ns 22.1ns 0.496 0 0 3.15 KB
#6126 SendAsync net6.0 4.14μs 1.2ns 4.63ns 0.031 0 0 2.22 KB
#6126 SendAsync netcoreapp3.1 5.11μs 3.05ns 11.8ns 0.0357 0 0 2.76 KB
#6126 SendAsync net472 7.75μs 4.02ns 15.6ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 1.1ns 4.27ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.5μs 2.25ns 8.41ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.54μs 1.24ns 4.62ns 0.249 0 0 1.57 KB
#6126 EnrichedLog net6.0 1.59μs 1.15ns 4.3ns 0.0227 0 0 1.64 KB
#6126 EnrichedLog netcoreapp3.1 2.37μs 0.83ns 3.21ns 0.0225 0 0 1.64 KB
#6126 EnrichedLog net472 2.4μs 0.8ns 2.99ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 148ns 575ns 0.058 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 200ns 749ns 0 0 0 4.28 KB
master EnrichedLog net472 147μs 99.3ns 372ns 0.658 0.219 0 4.46 KB
#6126 EnrichedLog net6.0 114μs 204ns 790ns 0.057 0 0 4.28 KB
#6126 EnrichedLog netcoreapp3.1 119μs 137ns 511ns 0.0592 0 0 4.28 KB
#6126 EnrichedLog net472 147μs 111ns 431ns 0.656 0.219 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.21μs 9.32ns 36.1ns 0.0301 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.16μs 2.83ns 11ns 0.029 0 0 2.2 KB
master EnrichedLog net472 4.92μs 5.75ns 22.3ns 0.32 0 0 2.02 KB
#6126 EnrichedLog net6.0 3.15μs 1.47ns 5.68ns 0.0299 0 0 2.2 KB
#6126 EnrichedLog netcoreapp3.1 4.18μs 10.6ns 38.1ns 0.0296 0 0 2.2 KB
#6126 EnrichedLog net472 4.79μs 3.92ns 15.2ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.38μs 0.464ns 1.74ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.66μs 0.713ns 2.76ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.15μs 1.43ns 5.34ns 0.183 0.00109 0 1.16 KB
#6126 SendReceive net6.0 1.27μs 0.468ns 1.75ns 0.0159 0 0 1.14 KB
#6126 SendReceive netcoreapp3.1 1.79μs 1.29ns 5ns 0.0152 0 0 1.14 KB
#6126 SendReceive net472 2.07μs 0.492ns 1.84ns 0.183 0.00104 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.85μs 1.03ns 3.99ns 0.0229 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.88μs 2.5ns 9.7ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.56μs 0.811ns 2.92ns 0.322 0 0 2.04 KB
#6126 EnrichedLog net6.0 2.73μs 1.78ns 6.91ns 0.0219 0 0 1.6 KB
#6126 EnrichedLog netcoreapp3.1 3.85μs 1.35ns 5.07ns 0.0213 0 0 1.65 KB
#6126 EnrichedLog net472 4.4μs 2.15ns 8.06ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6126

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.203 493.90 410.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 494ns 0.291ns 1.09ns 0.00801 0 0 576 B
master StartFinishSpan netcoreapp3.1 568ns 0.588ns 2.2ns 0.00795 0 0 576 B
master StartFinishSpan net472 668ns 0.53ns 2.05ns 0.0916 0 0 578 B
master StartFinishScope net6.0 535ns 0.23ns 0.893ns 0.0098 0 0 696 B
master StartFinishScope netcoreapp3.1 714ns 0.329ns 1.28ns 0.00929 0 0 696 B
master StartFinishScope net472 869ns 0.51ns 1.91ns 0.104 0 0 658 B
#6126 StartFinishSpan net6.0 411ns 0.276ns 1.07ns 0.008 0 0 576 B
#6126 StartFinishSpan netcoreapp3.1 554ns 0.207ns 0.748ns 0.00778 0 0 576 B
#6126 StartFinishSpan net472 704ns 0.575ns 2.23ns 0.0916 0 0 578 B
#6126 StartFinishScope net6.0 486ns 0.382ns 1.48ns 0.00988 0 0 696 B
#6126 StartFinishScope netcoreapp3.1 774ns 0.829ns 3.21ns 0.00955 0 0 696 B
#6126 StartFinishScope net472 909ns 0.819ns 3.17ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6126

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.125 996.52 885.42

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 738ns 0.532ns 2.06ns 0.00985 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 996ns 0.348ns 1.25ns 0.00966 0 0 696 B
master RunOnMethodBegin net472 1.14μs 0.707ns 2.64ns 0.104 0 0 658 B
#6126 RunOnMethodBegin net6.0 673ns 0.235ns 0.881ns 0.00976 0 0 696 B
#6126 RunOnMethodBegin netcoreapp3.1 885ns 0.412ns 1.6ns 0.0094 0 0 696 B
#6126 RunOnMethodBegin net472 1.13μs 0.488ns 1.69ns 0.104 0 0 658 B

@andrewlock

andrewlock commented Oct 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6126) (10.970M)   : 0, 10969507
    master (11.013M)   : 0, 11012653
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6126) (7.355M)   : 0, 7354549
    master (7.257M)   : 0, 7256944
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.393M)   : 0, 7393311

    section Manual
    master (11.210M)   : 0, 11210238

    section Manual + Automatic
    This PR (6126) (6.775M)   : 0, 6774664
    master (6.902M)   : 0, 6901880

    section DD_TRACE_ENABLED=0
    master (10.246M)   : 0, 10245809
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6126) (9.592M)   : 0, 9592402
    master (9.699M)   : 0, 9699374
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6126) (6.602M)   : 0, 6601923
    master (6.629M)   : 0, 6628939

    section Trace stats
    master (6.955M)   : 0, 6954928

    section Manual
    master (9.662M)   : 0, 9662390

    section Manual + Automatic
    This PR (6126) (6.021M)   : 0, 6020832
    master (6.096M)   : 0, 6095670

    section DD_TRACE_ENABLED=0
    master (8.710M)   : 0, 8710481
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6126) (10.381M)   : 0, 10381394
    master (10.071M)   : 0, 10071070
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6126) (6.589M)   : 0, 6589047
    master (6.612M)   : 0, 6612085
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.286M)   : 0, 7285519

    section Manual
    master (10.026M)   : 0, 10025950

    section Manual + Automatic
    This PR (6126) (6.088M)   : 0, 6087607
    master (6.346M)   : 0, 6345551

    section DD_TRACE_ENABLED=0
    master (9.203M)   : 0, 9203356
Loading

@andrewlock
andrewlock force-pushed the anrew/remove-nuke-json-file branch from 8e961d4 to e552be5 Compare October 8, 2024 14:29
@andrewlock
andrewlock merged commit 3752cf4 into master Oct 8, 2024
@andrewlock
andrewlock deleted the anrew/remove-nuke-json-file branch October 8, 2024 18:12
@github-actions github-actions Bot added this to the vNext-v3 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @bouwkast