Skip to content

[Profiler] Code cleanup#6114

Merged
gleocadie merged 6 commits into
masterfrom
gleocadie/spring-cleaning
Oct 4, 2024
Merged

[Profiler] Code cleanup#6114
gleocadie merged 6 commits into
masterfrom
gleocadie/spring-cleaning

Conversation

@gleocadie

@gleocadie gleocadie commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary of changes

Clean up a bit the code.

Reason for change

Fixing this there and there.

Implementation details

  • Use std::move whenever it's possible
  • Use std::string_view whenever it's possible
  • Remove Semaphore.h since the current behavior is the same as a lock
  • use const&
  • Prefer fs::path instead of std::filesystem (same class every where and even if windows fs==std::filesystem
  • Clean up ManagedThreadInfo
  • Use ScopeHandle instead of raw HANDLE

Test coverage

Other details

@datadog-ddstaging

datadog-ddstaging Bot commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: gleocadie/spring-cleaning
Commit report: 108da51
Test service: dd-trace-dotnet

✅ 0 Failed, 367768 Passed, 2360 Skipped, 17h 10m 3.01s Total Time

@andrewlock

andrewlock commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6114) - mean (71ms)  : 67, 74
     .   : milestone, 71,
    master - mean (71ms)  : 67, 74
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6114) - mean (1,110ms)  : 1084, 1137
     .   : milestone, 1110,
    master - mean (1,108ms)  : 1083, 1132
     .   : milestone, 1108,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6114) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6114) - mean (771ms)  : 754, 788
     .   : milestone, 771,
    master - mean (769ms)  : 750, 787
     .   : milestone, 769,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6114) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (92ms)  : 89, 96
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6114) - mean (728ms)  : 713, 744
     .   : milestone, 728,
    master - mean (732ms)  : 716, 748
     .   : milestone, 732,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6114) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6114) - mean (1,196ms)  : 1177, 1216
     .   : milestone, 1196,
    master - mean (1,197ms)  : 1174, 1219
     .   : milestone, 1197,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6114) - mean (276ms)  : 273, 279
     .   : milestone, 276,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6114) - mean (939ms)  : 918, 959
     .   : milestone, 939,
    master - mean (939ms)  : 925, 953
     .   : milestone, 939,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6114) - mean (265ms)  : 260, 269
     .   : milestone, 265,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6114) - mean (922ms)  : 905, 939
     .   : milestone, 922,
    master - mean (926ms)  : 904, 947
     .   : milestone, 926,
Loading

@gleocadie
gleocadie force-pushed the gleocadie/spring-cleaning branch from 798d5e6 to 108da51 Compare October 3, 2024 15:43
gleocadie
gleocadie commented Oct 3, 2024
View reviewed changes
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/CrashReporting.cpp
while (i < nativeFrames.size() && j < managedFrames.size())
{
if (nativeFrames.at(i).sp < managedFrames.at(j).sp)
if (nativeFrames[i].sp < managedFrames[j].sp)

@gleocadie gleocadie Oct 3, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use [] operator instead of at() to avoid bound-checking.
Since we go through all the element of the vector, there is no need (in all cases it throws )

@gleocadie gleocadie changed the title Gleocadie/spring cleaning [Profiler] Code cleanup Oct 3, 2024
@gleocadie
gleocadie marked this pull request as ready for review October 3, 2024 15:58
@gleocadie
gleocadie requested a review from a team as a code owner October 3, 2024 15:58
chrisnas
chrisnas approved these changes Oct 3, 2024
View reviewed changes

@chrisnas chrisnas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock

andrewlock commented Oct 3, 2024

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6114) (11.070M)   : 0, 11070417
    master (11.156M)   : 0, 11155643
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6114) (7.369M)   : 0, 7368600
    master (7.256M)   : 0, 7255967
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.626M)   : 0, 7625614

    section Manual
    master (11.069M)   : 0, 11069199

    section Manual + Automatic
    This PR (6114) (6.797M)   : 0, 6797367
    master (6.774M)   : 0, 6773822

    section DD_TRACE_ENABLED=0
    master (10.175M)   : 0, 10174621
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6114) (9.507M)   : 0, 9507278
    master (9.647M)   : 0, 9646736
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6114) (6.456M)   : 0, 6455724
    master (6.458M)   : 0, 6458330

    section Trace stats
    master (6.599M)   : 0, 6598920

    section Manual
    master (9.446M)   : 0, 9446143

    section Manual + Automatic
    This PR (6114) (6.110M)   : 0, 6110471
    master (6.008M)   : 0, 6007669

    section DD_TRACE_ENABLED=0
    master (8.928M)   : 0, 8928236
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6114) (10.071M)   : 0, 10070941
    master (10.044M)   : 0, 10043661
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6114) (6.546M)   : 0, 6545589
    master (6.627M)   : 0, 6627172
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.392M)   : 0, 7391957

    section Manual
    master (10.130M)   : 0, 10130379

    section Manual + Automatic
    This PR (6114) (6.139M)   : 0, 6139310
    master (6.167M)   : 0, 6167004

    section DD_TRACE_ENABLED=0
    master (9.288M)   : 0, 9287905
Loading

@andrewlock

andrewlock commented Oct 3, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6114 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.137
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.84μs 43.8ns 304ns 0.0165 0.00413 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10μs 54.3ns 326ns 0.0209 0.00523 0 5.61 KB
master StartStopWithChild net472 16μs 16.6ns 62.1ns 1.01 0.293 0.0952 6.07 KB
#6114 StartStopWithChild net6.0 8.23μs 41.5ns 190ns 0.012 0.00798 0 5.43 KB
#6114 StartStopWithChild netcoreapp3.1 10μs 53.1ns 260ns 0.0197 0.00986 0 5.62 KB
#6114 StartStopWithChild net472 17.7μs 38.8ns 150ns 0.993 0.275 0.0709 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6114

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.126 476,808.45 536,999.38

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 477μs 247ns 958ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 411ns 1.59μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 839μs 702ns 2.53μs 0.417 0 0 3.3 KB
#6114 WriteAndFlushEnrichedTraces net6.0 537μs 344ns 1.33μs 0 0 0 2.7 KB
#6114 WriteAndFlushEnrichedTraces netcoreapp3.1 638μs 330ns 1.28μs 0 0 0 2.7 KB
#6114 WriteAndFlushEnrichedTraces net472 830μs 536ns 1.93μs 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 195μs 1.11μs 8.32μs 0.188 0 0 18.45 KB
master SendRequest netcoreapp3.1 217μs 1.24μs 8.92μs 0.201 0 0 20.61 KB
master SendRequest net472 0.00215ns 0.000542ns 0.0021ns 0 0 0 0 b
#6114 SendRequest net6.0 192μs 1.07μs 6.68μs 0.18 0 0 18.45 KB
#6114 SendRequest netcoreapp3.1 217μs 1.22μs 7.9μs 0.217 0 0 20.61 KB
#6114 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 574μs 3.08μs 19μs 0.553 0 0 41.66 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 687μs 3.21μs 12.4μs 0.343 0 0 41.66 KB
master WriteAndFlushEnrichedTraces net472 854μs 4.02μs 16.6μs 8.08 2.55 0.425 53.29 KB
#6114 WriteAndFlushEnrichedTraces net6.0 550μs 2.43μs 9.41μs 0.566 0 0 41.57 KB
#6114 WriteAndFlushEnrichedTraces netcoreapp3.1 660μs 3.74μs 25.9μs 0.332 0 0 41.52 KB
#6114 WriteAndFlushEnrichedTraces net472 866μs 4.34μs 18.4μs 8.87 2.53 0.422 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.35μs 1.18ns 4.57ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.81μs 1.35ns 5.04ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 2.06μs 1.78ns 6.89ns 0.157 0 0 987 B
#6114 ExecuteNonQuery net6.0 1.27μs 0.517ns 1.86ns 0.0139 0 0 1.02 KB
#6114 ExecuteNonQuery netcoreapp3.1 1.82μs 1.77ns 6.84ns 0.0135 0 0 1.02 KB
#6114 ExecuteNonQuery net472 2.1μs 2.09ns 7.84ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.688ns 2.67ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 1.76ns 6.58ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.47μs 1.39ns 5.2ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.24μs 0.712ns 2.66ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.498ns 1.93ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 2.68ns 10.4ns 0.166 0 0 1.05 KB
#6114 CallElasticsearch net6.0 1.3μs 0.707ns 2.74ns 0.0137 0 0 976 B
#6114 CallElasticsearch netcoreapp3.1 1.47μs 0.705ns 2.73ns 0.0133 0 0 976 B
#6114 CallElasticsearch net472 2.52μs 1.29ns 5.01ns 0.157 0 0 995 B
#6114 CallElasticsearchAsync net6.0 1.29μs 0.891ns 3.33ns 0.0135 0 0 952 B
#6114 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.92ns 3.56ns 0.0137 0 0 1.02 KB
#6114 CallElasticsearchAsync net472 2.58μs 1.35ns 5.23ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.21μs 0.827ns 3.1ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 4.28ns 16.6ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.75μs 0.692ns 2.68ns 0.145 0 0 915 B
#6114 ExecuteAsync net6.0 1.28μs 0.359ns 1.39ns 0.0135 0 0 952 B
#6114 ExecuteAsync netcoreapp3.1 1.59μs 1.12ns 4.04ns 0.0127 0 0 952 B
#6114 ExecuteAsync net472 1.87μs 0.951ns 3.56ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.19μs 1.31ns 5.07ns 0.0313 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.14μs 2.12ns 7.63ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.78μs 3.22ns 12ns 0.496 0 0 3.15 KB
#6114 SendAsync net6.0 4.21μs 1.19ns 4.47ns 0.0312 0 0 2.22 KB
#6114 SendAsync netcoreapp3.1 5.13μs 1.75ns 6.56ns 0.0361 0 0 2.76 KB
#6114 SendAsync net472 7.76μs 1.94ns 7.52ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.528ns 2.04ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.1μs 3.92ns 15.2ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.48μs 1.14ns 4.43ns 0.249 0 0 1.57 KB
#6114 EnrichedLog net6.0 1.58μs 3.95ns 15.3ns 0.0228 0 0 1.64 KB
#6114 EnrichedLog netcoreapp3.1 2.14μs 1.09ns 3.93ns 0.0219 0 0 1.64 KB
#6114 EnrichedLog net472 2.54μs 0.894ns 3.46ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 426ns 1.9μs 0.0566 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 316ns 1.22μs 0 0 0 4.28 KB
master EnrichedLog net472 148μs 184ns 688ns 0.664 0.221 0 4.46 KB
#6114 EnrichedLog net6.0 113μs 199ns 770ns 0.0573 0 0 4.28 KB
#6114 EnrichedLog netcoreapp3.1 119μs 386ns 1.39μs 0 0 0 4.28 KB
#6114 EnrichedLog net472 147μs 111ns 429ns 0.657 0.219 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.24μs 0.736ns 2.75ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.18μs 1.16ns 4.36ns 0.0293 0 0 2.2 KB
master EnrichedLog net472 4.83μs 1.19ns 4.62ns 0.321 0 0 2.02 KB
#6114 EnrichedLog net6.0 3.02μs 1.89ns 7.33ns 0.0303 0 0 2.2 KB
#6114 EnrichedLog netcoreapp3.1 4.21μs 1.79ns 6.44ns 0.0295 0 0 2.2 KB
#6114 EnrichedLog net472 4.86μs 0.94ns 3.64ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 0.744ns 2.68ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 2.19ns 8.5ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.19μs 1.04ns 3.75ns 0.183 0.00105 0 1.16 KB
#6114 SendReceive net6.0 1.42μs 0.91ns 3.41ns 0.0163 0 0 1.14 KB
#6114 SendReceive netcoreapp3.1 1.71μs 1.24ns 4.8ns 0.0155 0 0 1.14 KB
#6114 SendReceive net472 2.08μs 3.76ns 14.5ns 0.183 0.00103 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.85μs 0.916ns 3.55ns 0.0214 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.01μs 0.984ns 3.68ns 0.022 0 0 1.65 KB
master EnrichedLog net472 4.33μs 2.63ns 9.5ns 0.323 0 0 2.04 KB
#6114 EnrichedLog net6.0 2.76μs 0.852ns 3.07ns 0.0221 0 0 1.6 KB
#6114 EnrichedLog netcoreapp3.1 3.82μs 1.62ns 6.27ns 0.0211 0 0 1.65 KB
#6114 EnrichedLog net472 4.37μs 1.71ns 6.39ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 400ns 0.209ns 0.808ns 0.00795 0 0 576 B
master StartFinishSpan netcoreapp3.1 610ns 0.328ns 1.27ns 0.00792 0 0 576 B
master StartFinishSpan net472 720ns 0.285ns 1.1ns 0.0916 0 0 578 B
master StartFinishScope net6.0 537ns 0.35ns 1.35ns 0.00984 0 0 696 B
master StartFinishScope netcoreapp3.1 752ns 0.407ns 1.58ns 0.0096 0 0 696 B
master StartFinishScope net472 839ns 0.46ns 1.66ns 0.104 0 0 658 B
#6114 StartFinishSpan net6.0 402ns 0.228ns 0.852ns 0.00811 0 0 576 B
#6114 StartFinishSpan netcoreapp3.1 579ns 0.512ns 1.98ns 0.00788 0 0 576 B
#6114 StartFinishSpan net472 714ns 0.733ns 2.84ns 0.0915 0 0 578 B
#6114 StartFinishScope net6.0 570ns 0.163ns 0.631ns 0.00973 0 0 696 B
#6114 StartFinishScope netcoreapp3.1 763ns 0.673ns 2.61ns 0.00944 0 0 696 B
#6114 StartFinishScope net472 858ns 0.574ns 2.15ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6114

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.149 587.24 674.49

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 587ns 0.183ns 0.707ns 0.00972 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 883ns 0.45ns 1.74ns 0.0093 0 0 696 B
master RunOnMethodBegin net472 1.16μs 0.732ns 2.84ns 0.104 0 0 658 B
#6114 RunOnMethodBegin net6.0 675ns 0.406ns 1.57ns 0.00987 0 0 696 B
#6114 RunOnMethodBegin netcoreapp3.1 930ns 0.352ns 1.36ns 0.00943 0 0 696 B
#6114 RunOnMethodBegin net472 1.14μs 0.849ns 3.29ns 0.104 0 0 658 B

kevingosse
kevingosse approved these changes Oct 4, 2024
View reviewed changes

@kevingosse kevingosse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(only reviewed the crashtracking changes)

@gleocadie
gleocadie merged commit 94ff048 into master Oct 4, 2024
@gleocadie
gleocadie deleted the gleocadie/spring-cleaning branch October 4, 2024 11:51
@github-actions github-actions Bot added this to the vNext-v3 milestone Oct 4, 2024
@andrewlock andrewlock added type:cleanup Minor code clean up area:profiler Issues related to the continous-profiler labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisnas chrisnas chrisnas approved these changes
+1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler type:cleanup Minor code clean up

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@gleocadie @andrewlock @chrisnas @kevingosse