[Profiler] Bump libdatadog 13.1 by gleocadie · Pull Request #6112 · DataDog/dd-trace-dotnet

gleocadie · 2024-10-03T11:52:55Z

Summary of changes

Bump libdatadog to v13.1

Reason for change

Benefit from support for PDB in libdatadog.

Implementation details

update nuget package
update cmake file

Test coverage

Other details

datadog-ddstaging · 2024-10-03T12:16:17Z

Datadog Report

Branch report: gleocadie/bump-libdatadog-13.1
Commit report: ce1faf6
Test service: dd-trace-dotnet

✅ 0 Failed, 364946 Passed, 2361 Skipped, 17h 7m 6.8s Total Time

andrewlock · 2024-10-03T12:25:16Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6112) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6112) - mean (1,109ms)  : 1080, 1138
     .   : milestone, 1109,
    master - mean (1,105ms)  : 1087, 1123
     .   : milestone, 1105,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6112) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6112) - mean (774ms)  : 758, 790
     .   : milestone, 774,
    master - mean (772ms)  : 756, 787
     .   : milestone, 772,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6112) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6112) - mean (732ms)  : 713, 750
     .   : milestone, 732,
    master - mean (727ms)  : 709, 744
     .   : milestone, 727,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6112) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6112) - mean (1,200ms)  : 1175, 1226
     .   : milestone, 1200,
    master - mean (1,194ms)  : 1165, 1223
     .   : milestone, 1194,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6112) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6112) - mean (940ms)  : 919, 960
     .   : milestone, 940,
    master - mean (936ms)  : 920, 952
     .   : milestone, 936,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6112) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6112) - mean (922ms)  : 905, 939
     .   : milestone, 922,
    master - mean (923ms)  : 906, 940
     .   : milestone, 923,

andrewlock · 2024-10-03T13:05:06Z

Benchmarks Report for tracer 🐌

Benchmarks for #6112 compared to master:

1 benchmarks are faster, with geometric mean 1.133
3 benchmarks are slower, with geometric mean 1.143
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.73μs	42.5ns	312ns	0.0228	0.0114	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.77μs	46.7ns	198ns	0.0146	0.00486	0	5.62 KB
master	`StartStopWithChild`	net472	16.2μs	63.5ns	246ns	1.03	0.329	0.104	6.06 KB
#6112	`StartStopWithChild`	net6.0	7.68μs	42.4ns	275ns	0.0108	0.00359	0	5.43 KB
#6112	`StartStopWithChild`	netcoreapp3.1	9.76μs	55.6ns	385ns	0.0191	0.00956	0	5.62 KB
#6112	`StartStopWithChild`	net472	16.1μs	54.3ns	203ns	1.02	0.296	0.0961	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	485μs	232ns	900ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	636μs	302ns	1.13μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	825μs	771ns	2.99μs	0.414	3.3 KB
#6112	`WriteAndFlushEnrichedTraces`	net6.0	482μs	274ns	1.06μs	0	2.7 KB
#6112	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	295ns	1.14μs	0	2.7 KB
#6112	`WriteAndFlushEnrichedTraces`	net472	827μs	453ns	1.75μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	184μs	945ns	4.43μs	0.191	18.45 KB
master	`SendRequest`	netcoreapp3.1	210μs	1.16μs	8.23μs	0.212	20.61 KB
master	`SendRequest`	net472	0.00311ns	0.00137ns	0.00511ns	0	0 b
#6112	`SendRequest`	net6.0	194μs	1.01μs	5.36μs	0.182	18.45 KB
#6112	`SendRequest`	netcoreapp3.1	220μs	1.2μs	7.22μs	0.21	20.61 KB
#6112	`SendRequest`	net472	0.00159ns	0.000586ns	0.00227ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	567μs	3.13μs	18.8μs	0.548	0	0	41.61 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	683μs	2.86μs	11.1μs	0.331	0	0	41.83 KB
master	`WriteAndFlushEnrichedTraces`	net472	858μs	4.31μs	20.2μs	8.45	2.53	0.422	53.3 KB
#6112	`WriteAndFlushEnrichedTraces`	net6.0	553μs	2.67μs	10.3μs	0.571	0	0	41.56 KB
#6112	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	683μs	3.26μs	13.8μs	0.34	0	0	41.82 KB
#6112	`WriteAndFlushEnrichedTraces`	net472	837μs	3.81μs	14.8μs	8.28	2.48	0.414	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	0.973ns	3.77ns	0.0141	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.32ns	4.94ns	0.0135	1.02 KB
master	`ExecuteNonQuery`	net472	1.99μs	2.03ns	7.86ns	0.156	987 B
#6112	`ExecuteNonQuery`	net6.0	1.28μs	0.64ns	2.39ns	0.0142	1.02 KB
#6112	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.34ns	4.65ns	0.0139	1.02 KB
#6112	`ExecuteNonQuery`	net472	2.09μs	1.17ns	4.37ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.24μs	0.765ns	2.86ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.442ns	1.66ns	0.0135	976 B
master	`CallElasticsearch`	net472	2.51μs	1.01ns	3.77ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.31μs	0.952ns	3.69ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.478ns	1.72ns	0.0138	1.02 KB
master	`CallElasticsearchAsync`	net472	2.62μs	2.17ns	8.14ns	0.166	1.05 KB
#6112	`CallElasticsearch`	net6.0	1.18μs	0.507ns	1.9ns	0.0135	976 B
#6112	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.482ns	1.74ns	0.0129	976 B
#6112	`CallElasticsearch`	net472	2.52μs	2.14ns	8.29ns	0.157	995 B
#6112	`CallElasticsearchAsync`	net6.0	1.22μs	0.407ns	1.47ns	0.0128	952 B
#6112	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	1.05ns	3.94ns	0.0139	1.02 KB
#6112	`CallElasticsearchAsync`	net472	2.61μs	1.84ns	6.9ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6112

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.181	1,176.20	1,388.84

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.18μs	1ns	3.88ns	0.0136	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.98ns	3.79ns	0.013	952 B
master	`ExecuteAsync`	net472	1.8μs	0.934ns	3.62ns	0.145	915 B
#6112	`ExecuteAsync`	net6.0	1.39μs	1.03ns	4ns	0.0133	952 B
#6112	`ExecuteAsync`	netcoreapp3.1	1.58μs	2.56ns	9.59ns	0.0126	952 B
#6112	`ExecuteAsync`	net472	1.76μs	0.883ns	3.42ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.15μs	1.11ns	4.16ns	0.0312	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.16μs	3.65ns	14.2ns	0.0363	2.76 KB
master	`SendAsync`	net472	7.71μs	1ns	3.75ns	0.498	3.15 KB
#6112	`SendAsync`	net6.0	4.07μs	1.09ns	4.22ns	0.0307	2.22 KB
#6112	`SendAsync`	netcoreapp3.1	5.07μs	2.17ns	8.11ns	0.0359	2.76 KB
#6112	`SendAsync`	net472	7.79μs	1.68ns	6.49ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	1.04ns	4.03ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.33μs	0.69ns	2.49ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.64μs	0.792ns	3.07ns	0.249	1.57 KB
#6112	`EnrichedLog`	net6.0	1.59μs	0.816ns	3.16ns	0.023	1.64 KB
#6112	`EnrichedLog`	netcoreapp3.1	2.11μs	1.26ns	4.86ns	0.0222	1.64 KB
#6112	`EnrichedLog`	net472	2.47μs	1.29ns	5.01ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	183ns	710ns	0.0571	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	187ns	725ns	0.0587	0	4.28 KB
master	`EnrichedLog`	net472	145μs	92.6ns	346ns	0.655	0.218	4.46 KB
#6112	`EnrichedLog`	net6.0	115μs	438ns	1.7μs	0.0576	0	4.28 KB
#6112	`EnrichedLog`	netcoreapp3.1	118μs	103ns	386ns	0.0588	0	4.28 KB
#6112	`EnrichedLog`	net472	146μs	137ns	531ns	0.655	0.218	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3μs	1.18ns	4.57ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.27μs	1.47ns	5.68ns	0.0299	2.2 KB
master	`EnrichedLog`	net472	5.14μs	1.32ns	4.92ns	0.321	2.02 KB
#6112	`EnrichedLog`	net6.0	3.13μs	0.7ns	2.62ns	0.0316	2.2 KB
#6112	`EnrichedLog`	netcoreapp3.1	4.26μs	1.44ns	5.58ns	0.0278	2.2 KB
#6112	`EnrichedLog`	net472	4.87μs	1.61ns	6.25ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.25μs	0.623ns	2.33ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.797ns	2.98ns	0.0151	0	1.14 KB
master	`SendReceive`	net472	2.13μs	2.36ns	8.83ns	0.183	0.00105	1.16 KB
#6112	`SendReceive`	net6.0	1.36μs	0.492ns	1.71ns	0.0162	0	1.14 KB
#6112	`SendReceive`	netcoreapp3.1	1.73μs	1.12ns	4.34ns	0.0157	0	1.14 KB
#6112	`SendReceive`	net472	2.02μs	0.94ns	3.64ns	0.183	0.00101	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.69μs	1.31ns	5.06ns	0.023	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.93μs	1.14ns	4.4ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.37μs	2.39ns	9.26ns	0.322	2.04 KB
#6112	`EnrichedLog`	net6.0	2.76μs	1.06ns	4.12ns	0.0221	1.6 KB
#6112	`EnrichedLog`	netcoreapp3.1	3.82μs	1.79ns	6.93ns	0.0211	1.65 KB
#6112	`EnrichedLog`	net472	4.44μs	2.14ns	8.3ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6112

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.125	547.27	615.47

Faster 🎉 in #6112

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.133	452.12	399.03

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	452ns	0.439ns	1.7ns	0.00798	576 B
master	`StartFinishSpan`	netcoreapp3.1	547ns	0.379ns	1.47ns	0.00794	576 B
master	`StartFinishSpan`	net472	660ns	0.378ns	1.46ns	0.0917	578 B
master	`StartFinishScope`	net6.0	482ns	0.408ns	1.58ns	0.00983	696 B
master	`StartFinishScope`	netcoreapp3.1	677ns	1.07ns	4.16ns	0.00943	696 B
master	`StartFinishScope`	net472	844ns	1.36ns	5.26ns	0.104	658 B
#6112	`StartFinishSpan`	net6.0	398ns	0.496ns	1.92ns	0.00818	576 B
#6112	`StartFinishSpan`	netcoreapp3.1	614ns	0.906ns	3.51ns	0.00795	576 B
#6112	`StartFinishSpan`	net472	637ns	0.501ns	1.94ns	0.0918	578 B
#6112	`StartFinishScope`	net6.0	478ns	1.33ns	4.99ns	0.00975	696 B
#6112	`StartFinishScope`	netcoreapp3.1	666ns	0.535ns	2.07ns	0.00931	696 B
#6112	`StartFinishScope`	net472	892ns	0.933ns	3.61ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6112

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.126	657.71	740.47

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	658ns	0.387ns	1.5ns	0.00982	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	916ns	0.802ns	3.11ns	0.00933	696 B
master	`RunOnMethodBegin`	net472	1.1μs	1.28ns	4.97ns	0.104	658 B
#6112	`RunOnMethodBegin`	net6.0	741ns	0.328ns	1.27ns	0.00964	696 B
#6112	`RunOnMethodBegin`	netcoreapp3.1	850ns	0.875ns	3.39ns	0.00917	696 B
#6112	`RunOnMethodBegin`	net472	1.11μs	0.784ns	3.04ns	0.105	658 B

gleocadie added 2 commits October 3, 2024 13:44

Bump libdatadog 13.1 for Windows

4cf939e

Bump libdatadog v13.1 for Linux

ce1faf6

gleocadie requested review from a team as code owners October 3, 2024 11:52

github-actions Bot added the area:profiler Issues related to the continous-profiler label Oct 3, 2024

kevingosse approved these changes Oct 3, 2024

View reviewed changes

gleocadie merged commit 5c09446 into master Oct 3, 2024

gleocadie deleted the gleocadie/bump-libdatadog-13.1 branch October 3, 2024 13:26

github-actions Bot added this to the vNext-v3 milestone Oct 3, 2024

agocs pushed a commit that referenced this pull request Oct 8, 2024

[Profiler] Bump libdatadog 13.1 (#6112)

a4b1301

Uh oh!

Conversation

gleocadie commented Oct 3, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-ddstaging Bot commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock commented Oct 3, 2024

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock commented Oct 3, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6112

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6112

Faster 🎉 in #6112

Raw results

Slower ⚠️ in #6112

Raw results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-ddstaging Bot commented Oct 3, 2024 •

edited

Loading