Skip to content

Minor build fixes#6099

Merged
andrewlock merged 2 commits into
masterfrom
andrew/minor-build-updates
Sep 30, 2024
Merged

Minor build fixes#6099
andrewlock merged 2 commits into
masterfrom
andrew/minor-build-updates

Conversation

@andrewlock

@andrewlock andrewlock commented Sep 30, 2024

Copy link
Copy Markdown
Member

Summary of changes

  • Ensure we always upload logs, even if a job is cancelled
  • Don't clean test results multiple times per run

Reason for change

We have some cases where integration tests are taking way too long to run, and CI times out and cancels the job. Currently, that means we also don't get any logs.

Also, we're (accidentally) cleaning the test log folder multiple times in some stages. For example, we run Windows integration tests and regressions tests (two different stages) in the CI with a single command. Both of the run steps will clear the test folder, so we end up losing the integration test logs (unless they fail, in which case the regression tests never run)

Implementation details

  • Changed from succeededOrFailed() to always() for the log and snapshot upload steps
  • Extracted a "clean test folder" target which runs automatically once for the full execution.

Test coverage

This is the test

@andrewlock
Ensure we clean the tests _once_ per Nuke execution, by moving to a s…
43a4c57 
…eparate target.

Solves an issue where the regression tests were clearing the logs from the previous integration tests
@andrewlock
Ensure we _always_ try to upload logs even if a job is cancelled
4144915
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 30, 2024
@andrewlock
andrewlock requested a review from a team as a code owner September 30, 2024 10:37
kevingosse
kevingosse approved these changes Sep 30, 2024
View reviewed changes

@kevingosse kevingosse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datadog-ddstaging

datadog-ddstaging Bot commented Sep 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/minor-build-updates
Commit report: 4144915
Test service: dd-trace-dotnet

✅ 0 Failed, 365885 Passed, 2050 Skipped, 15h 27m 20.4s Total Time

@andrewlock

andrewlock commented Sep 30, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6099) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6099) - mean (1,104ms)  : 1081, 1128
     .   : milestone, 1104,
    master - mean (1,108ms)  : 1086, 1130
     .   : milestone, 1108,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6099) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6099) - mean (771ms)  : 751, 792
     .   : milestone, 771,
    master - mean (772ms)  : 753, 791
     .   : milestone, 772,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6099) - mean (94ms)  : 89, 98
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6099) - mean (726ms)  : 711, 742
     .   : milestone, 726,
    master - mean (731ms)  : 709, 753
     .   : milestone, 731,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6099) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6099) - mean (1,198ms)  : 1177, 1219
     .   : milestone, 1198,
    master - mean (1,198ms)  : 1173, 1223
     .   : milestone, 1198,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6099) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (276ms)  : 273, 279
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6099) - mean (941ms)  : 914, 968
     .   : milestone, 941,
    master - mean (938ms)  : 923, 953
     .   : milestone, 938,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6099) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6099) - mean (922ms)  : 906, 939
     .   : milestone, 922,
    master - mean (927ms)  : 906, 949
     .   : milestone, 927,
Loading

@andrewlock

andrewlock commented Sep 30, 2024

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6099) (11.148M)   : 0, 11148174
    master (11.214M)   : 0, 11213559
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6099) (7.330M)   : 0, 7330175
    master (7.414M)   : 0, 7414388
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.737M)   : 0, 7737460

    section Manual
    master (11.115M)   : 0, 11114877

    section Manual + Automatic
    This PR (6099) (6.778M)   : 0, 6777537
    master (6.964M)   : 0, 6963791

    section DD_TRACE_ENABLED=0
    master (10.268M)   : 0, 10267825
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6099) (9.510M)   : 0, 9510180
    master (9.609M)   : 0, 9608747
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6099) (6.590M)   : 0, 6590058
    master (6.616M)   : 0, 6616057

    section Trace stats
    master (6.832M)   : 0, 6832011

    section Manual
    master (9.547M)   : 0, 9547071

    section Manual + Automatic
    This PR (6099) (6.118M)   : 0, 6117976
    master (6.118M)   : 0, 6117867

    section DD_TRACE_ENABLED=0
    master (9.018M)   : 0, 9018069
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6099) (10.293M)   : 0, 10292641
    master (10.124M)   : 0, 10123739
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6099) (6.678M)   : 0, 6678348
    master (6.654M)   : 0, 6653810
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.417M)   : 0, 7416762

    section Manual
    master (9.870M)   : 0, 9869748

    section Manual + Automatic
    This PR (6099) (6.231M)   : 0, 6231080
    master (6.325M)   : 0, 6325090

    section DD_TRACE_ENABLED=0
    master (9.274M)   : 0, 9273906
Loading

@andrewlock

andrewlock commented Sep 30, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6099 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.120
  • 1 benchmarks are slower, with geometric mean 1.116
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.65μs 43.1ns 314ns 0.0226 0.0113 0 5.42 KB
master StartStopWithChild netcoreapp3.1 10.1μs 54.3ns 277ns 0.0242 0.00484 0 5.62 KB
master StartStopWithChild net472 15.8μs 38.9ns 151ns 1.01 0.297 0.0937 6.07 KB
#6099 StartStopWithChild net6.0 7.78μs 43.6ns 292ns 0.0164 0.00819 0 5.42 KB
#6099 StartStopWithChild netcoreapp3.1 10μs 55.5ns 356ns 0.0148 0.00495 0 5.62 KB
#6099 StartStopWithChild net472 15.9μs 50ns 194ns 1.02 0.31 0.0953 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 489μs 191ns 713ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 209ns 810ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 834μs 600ns 2.24μs 0.419 0 0 3.3 KB
#6099 WriteAndFlushEnrichedTraces net6.0 501μs 190ns 737ns 0 0 0 2.7 KB
#6099 WriteAndFlushEnrichedTraces netcoreapp3.1 626μs 265ns 1.03μs 0 0 0 2.7 KB
#6099 WriteAndFlushEnrichedTraces net472 863μs 566ns 2.19μs 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 202μs 1.36μs 13.5μs 0.191 0 0 18.45 KB
master SendRequest netcoreapp3.1 217μs 1.23μs 8.64μs 0.236 0 0 20.61 KB
master SendRequest net472 0.00322ns 0.00136ns 0.00526ns 0 0 0 0 b
#6099 SendRequest net6.0 196μs 1.03μs 6.76μs 0.196 0 0 18.45 KB
#6099 SendRequest netcoreapp3.1 217μs 1.16μs 6.03μs 0.209 0 0 20.61 KB
#6099 SendRequest net472 0.000757ns 0.000422ns 0.00164ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 559μs 2.07μs 7.46μs 0.548 0 0 41.66 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.35μs 14.6μs 0.327 0 0 41.81 KB
master WriteAndFlushEnrichedTraces net472 888μs 1.93μs 7.47μs 8.13 2.57 0.428 53.3 KB
#6099 WriteAndFlushEnrichedTraces net6.0 576μs 2.77μs 12.1μs 0.563 0 0 41.59 KB
#6099 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 2.06μs 7.44μs 0.332 0 0 41.81 KB
#6099 WriteAndFlushEnrichedTraces net472 865μs 3.58μs 13.9μs 8.45 2.53 0.422 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 1.31ns 5.05ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 2.13ns 8.24ns 0.0132 0 0 1.02 KB
master ExecuteNonQuery net472 2.17μs 1.76ns 6.34ns 0.156 0 0 987 B
#6099 ExecuteNonQuery net6.0 1.27μs 1.42ns 5.32ns 0.014 0 0 1.02 KB
#6099 ExecuteNonQuery netcoreapp3.1 1.81μs 2.06ns 7.97ns 0.013 0 0 1.02 KB
#6099 ExecuteNonQuery net472 2.11μs 2.44ns 9.46ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.968ns 3.62ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.628ns 2.35ns 0.0134 0 0 976 B
master CallElasticsearch net472 2.43μs 2.47ns 9.56ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.21μs 1.09ns 4.22ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 0.907ns 3.39ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.61μs 1.48ns 5.73ns 0.166 0 0 1.05 KB
#6099 CallElasticsearch net6.0 1.16μs 0.632ns 2.45ns 0.0134 0 0 976 B
#6099 CallElasticsearch netcoreapp3.1 1.46μs 0.653ns 2.44ns 0.0132 0 0 976 B
#6099 CallElasticsearch net472 2.43μs 1.53ns 5.91ns 0.157 0 0 995 B
#6099 CallElasticsearchAsync net6.0 1.27μs 0.623ns 2.41ns 0.0134 0 0 952 B
#6099 CallElasticsearchAsync netcoreapp3.1 1.57μs 1.18ns 4.42ns 0.0142 0 0 1.02 KB
#6099 CallElasticsearchAsync net472 2.46μs 1.71ns 6.64ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.37μs 0.831ns 3.11ns 0.0136 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 0.56ns 2.02ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.8μs 0.733ns 2.74ns 0.145 0 0 915 B
#6099 ExecuteAsync net6.0 1.31μs 0.822ns 3.08ns 0.0131 0 0 952 B
#6099 ExecuteAsync netcoreapp3.1 1.75μs 1.23ns 4.77ns 0.0123 0 0 952 B
#6099 ExecuteAsync net472 1.77μs 1.97ns 7.65ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.25μs 1.9ns 7.11ns 0.032 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.15μs 1.62ns 5.86ns 0.0361 0 0 2.76 KB
master SendAsync net472 7.75μs 1.61ns 6.03ns 0.499 0 0 3.15 KB
#6099 SendAsync net6.0 4.17μs 1.42ns 5.32ns 0.0314 0 0 2.22 KB
#6099 SendAsync netcoreapp3.1 5.14μs 2.08ns 8.05ns 0.0363 0 0 2.76 KB
#6099 SendAsync net472 7.76μs 1.96ns 7.6ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6099

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.116 1,448.12 1,615.96

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.83ns 3.22ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.09μs 1.02ns 3.96ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.48μs 1.7ns 6.57ns 0.249 0 0 1.57 KB
#6099 EnrichedLog net6.0 1.62μs 0.785ns 2.94ns 0.0233 0 0 1.64 KB
#6099 EnrichedLog netcoreapp3.1 2.22μs 3.72ns 14.4ns 0.0221 0 0 1.64 KB
#6099 EnrichedLog net472 2.35μs 1.43ns 5.55ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 155ns 558ns 0.0573 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 118ns 441ns 0.0593 0 0 4.28 KB
master EnrichedLog net472 146μs 102ns 380ns 0.656 0.219 0 4.46 KB
#6099 EnrichedLog net6.0 112μs 221ns 858ns 0.0562 0 0 4.28 KB
#6099 EnrichedLog netcoreapp3.1 117μs 151ns 587ns 0.0584 0 0 4.28 KB
#6099 EnrichedLog net472 148μs 213ns 823ns 0.664 0.221 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.17μs 0.998ns 3.86ns 0.0301 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.37μs 0.777ns 2.91ns 0.0283 0 0 2.2 KB
master EnrichedLog net472 4.86μs 2.07ns 8.02ns 0.319 0 0 2.02 KB
#6099 EnrichedLog net6.0 3.12μs 0.858ns 3.21ns 0.0312 0 0 2.2 KB
#6099 EnrichedLog netcoreapp3.1 4.31μs 1.79ns 6.71ns 0.0279 0 0 2.2 KB
#6099 EnrichedLog net472 4.99μs 1.48ns 5.75ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 0.695ns 2.69ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 1.15ns 4.46ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.04μs 1.95ns 7.55ns 0.183 0 0 1.16 KB
#6099 SendReceive net6.0 1.37μs 0.579ns 2.24ns 0.0158 0 0 1.14 KB
#6099 SendReceive netcoreapp3.1 1.75μs 1.03ns 3.85ns 0.015 0 0 1.14 KB
#6099 SendReceive net472 2.13μs 1.13ns 4.08ns 0.183 0.00107 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.72μs 0.942ns 3.53ns 0.0217 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.91μs 1.6ns 6.21ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.33μs 2.71ns 10.5ns 0.322 0 0 2.04 KB
#6099 EnrichedLog net6.0 2.95μs 1.08ns 4.19ns 0.0221 0 0 1.6 KB
#6099 EnrichedLog netcoreapp3.1 3.82μs 1.61ns 6.22ns 0.0227 0 0 1.65 KB
#6099 EnrichedLog net472 4.37μs 3.3ns 12.8ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6099

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.120 794.31 709.49

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 399ns 0.317ns 1.23ns 0.0081 0 0 576 B
master StartFinishSpan netcoreapp3.1 594ns 0.511ns 1.91ns 0.00785 0 0 576 B
master StartFinishSpan net472 650ns 0.638ns 2.47ns 0.0917 0 0 578 B
master StartFinishScope net6.0 494ns 0.159ns 0.596ns 0.00964 0 0 696 B
master StartFinishScope netcoreapp3.1 794ns 0.664ns 2.49ns 0.00925 0 0 696 B
master StartFinishScope net472 877ns 1.32ns 5.13ns 0.104 0 0 658 B
#6099 StartFinishSpan net6.0 418ns 0.235ns 0.91ns 0.00818 0 0 576 B
#6099 StartFinishSpan netcoreapp3.1 650ns 0.563ns 2.18ns 0.00779 0 0 576 B
#6099 StartFinishSpan net472 692ns 1.45ns 5.62ns 0.0915 0 0 578 B
#6099 StartFinishScope net6.0 530ns 0.328ns 1.27ns 0.00978 0 0 696 B
#6099 StartFinishScope netcoreapp3.1 709ns 0.621ns 2.4ns 0.00933 0 0 696 B
#6099 StartFinishScope net472 859ns 0.817ns 3.17ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 639ns 0.671ns 2.6ns 0.00966 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 907ns 1.63ns 6.33ns 0.00916 0 0 696 B
master RunOnMethodBegin net472 1.06μs 1.28ns 4.96ns 0.104 0 0 658 B
#6099 RunOnMethodBegin net6.0 588ns 0.328ns 1.27ns 0.0097 0 0 696 B
#6099 RunOnMethodBegin netcoreapp3.1 999ns 0.531ns 2.06ns 0.00955 0 0 696 B
#6099 RunOnMethodBegin net472 1.06μs 0.948ns 3.67ns 0.104 0 0 658 B

bouwkast
bouwkast approved these changes Sep 30, 2024
View reviewed changes

@bouwkast bouwkast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@andrewlock
andrewlock merged commit dce153d into master Sep 30, 2024
@andrewlock
andrewlock deleted the andrew/minor-build-updates branch September 30, 2024 14:54
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 30, 2024
agocs pushed a commit that referenced this pull request Oct 8, 2024
@andrewlock
Minor build fixes (#6099)
bf5a010 
## Summary of changes

- Ensure we always upload logs, even if a job is cancelled
- Don't clean test results multiple times per run

## Reason for change

We have some cases where integration tests are taking _way_ too long to
run, and CI times out and cancels the job. Currently, that means we also
don't get any logs.

Also, we're (accidentally) cleaning the test log folder multiple times
in some stages. For example, we run Windows integration tests and
regressions tests (two different stages) in the CI with a single
command. Both of the run steps will clear the test folder, so we end up
losing the integration test logs (unless they fail, in which case the
regression tests never run)

## Implementation details

- Changed from `succeededOrFailed()` to `always()` for the log and
snapshot upload steps
- Extracted a "clean test folder" target which runs automatically _once_
for the full execution.

## Test coverage

This is the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes
+1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @bouwkast @kevingosse