Skip to content

[Test Package Versions Bump] Updating package versions#6098

Merged
andrewlock merged 1 commit into
masterfrom
bot/test-package-versions-bump
Sep 30, 2024
Merged

[Test Package Versions Bump] Updating package versions#6098
andrewlock merged 1 commit into
masterfrom
bot/test-package-versions-bump

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Updates the package versions for integration tests.

@github-actions
github-actions Bot requested review from a team as code owners September 29, 2024 00:24
@andrewlock

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6098) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (71ms)  : 65, 77
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6098) - mean (1,106ms)  : 1085, 1127
     .   : milestone, 1106,
    master - mean (1,109ms)  : 1091, 1127
     .   : milestone, 1109,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6098) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6098) - mean (772ms)  : 757, 787
     .   : milestone, 772,
    master - mean (774ms)  : 757, 790
     .   : milestone, 774,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6098) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6098) - mean (732ms)  : 715, 749
     .   : milestone, 732,
    master - mean (730ms)  : 714, 745
     .   : milestone, 730,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6098) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6098) - mean (1,198ms)  : 1174, 1222
     .   : milestone, 1198,
    master - mean (1,200ms)  : 1176, 1225
     .   : milestone, 1200,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6098) - mean (279ms)  : 274, 284
     .   : milestone, 279,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6098) - mean (939ms)  : 921, 957
     .   : milestone, 939,
    master - mean (943ms)  : 925, 961
     .   : milestone, 943,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6098) - mean (265ms)  : 259, 271
     .   : milestone, 265,
    master - mean (265ms)  : 262, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6098) - mean (927ms)  : 908, 946
     .   : milestone, 927,
    master - mean (925ms)  : 907, 944
     .   : milestone, 925,

Loading

@datadog-ddstaging

datadog-ddstaging Bot commented Sep 29, 2024

Copy link
Copy Markdown

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 74cb99b
Test service: dd-trace-dotnet

✅ 0 Failed, 366963 Passed, 2066 Skipped, 15h 45m 40.96s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.StackExchangeRedisTests

@andrewlock

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6098 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.214
  • 1 benchmarks are slower, with geometric mean 1.115
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.56μs 42.9ns 297ns 0.0177 0.00706 0 5.42 KB
master StartStopWithChild netcoreapp3.1 10μs 54.4ns 308ns 0.0197 0.00985 0 5.62 KB
master StartStopWithChild net472 15.9μs 59.2ns 229ns 1.01 0.289 0.0937 6.07 KB
#6098 StartStopWithChild net6.0 7.77μs 42.6ns 256ns 0.015 0.00752 0 5.42 KB
#6098 StartStopWithChild netcoreapp3.1 9.9μs 48.7ns 284ns 0.0147 0.00489 0 5.62 KB
#6098 StartStopWithChild net472 16.1μs 50.1ns 194ns 1.02 0.301 0.0976 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 469μs 605ns 2.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 259ns 1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 835μs 831ns 3.11μs 0.414 0 0 3.3 KB
#6098 WriteAndFlushEnrichedTraces net6.0 479μs 171ns 661ns 0 0 0 2.7 KB
#6098 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 382ns 1.48μs 0 0 0 2.7 KB
#6098 WriteAndFlushEnrichedTraces net472 842μs 558ns 2.16μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 196μs 1.05μs 6.15μs 0.19 0 0 18.45 KB
master SendRequest netcoreapp3.1 217μs 1.19μs 7.37μs 0.23 0 0 20.61 KB
master SendRequest net472 8.85E‑05ns 6.28E‑05ns 0.000235ns 0 0 0 0 b
#6098 SendRequest net6.0 196μs 1.13μs 8.95μs 0.201 0 0 18.45 KB
#6098 SendRequest netcoreapp3.1 221μs 1.28μs 10.8μs 0.209 0 0 20.61 KB
#6098 SendRequest net472 0.000989ns 0.000384ns 0.00144ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6098

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.42 KB 41.67 KB 256 B 0.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 549μs 2.82μs 13.2μs 0.546 0 0 41.42 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.05μs 11μs 0.336 0 0 41.79 KB
master WriteAndFlushEnrichedTraces net472 844μs 3.84μs 14.9μs 8.58 2.45 0.408 53.28 KB
#6098 WriteAndFlushEnrichedTraces net6.0 575μs 2.65μs 10.6μs 0.543 0 0 41.67 KB
#6098 WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 3.27μs 13.1μs 0.338 0 0 41.87 KB
#6098 WriteAndFlushEnrichedTraces net472 863μs 3.72μs 14.4μs 8.39 2.52 0.419 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.29μs 1.51ns 5.83ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.48ns 5.71ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 2.15ns 8.03ns 0.156 0 0 987 B
#6098 ExecuteNonQuery net6.0 1.4μs 1.17ns 4.38ns 0.014 0 0 1.02 KB
#6098 ExecuteNonQuery netcoreapp3.1 1.73μs 2.06ns 7.99ns 0.0138 0 0 1.02 KB
#6098 ExecuteNonQuery net472 2.06μs 1.44ns 5.58ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6098

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.214 1,434.24 1,181.45

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.876ns 3.28ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.48μs 0.414ns 1.55ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.52μs 1.6ns 6.19ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.43μs 1.04ns 4.01ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 0.89ns 3.33ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.65μs 2.03ns 7.87ns 0.167 0 0 1.05 KB
#6098 CallElasticsearch net6.0 1.16μs 1.05ns 3.93ns 0.014 0 0 976 B
#6098 CallElasticsearch netcoreapp3.1 1.58μs 0.438ns 1.52ns 0.0134 0 0 976 B
#6098 CallElasticsearch net472 2.6μs 2.47ns 9.58ns 0.158 0 0 995 B
#6098 CallElasticsearchAsync net6.0 1.18μs 0.465ns 1.8ns 0.0136 0 0 952 B
#6098 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.506ns 1.96ns 0.0135 0 0 1.02 KB
#6098 CallElasticsearchAsync net472 2.58μs 2.22ns 8.61ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.25μs 1.73ns 6.68ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.58μs 0.64ns 2.31ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.77μs 0.563ns 2.18ns 0.145 0 0 915 B
#6098 ExecuteAsync net6.0 1.23μs 0.412ns 1.54ns 0.0135 0 0 952 B
#6098 ExecuteAsync netcoreapp3.1 1.62μs 0.917ns 3.31ns 0.013 0 0 952 B
#6098 ExecuteAsync net472 1.78μs 0.719ns 2.79ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.15μs 1.65ns 6.19ns 0.0315 0 0 2.22 KB
master SendAsync netcoreapp3.1 4.94μs 2.6ns 10.1ns 0.0371 0 0 2.76 KB
master SendAsync net472 7.76μs 2.44ns 9.45ns 0.498 0 0 3.15 KB
#6098 SendAsync net6.0 4.14μs 1.75ns 6.33ns 0.0309 0 0 2.22 KB
#6098 SendAsync netcoreapp3.1 5.04μs 2.03ns 7.59ns 0.0377 0 0 2.76 KB
#6098 SendAsync net472 7.85μs 0.97ns 3.63ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.44μs 1.37ns 5.13ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.31μs 1.53ns 5.92ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.46μs 0.452ns 1.69ns 0.249 0 0 1.57 KB
#6098 EnrichedLog net6.0 1.51μs 0.665ns 2.49ns 0.0227 0 0 1.64 KB
#6098 EnrichedLog netcoreapp3.1 2.31μs 0.756ns 2.83ns 0.022 0 0 1.64 KB
#6098 EnrichedLog net472 2.54μs 0.632ns 2.36ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 107ns 400ns 0.057 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 118μs 194ns 752ns 0.0588 0 0 4.28 KB
master EnrichedLog net472 147μs 171ns 663ns 0.657 0.219 0 4.46 KB
#6098 EnrichedLog net6.0 114μs 229ns 887ns 0.057 0 0 4.28 KB
#6098 EnrichedLog netcoreapp3.1 119μs 217ns 842ns 0.0592 0 0 4.28 KB
#6098 EnrichedLog net472 146μs 111ns 429ns 0.655 0.218 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.06μs 0.825ns 3.09ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.23μs 1.64ns 5.92ns 0.0295 0 0 2.2 KB
master EnrichedLog net472 5.01μs 1.33ns 5.16ns 0.318 0 0 2.02 KB
#6098 EnrichedLog net6.0 3.04μs 0.889ns 3.44ns 0.0303 0 0 2.2 KB
#6098 EnrichedLog netcoreapp3.1 4.27μs 1.53ns 5.74ns 0.0278 0 0 2.2 KB
#6098 EnrichedLog net472 4.75μs 0.933ns 3.49ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 0.679ns 2.54ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 0.67ns 2.32ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.06μs 1.28ns 4.97ns 0.183 0.00103 0 1.16 KB
#6098 SendReceive net6.0 1.43μs 0.973ns 3.77ns 0.0158 0 0 1.14 KB
#6098 SendReceive netcoreapp3.1 1.77μs 1.42ns 5.51ns 0.0159 0 0 1.14 KB
#6098 SendReceive net472 2.09μs 0.831ns 3.22ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 0.587ns 2.27ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.76μs 3.02ns 11.7ns 0.0223 0 0 1.65 KB
master EnrichedLog net472 4.43μs 2.08ns 8.05ns 0.323 0 0 2.04 KB
#6098 EnrichedLog net6.0 2.84μs 0.753ns 2.92ns 0.0227 0 0 1.6 KB
#6098 EnrichedLog netcoreapp3.1 3.93μs 1.34ns 5.01ns 0.0216 0 0 1.65 KB
#6098 EnrichedLog net472 4.43μs 2.35ns 9.12ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6098

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.115 679.15 757.30

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 398ns 0.267ns 1.03ns 0.00802 0 0 576 B
master StartFinishSpan netcoreapp3.1 615ns 0.632ns 2.45ns 0.00792 0 0 576 B
master StartFinishSpan net472 645ns 0.883ns 3.42ns 0.0916 0 0 578 B
master StartFinishScope net6.0 546ns 0.525ns 2.03ns 0.00979 0 0 696 B
master StartFinishScope netcoreapp3.1 678ns 0.749ns 2.9ns 0.00945 0 0 696 B
master StartFinishScope net472 846ns 2.97ns 11.5ns 0.104 0 0 658 B
#6098 StartFinishSpan net6.0 442ns 0.517ns 2ns 0.00801 0 0 576 B
#6098 StartFinishSpan netcoreapp3.1 600ns 1.02ns 3.95ns 0.00777 0 0 576 B
#6098 StartFinishSpan net472 700ns 0.34ns 1.27ns 0.0916 0 0 578 B
#6098 StartFinishScope net6.0 538ns 0.44ns 1.7ns 0.00966 0 0 696 B
#6098 StartFinishScope netcoreapp3.1 758ns 1.08ns 4.17ns 0.00943 0 0 696 B
#6098 StartFinishScope net472 815ns 0.69ns 2.67ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 737ns 0.465ns 1.8ns 0.00979 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 914ns 1.02ns 3.94ns 0.00916 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.24ns 4.79ns 0.104 0 0 658 B
#6098 RunOnMethodBegin net6.0 721ns 0.46ns 1.78ns 0.0097 0 0 696 B
#6098 RunOnMethodBegin netcoreapp3.1 938ns 0.824ns 3.08ns 0.00937 0 0 696 B
#6098 RunOnMethodBegin net472 1.06μs 1.67ns 6.24ns 0.104 0 0 658 B

@andrewlock

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6098) (11.021M)   : 0, 11020612
    master (10.977M)   : 0, 10977011
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6098) (7.334M)   : 0, 7334153
    master (7.302M)   : 0, 7302144
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.535M)   : 0, 7534644

    section Manual
    master (10.921M)   : 0, 10921042

    section Manual + Automatic
    This PR (6098) (6.726M)   : 0, 6725732
    master (6.804M)   : 0, 6804085

    section DD_TRACE_ENABLED=0
    master (10.206M)   : 0, 10206024

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6098) (9.483M)   : 0, 9483254
    master (9.594M)   : 0, 9593883
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6098) (6.584M)   : 0, 6584164
    master (6.587M)   : 0, 6587124

    section Trace stats
    master (6.704M)   : 0, 6704142

    section Manual
    master (9.365M)   : 0, 9365438

    section Manual + Automatic
    This PR (6098) (6.046M)   : 0, 6045556
    master (6.085M)   : 0, 6084988

    section DD_TRACE_ENABLED=0
    master (8.923M)   : 0, 8922655

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6098) (10.150M)   : 0, 10149887
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6098) (6.748M)   : 0, 6747919
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Manual + Automatic
    This PR (6098) (6.344M)   : 0, 6344278

Loading

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock
andrewlock merged commit b3fc460 into master Sep 30, 2024
@andrewlock
andrewlock deleted the bot/test-package-versions-bump branch September 30, 2024 09:14
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 30, 2024
@andrewlock andrewlock added area:tests unit tests, integration tests area:dependabot dependabot updates area:test-apps apps used to test integrations labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant