[APMAPI-473] Making `DD_HTTP_*_ERROR_STATUSES` Config Keys Consistent by link04 · Pull Request #6095 · DataDog/dd-trace-dotnet

link04 · 2024-09-27T18:29:25Z

Summary of changes

Added the new DD_TRACE_HTTP_SERVER_ERROR_STATUSES & DD_TRACE_HTTP_CLIENT_ERROR_STATUSES config keys and updated telemetry key used as well.
Moved the existing DD_HTTP_SERVER_ERROR_STATUSES & DD_HTTP_CLIENT_ERROR_STATUSES config keys to deprecated.
Tested the outcome of having both keys and that the new one takes precedence.

Test coverage

Added 2 tests to check the outcome of both env vars being set together or by themselves on the existing TracerSettingsTests class with the new ones taking precedence.

Other details

andrewlock · 2024-09-27T19:00:46Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6095) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6095) - mean (1,109ms)  : 1090, 1127
     .   : milestone, 1109,
    master - mean (1,104ms)  : 1073, 1135
     .   : milestone, 1104,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6095) - mean (109ms)  : 105, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6095) - mean (772ms)  : 758, 785
     .   : milestone, 772,
    master - mean (772ms)  : 754, 789
     .   : milestone, 772,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6095) - mean (92ms)  : 89, 96
     .   : milestone, 92,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6095) - mean (734ms)  : 714, 753
     .   : milestone, 734,
    master - mean (732ms)  : 714, 750
     .   : milestone, 732,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6095) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6095) - mean (1,195ms)  : 1173, 1217
     .   : milestone, 1195,
    master - mean (1,199ms)  : 1177, 1222
     .   : milestone, 1199,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6095) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6095) - mean (939ms)  : 919, 959
     .   : milestone, 939,
    master - mean (937ms)  : 921, 953
     .   : milestone, 937,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6095) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6095) - mean (925ms)  : 904, 946
     .   : milestone, 925,
    master - mean (931ms)  : 912, 950
     .   : milestone, 931,

andrewlock · 2024-09-27T21:30:57Z

Benchmarks Report for tracer 🐌

Benchmarks for #6095 compared to master:

1 benchmarks are faster, with geometric mean 1.120
1 benchmarks are slower, with geometric mean 1.133
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.84μs	43.8ns	304ns	0.0165	0.00413	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	54.3ns	326ns	0.0209	0.00523	0	5.61 KB
master	`StartStopWithChild`	net472	16μs	16.6ns	62.1ns	1.01	0.293	0.0952	6.07 KB
#6095	`StartStopWithChild`	net6.0	7.65μs	42.5ns	279ns	0.0152	0.00379	0	5.43 KB
#6095	`StartStopWithChild`	netcoreapp3.1	9.82μs	54.6ns	337ns	0.0143	0.00478	0	5.62 KB
#6095	`StartStopWithChild`	net472	16.1μs	47.9ns	186ns	1.01	0.289	0.0882	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	477μs	247ns	958ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	411ns	1.59μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	839μs	702ns	2.53μs	0.417	3.3 KB
#6095	`WriteAndFlushEnrichedTraces`	net6.0	466μs	407ns	1.52μs	0	2.7 KB
#6095	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	660μs	327ns	1.22μs	0	2.7 KB
#6095	`WriteAndFlushEnrichedTraces`	net472	825μs	562ns	2.18μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	195μs	1.11μs	8.32μs	0.188	18.45 KB
master	`SendRequest`	netcoreapp3.1	217μs	1.24μs	8.92μs	0.201	20.61 KB
master	`SendRequest`	net472	0.00215ns	0.000542ns	0.0021ns	0	0 b
#6095	`SendRequest`	net6.0	193μs	1.11μs	8.85μs	0.186	18.45 KB
#6095	`SendRequest`	netcoreapp3.1	215μs	1.17μs	6.29μs	0.217	20.61 KB
#6095	`SendRequest`	net472	0.00201ns	0.000806ns	0.00301ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	574μs	3.08μs	19μs	0.553	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	687μs	3.21μs	12.4μs	0.343	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	net472	854μs	4.02μs	16.6μs	8.08	2.55	0.425	53.29 KB
#6095	`WriteAndFlushEnrichedTraces`	net6.0	583μs	3.12μs	17.1μs	0.576	0	0	41.76 KB
#6095	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	687μs	2.67μs	9.62μs	0.34	0	0	41.66 KB
#6095	`WriteAndFlushEnrichedTraces`	net472	851μs	4.22μs	17.4μs	8.45	2.53	0.422	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.35μs	1.18ns	4.57ns	0.0144	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.35ns	5.04ns	0.0136	1.02 KB
master	`ExecuteNonQuery`	net472	2.06μs	1.78ns	6.89ns	0.157	987 B
#6095	`ExecuteNonQuery`	net6.0	1.25μs	1.59ns	6.15ns	0.0144	1.02 KB
#6095	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	0.703ns	2.63ns	0.0134	1.02 KB
#6095	`ExecuteNonQuery`	net472	2.09μs	2.14ns	8.3ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.18μs	0.688ns	2.67ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.76ns	6.58ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.47μs	1.39ns	5.2ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.24μs	0.712ns	2.66ns	0.0136	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.498ns	1.93ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	2.68ns	10.4ns	0.166	1.05 KB
#6095	`CallElasticsearch`	net6.0	1.28μs	1.03ns	4ns	0.0134	976 B
#6095	`CallElasticsearch`	netcoreapp3.1	1.47μs	0.664ns	2.57ns	0.0127	976 B
#6095	`CallElasticsearch`	net472	2.52μs	1.41ns	5.45ns	0.157	995 B
#6095	`CallElasticsearchAsync`	net6.0	1.28μs	0.747ns	2.9ns	0.0134	952 B
#6095	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	0.508ns	1.83ns	0.0135	1.02 KB
#6095	`CallElasticsearchAsync`	net472	2.64μs	1.2ns	4.64ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.21μs	0.827ns	3.1ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	4.28ns	16.6ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.75μs	0.692ns	2.68ns	0.145	915 B
#6095	`ExecuteAsync`	net6.0	1.21μs	1.32ns	5.1ns	0.0133	952 B
#6095	`ExecuteAsync`	netcoreapp3.1	1.64μs	1.49ns	5.58ns	0.0131	952 B
#6095	`ExecuteAsync`	net472	1.72μs	1.41ns	5.46ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.19μs	1.31ns	5.07ns	0.0313	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.14μs	2.12ns	7.63ns	0.0359	2.76 KB
master	`SendAsync`	net472	7.78μs	3.22ns	12ns	0.496	3.15 KB
#6095	`SendAsync`	net6.0	4.28μs	2.7ns	10.1ns	0.03	2.22 KB
#6095	`SendAsync`	netcoreapp3.1	5.16μs	2.43ns	9.1ns	0.0364	2.76 KB
#6095	`SendAsync`	net472	7.72μs	4.87ns	18.9ns	0.497	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.528ns	2.04ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.1μs	3.92ns	15.2ns	0.0221	1.64 KB
master	`EnrichedLog`	net472	2.48μs	1.14ns	4.43ns	0.249	1.57 KB
#6095	`EnrichedLog`	net6.0	1.45μs	0.839ns	3.14ns	0.0226	1.64 KB
#6095	`EnrichedLog`	netcoreapp3.1	2.23μs	1.15ns	4.44ns	0.0223	1.64 KB
#6095	`EnrichedLog`	net472	2.5μs	0.824ns	3.19ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	426ns	1.9μs	0.0566	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	316ns	1.22μs	0	0	4.28 KB
master	`EnrichedLog`	net472	148μs	184ns	688ns	0.664	0.221	4.46 KB
#6095	`EnrichedLog`	net6.0	115μs	187ns	723ns	0.0577	0	4.28 KB
#6095	`EnrichedLog`	netcoreapp3.1	118μs	184ns	713ns	0.0589	0	4.28 KB
#6095	`EnrichedLog`	net472	146μs	73.8ns	276ns	0.661	0.22	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.24μs	0.736ns	2.75ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.18μs	1.16ns	4.36ns	0.0293	2.2 KB
master	`EnrichedLog`	net472	4.83μs	1.19ns	4.62ns	0.321	2.02 KB
#6095	`EnrichedLog`	net6.0	3.14μs	1.32ns	4.94ns	0.0318	2.2 KB
#6095	`EnrichedLog`	netcoreapp3.1	4.3μs	2.33ns	9.02ns	0.0303	2.2 KB
#6095	`EnrichedLog`	net472	4.86μs	4.47ns	17.3ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.31μs	0.744ns	2.68ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.78μs	2.19ns	8.5ns	0.0152	0	1.14 KB
master	`SendReceive`	net472	2.19μs	1.04ns	3.75ns	0.183	0.00105	1.16 KB
#6095	`SendReceive`	net6.0	1.41μs	1.43ns	5.52ns	0.0163	0	1.14 KB
#6095	`SendReceive`	netcoreapp3.1	1.76μs	0.921ns	3.57ns	0.015	0	1.14 KB
#6095	`SendReceive`	net472	2.06μs	1.22ns	4.72ns	0.183	0.00103	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.85μs	0.916ns	3.55ns	0.0214	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.01μs	0.984ns	3.68ns	0.022	1.65 KB
master	`EnrichedLog`	net472	4.33μs	2.63ns	9.5ns	0.323	2.04 KB
#6095	`EnrichedLog`	net6.0	2.75μs	0.8ns	3.1ns	0.0222	1.6 KB
#6095	`EnrichedLog`	netcoreapp3.1	3.83μs	1.81ns	7.01ns	0.021	1.65 KB
#6095	`EnrichedLog`	net472	4.43μs	1.21ns	4.67ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6095

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.120	537.67	479.89

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	400ns	0.209ns	0.808ns	0.00795	576 B
master	`StartFinishSpan`	netcoreapp3.1	610ns	0.328ns	1.27ns	0.00792	576 B
master	`StartFinishSpan`	net472	720ns	0.285ns	1.1ns	0.0916	578 B
master	`StartFinishScope`	net6.0	537ns	0.35ns	1.35ns	0.00984	696 B
master	`StartFinishScope`	netcoreapp3.1	752ns	0.407ns	1.58ns	0.0096	696 B
master	`StartFinishScope`	net472	839ns	0.46ns	1.66ns	0.104	658 B
#6095	`StartFinishSpan`	net6.0	391ns	0.0888ns	0.32ns	0.00809	576 B
#6095	`StartFinishSpan`	netcoreapp3.1	605ns	0.194ns	0.726ns	0.00787	576 B
#6095	`StartFinishSpan`	net472	681ns	0.636ns	2.38ns	0.0918	578 B
#6095	`StartFinishScope`	net6.0	480ns	0.15ns	0.562ns	0.00987	696 B
#6095	`StartFinishScope`	netcoreapp3.1	679ns	0.418ns	1.56ns	0.00949	696 B
#6095	`StartFinishScope`	net472	861ns	0.373ns	1.45ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6095

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.133	587.24	665.28

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	587ns	0.183ns	0.707ns	0.00972	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	883ns	0.45ns	1.74ns	0.0093	696 B
master	`RunOnMethodBegin`	net472	1.16μs	0.732ns	2.84ns	0.104	658 B
#6095	`RunOnMethodBegin`	net6.0	666ns	0.215ns	0.805ns	0.0097	696 B
#6095	`RunOnMethodBegin`	netcoreapp3.1	940ns	1.35ns	5.21ns	0.00938	696 B
#6095	`RunOnMethodBegin`	net472	1.09μs	0.643ns	2.49ns	0.104	658 B

andrewlock · 2024-09-27T21:43:12Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6095) (10.989M)   : 0, 10988793
    master (11.010M)   : 0, 11009750
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6095) (7.279M)   : 0, 7278552
    master (7.342M)   : 0, 7341764
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.612M)   : 0, 7611509

    section Manual
    master (11.036M)   : 0, 11035988

    section Manual + Automatic
    This PR (6095) (6.787M)   : 0, 6786865
    master (6.787M)   : 0, 6786622

    section DD_TRACE_ENABLED=0
    master (10.197M)   : 0, 10197476

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6095) (9.497M)   : 0, 9497088
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6095) (6.621M)   : 0, 6620737

    section Manual + Automatic
    This PR (6095) (6.128M)   : 0, 6127997

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6095) (10.387M)   : 0, 10386680
    master (9.928M)   : 0, 9927889
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6095) (6.590M)   : 0, 6590068
    master (6.677M)   : 0, 6676729
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.399M)   : 0, 7399205

    section Manual
    master (10.064M)   : 0, 10063510

    section Manual + Automatic
    This PR (6095) (6.126M)   : 0, 6125711
    master (6.276M)   : 0, 6276469

    section DD_TRACE_ENABLED=0
    master (9.331M)   : 0, 9330779

bouwkast

Looks good, just some test nitpicks

bouwkast · 2024-09-30T15:02:32Z

        public HttpMessageHandlerTests(ITestOutputHelper output)
            : base("HttpMessageHandler", output)
        {
-            SetEnvironmentVariable("DD_HTTP_CLIENT_ERROR_STATUSES", "400-499, 502,-343,11-53, 500-500-200");


Wondering if we should still have integration tests for the deprecated ones to validate that they do still work?

(but if I recall this test suite is quite large)

Yeah since the change was only to the name I hoped adding the test for asserting the precedence was enough since they check for the ranges in other tests too: https://github.com/DataDog/dd-trace-dotnet/blob/7fa9adde56eb12badda28c82929e7f14d56b8d82/tracer/test/Datadog.Trace.Tests/Configuration/TracerSettingsTests.cs

Since we are not deprecating the env var I can leave it there in that line for testing porpuses.

link04 and others added 2 commits September 27, 2024 14:19

Updating both config names everywhere and testing

154ac9b

Merge branch 'master' into maximo/renaming-inconsistent-configs

d59e45f

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

Adding new env vars instead of removing old

7fa9add

DataDog deleted a comment from datadog-ddstaging Bot Sep 27, 2024

link04 marked this pull request as ready for review September 30, 2024 14:23

link04 requested review from a team as code owners September 30, 2024 14:23

bouwkast approved these changes Sep 30, 2024

View reviewed changes

link04 added 2 commits October 3, 2024 19:10

Addressing nits and improving tests

416297a

Merge branch 'master' into maximo/renaming-inconsistent-configs

f333ffa

link04 merged commit d07f1ce into master Oct 4, 2024

link04 deleted the maximo/renaming-inconsistent-configs branch October 4, 2024 16:20

github-actions Bot added this to the vNext-v3 milestone Oct 4, 2024

andrewlock added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 23, 2024

Uh oh!

Conversation

link04 commented Sep 27, 2024

Summary of changes

Test coverage

Other details

Uh oh!

andrewlock commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

andrewlock commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6095

Raw results

Slower ⚠️ in #6095

Raw results

Uh oh!

andrewlock commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throughput/Crank Report ⚡

Uh oh!

bouwkast left a comment

Choose a reason for hiding this comment

Uh oh!

bouwkast Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

bouwkast Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

link04 Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewlock commented Sep 27, 2024 •

edited

Loading

andrewlock commented Sep 27, 2024 •

edited

Loading

andrewlock commented Sep 27, 2024 •

edited

Loading

link04 Sep 30, 2024 •

edited

Loading