Skip to content

[CI Visibility] Hide running command by default.#6086

Merged
tonyredondo merged 1 commit into
masterfrom
tony/civisibility-hide-running-commandline-by-default
Sep 26, 2024
Merged

[CI Visibility] Hide running command by default.#6086
tonyredondo merged 1 commit into
masterfrom
tony/civisibility-hide-running-commandline-by-default

Conversation

@tonyredondo

@tonyredondo tonyredondo commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

This PR hides the Running: ... message from the stdout by default (available if we run it in debug mode). Also changes the method used to output the message from Spectre.Console to Console

Reason for change

This should fix: https://datadoghq.atlassian.net/browse/APMS-13380

Notes:

  • The CI filter is not kicking in probably because the way AnsiConsole.WriteLine handles the output, changing it to Console.WriteLine should fix the CI filter.
  • We don't have an strong reason to print the Running... message so we can just leave it for debug mode, hiding the output as default.

Implementation details

  • Print the message only if DD_TRACE_DEBUG=true
  • Change AnsiConsole.WriteLine with Console.WriteLine

@tonyredondo
tonyredondo requested a review from a team as a code owner September 26, 2024 11:18
@tonyredondo tonyredondo self-assigned this Sep 26, 2024
andrewlock
andrewlock reviewed Sep 26, 2024
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have an strong reason to print the Running... message

It's not a strong reason, but I've found it very useful when I screwed something up...

As for replacing just this one argument... I wonder if we need to have a closer look into Spectre.Console and see if we can fix the cause etc, because this is a bit concerning...

@andrewlock

andrewlock commented Sep 26, 2024

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6086) - mean (71ms)  : 68, 75
     .   : milestone, 71,
    master - mean (78ms)  : 69, 87
     .   : milestone, 78,

    section CallTarget+Inlining+NGEN
    This PR (6086) - mean (1,107ms)  : 1078, 1136
     .   : milestone, 1107,
    master - mean (1,148ms)  : 1123, 1174
     .   : milestone, 1148,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6086) - mean (111ms)  : 106, 115
     .   : milestone, 111,
    master - mean (117ms)  : 106, 127
     .   : milestone, 117,

    section CallTarget+Inlining+NGEN
    This PR (6086) - mean (777ms)  : 759, 795
     .   : milestone, 777,
    master - mean (816ms)  : 797, 834
     .   : milestone, 816,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6086) - mean (94ms)  : 89, 98
     .   : milestone, 94,
    master - mean (100ms)  : 94, 106
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (6086) - mean (740ms)  : 718, 763
     .   : milestone, 740,
    master - mean (766ms)  : 735, 797
     .   : milestone, 766,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6086) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6086) - mean (1,192ms)  : 1170, 1215
     .   : milestone, 1192,
    master - mean (1,193ms)  : 1171, 1215
     .   : milestone, 1193,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6086) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 279
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6086) - mean (940ms)  : 922, 957
     .   : milestone, 940,
    master - mean (942ms)  : 923, 960
     .   : milestone, 942,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6086) - mean (265ms)  : 260, 269
     .   : milestone, 265,
    master - mean (264ms)  : 261, 267
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6086) - mean (927ms)  : 907, 946
     .   : milestone, 927,
    master - mean (928ms)  : 910, 946
     .   : milestone, 928,
Loading

@datadog-ddstaging

datadog-ddstaging Bot commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: tony/civisibility-hide-running-commandline-by-default
Commit report: 4e0d131
Test service: dd-trace-dotnet

✅ 0 Failed, 365954 Passed, 2079 Skipped, 15h 24m 46.07s Total Time

@tonyredondo

tonyredondo commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

We don't have an strong reason to print the Running... message

It's not a strong reason, but I've found it very useful when I screwed something up...

As for replacing just this one argument... I wonder if we need to have a closer look into Spectre.Console and see if we can fix the cause etc, because this is a bit concerning...

Sadly there's no solution right now:

@andrewlock

andrewlock commented Sep 26, 2024

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6086) (11.010M)   : 0, 11009720
    master (11.031M)   : 0, 11030770
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6086) (7.262M)   : 0, 7261761
    master (7.287M)   : 0, 7286559
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.697M)   : 0, 7696608

    section Manual
    master (11.084M)   : 0, 11083839

    section Manual + Automatic
    This PR (6086) (6.817M)   : 0, 6816727
    master (6.821M)   : 0, 6821015

    section DD_TRACE_ENABLED=0
    master (10.243M)   : 0, 10243116
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6086) (9.153M)   : 0, 9153232
    master (9.514M)   : 0, 9514330
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6086) (6.537M)   : 0, 6537447
    master (6.630M)   : 0, 6629847

    section Trace stats
    master (6.750M)   : 0, 6749832

    section Manual
    master (9.657M)   : 0, 9657097

    section Manual + Automatic
    This PR (6086) (6.091M)   : 0, 6091016
    master (5.882M)   : 0, 5881704

    section DD_TRACE_ENABLED=0
    master (8.860M)   : 0, 8860464
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6086) (8.038M)   : 0, 8038237
    master (10.111M)   : 0, 10110593
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6086) (6.725M)   : 0, 6724649
    master (6.720M)   : 0, 6720265
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.385M)   : 0, 7384835

    section Manual
    master (10.056M)   : 0, 10056146

    section Manual + Automatic
    This PR (6086) (6.198M)   : 0, 6197548
    master (6.271M)   : 0, 6270956

    section DD_TRACE_ENABLED=0
    master (9.426M)   : 0, 9425661
Loading

@andrewlock

andrewlock commented Sep 26, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6086 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.116
  • 2 benchmarks are slower, with geometric mean 1.158
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.78μs 44.7ns 334ns 0.011 0.00368 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.77μs 48.9ns 219ns 0.0146 0.00975 0 5.62 KB
master StartStopWithChild net472 15.9μs 52.3ns 202ns 1.02 0.3 0.0948 6.06 KB
#6086 StartStopWithChild net6.0 7.53μs 40.2ns 224ns 0.0118 0.00393 0 5.43 KB
#6086 StartStopWithChild netcoreapp3.1 9.78μs 54.3ns 326ns 0.014 0.00467 0 5.62 KB
#6086 StartStopWithChild net472 16.1μs 42.8ns 166ns 1.01 0.294 0.0897 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 473μs 380ns 1.47μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 1.5μs 5.8μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 835μs 360ns 1.3μs 0.417 0 0 3.3 KB
#6086 WriteAndFlushEnrichedTraces net6.0 477μs 381ns 1.48μs 0 0 0 2.7 KB
#6086 WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 359ns 1.34μs 0 0 0 2.7 KB
#6086 WriteAndFlushEnrichedTraces net472 837μs 544ns 2.11μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 201μs 1.17μs 10.4μs 0.197 0 0 18.45 KB
master SendRequest netcoreapp3.1 214μs 1.07μs 4.66μs 0.214 0 0 20.61 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#6086 SendRequest net6.0 195μs 1.08μs 6.73μs 0.189 0 0 18.45 KB
#6086 SendRequest netcoreapp3.1 215μs 1.2μs 7.51μs 0.22 0 0 20.61 KB
#6086 SendRequest net472 0.00103ns 0.000502ns 0.00188ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6086

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.62 KB 41.36 KB -253 B -0.61%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 575μs 1.45μs 5.03μs 0.566 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.74μs 6.53μs 0.336 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 856μs 3.26μs 12.2μs 8.45 2.53 0.422 53.29 KB
#6086 WriteAndFlushEnrichedTraces net6.0 581μs 1.01μs 3.51μs 0.604 0 0 41.36 KB
#6086 WriteAndFlushEnrichedTraces netcoreapp3.1 699μs 3.36μs 13.4μs 0.345 0 0 41.84 KB
#6086 WriteAndFlushEnrichedTraces net472 871μs 3μs 11.6μs 8.3 2.62 0.437 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.22μs 0.904ns 3.38ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 0.997ns 3.86ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.03μs 1.27ns 4.74ns 0.157 0 0 987 B
#6086 ExecuteNonQuery net6.0 1.19μs 1.15ns 4.46ns 0.0144 0 0 1.02 KB
#6086 ExecuteNonQuery netcoreapp3.1 1.74μs 1.24ns 4.82ns 0.0139 0 0 1.02 KB
#6086 ExecuteNonQuery net472 2.19μs 1.77ns 6.63ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.12μs 0.704ns 2.63ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.62μs 0.691ns 2.49ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.5μs 0.986ns 3.82ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 1.09ns 4.23ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.58μs 0.751ns 2.81ns 0.0142 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 3.68ns 13.8ns 0.166 0 0 1.05 KB
#6086 CallElasticsearch net6.0 1.16μs 0.748ns 2.8ns 0.0139 0 0 976 B
#6086 CallElasticsearch netcoreapp3.1 1.58μs 0.524ns 1.89ns 0.0134 0 0 976 B
#6086 CallElasticsearch net472 2.44μs 1.25ns 4.68ns 0.157 0 0 995 B
#6086 CallElasticsearchAsync net6.0 1.27μs 1.02ns 3.96ns 0.0133 0 0 952 B
#6086 CallElasticsearchAsync netcoreapp3.1 1.71μs 0.793ns 3.07ns 0.0134 0 0 1.02 KB
#6086 CallElasticsearchAsync net472 2.6μs 2.62ns 10.1ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6086

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 1.174 1,501.23 1,762.91

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.374ns 1.4ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.5μs 0.847ns 3.17ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.82μs 0.667ns 2.58ns 0.145 0 0 915 B
#6086 ExecuteAsync net6.0 1.24μs 0.894ns 3.46ns 0.0131 0 0 952 B
#6086 ExecuteAsync netcoreapp3.1 1.77μs 1.63ns 6.33ns 0.0131 0 0 952 B
#6086 ExecuteAsync net472 1.79μs 2.14ns 8.27ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.16μs 1.95ns 7.02ns 0.0313 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.17μs 3.33ns 12.9ns 0.0362 0 0 2.76 KB
master SendAsync net472 7.87μs 1.98ns 7.68ns 0.497 0 0 3.15 KB
#6086 SendAsync net6.0 4.12μs 1.56ns 5.83ns 0.0308 0 0 2.22 KB
#6086 SendAsync netcoreapp3.1 5.09μs 1.74ns 6.52ns 0.038 0 0 2.76 KB
#6086 SendAsync net472 7.73μs 10.3ns 40.1ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.976ns 3.65ns 0.0234 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.3μs 1.11ns 4.17ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.63μs 0.546ns 1.97ns 0.249 0 0 1.57 KB
#6086 EnrichedLog net6.0 1.59μs 0.81ns 2.92ns 0.0226 0 0 1.64 KB
#6086 EnrichedLog netcoreapp3.1 2.16μs 1.76ns 6.6ns 0.0226 0 0 1.64 KB
#6086 EnrichedLog net472 2.63μs 0.66ns 2.55ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 171ns 664ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 208ns 805ns 0 0 0 4.28 KB
master EnrichedLog net472 146μs 50.2ns 188ns 0.655 0.218 0 4.46 KB
#6086 EnrichedLog net6.0 114μs 190ns 737ns 0.0573 0 0 4.28 KB
#6086 EnrichedLog netcoreapp3.1 118μs 158ns 612ns 0.0591 0 0 4.28 KB
#6086 EnrichedLog net472 148μs 253ns 981ns 0.662 0.221 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.16μs 1.05ns 3.93ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.37μs 9.63ns 36ns 0.0302 0 0 2.2 KB
master EnrichedLog net472 4.67μs 1.12ns 4.35ns 0.32 0 0 2.02 KB
#6086 EnrichedLog net6.0 3.15μs 0.719ns 2.69ns 0.0316 0 0 2.2 KB
#6086 EnrichedLog netcoreapp3.1 4.15μs 1.57ns 6.08ns 0.029 0 0 2.2 KB
#6086 EnrichedLog net472 4.91μs 1.13ns 4.39ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 0.468ns 1.75ns 0.0156 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.74μs 0.722ns 2.7ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.16μs 1.77ns 6.85ns 0.183 0 0 1.16 KB
#6086 SendReceive net6.0 1.26μs 0.798ns 2.98ns 0.0158 0 0 1.14 KB
#6086 SendReceive netcoreapp3.1 1.69μs 1.99ns 7.7ns 0.0151 0 0 1.14 KB
#6086 SendReceive net472 2.06μs 0.594ns 2.22ns 0.183 0.00103 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.87μs 1.18ns 4.41ns 0.023 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 1.12ns 3.87ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.25μs 2.39ns 9.27ns 0.324 0 0 2.04 KB
#6086 EnrichedLog net6.0 2.75μs 0.847ns 3.28ns 0.0221 0 0 1.6 KB
#6086 EnrichedLog netcoreapp3.1 3.89μs 2.04ns 7.89ns 0.0213 0 0 1.65 KB
#6086 EnrichedLog net472 4.4μs 1.94ns 7.52ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6086

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.116 453.33 406.28

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 453ns 0.326ns 1.26ns 0.00794 0 0 576 B
master StartFinishSpan netcoreapp3.1 589ns 0.53ns 2.05ns 0.00773 0 0 576 B
master StartFinishSpan net472 651ns 0.872ns 3.38ns 0.0917 0 0 578 B
master StartFinishScope net6.0 527ns 0.304ns 1.18ns 0.00979 0 0 696 B
master StartFinishScope netcoreapp3.1 713ns 0.463ns 1.79ns 0.00946 0 0 696 B
master StartFinishScope net472 890ns 1.11ns 4.29ns 0.105 0 0 658 B
#6086 StartFinishSpan net6.0 406ns 0.319ns 1.15ns 0.0081 0 0 576 B
#6086 StartFinishSpan netcoreapp3.1 571ns 0.696ns 2.7ns 0.00776 0 0 576 B
#6086 StartFinishSpan net472 710ns 0.264ns 1.02ns 0.0915 0 0 578 B
#6086 StartFinishScope net6.0 515ns 0.254ns 0.984ns 0.00987 0 0 696 B
#6086 StartFinishScope netcoreapp3.1 743ns 0.791ns 3.06ns 0.00931 0 0 696 B
#6086 StartFinishScope net472 907ns 1.15ns 4.46ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6086

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.142 867.56 990.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 739ns 0.67ns 2.59ns 0.00963 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 868ns 0.742ns 2.87ns 0.0094 0 0 696 B
master RunOnMethodBegin net472 1.11μs 1.07ns 3.86ns 0.104 0 0 658 B
#6086 RunOnMethodBegin net6.0 678ns 0.301ns 1.17ns 0.00987 0 0 696 B
#6086 RunOnMethodBegin netcoreapp3.1 990ns 0.413ns 1.6ns 0.00953 0 0 696 B
#6086 RunOnMethodBegin net472 1.13μs 0.435ns 1.68ns 0.104 0 0 658 B

@tonyredondo
tonyredondo merged commit 6903dee into master Sep 26, 2024
@tonyredondo
tonyredondo deleted the tony/civisibility-hide-running-commandline-by-default branch September 26, 2024 14:11
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

@tonyredondo tonyredondo

Labels

area:ci-visibility identified-by:customer

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tonyredondo @andrewlock