Skip to content

[TESTING] Fix missing snapshot#6066

Merged
dromanol merged 1 commit into
masterfrom
dani/iast/fix_netcore2_snapshot
Sep 24, 2024
Merged

[TESTING] Fix missing snapshot#6066
dromanol merged 1 commit into
masterfrom
dani/iast/fix_netcore2_snapshot

Conversation

@dromanol

@dromanol dromanol commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

Added missing snapshot modification for netcore 2

Reason for change

Implementation details

Test coverage

Other details

@dromanol
dromanol requested a review from a team as a code owner September 24, 2024 08:22
@dromanol dromanol added area:tests unit tests, integration tests area:asm-iast labels Sep 24, 2024
@github-actions

github-actions Bot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

-      "hash": -1837181716,
+      "hash": -636226626,
[...]
-      "hash": 1990393425,
+      "hash": -60481650,
[...]
-      "hash": 1170867602,
+      "hash": 990913114,
[...]
-      "hash": -1837181716,
+      "hash": -636226626,
[...]
-      "hash": 1990393425,
+      "hash": -60481650,
[...]
-      "hash": 1170867602,
+      "hash": 990913114,
[...]
-      "hash": -1837181716,
+      "hash": -636226626,
[...]
-      "hash": 1990393425,
+      "hash": -60481650,
[...]
-      "hash": 1170867602,
+      "hash": 990913114,

@datadog-ddstaging

datadog-ddstaging Bot commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: dani/iast/fix_netcore2_snapshot
Commit report: 79cd672
Test service: dd-trace-dotnet

✅ 0 Failed, 366186 Passed, 2064 Skipped, 15h 21m 39.09s Total Time

@andrewlock

andrewlock commented Sep 24, 2024

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6066) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6066) - mean (1,099ms)  : 1075, 1123
     .   : milestone, 1099,
    master - mean (1,105ms)  : 1067, 1143
     .   : milestone, 1105,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6066) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6066) - mean (769ms)  : 756, 782
     .   : milestone, 769,
    master - mean (766ms)  : 751, 782
     .   : milestone, 766,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6066) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6066) - mean (723ms)  : 708, 738
     .   : milestone, 723,
    master - mean (727ms)  : 707, 747
     .   : milestone, 727,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6066) - mean (191ms)  : 188, 193
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6066) - mean (1,195ms)  : 1172, 1218
     .   : milestone, 1195,
    master - mean (1,202ms)  : 1165, 1240
     .   : milestone, 1202,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6066) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6066) - mean (936ms)  : 914, 958
     .   : milestone, 936,
    master - mean (938ms)  : 918, 958
     .   : milestone, 938,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6066) - mean (264ms)  : 258, 270
     .   : milestone, 264,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6066) - mean (922ms)  : 901, 942
     .   : milestone, 922,
    master - mean (922ms)  : 906, 939
     .   : milestone, 922,
Loading

@andrewlock

andrewlock commented Sep 24, 2024

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6066) (10.722M)   : 0, 10722253
    master (11.101M)   : 0, 11101013
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6066) (7.267M)   : 0, 7266683
    master (7.322M)   : 0, 7321945
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.648M)   : 0, 7647979

    section Manual
    master (11.159M)   : 0, 11158874

    section Manual + Automatic
    This PR (6066) (6.692M)   : 0, 6692084
    master (6.756M)   : 0, 6755889

    section DD_TRACE_ENABLED=0
    master (10.104M)   : 0, 10103630
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6066) (9.549M)   : 0, 9548744
    master (9.538M)   : 0, 9538166
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6066) (6.548M)   : 0, 6547658
    master (6.560M)   : 0, 6559669

    section Trace stats
    master (6.899M)   : 0, 6898524

    section Manual
    master (9.530M)   : 0, 9529944

    section Manual + Automatic
    This PR (6066) (5.985M)   : 0, 5985423
    master (6.111M)   : 0, 6111240

    section DD_TRACE_ENABLED=0
    master (8.837M)   : 0, 8836832
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6066) (10.114M)   : 0, 10114098
    master (10.017M)   : 0, 10017307
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6066) (6.842M)   : 0, 6842082
    master (6.715M)   : 0, 6715040
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.357M)   : 0, 7357178

    section Manual
    master (9.959M)   : 0, 9958707

    section Manual + Automatic
    This PR (6066) (6.199M)   : 0, 6198912
    master (6.139M)   : 0, 6139159

    section DD_TRACE_ENABLED=0
    master (9.384M)   : 0, 9383899
Loading

@andrewlock

andrewlock commented Sep 24, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6066 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.116
  • 2 benchmarks are slower, with geometric mean 1.148
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.88μs 43.3ns 256ns 0.0162 0.00812 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.88μs 55.7ns 390ns 0.0189 0.00945 0 5.61 KB
master StartStopWithChild net472 15.8μs 52.8ns 205ns 1.02 0.3 0.103 6.07 KB
#6066 StartStopWithChild net6.0 7.77μs 43.8ns 284ns 0.0151 0.00756 0 5.42 KB
#6066 StartStopWithChild netcoreapp3.1 9.78μs 55.9ns 411ns 0.019 0.00949 0 5.62 KB
#6066 StartStopWithChild net472 16μs 45.6ns 177ns 1.03 0.294 0.0874 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 484μs 485ns 1.88μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 417ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 835μs 498ns 1.93μs 0.417 0 0 3.3 KB
#6066 WriteAndFlushEnrichedTraces net6.0 485μs 212ns 820ns 0 0 0 2.7 KB
#6066 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 234ns 876ns 0 0 0 2.7 KB
#6066 WriteAndFlushEnrichedTraces net472 830μs 603ns 2.34μs 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 207μs 1.21μs 11.1μs 0.202 0 0 18.45 KB
master SendRequest netcoreapp3.1 237μs 1.35μs 9.76μs 0.215 0 0 20.61 KB
master SendRequest net472 0.00304ns 0.00115ns 0.00444ns 0 0 0 0 b
#6066 SendRequest net6.0 209μs 1.19μs 8.91μs 0.198 0 0 18.45 KB
#6066 SendRequest netcoreapp3.1 227μs 1.28μs 9.25μs 0.223 0 0 20.61 KB
#6066 SendRequest net472 0.00127ns 0.000536ns 0.00208ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6066

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.57 KB 41.84 KB 269 B 0.65%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.64 KB 41.89 KB 255 B 0.61%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 577μs 3.1μs 17.8μs 0.566 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.28μs 14.3μs 0.347 0 0 41.64 KB
master WriteAndFlushEnrichedTraces net472 875μs 3.4μs 12.7μs 8.09 2.25 0.45 53.33 KB
#6066 WriteAndFlushEnrichedTraces net6.0 583μs 2.91μs 12.3μs 0.576 0 0 41.84 KB
#6066 WriteAndFlushEnrichedTraces netcoreapp3.1 707μs 3.28μs 12.3μs 0.343 0 0 41.89 KB
#6066 WriteAndFlushEnrichedTraces net472 869μs 3.71μs 14.4μs 8.19 2.59 0.431 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.34μs 1.32ns 4.95ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.13ns 4.39ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.13μs 2.16ns 8.36ns 0.156 0 0 987 B
#6066 ExecuteNonQuery net6.0 1.37μs 2.01ns 7.23ns 0.0143 0 0 1.02 KB
#6066 ExecuteNonQuery netcoreapp3.1 1.78μs 1.74ns 6.73ns 0.0134 0 0 1.02 KB
#6066 ExecuteNonQuery net472 1.99μs 2.15ns 8.33ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6066

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.173 1,174.70 1,378.04

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 3.91ns 14.6ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.53μs 0.951ns 3.56ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.46μs 1.66ns 6.41ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.17μs 1.32ns 4.93ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 0.823ns 3.08ns 0.0134 0 0 1.02 KB
master CallElasticsearchAsync net472 2.55μs 1.79ns 6.95ns 0.166 0 0 1.05 KB
#6066 CallElasticsearch net6.0 1.13μs 2.1ns 7.58ns 0.0135 0 0 976 B
#6066 CallElasticsearch netcoreapp3.1 1.61μs 0.449ns 1.74ns 0.0132 0 0 976 B
#6066 CallElasticsearch net472 2.54μs 1.23ns 4.75ns 0.158 0 0 995 B
#6066 CallElasticsearchAsync net6.0 1.38μs 0.895ns 3.35ns 0.013 0 0 952 B
#6066 CallElasticsearchAsync netcoreapp3.1 1.58μs 0.423ns 1.64ns 0.0142 0 0 1.02 KB
#6066 CallElasticsearchAsync net472 2.59μs 2.59ns 10ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.23μs 0.572ns 2.14ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 2.86ns 11.1ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.81μs 0.978ns 3.79ns 0.145 0 0 915 B
#6066 ExecuteAsync net6.0 1.26μs 0.594ns 2.22ns 0.0131 0 0 952 B
#6066 ExecuteAsync netcoreapp3.1 1.65μs 0.886ns 3.43ns 0.0131 0 0 952 B
#6066 ExecuteAsync net472 1.81μs 0.653ns 2.53ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.26μs 1.23ns 4.6ns 0.0298 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.07μs 4.13ns 16ns 0.0354 0 0 2.76 KB
master SendAsync net472 7.85μs 1.34ns 5.2ns 0.497 0 0 3.15 KB
#6066 SendAsync net6.0 4.19μs 2.25ns 8.72ns 0.0314 0 0 2.22 KB
#6066 SendAsync netcoreapp3.1 4.98μs 4.11ns 15.9ns 0.0349 0 0 2.76 KB
#6066 SendAsync net472 7.72μs 1.59ns 6.16ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 0.743ns 2.88ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.2μs 1.15ns 4.46ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.6μs 1.54ns 5.96ns 0.249 0 0 1.57 KB
#6066 EnrichedLog net6.0 1.46μs 4.61ns 17.9ns 0.023 0 0 1.64 KB
#6066 EnrichedLog netcoreapp3.1 2.27μs 1.56ns 5.84ns 0.0224 0 0 1.64 KB
#6066 EnrichedLog net472 2.55μs 1.77ns 6.84ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 120ns 464ns 0.0566 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 106ns 411ns 0.0598 0 0 4.28 KB
master EnrichedLog net472 145μs 67.6ns 244ns 0.656 0.219 0 4.46 KB
#6066 EnrichedLog net6.0 113μs 166ns 641ns 0.0563 0 0 4.28 KB
#6066 EnrichedLog netcoreapp3.1 118μs 154ns 598ns 0 0 0 4.28 KB
#6066 EnrichedLog net472 146μs 133ns 514ns 0.651 0.217 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.09μs 0.928ns 3.59ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.41μs 1.9ns 7.37ns 0.0287 0 0 2.2 KB
master EnrichedLog net472 4.81μs 1.3ns 4.85ns 0.32 0 0 2.02 KB
#6066 EnrichedLog net6.0 3.02μs 1.04ns 4.01ns 0.0303 0 0 2.2 KB
#6066 EnrichedLog netcoreapp3.1 4.4μs 0.936ns 3.63ns 0.0301 0 0 2.2 KB
#6066 EnrichedLog net472 4.91μs 1.62ns 6.26ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 0.7ns 2.62ns 0.0156 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 1.22ns 4.58ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.17μs 1.16ns 4.32ns 0.183 0.00109 0 1.16 KB
#6066 SendReceive net6.0 1.37μs 0.538ns 2.08ns 0.0158 0 0 1.14 KB
#6066 SendReceive netcoreapp3.1 1.79μs 0.977ns 3.78ns 0.0154 0 0 1.14 KB
#6066 SendReceive net472 2.11μs 0.88ns 3.41ns 0.183 0.00101 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 10.3ns 40.1ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.77μs 1.36ns 5.08ns 0.0209 0 0 1.65 KB
master EnrichedLog net472 4.33μs 1.67ns 6.46ns 0.323 0 0 2.04 KB
#6066 EnrichedLog net6.0 2.73μs 7.77ns 29.1ns 0.0216 0 0 1.6 KB
#6066 EnrichedLog netcoreapp3.1 3.86μs 2.64ns 10.2ns 0.0214 0 0 1.65 KB
#6066 EnrichedLog net472 4.36μs 1.3ns 4.88ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6066

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.123 477.11 535.99

Faster 🎉 in #6066

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.116 758.39 679.49

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 407ns 0.361ns 1.4ns 0.00818 0 0 576 B
master StartFinishSpan netcoreapp3.1 594ns 1.01ns 3.93ns 0.00798 0 0 576 B
master StartFinishSpan net472 654ns 1.56ns 5.84ns 0.0917 0 0 578 B
master StartFinishScope net6.0 477ns 0.235ns 0.911ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 759ns 1.06ns 4.09ns 0.00938 0 0 696 B
master StartFinishScope net472 888ns 1.04ns 4.01ns 0.105 0 0 658 B
#6066 StartFinishSpan net6.0 398ns 0.397ns 1.49ns 0.00801 0 0 576 B
#6066 StartFinishSpan netcoreapp3.1 609ns 0.244ns 0.943ns 0.00789 0 0 576 B
#6066 StartFinishSpan net472 646ns 0.652ns 2.53ns 0.0917 0 0 578 B
#6066 StartFinishScope net6.0 536ns 0.397ns 1.54ns 0.0097 0 0 696 B
#6066 StartFinishScope netcoreapp3.1 679ns 0.523ns 2.03ns 0.00966 0 0 696 B
#6066 StartFinishScope net472 841ns 1.03ns 4.01ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 676ns 0.514ns 1.99ns 0.00988 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 982ns 0.697ns 2.61ns 0.00936 0 0 696 B
master RunOnMethodBegin net472 1.11μs 0.875ns 3.39ns 0.105 0 0 658 B
#6066 RunOnMethodBegin net6.0 681ns 0.611ns 2.36ns 0.00984 0 0 696 B
#6066 RunOnMethodBegin netcoreapp3.1 938ns 0.97ns 3.75ns 0.00942 0 0 696 B
#6066 RunOnMethodBegin net472 1.11μs 1.21ns 4.7ns 0.105 0 0 658 B

@dromanol
dromanol merged commit 009918f into master Sep 24, 2024
@dromanol
dromanol deleted the dani/iast/fix_netcore2_snapshot branch September 24, 2024 12:45
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anna-git anna-git anna-git approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:asm-iast area:tests unit tests, integration tests

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dromanol @andrewlock @anna-git