Ignore more processes by andrewlock · Pull Request #6065 · DataDog/dd-trace-dotnet

andrewlock · 2024-09-24T07:47:04Z

Summary of changes

Ignore some more processes there's no value in instrumenting

Reason for change

There's no value in instrumenting them

Implementation details

Add to the ignore list

Test coverage

Meh

Other details

We explicitly ignore a bunch of processes in our testing code...

dd-trace-dotnet/tracer/test/Datadog.Trace.TestHelpers/EnvironmentHelper.cs

Line 292 in cc814d2

    
           "ServiceHub.DataWarehouseHost.exe;sqlservr.exe;VBCSCompiler.exe;iisexpresstray.exe;msvsmon.exe;PerfWatson2.exe;" +

Is there a good reason we don't always ignore them? 🤔

andrewlock · 2024-09-24T08:18:27Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6065) - mean (71ms)  : 67, 75
     .   : milestone, 71,
    master - mean (71ms)  : 68, 73
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6065) - mean (1,111ms)  : 1088, 1133
     .   : milestone, 1111,
    master - mean (1,108ms)  : 1088, 1129
     .   : milestone, 1108,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6065) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6065) - mean (774ms)  : 756, 793
     .   : milestone, 774,
    master - mean (773ms)  : 759, 787
     .   : milestone, 773,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6065) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6065) - mean (733ms)  : 715, 751
     .   : milestone, 733,
    master - mean (752ms)  : 674, 829
     .   : milestone, 752,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6065) - mean (192ms)  : 189, 194
     .   : milestone, 192,
    master - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6065) - mean (1,200ms)  : 1180, 1220
     .   : milestone, 1200,
    master - mean (1,200ms)  : 1178, 1223
     .   : milestone, 1200,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6065) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (278ms)  : 274, 281
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6065) - mean (948ms)  : 929, 966
     .   : milestone, 948,
    master - mean (946ms)  : 926, 966
     .   : milestone, 946,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6065) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (267ms)  : 261, 273
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6065) - mean (927ms)  : 903, 950
     .   : milestone, 927,
    master - mean (930ms)  : 910, 950
     .   : milestone, 930,

andrewlock · 2024-09-24T08:47:06Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6065) (11.107M)   : 0, 11106688
    master (11.146M)   : 0, 11146375
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6065) (7.369M)   : 0, 7368656
    master (7.463M)   : 0, 7462675
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.693M)   : 0, 7692522

    section Manual
    master (11.106M)   : 0, 11105764

    section Manual + Automatic
    This PR (6065) (6.812M)   : 0, 6812365
    master (6.896M)   : 0, 6895861

    section DD_TRACE_ENABLED=0
    master (10.237M)   : 0, 10237246

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6065) (9.758M)   : 0, 9758211
    master (9.651M)   : 0, 9651362
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6065) (6.680M)   : 0, 6680270
    master (6.660M)   : 0, 6660101

    section Trace stats
    master (6.770M)   : 0, 6770482

    section Manual
    master (9.625M)   : 0, 9625167

    section Manual + Automatic
    This PR (6065) (6.121M)   : 0, 6121457
    master (6.281M)   : 0, 6280721

    section DD_TRACE_ENABLED=0
    master (8.820M)   : 0, 8819826

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6065) (10.423M)   : 0, 10423051
    master (10.127M)   : 0, 10126710
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6065) (6.806M)   : 0, 6806109
    master (6.586M)   : 0, 6586437
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.339M)   : 0, 7339125

    section Manual
    master (10.053M)   : 0, 10053372

    section Manual + Automatic
    This PR (6065) (6.400M)   : 0, 6400313
    master (6.158M)   : 0, 6158464

    section DD_TRACE_ENABLED=0
    master (9.452M)   : 0, 9451730

datadog-ddstaging · 2024-09-24T08:48:36Z

Datadog Report

Branch report: andrew/ignore-more-processes
Commit report: e00e77b
Test service: dd-trace-dotnet

❌ 1 Failed (0 Known Flaky), 370992 Passed, 2984 Skipped, 28h 17m 54.34s Total Time
❄️ 1 New Flaky

❌ Failed Tests (1)

Profiler_liveheap_cpu_walltime - scenarios - Details

Expand for error

 
  ########### Finishing run at 9/25/2024 5:25:31 PM4375eak 25 times with 1 thread(s).shared\bin\monitoring-home\win-x86\Datadog.Profiler.Native.dlltation 5=compute fibonacci 6=n sleeping threads 7=async calls 8=iterator calls 9=allocate array of Generic<int>> 10=threads competing for a lock 11=lunix signal handler 12=trigger garbage collections 13=memory leak 14=short lived threads] [--param <any number to pass to the scenario - used for contention duration for example>] [--timeout <duration in seconds> | --run-infinitely]uteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread)
    at System.Threading.Tasks.Task.ExecuteEntryUnsafe(System.Threading.Thread)
    at System.Threading.Tasks.ThreadPoolTaskScheduler+<>c.<.cctor>b__10_0(System.Object)
    at System.Threading.Thread.StartCallback()

New Flaky Tests (1)

HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Last Failure

Expand for error

 
 Expected var integration = latestIntegrations {empty} to contain key "CurlHandler".), but no such item was found.t found False.

andrewlock · 2024-09-24T09:06:31Z

Benchmarks Report for tracer 🐌

Benchmarks for #6065 compared to master:

1 benchmarks are faster, with geometric mean 1.170
2 benchmarks are slower, with geometric mean 1.146
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.82μs	45.1ns	361ns	0.0153	0.00765	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.78μs	54.3ns	339ns	0.0143	0.00478	0	5.61 KB
master	`StartStopWithChild`	net472	16.1μs	59.8ns	232ns	1.01	0.293	0.0951	6.06 KB
#6065	`StartStopWithChild`	net6.0	7.6μs	42.1ns	252ns	0.015	0.00752	0	5.42 KB
#6065	`StartStopWithChild`	netcoreapp3.1	9.71μs	50.4ns	252ns	0.02	0.00499	0	5.61 KB
#6065	`StartStopWithChild`	net472	16μs	40.8ns	158ns	1.02	0.309	0.0952	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	479μs	242ns	937ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	306ns	1.19μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	832μs	728ns	2.82μs	0.419	3.3 KB
#6065	`WriteAndFlushEnrichedTraces`	net6.0	493μs	217ns	812ns	0	2.7 KB
#6065	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	625μs	681ns	2.64μs	0	2.7 KB
#6065	`WriteAndFlushEnrichedTraces`	net472	831μs	539ns	2.09μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	198μs	882ns	3.3μs	0.211	18.45 KB
master	`SendRequest`	netcoreapp3.1	219μs	1.26μs	9.58μs	0.216	20.61 KB
master	`SendRequest`	net472	0.000333ns	0.000216ns	0.000806ns	0	0 b
#6065	`SendRequest`	net6.0	196μs	1.13μs	8.85μs	0.192	18.45 KB
#6065	`SendRequest`	netcoreapp3.1	222μs	1.21μs	8.72μs	0.215	20.61 KB
#6065	`SendRequest`	net472	0.000649ns	0.000348ns	0.0013ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	572μs	2.38μs	10.4μs	0.571	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	684μs	3.63μs	18.2μs	0.329	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	net472	873μs	3.25μs	12.2μs	8.25	2.6	0.434	53.27 KB
#6065	`WriteAndFlushEnrichedTraces`	net6.0	561μs	1.91μs	7.17μs	0.568	0	0	41.69 KB
#6065	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	675μs	1.26μs	4.56μs	0.336	0	0	41.6 KB
#6065	`WriteAndFlushEnrichedTraces`	net472	879μs	4.04μs	16.1μs	8.3	2.62	0.437	53.33 KB

Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6065

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.150	1,220.93	1,404.54

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.22μs	1.22ns	4.71ns	0.0141	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.11ns	4.3ns	0.0133	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	2.37ns	8.85ns	0.156	987 B
#6065	`ExecuteNonQuery`	net6.0	1.4μs	1ns	3.89ns	0.0141	1.02 KB
#6065	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.37ns	5.32ns	0.0135	1.02 KB
#6065	`ExecuteNonQuery`	net472	2.07μs	1.98ns	7.68ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.16μs	0.648ns	2.51ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.765ns	2.96ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.48μs	1.4ns	5.43ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.29μs	2.44ns	9.46ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.799ns	2.99ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.72μs	2.24ns	8.68ns	0.167	1.05 KB
#6065	`CallElasticsearch`	net6.0	1.17μs	0.745ns	2.58ns	0.0135	976 B
#6065	`CallElasticsearch`	netcoreapp3.1	1.63μs	4.61ns	17.8ns	0.0131	976 B
#6065	`CallElasticsearch`	net472	2.41μs	1.62ns	6.27ns	0.158	995 B
#6065	`CallElasticsearchAsync`	net6.0	1.27μs	0.98ns	3.67ns	0.0133	952 B
#6065	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	2.15ns	8.34ns	0.0134	1.02 KB
#6065	`CallElasticsearchAsync`	net472	2.68μs	2.04ns	7.9ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.28μs	0.682ns	2.64ns	0.0129	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.467ns	1.75ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.74μs	0.721ns	2.7ns	0.145	915 B
#6065	`ExecuteAsync`	net6.0	1.24μs	1.68ns	6.06ns	0.013	952 B
#6065	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.965ns	3.74ns	0.0127	952 B
#6065	`ExecuteAsync`	net472	1.74μs	0.579ns	2.24ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.1μs	2.41ns	9.33ns	0.0306	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.06μs	2.66ns	10.3ns	0.036	2.76 KB
master	`SendAsync`	net472	7.84μs	2.17ns	8.4ns	0.498	3.15 KB
#6065	`SendAsync`	net6.0	4.24μs	2.34ns	8.42ns	0.032	2.22 KB
#6065	`SendAsync`	netcoreapp3.1	5.12μs	1.97ns	7.35ns	0.036	2.76 KB
#6065	`SendAsync`	net472	7.83μs	8.48ns	31.7ns	0.497	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6065

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.142	1,438.12	1,641.82

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	1.11ns	4.29ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.26μs	0.979ns	3.53ns	0.0228	1.64 KB
master	`EnrichedLog`	net472	2.58μs	0.884ns	3.43ns	0.25	1.57 KB
#6065	`EnrichedLog`	net6.0	1.64μs	0.961ns	3.6ns	0.0235	1.64 KB
#6065	`EnrichedLog`	netcoreapp3.1	2.17μs	0.601ns	2.08ns	0.0216	1.64 KB
#6065	`EnrichedLog`	net472	2.64μs	11.9ns	46.3ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	152ns	588ns	0.0569	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	180ns	695ns	0.0592	0	4.28 KB
master	`EnrichedLog`	net472	146μs	201ns	780ns	0.656	0.219	4.46 KB
#6065	`EnrichedLog`	net6.0	113μs	116ns	449ns	0.0567	0	4.28 KB
#6065	`EnrichedLog`	netcoreapp3.1	118μs	139ns	519ns	0.0588	0	4.28 KB
#6065	`EnrichedLog`	net472	149μs	263ns	983ns	0.656	0.219	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.05μs	0.612ns	2.37ns	0.0303	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.34μs	1.4ns	5.22ns	0.0282	2.2 KB
master	`EnrichedLog`	net472	4.7μs	1.36ns	5.09ns	0.321	2.02 KB
#6065	`EnrichedLog`	net6.0	3.03μs	1.2ns	4.63ns	0.0303	2.2 KB
#6065	`EnrichedLog`	netcoreapp3.1	4.31μs	5.99ns	23.2ns	0.0294	2.2 KB
#6065	`EnrichedLog`	net472	4.75μs	2.21ns	8.26ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.34μs	0.59ns	2.13ns	0.016	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.65μs	1.13ns	4.24ns	0.0158	0	1.14 KB
master	`SendReceive`	net472	2.05μs	1.3ns	5.05ns	0.183	0.00103	1.16 KB
#6065	`SendReceive`	net6.0	1.37μs	1.16ns	4.5ns	0.0165	0	1.14 KB
#6065	`SendReceive`	netcoreapp3.1	1.77μs	7.44ns	29.7ns	0.0155	0	1.14 KB
#6065	`SendReceive`	net472	2.14μs	1.13ns	4.37ns	0.183	0.00108	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	1.03ns	3.86ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.92μs	1.46ns	5.67ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.23μs	1.88ns	7.04ns	0.323	2.04 KB
#6065	`EnrichedLog`	net6.0	2.69μs	0.725ns	2.81ns	0.0215	1.6 KB
#6065	`EnrichedLog`	netcoreapp3.1	3.88μs	1.59ns	6.15ns	0.0214	1.65 KB
#6065	`EnrichedLog`	net472	4.41μs	3.39ns	13.1ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6065

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.170	550.52	470.33

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.306ns	1.19ns	0.00813	576 B
master	`StartFinishSpan`	netcoreapp3.1	659ns	0.498ns	1.93ns	0.00755	576 B
master	`StartFinishSpan`	net472	672ns	0.514ns	1.85ns	0.0917	578 B
master	`StartFinishScope`	net6.0	550ns	0.281ns	1.09ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	742ns	1.23ns	4.6ns	0.00959	696 B
master	`StartFinishScope`	net472	862ns	3.83ns	14.8ns	0.104	658 B
#6065	`StartFinishSpan`	net6.0	399ns	0.181ns	0.701ns	0.008	576 B
#6065	`StartFinishSpan`	netcoreapp3.1	597ns	0.247ns	0.923ns	0.00776	576 B
#6065	`StartFinishSpan`	net472	642ns	0.512ns	1.98ns	0.0917	578 B
#6065	`StartFinishScope`	net6.0	470ns	0.136ns	0.509ns	0.00967	696 B
#6065	`StartFinishScope`	netcoreapp3.1	784ns	0.723ns	2.8ns	0.00968	696 B
#6065	`StartFinishScope`	net472	909ns	0.619ns	2.4ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	647ns	1.36ns	5.07ns	0.00998	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	923ns	1.07ns	4.14ns	0.00961	696 B
master	`RunOnMethodBegin`	net472	1.12μs	4.75ns	18.4ns	0.104	658 B
#6065	`RunOnMethodBegin`	net6.0	696ns	0.368ns	1.43ns	0.00977	696 B
#6065	`RunOnMethodBegin`	netcoreapp3.1	924ns	0.627ns	2.43ns	0.00924	696 B
#6065	`RunOnMethodBegin`	net472	1.11μs	0.372ns	1.44ns	0.104	658 B

bouwkast

Thanks!

lucaspimentel · 2024-09-24T15:38:54Z

We explicitly ignore a bunch of processes in our testing code... Is there a good reason we don't always ignore them? 🤔

These ignore lists in testing code probably predate the default ignore list we have now. At the time, most were added as a convenience for developers running the tests from VS (most of these are VS child processes). But yeah, we probably should ignore these by default.

andrewlock · 2024-09-25T17:04:56Z

We explicitly ignore a bunch of processes in our testing code... Is there a good reason we don't always ignore them? 🤔

These ignore lists in testing code probably predate the default ignore list we have now. At the time, most were added as a convenience for developers running the tests from VS (most of this are VS child processes). But yeah, we probably should ignore these by default.

I agree, I added all those to the exclude list too

Ignore more processes

65fced6

andrewlock added the area:shared-components label Sep 24, 2024

andrewlock requested review from a team as code owners September 24, 2024 07:47

bouwkast approved these changes Sep 24, 2024

View reviewed changes

Comment thread tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h

lucaspimentel approved these changes Sep 24, 2024

View reviewed changes

andrewlock added 2 commits September 25, 2024 18:03

Add more processes to the ignore list

9cc6eaf

No need to override in tests if we do it by default

e00e77b

andrewlock merged commit 0f7aba2 into master Sep 26, 2024

andrewlock deleted the andrew/ignore-more-processes branch September 26, 2024 09:32

github-actions Bot added this to the vNext-v3 milestone Sep 26, 2024

andrewlock added the area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) label Oct 23, 2024

Uh oh!

Conversation

andrewlock commented Sep 24, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

andrewlock commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throughput/Crank Report ⚡

Uh oh!

datadog-ddstaging Bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

❌ Failed Tests (1)

New Flaky Tests (1)

Uh oh!

andrewlock commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6065

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6065

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6065

Raw results

Raw results

Uh oh!

bouwkast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucaspimentel commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewlock commented Sep 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewlock commented Sep 24, 2024 •

edited

Loading

andrewlock commented Sep 24, 2024 •

edited

Loading

datadog-ddstaging Bot commented Sep 24, 2024 •

edited

Loading

andrewlock commented Sep 24, 2024 •

edited

Loading

lucaspimentel commented Sep 24, 2024 •

edited

Loading