Skip to content

add aws credentials for system tests#6040

Merged
bouwkast merged 2 commits into
masterfrom
conti/aws-system-tests
Sep 19, 2024
Merged

add aws credentials for system tests#6040
bouwkast merged 2 commits into
masterfrom
conti/aws-system-tests

Conversation

@wconti27

@wconti27 wconti27 commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

necessary for new system tests using AWS resources

Reason for change

tests r good, tests r fun,

Implementation details

Test coverage

Other details

@wconti27
wconti27 requested a review from a team as a code owner September 16, 2024 17:03
bouwkast
bouwkast approved these changes Sep 16, 2024
View reviewed changes

@bouwkast bouwkast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wconti27!

@datadog-ddstaging

datadog-ddstaging Bot commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: conti/aws-system-tests
Commit report: a84319a
Test service: dd-trace-dotnet

✅ 0 Failed, 364693 Passed, 2089 Skipped, 15h 50m 3.23s Total Time
❄️ 4 New Flaky

New Flaky Tests (4)

  • OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests

  • OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests

  • OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests

  • OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests

@andrewlock

andrewlock commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6040) - mean (71ms)  : 65, 77
     .   : milestone, 71,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6040) - mean (1,112ms)  : 1084, 1139
     .   : milestone, 1112,
    master - mean (1,117ms)  : 1090, 1144
     .   : milestone, 1117,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6040) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (109ms)  : 105, 114
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6040) - mean (810ms)  : 793, 826
     .   : milestone, 810,
    master - mean (812ms)  : 784, 840
     .   : milestone, 812,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6040) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (93ms)  : 88, 99
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6040) - mean (762ms)  : 737, 787
     .   : milestone, 762,
    master - mean (764ms)  : 739, 788
     .   : milestone, 764,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6040) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6040) - mean (1,197ms)  : 1174, 1220
     .   : milestone, 1197,
    master - mean (1,194ms)  : 1172, 1217
     .   : milestone, 1194,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6040) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (277ms)  : 272, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6040) - mean (971ms)  : 945, 997
     .   : milestone, 971,
    master - mean (969ms)  : 949, 989
     .   : milestone, 969,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6040) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6040) - mean (945ms)  : 920, 971
     .   : milestone, 945,
    master - mean (946ms)  : 922, 970
     .   : milestone, 946,
Loading

bouwkast
bouwkast reviewed Sep 16, 2024
View reviewed changes
Comment thread .azure-pipelines/ultimate-pipeline.yml
@andrewlock

andrewlock commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6040) (10.489M)   : 0, 10488982
    master (10.867M)   : 0, 10866655
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6040) (7.042M)   : 0, 7042371
    master (7.063M)   : 0, 7062638
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.364M)   : 0, 7364303

    section Manual
    master (10.824M)   : 0, 10823898

    section Manual + Automatic
    This PR (6040) (6.490M)   : 0, 6489506
    master (6.575M)   : 0, 6575042

    section DD_TRACE_ENABLED=0
    master (9.990M)   : 0, 9989817
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6040) (9.645M)   : 0, 9645085
    master (9.746M)   : 0, 9746139
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6040) (6.683M)   : 0, 6682853
    master (6.518M)   : 0, 6518443

    section Trace stats
    master (6.791M)   : 0, 6791013

    section Manual
    master (9.554M)   : 0, 9554347

    section Manual + Automatic
    This PR (6040) (6.178M)   : 0, 6178019
    master (6.054M)   : 0, 6053863

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8868379
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6040) (10.455M)   : 0, 10454874
    master (10.125M)   : 0, 10125159
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6040) (6.829M)   : 0, 6828661
    master (6.789M)   : 0, 6788744
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.427M)   : 0, 7426998

    section Manual
    master (10.349M)   : 0, 10348694

    section Manual + Automatic
    This PR (6040) (6.361M)   : 0, 6360589
    master (6.321M)   : 0, 6321226

    section DD_TRACE_ENABLED=0
    master (9.558M)   : 0, 9557791
Loading

zacharycmontoya
zacharycmontoya approved these changes Sep 16, 2024
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like accessing the secrets should all be set up 👍🏼

@andrewlock

andrewlock commented Sep 16, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6040 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.78μs 44.5ns 324ns 0.0112 0.00374 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.85μs 43.4ns 157ns 0.0143 0.00476 0 5.62 KB
master StartStopWithChild net472 16.1μs 33ns 123ns 1.03 0.313 0.102 6.06 KB
#6040 StartStopWithChild net6.0 7.54μs 39.8ns 218ns 0.019 0.00762 0 5.42 KB
#6040 StartStopWithChild netcoreapp3.1 9.75μs 53.8ns 309ns 0.0135 0.00449 0 5.62 KB
#6040 StartStopWithChild net472 16.3μs 50.9ns 197ns 1.01 0.296 0.096 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 481μs 158ns 549ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 625μs 304ns 1.18μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 844μs 342ns 1.33μs 0.419 0 0 3.3 KB
#6040 WriteAndFlushEnrichedTraces net6.0 456μs 103ns 370ns 0 0 0 2.7 KB
#6040 WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 1.58μs 6.11μs 0 0 0 2.7 KB
#6040 WriteAndFlushEnrichedTraces net472 824μs 964ns 3.74μs 0.411 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 203μs 1.17μs 9.62μs 0.197 0 0 18.45 KB
master SendRequest netcoreapp3.1 225μs 1.29μs 9.79μs 0.216 0 0 20.61 KB
master SendRequest net472 0.00235ns 0.000752ns 0.00291ns 0 0 0 0 b
#6040 SendRequest net6.0 186μs 1.02μs 5.87μs 0.188 0 0 18.45 KB
#6040 SendRequest netcoreapp3.1 219μs 1.17μs 9.08μs 0.215 0 0 20.61 KB
#6040 SendRequest net472 0.000251ns 8.88E‑05ns 0.00032ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6040

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.87 KB 41.61 KB -262 B -0.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 562μs 2.9μs 16.2μs 0.558 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 697μs 3.34μs 13.8μs 0.326 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 862μs 2.83μs 11μs 8.45 2.53 0.422 53.29 KB
#6040 WriteAndFlushEnrichedTraces net6.0 583μs 2.76μs 11μs 0.576 0 0 41.77 KB
#6040 WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.05μs 12.6μs 0.351 0 0 41.61 KB
#6040 WriteAndFlushEnrichedTraces net472 879μs 4.09μs 15.8μs 8.36 2.64 0.44 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 0.95ns 3.68ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.25ns 4.84ns 0.0131 0 0 1.02 KB
master ExecuteNonQuery net472 2.04μs 2.14ns 8.31ns 0.156 0 0 987 B
#6040 ExecuteNonQuery net6.0 1.22μs 0.709ns 2.74ns 0.0146 0 0 1.02 KB
#6040 ExecuteNonQuery netcoreapp3.1 1.8μs 1.41ns 5.47ns 0.0131 0 0 1.02 KB
#6040 ExecuteNonQuery net472 2.14μs 2.61ns 9.78ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.454ns 1.7ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 1.79ns 6.7ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.61μs 2.1ns 8.13ns 0.158 0.0013 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 0.955ns 3.58ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 0.667ns 2.41ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 1.14ns 4.11ns 0.166 0.00133 0 1.05 KB
#6040 CallElasticsearch net6.0 1.12μs 0.818ns 3.17ns 0.0134 0 0 976 B
#6040 CallElasticsearch netcoreapp3.1 1.51μs 1.72ns 6.67ns 0.013 0 0 976 B
#6040 CallElasticsearch net472 2.41μs 1.01ns 3.76ns 0.158 0 0 995 B
#6040 CallElasticsearchAsync net6.0 1.37μs 0.878ns 3.29ns 0.0134 0 0 952 B
#6040 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.528ns 1.9ns 0.0137 0 0 1.02 KB
#6040 CallElasticsearchAsync net472 2.63μs 2.02ns 7.81ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 1.22ns 4.71ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.891ns 3.21ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.82μs 2.47ns 9.55ns 0.145 0 0 915 B
#6040 ExecuteAsync net6.0 1.23μs 6.38ns 31.9ns 0.0132 0 0 952 B
#6040 ExecuteAsync netcoreapp3.1 1.55μs 1.79ns 6.92ns 0.0123 0 0 952 B
#6040 ExecuteAsync net472 1.8μs 1.17ns 4.52ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.15μs 0.911ns 3.29ns 0.0312 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.2μs 20.1ns 78ns 0.036 0 0 2.76 KB
master SendAsync net472 7.84μs 1.8ns 6.98ns 0.496 0 0 3.15 KB
#6040 SendAsync net6.0 4.15μs 1.82ns 7.04ns 0.031 0 0 2.22 KB
#6040 SendAsync netcoreapp3.1 5.12μs 3.8ns 14.7ns 0.0357 0 0 2.76 KB
#6040 SendAsync net472 7.75μs 4.84ns 18.8ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.752ns 2.81ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.25μs 1.17ns 4.36ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.53μs 0.603ns 2.26ns 0.25 0 0 1.57 KB
#6040 EnrichedLog net6.0 1.42μs 0.485ns 1.88ns 0.0228 0 0 1.64 KB
#6040 EnrichedLog netcoreapp3.1 2.13μs 1.08ns 4.19ns 0.0216 0 0 1.64 KB
#6040 EnrichedLog net472 2.51μs 0.689ns 2.67ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 165ns 594ns 0.0572 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 98.7ns 382ns 0.0589 0 0 4.28 KB
master EnrichedLog net472 145μs 54.4ns 211ns 0.654 0.218 0 4.46 KB
#6040 EnrichedLog net6.0 112μs 77.2ns 299ns 0.0558 0 0 4.28 KB
#6040 EnrichedLog netcoreapp3.1 119μs 152ns 588ns 0 0 0 4.28 KB
#6040 EnrichedLog net472 146μs 38.4ns 144ns 0.656 0.219 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.04μs 1.35ns 5.05ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.31μs 1.12ns 4.36ns 0.0302 0 0 2.2 KB
master EnrichedLog net472 4.89μs 0.944ns 3.66ns 0.32 0 0 2.02 KB
#6040 EnrichedLog net6.0 3.08μs 2.17ns 8.41ns 0.0309 0 0 2.2 KB
#6040 EnrichedLog netcoreapp3.1 4.32μs 1.94ns 7.26ns 0.0281 0 0 2.2 KB
#6040 EnrichedLog net472 5.02μs 2.02ns 7.83ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.38μs 0.582ns 2.18ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 0.981ns 3.8ns 0.015 0 0 1.14 KB
master SendReceive net472 2.07μs 1.26ns 4.86ns 0.183 0.00103 0 1.16 KB
#6040 SendReceive net6.0 1.42μs 0.874ns 3.39ns 0.0162 0 0 1.14 KB
#6040 SendReceive netcoreapp3.1 1.68μs 0.866ns 3.24ns 0.0152 0 0 1.14 KB
#6040 SendReceive net472 2.12μs 0.714ns 2.77ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.69μs 10.2ns 39.3ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.03μs 1.14ns 4.41ns 0.0221 0 0 1.65 KB
master EnrichedLog net472 4.38μs 3.19ns 12.3ns 0.322 0 0 2.04 KB
#6040 EnrichedLog net6.0 2.82μs 0.943ns 3.53ns 0.0225 0 0 1.6 KB
#6040 EnrichedLog netcoreapp3.1 4.09μs 1.84ns 7.14ns 0.0222 0 0 1.65 KB
#6040 EnrichedLog net472 4.41μs 2.06ns 7.72ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 412ns 0.227ns 0.819ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 579ns 0.265ns 0.99ns 0.00795 0 0 576 B
master StartFinishSpan net472 679ns 0.578ns 2.24ns 0.0918 0 0 578 B
master StartFinishScope net6.0 508ns 0.277ns 1.07ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 704ns 0.446ns 1.67ns 0.00933 0 0 696 B
master StartFinishScope net472 856ns 1.78ns 6.89ns 0.104 0 0 658 B
#6040 StartFinishSpan net6.0 453ns 0.331ns 1.28ns 0.00815 0 0 576 B
#6040 StartFinishSpan netcoreapp3.1 589ns 1.65ns 6.38ns 0.00772 0 0 576 B
#6040 StartFinishSpan net472 707ns 0.494ns 1.91ns 0.0917 0 0 578 B
#6040 StartFinishScope net6.0 473ns 0.269ns 1.04ns 0.00977 0 0 696 B
#6040 StartFinishScope netcoreapp3.1 758ns 0.752ns 2.91ns 0.00953 0 0 696 B
#6040 StartFinishScope net472 808ns 0.677ns 2.62ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 653ns 0.484ns 1.88ns 0.00979 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 895ns 4.29ns 17.1ns 0.00925 0 0 696 B
master RunOnMethodBegin net472 1.12μs 1.12ns 4.33ns 0.104 0 0 658 B
#6040 RunOnMethodBegin net6.0 657ns 0.798ns 3.09ns 0.00964 0 0 696 B
#6040 RunOnMethodBegin netcoreapp3.1 870ns 0.405ns 1.57ns 0.00941 0 0 696 B
#6040 RunOnMethodBegin net472 1.11μs 0.697ns 2.7ns 0.104 0 0 658 B

@bouwkast
bouwkast merged commit 0bd9f9d into master Sep 19, 2024
@bouwkast
bouwkast deleted the conti/aws-system-tests branch September 19, 2024 18:02
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 19, 2024
@andrewlock andrewlock added the area:tests unit tests, integration tests label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes
@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wconti27 @andrewlock @bouwkast @zacharycmontoya