Skip to content

Diagnostic tool: Check if DD_INJECTION_ENABLED contains profiler#5991

Closed
kevingosse wants to merge 1 commit into
masterfrom
kevin/profiler_ssi
Closed

Diagnostic tool: Check if DD_INJECTION_ENABLED contains profiler#5991
kevingosse wants to merge 1 commit into
masterfrom
kevin/profiler_ssi

Conversation

@kevingosse

@kevingosse kevingosse commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

In the diagnostic tool, we consider that the profiler should be loaded whenever DD_INJECTION_ENABLED. While that might be true (?), the profiler shouldn't be enabled, so instead look specifically for the value profiler.

Reason for change

This causes failures in the CI in the SSI run.

@kevingosse
kevingosse requested a review from a team as a code owner September 5, 2024 14:11
@datadog-ddstaging

datadog-ddstaging Bot commented Sep 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: kevin/profiler_ssi
Commit report: 27a82d5
Test service: dd-trace-dotnet

✅ 0 Failed, 363165 Passed, 2050 Skipped, 15h 10m 18.55s Total Time

@andrewlock

andrewlock commented Sep 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5991) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (71ms)  : 67, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (5991) - mean (1,078ms)  : 1050, 1106
     .   : milestone, 1078,
    master - mean (1,085ms)  : 1060, 1110
     .   : milestone, 1085,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5991) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5991) - mean (762ms)  : 737, 787
     .   : milestone, 762,
    master - mean (759ms)  : 741, 778
     .   : milestone, 759,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5991) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5991) - mean (710ms)  : 694, 727
     .   : milestone, 710,
    master - mean (712ms)  : 692, 732
     .   : milestone, 712,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5991) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5991) - mean (1,161ms)  : 1131, 1191
     .   : milestone, 1161,
    master - mean (1,165ms)  : 1135, 1194
     .   : milestone, 1165,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5991) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5991) - mean (919ms)  : 903, 934
     .   : milestone, 919,
    master - mean (927ms)  : 906, 947
     .   : milestone, 927,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5991) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (265ms)  : 261, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5991) - mean (905ms)  : 883, 927
     .   : milestone, 905,
    master - mean (905ms)  : 876, 934
     .   : milestone, 905,
Loading

@andrewlock

andrewlock commented Sep 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5991 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.132
  • 2 benchmarks are slower, with geometric mean 1.134
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.7μs 42.1ns 252ns 0.015 0.00375 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10.1μs 56.8ns 398ns 0.0155 0.00516 0 5.62 KB
master StartStopWithChild net472 15.9μs 49.6ns 192ns 1.01 0.3 0.0947 6.06 KB
#5991 StartStopWithChild net6.0 7.8μs 41.7ns 213ns 0.0196 0.00782 0 5.43 KB
#5991 StartStopWithChild netcoreapp3.1 10μs 51.8ns 238ns 0.0196 0.0049 0 5.62 KB
#5991 StartStopWithChild net472 16μs 53ns 191ns 1.02 0.306 0.0885 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 485μs 347ns 1.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 2.07μs 7.47μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 833μs 503ns 1.95μs 0.417 0 0 3.3 KB
#5991 WriteAndFlushEnrichedTraces net6.0 468μs 291ns 1.13μs 0 0 0 2.7 KB
#5991 WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 382ns 1.48μs 0 0 0 2.7 KB
#5991 WriteAndFlushEnrichedTraces net472 839μs 358ns 1.34μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 199μs 1.16μs 10.1μs 0.194 0 0 18.45 KB
master SendRequest netcoreapp3.1 220μs 1.2μs 7.31μs 0.212 0 0 20.61 KB
master SendRequest net472 0.000867ns 0.000421ns 0.00163ns 0 0 0 0 b
#5991 SendRequest net6.0 207μs 1.43μs 14μs 0.194 0 0 18.45 KB
#5991 SendRequest netcoreapp3.1 226μs 1.3μs 11.1μs 0.21 0 0 20.61 KB
#5991 SendRequest net472 0.00077ns 0.000344ns 0.00133ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5991

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.45 KB 41.86 KB 413 B 1.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 601μs 3.09μs 15.5μs 0.584 0 0 41.45 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 739μs 4.09μs 26.8μs 0.349 0 0 41.45 KB
master WriteAndFlushEnrichedTraces net472 874μs 2.78μs 10.8μs 8.08 2.55 0.425 53.27 KB
#5991 WriteAndFlushEnrichedTraces net6.0 578μs 2.97μs 13.6μs 0.336 0 0 41.63 KB
#5991 WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.37μs 13.5μs 0.343 0 0 41.86 KB
#5991 WriteAndFlushEnrichedTraces net472 858μs 3.92μs 15.2μs 8.19 2.59 0.431 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 0.844ns 3.16ns 0.0147 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.7μs 1.17ns 4.53ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.03μs 2.82ns 10.9ns 0.156 0 0 987 B
#5991 ExecuteNonQuery net6.0 1.23μs 1.2ns 4.65ns 0.0142 0 0 1.02 KB
#5991 ExecuteNonQuery netcoreapp3.1 1.77μs 1.06ns 4.11ns 0.0134 0 0 1.02 KB
#5991 ExecuteNonQuery net472 2.12μs 2.64ns 10.2ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5991

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.133 1,215.95 1,377.40

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 1.28ns 4.78ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 2.34ns 8.76ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.42μs 1.59ns 6.17ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.22μs 1.01ns 3.77ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.81ns 3.03ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.5μs 1.69ns 6.32ns 0.166 0 0 1.05 KB
#5991 CallElasticsearch net6.0 1.17μs 0.343ns 1.29ns 0.0135 0 0 976 B
#5991 CallElasticsearch netcoreapp3.1 1.49μs 0.71ns 2.66ns 0.0136 0 0 976 B
#5991 CallElasticsearch net472 2.47μs 0.789ns 3.06ns 0.157 0 0 995 B
#5991 CallElasticsearchAsync net6.0 1.38μs 0.567ns 2.2ns 0.0131 0 0 952 B
#5991 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.402ns 1.39ns 0.0137 0 0 1.02 KB
#5991 CallElasticsearchAsync net472 2.54μs 1.61ns 6.02ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.19μs 0.58ns 2.17ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.391ns 1.41ns 0.0122 0 0 952 B
master ExecuteAsync net472 1.76μs 1.63ns 6.3ns 0.145 0 0 915 B
#5991 ExecuteAsync net6.0 1.27μs 0.684ns 2.56ns 0.0134 0 0 952 B
#5991 ExecuteAsync netcoreapp3.1 1.55μs 0.46ns 1.72ns 0.0125 0 0 952 B
#5991 ExecuteAsync net472 1.76μs 0.821ns 2.84ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.15μs 1.68ns 6.29ns 0.031 0 0 2.22 KB
master SendAsync netcoreapp3.1 4.98μs 1.25ns 4.52ns 0.0374 0 0 2.76 KB
master SendAsync net472 7.9μs 1.89ns 7.31ns 0.498 0 0 3.15 KB
#5991 SendAsync net6.0 4.22μs 1.14ns 4.11ns 0.0298 0 0 2.22 KB
#5991 SendAsync netcoreapp3.1 5.01μs 1.48ns 5.73ns 0.0375 0 0 2.76 KB
#5991 SendAsync net472 7.79μs 3.41ns 13.2ns 0.5 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5991

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.123 1,617.56 1,440.19

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.62μs 0.937ns 3.51ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.4μs 8.57ns 33.2ns 0.0226 0 0 1.64 KB
master EnrichedLog net472 2.63μs 1.88ns 7.3ns 0.249 0 0 1.57 KB
#5991 EnrichedLog net6.0 1.44μs 0.598ns 2.24ns 0.0231 0 0 1.64 KB
#5991 EnrichedLog netcoreapp3.1 2.22μs 0.666ns 2.4ns 0.0223 0 0 1.64 KB
#5991 EnrichedLog net472 2.74μs 2.38ns 9.2ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 149ns 576ns 0.0581 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 225ns 871ns 0 0 0 4.28 KB
master EnrichedLog net472 146μs 255ns 988ns 0.662 0.221 0 4.46 KB
#5991 EnrichedLog net6.0 115μs 251ns 974ns 0.0577 0 0 4.28 KB
#5991 EnrichedLog netcoreapp3.1 120μs 236ns 913ns 0 0 0 4.28 KB
#5991 EnrichedLog net472 149μs 402ns 1.56μs 0.66 0.22 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.93μs 4.77ns 18.5ns 0.0303 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.2μs 4.49ns 17.4ns 0.0301 0 0 2.2 KB
master EnrichedLog net472 4.89μs 1.07ns 4.01ns 0.32 0 0 2.02 KB
#5991 EnrichedLog net6.0 2.91μs 1.05ns 4.08ns 0.0307 0 0 2.2 KB
#5991 EnrichedLog netcoreapp3.1 4.14μs 2.59ns 10ns 0.029 0 0 2.2 KB
#5991 EnrichedLog net472 4.83μs 1.65ns 6.38ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 1.29ns 4.84ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 0.255ns 0.883ns 0.016 0 0 1.14 KB
master SendReceive net472 2.12μs 1.47ns 5.51ns 0.183 0.00106 0 1.16 KB
#5991 SendReceive net6.0 1.34μs 0.626ns 2.34ns 0.016 0 0 1.14 KB
#5991 SendReceive netcoreapp3.1 1.76μs 0.728ns 2.72ns 0.0157 0 0 1.14 KB
#5991 SendReceive net472 2.14μs 0.98ns 3.53ns 0.183 0.00107 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 0.831ns 3.11ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.84μs 2.02ns 7.57ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.41μs 3.55ns 13.3ns 0.323 0 0 2.04 KB
#5991 EnrichedLog net6.0 2.73μs 0.907ns 3.51ns 0.0219 0 0 1.6 KB
#5991 EnrichedLog netcoreapp3.1 3.86μs 2.15ns 7.77ns 0.0212 0 0 1.65 KB
#5991 EnrichedLog net472 4.38μs 1.71ns 6.62ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5991

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.142 772.30 676.47

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 394ns 0.342ns 1.32ns 0.00817 0 0 576 B
master StartFinishSpan netcoreapp3.1 549ns 0.374ns 1.4ns 0.00767 0 0 576 B
master StartFinishSpan net472 578ns 1.02ns 3.94ns 0.0917 0 0 578 B
master StartFinishScope net6.0 546ns 0.315ns 1.22ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 773ns 0.679ns 2.63ns 0.00927 0 0 696 B
master StartFinishScope net472 802ns 0.592ns 2.21ns 0.104 0 0 658 B
#5991 StartFinishSpan net6.0 397ns 0.109ns 0.423ns 0.00812 0 0 576 B
#5991 StartFinishSpan netcoreapp3.1 565ns 1.38ns 5.34ns 0.0078 0 0 576 B
#5991 StartFinishSpan net472 635ns 0.7ns 2.71ns 0.0915 0 0 578 B
#5991 StartFinishScope net6.0 545ns 0.429ns 1.66ns 0.00978 0 0 696 B
#5991 StartFinishScope netcoreapp3.1 672ns 2.33ns 9.02ns 0.00954 0 0 696 B
#5991 StartFinishScope net472 836ns 0.607ns 2.35ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5991

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.135 876.30 994.62

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 655ns 0.405ns 1.57ns 0.00955 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 876ns 0.696ns 2.69ns 0.00938 0 0 696 B
master RunOnMethodBegin net472 1.09μs 1.23ns 4.76ns 0.105 0 0 658 B
#5991 RunOnMethodBegin net6.0 588ns 0.692ns 2.68ns 0.00993 0 0 696 B
#5991 RunOnMethodBegin netcoreapp3.1 994ns 0.739ns 2.86ns 0.00963 0 0 696 B
#5991 RunOnMethodBegin net472 1.1μs 1.18ns 4.59ns 0.105 0 0 658 B

@andrewlock
andrewlock force-pushed the kevin/profiler_ssi branch 2 times, most recently from 76e4f78 to 27a82d5 Compare September 10, 2024 08:07
@andrewlock

andrewlock commented Sep 10, 2024

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5991) (11.191M)   : 0, 11191127
    master (11.202M)   : 0, 11202155
    benchmarks/2.9.0 (11.142M)   : 0, 11142344

    section Automatic
    This PR (5991) (7.440M)   : 0, 7440439
    master (7.437M)   : 0, 7437019
    benchmarks/2.9.0 (7.893M)   : 0, 7893301

    section Trace stats
    master (7.824M)   : 0, 7824309

    section Manual
    master (11.306M)   : 0, 11305639

    section Manual + Automatic
    This PR (5991) (6.959M)   : 0, 6959402
    master (6.918M)   : 0, 6917708

    section DD_TRACE_ENABLED=0
    master (10.325M)   : 0, 10325290
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5991) (9.557M)   : 0, 9556983
    master (9.731M)   : 0, 9730961
    benchmarks/2.9.0 (9.585M)   : 0, 9584514

    section Automatic
    This PR (5991) (6.456M)   : 0, 6456482
    master (6.575M)   : 0, 6574988

    section Trace stats
    master (7.001M)   : 0, 7000523

    section Manual
    master (9.504M)   : 0, 9504255

    section Manual + Automatic
    This PR (5991) (6.258M)   : 0, 6257658
    master (6.217M)   : 0, 6216600

    section DD_TRACE_ENABLED=0
    master (9.049M)   : 0, 9048961
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5991) (10.021M)   : 0, 10021395
    master (10.040M)   : 0, 10040090
    benchmarks/2.9.0 (10.094M)   : 0, 10093850

    section Automatic
    This PR (5991) (6.663M)   : 0, 6662902
    master (6.783M)   : 0, 6782944
    benchmarks/2.9.0 (7.257M)   : 0, 7257483

    section Trace stats
    master (7.323M)   : 0, 7323194

    section Manual
    master (10.061M)   : 0, 10060796

    section Manual + Automatic
    This PR (5991) (6.177M)   : 0, 6176859
    master (6.342M)   : 0, 6342001

    section DD_TRACE_ENABLED=0
    master (9.357M)   : 0, 9357055
Loading

@andrewlock andrewlock mentioned this pull request Sep 10, 2024
Merged
@andrewlock

andrewlock commented Sep 11, 2024

Copy link
Copy Markdown
Member

Superseded by #6014

@andrewlock andrewlock closed this Sep 11, 2024
andrewlock added a commit that referenced this pull request Sep 12, 2024
@andrewlock @chrisnas
[Tool] update continuous profiler diagnostics (#6014)
e84f74c 
## Summary of changes

Fix the diagnostics associated with the expected state of the continuous
profiler

## Reason for change

In #5240, the continuous profiler gained two new "modes" of operation:
delayed enablement based on heuristics, and "monitoring" mode. The tool
should be updated to understand those possibilities + handle it in the
tests

## Implementation details

- Reset the `DD_INJECTION_ENABLED` variable before running the tests -
the presence/absence of the variable changes the expectations, so we
need to account for it
- Explicitly test the various combinations of `DD_INJECTION_ENABLED` and
`DD_PROFILING_ENABLED`.

## Test coverage

Added additional integration and artifact tests

## Other details

This should address most of the issues in the scheduled SSI run. I
suspect the windows integration tests _may_ need additional work, as
currently the profiler library isn't copied to those tests. Will fix in
this PR if that ends up being the case

Supersedes 
- #5991

---------

Co-authored-by: chrisnas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevingosse @andrewlock