[IAST] Added missing netstd snapshot#5966
Conversation
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 1 occurrences of : + },
+ {
+ "type": "NO_SAMESITE_COOKIE",
+ "hash": -1837181716,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.0"
+ }
+ },
+ {
+ "type": "NO_HTTPONLY_COOKIE",
+ "hash": 1990393425,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.0"
+ }
+ },
+ {
+ "type": "INSECURE_COOKIE",
+ "hash": 1170867602,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.0"
+ }
+ },
+ {
+ "type": "NO_SAMESITE_COOKIE",
+ "hash": -1837181716,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.1"
+ }
+ },
+ {
+ "type": "NO_HTTPONLY_COOKIE",
+ "hash": 1990393425,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.1"
+ }
+ },
+ {
+ "type": "INSECURE_COOKIE",
+ "hash": 1170867602,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.1"
+ }
+ },
+ {
+ "type": "NO_SAMESITE_COOKIE",
+ "hash": -1837181716,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.2"
+ }
+ },
+ {
+ "type": "NO_HTTPONLY_COOKIE",
+ "hash": 1990393425,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.2"
+ }
+ },
+ {
+ "type": "INSECURE_COOKIE",
+ "hash": 1170867602,
+ "evidence": {
+ "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.2"
+ }
|
Datadog ReportBranch report: ✅ 0 Failed, 388180 Passed, 2760 Skipped, 33h 50m 27.19s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). |
Benchmarks Report for tracer 🐌Benchmarks for #5966 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 | 1.140 | 1,345.55 | 1,180.66 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.19μs | 0.497ns | 1.86ns | 0.0137 | 0 | 0 | 976 B |
| master | CallElasticsearch |
netcoreapp3.1 | 1.46μs | 0.583ns | 2.1ns | 0.0132 | 0 | 0 | 976 B |
| master | CallElasticsearch |
net472 | 2.47μs | 1.59ns | 5.97ns | 0.158 | 0 | 0 | 995 B |
| master | CallElasticsearchAsync |
net6.0 | 1.35μs | 1.64ns | 6.37ns | 0.0135 | 0 | 0 | 952 B |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 1.65μs | 0.594ns | 2.3ns | 0.0142 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
net472 | 2.51μs | 1.25ns | 4.67ns | 0.166 | 0 | 0 | 1.05 KB |
| #5966 | CallElasticsearch |
net6.0 | 1.07μs | 0.485ns | 1.88ns | 0.0135 | 0 | 0 | 976 B |
| #5966 | CallElasticsearch |
netcoreapp3.1 | 1.55μs | 1.46ns | 5.66ns | 0.0131 | 0 | 0 | 976 B |
| #5966 | CallElasticsearch |
net472 | 2.41μs | 5.6ns | 20.9ns | 0.158 | 0 | 0 | 995 B |
| #5966 | CallElasticsearchAsync |
net6.0 | 1.18μs | 0.99ns | 3.7ns | 0.0136 | 0 | 0 | 952 B |
| #5966 | CallElasticsearchAsync |
netcoreapp3.1 | 1.62μs | 0.824ns | 3.08ns | 0.0138 | 0 | 0 | 1.02 KB |
| #5966 | CallElasticsearchAsync |
net472 | 2.55μs | 0.744ns | 2.58ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.34μs | 0.561ns | 2.1ns | 0.013 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 1.57μs | 0.783ns | 2.82ns | 0.0127 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 1.73μs | 0.546ns | 2.04ns | 0.145 | 0 | 0 | 915 B |
| #5966 | ExecuteAsync |
net6.0 | 1.29μs | 0.86ns | 3.22ns | 0.0129 | 0 | 0 | 952 B |
| #5966 | ExecuteAsync |
netcoreapp3.1 | 1.65μs | 1.25ns | 4.66ns | 0.013 | 0 | 0 | 952 B |
| #5966 | ExecuteAsync |
net472 | 1.75μs | 0.945ns | 3.54ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 4.14μs | 0.957ns | 3.58ns | 0.0311 | 0 | 0 | 2.22 KB |
| master | SendAsync |
netcoreapp3.1 | 5.1μs | 2.15ns | 8.05ns | 0.0359 | 0 | 0 | 2.76 KB |
| master | SendAsync |
net472 | 7.75μs | 2.41ns | 9.35ns | 0.496 | 0 | 0 | 3.15 KB |
| #5966 | SendAsync |
net6.0 | 4.02μs | 0.869ns | 3.13ns | 0.0303 | 0 | 0 | 2.22 KB |
| #5966 | SendAsync |
netcoreapp3.1 | 5.15μs | 3.65ns | 14.1ns | 0.0365 | 0 | 0 | 2.76 KB |
| #5966 | SendAsync |
net472 | 7.64μs | 2.22ns | 8.59ns | 0.497 | 0 | 0 | 3.15 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 1.47μs | 0.435ns | 1.68ns | 0.0229 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 2.38μs | 0.732ns | 2.74ns | 0.0225 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
net472 | 2.71μs | 1.55ns | 5.99ns | 0.249 | 0 | 0 | 1.57 KB |
| #5966 | EnrichedLog |
net6.0 | 1.6μs | 1.13ns | 4.23ns | 0.0234 | 0 | 0 | 1.64 KB |
| #5966 | EnrichedLog |
netcoreapp3.1 | 2.28μs | 0.679ns | 2.63ns | 0.0219 | 0 | 0 | 1.64 KB |
| #5966 | EnrichedLog |
net472 | 2.74μs | 1.44ns | 5.21ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 117μs | 134ns | 502ns | 0.0589 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
netcoreapp3.1 | 121μs | 386ns | 1.5μs | 0 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
net472 | 151μs | 215ns | 832ns | 0.682 | 0.227 | 0 | 4.46 KB |
| #5966 | EnrichedLog |
net6.0 | 115μs | 117ns | 455ns | 0.0577 | 0 | 0 | 4.28 KB |
| #5966 | EnrichedLog |
netcoreapp3.1 | 119μs | 269ns | 1.04μs | 0.0594 | 0 | 0 | 4.28 KB |
| #5966 | EnrichedLog |
net472 | 150μs | 192ns | 745ns | 0.671 | 0.224 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 3.07μs | 0.986ns | 3.69ns | 0.0305 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
netcoreapp3.1 | 4.39μs | 0.973ns | 3.77ns | 0.0305 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
net472 | 4.85μs | 1.03ns | 4.01ns | 0.32 | 0 | 0 | 2.02 KB |
| #5966 | EnrichedLog |
net6.0 | 2.98μs | 0.995ns | 3.72ns | 0.03 | 0 | 0 | 2.2 KB |
| #5966 | EnrichedLog |
netcoreapp3.1 | 4.16μs | 1.26ns | 4.73ns | 0.0292 | 0 | 0 | 2.2 KB |
| #5966 | EnrichedLog |
net472 | 4.88μs | 1.7ns | 6.58ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.31μs | 0.747ns | 2.79ns | 0.0164 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.75μs | 0.965ns | 3.48ns | 0.0158 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.14μs | 1.44ns | 5.38ns | 0.183 | 0 | 0 | 1.16 KB |
| #5966 | SendReceive |
net6.0 | 1.38μs | 0.756ns | 2.93ns | 0.0159 | 0 | 0 | 1.14 KB |
| #5966 | SendReceive |
netcoreapp3.1 | 1.79μs | 2.46ns | 9.54ns | 0.0153 | 0 | 0 | 1.14 KB |
| #5966 | SendReceive |
net472 | 2.08μs | 1.12ns | 4.35ns | 0.183 | 0.00104 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.79μs | 1.15ns | 4.44ns | 0.0224 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.94μs | 2.01ns | 7.77ns | 0.0218 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.35μs | 1.25ns | 4.67ns | 0.322 | 0 | 0 | 2.04 KB |
| #5966 | EnrichedLog |
net6.0 | 2.77μs | 0.714ns | 2.67ns | 0.0221 | 0 | 0 | 1.6 KB |
| #5966 | EnrichedLog |
netcoreapp3.1 | 3.92μs | 1.03ns | 3.99ns | 0.0215 | 0 | 0 | 1.65 KB |
| #5966 | EnrichedLog |
net472 | 4.38μs | 2.48ns | 9.26ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5966
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.128
537.55
606.11
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.128 | 537.55 | 606.11 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 400ns | 0.257ns | 0.993ns | 0.00803 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 574ns | 1.16ns | 4.5ns | 0.00761 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 618ns | 0.706ns | 2.73ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 537ns | 0.549ns | 2.05ns | 0.00971 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 685ns | 1.12ns | 4.33ns | 0.00929 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 809ns | 0.641ns | 2.48ns | 0.104 | 0 | 0 | 658 B |
| #5966 | StartFinishSpan |
net6.0 | 381ns | 0.279ns | 1.08ns | 0.00802 | 0 | 0 | 576 B |
| #5966 | StartFinishSpan |
netcoreapp3.1 | 612ns | 0.829ns | 3.21ns | 0.00769 | 0 | 0 | 576 B |
| #5966 | StartFinishSpan |
net472 | 621ns | 1.02ns | 3.96ns | 0.0916 | 0 | 0 | 578 B |
| #5966 | StartFinishScope |
net6.0 | 607ns | 0.796ns | 3.08ns | 0.00966 | 0 | 0 | 696 B |
| #5966 | StartFinishScope |
netcoreapp3.1 | 726ns | 0.79ns | 3.06ns | 0.00909 | 0 | 0 | 696 B |
| #5966 | StartFinishScope |
net472 | 814ns | 1.34ns | 5.2ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 582ns | 0.413ns | 1.6ns | 0.00987 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 899ns | 1.01ns | 3.77ns | 0.00949 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.02μs | 1.54ns | 5.96ns | 0.104 | 0 | 0 | 658 B |
| #5966 | RunOnMethodBegin |
net6.0 | 601ns | 0.585ns | 2.27ns | 0.00965 | 0 | 0 | 696 B |
| #5966 | RunOnMethodBegin |
netcoreapp3.1 | 939ns | 0.957ns | 3.71ns | 0.00933 | 0 | 0 | 696 B |
| #5966 | RunOnMethodBegin |
net472 | 1.12μs | 1.43ns | 5.55ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
Added missing snapshot for netstd tests
Reason for change
Build was failing on master
Implementation details
Test coverage
Other details