Skip to content

[IAST] Added missing netstd snapshot#5966

Merged
andrewlock merged 1 commit into
masterfrom
dani/iast/netstd_cookie_test_fix
Aug 30, 2024
Merged

[IAST] Added missing netstd snapshot#5966
andrewlock merged 1 commit into
masterfrom
dani/iast/netstd_cookie_test_fix

Conversation

@dromanol

Copy link
Copy Markdown
Contributor

Summary of changes

Added missing snapshot for netstd tests

Reason for change

Build was failing on master

Implementation details

Test coverage

Other details

@dromanol dromanol added area:tests unit tests, integration tests area:asm-iast labels Aug 30, 2024
@dromanol
dromanol requested a review from a team as a code owner August 30, 2024 10:08
@github-actions

Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

+    },
+    {
+      "type": "NO_SAMESITE_COOKIE",
+      "hash": -1837181716,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.0"
+      }
+    },
+    {
+      "type": "NO_HTTPONLY_COOKIE",
+      "hash": 1990393425,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.0"
+      }
+    },
+    {
+      "type": "INSECURE_COOKIE",
+      "hash": 1170867602,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.0"
+      }
+    },
+    {
+      "type": "NO_SAMESITE_COOKIE",
+      "hash": -1837181716,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.1"
+      }
+    },
+    {
+      "type": "NO_HTTPONLY_COOKIE",
+      "hash": 1990393425,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.1"
+      }
+    },
+    {
+      "type": "INSECURE_COOKIE",
+      "hash": 1170867602,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.1"
+      }
+    },
+    {
+      "type": "NO_SAMESITE_COOKIE",
+      "hash": -1837181716,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.2"
+      }
+    },
+    {
+      "type": "NO_HTTPONLY_COOKIE",
+      "hash": 1990393425,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.2"
+      }
+    },
+    {
+      "type": "INSECURE_COOKIE",
+      "hash": 1170867602,
+      "evidence": {
+        "value": "LongCookie.abcdefghijklmnopqrstuvwxyz0123456789.2"
+      }

@datadog-ddstaging

datadog-ddstaging Bot commented Aug 30, 2024

Copy link
Copy Markdown

Datadog Report

Branch report: dani/iast/netstd_cookie_test_fix
Commit report: 1c6f7b5
Test service: dd-trace-dotnet

✅ 0 Failed, 388180 Passed, 2760 Skipped, 33h 50m 27.19s Total Time

@andrewlock

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5966 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.140
  • 1 benchmarks are slower, with geometric mean 1.128
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.76μs 43.7ns 303ns 0.0148 0.00738 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.78μs 55.1ns 389ns 0.0241 0.00963 0 5.61 KB
master StartStopWithChild net472 15.8μs 46.9ns 175ns 1.02 0.302 0.103 6.07 KB
#5966 StartStopWithChild net6.0 7.61μs 42ns 269ns 0.0155 0.00775 0 5.43 KB
#5966 StartStopWithChild netcoreapp3.1 10.1μs 53.2ns 271ns 0.0247 0.0148 0.00494 5.62 KB
#5966 StartStopWithChild net472 15.9μs 64.4ns 249ns 1.02 0.297 0.102 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 476μs 256ns 990ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 131ns 473ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 839μs 659ns 2.55μs 0.417 0 0 3.3 KB
#5966 WriteAndFlushEnrichedTraces net6.0 484μs 231ns 831ns 0 0 0 2.7 KB
#5966 WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 228ns 852ns 0 0 0 2.7 KB
#5966 WriteAndFlushEnrichedTraces net472 835μs 402ns 1.56μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 187μs 884ns 3.54μs 0.183 0 0 18.45 KB
master SendRequest netcoreapp3.1 207μs 1.1μs 5.91μs 0.209 0 0 20.61 KB
master SendRequest net472 0.0059ns 0.00211ns 0.00818ns 0 0 0 0 b
#5966 SendRequest net6.0 183μs 894ns 3.58μs 0.18 0 0 18.45 KB
#5966 SendRequest netcoreapp3.1 211μs 1.15μs 9.19μs 0.214 0 0 20.61 KB
#5966 SendRequest net472 0.00069ns 0.000436ns 0.00169ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 543μs 1.82μs 6.83μs 0.546 0 0 41.52 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.19μs 14.6μs 0.329 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 875μs 3.56μs 13.8μs 8.13 2.57 0.428 53.27 KB
#5966 WriteAndFlushEnrichedTraces net6.0 573μs 2.77μs 11.7μs 0.563 0 0 41.58 KB
#5966 WriteAndFlushEnrichedTraces netcoreapp3.1 680μs 3.46μs 15.1μs 0.336 0 0 41.77 KB
#5966 WriteAndFlushEnrichedTraces net472 858μs 4.06μs 16.7μs 8.13 2.57 0.428 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.35μs 1.31ns 5.06ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.72μs 1.68ns 6.5ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.02μs 0.813ns 2.93ns 0.157 0 0 987 B
#5966 ExecuteNonQuery net6.0 1.21μs 1.42ns 5.11ns 0.0145 0 0 1.02 KB
#5966 ExecuteNonQuery netcoreapp3.1 1.77μs 1.34ns 5.17ns 0.0141 0 0 1.02 KB
#5966 ExecuteNonQuery net472 2μs 1.96ns 7.58ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5966

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.140 1,345.55 1,180.66

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.497ns 1.86ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.46μs 0.583ns 2.1ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.47μs 1.59ns 5.97ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 1.64ns 6.37ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 0.594ns 2.3ns 0.0142 0 0 1.02 KB
master CallElasticsearchAsync net472 2.51μs 1.25ns 4.67ns 0.166 0 0 1.05 KB
#5966 CallElasticsearch net6.0 1.07μs 0.485ns 1.88ns 0.0135 0 0 976 B
#5966 CallElasticsearch netcoreapp3.1 1.55μs 1.46ns 5.66ns 0.0131 0 0 976 B
#5966 CallElasticsearch net472 2.41μs 5.6ns 20.9ns 0.158 0 0 995 B
#5966 CallElasticsearchAsync net6.0 1.18μs 0.99ns 3.7ns 0.0136 0 0 952 B
#5966 CallElasticsearchAsync netcoreapp3.1 1.62μs 0.824ns 3.08ns 0.0138 0 0 1.02 KB
#5966 CallElasticsearchAsync net472 2.55μs 0.744ns 2.58ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 0.561ns 2.1ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.783ns 2.82ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.73μs 0.546ns 2.04ns 0.145 0 0 915 B
#5966 ExecuteAsync net6.0 1.29μs 0.86ns 3.22ns 0.0129 0 0 952 B
#5966 ExecuteAsync netcoreapp3.1 1.65μs 1.25ns 4.66ns 0.013 0 0 952 B
#5966 ExecuteAsync net472 1.75μs 0.945ns 3.54ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.14μs 0.957ns 3.58ns 0.0311 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.1μs 2.15ns 8.05ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.75μs 2.41ns 9.35ns 0.496 0 0 3.15 KB
#5966 SendAsync net6.0 4.02μs 0.869ns 3.13ns 0.0303 0 0 2.22 KB
#5966 SendAsync netcoreapp3.1 5.15μs 3.65ns 14.1ns 0.0365 0 0 2.76 KB
#5966 SendAsync net472 7.64μs 2.22ns 8.59ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.435ns 1.68ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.38μs 0.732ns 2.74ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.71μs 1.55ns 5.99ns 0.249 0 0 1.57 KB
#5966 EnrichedLog net6.0 1.6μs 1.13ns 4.23ns 0.0234 0 0 1.64 KB
#5966 EnrichedLog netcoreapp3.1 2.28μs 0.679ns 2.63ns 0.0219 0 0 1.64 KB
#5966 EnrichedLog net472 2.74μs 1.44ns 5.21ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 134ns 502ns 0.0589 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 386ns 1.5μs 0 0 0 4.28 KB
master EnrichedLog net472 151μs 215ns 832ns 0.682 0.227 0 4.46 KB
#5966 EnrichedLog net6.0 115μs 117ns 455ns 0.0577 0 0 4.28 KB
#5966 EnrichedLog netcoreapp3.1 119μs 269ns 1.04μs 0.0594 0 0 4.28 KB
#5966 EnrichedLog net472 150μs 192ns 745ns 0.671 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 0.986ns 3.69ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.39μs 0.973ns 3.77ns 0.0305 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.03ns 4.01ns 0.32 0 0 2.02 KB
#5966 EnrichedLog net6.0 2.98μs 0.995ns 3.72ns 0.03 0 0 2.2 KB
#5966 EnrichedLog netcoreapp3.1 4.16μs 1.26ns 4.73ns 0.0292 0 0 2.2 KB
#5966 EnrichedLog net472 4.88μs 1.7ns 6.58ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 0.747ns 2.79ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 0.965ns 3.48ns 0.0158 0 0 1.14 KB
master SendReceive net472 2.14μs 1.44ns 5.38ns 0.183 0 0 1.16 KB
#5966 SendReceive net6.0 1.38μs 0.756ns 2.93ns 0.0159 0 0 1.14 KB
#5966 SendReceive netcoreapp3.1 1.79μs 2.46ns 9.54ns 0.0153 0 0 1.14 KB
#5966 SendReceive net472 2.08μs 1.12ns 4.35ns 0.183 0.00104 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 1.15ns 4.44ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 2.01ns 7.77ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.35μs 1.25ns 4.67ns 0.322 0 0 2.04 KB
#5966 EnrichedLog net6.0 2.77μs 0.714ns 2.67ns 0.0221 0 0 1.6 KB
#5966 EnrichedLog netcoreapp3.1 3.92μs 1.03ns 3.99ns 0.0215 0 0 1.65 KB
#5966 EnrichedLog net472 4.38μs 2.48ns 9.26ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5966

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.128 537.55 606.11

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 400ns 0.257ns 0.993ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 574ns 1.16ns 4.5ns 0.00761 0 0 576 B
master StartFinishSpan net472 618ns 0.706ns 2.73ns 0.0916 0 0 578 B
master StartFinishScope net6.0 537ns 0.549ns 2.05ns 0.00971 0 0 696 B
master StartFinishScope netcoreapp3.1 685ns 1.12ns 4.33ns 0.00929 0 0 696 B
master StartFinishScope net472 809ns 0.641ns 2.48ns 0.104 0 0 658 B
#5966 StartFinishSpan net6.0 381ns 0.279ns 1.08ns 0.00802 0 0 576 B
#5966 StartFinishSpan netcoreapp3.1 612ns 0.829ns 3.21ns 0.00769 0 0 576 B
#5966 StartFinishSpan net472 621ns 1.02ns 3.96ns 0.0916 0 0 578 B
#5966 StartFinishScope net6.0 607ns 0.796ns 3.08ns 0.00966 0 0 696 B
#5966 StartFinishScope netcoreapp3.1 726ns 0.79ns 3.06ns 0.00909 0 0 696 B
#5966 StartFinishScope net472 814ns 1.34ns 5.2ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 582ns 0.413ns 1.6ns 0.00987 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 899ns 1.01ns 3.77ns 0.00949 0 0 696 B
master RunOnMethodBegin net472 1.02μs 1.54ns 5.96ns 0.104 0 0 658 B
#5966 RunOnMethodBegin net6.0 601ns 0.585ns 2.27ns 0.00965 0 0 696 B
#5966 RunOnMethodBegin netcoreapp3.1 939ns 0.957ns 3.71ns 0.00933 0 0 696 B
#5966 RunOnMethodBegin net472 1.12μs 1.43ns 5.55ns 0.104 0 0 658 B

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewlock
andrewlock merged commit d21bf77 into master Aug 30, 2024
@andrewlock
andrewlock deleted the dani/iast/netstd_cookie_test_fix branch August 30, 2024 14:02
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:asm-iast area:tests unit tests, integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants