Skip to content

Fix debugger arm64 alpine tests#5965

Merged
andrewlock merged 1 commit into
masterfrom
andrew/try-fix-debugger-tests
Aug 30, 2024
Merged

Fix debugger arm64 alpine tests#5965
andrewlock merged 1 commit into
masterfrom
andrew/try-fix-debugger-tests

Conversation

@andrewlock

@andrewlock andrewlock commented Aug 30, 2024

Copy link
Copy Markdown
Member

Summary of changes

Fixes the debugger alpine tests that were broken by #5933

Reason for change

The debugger tests were broken, but because that PR didn't run the debugger tests by default, we didn't notice.

Implementation details

Download the correct artifacts in arm64 alpine

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 30, 2024
@andrewlock
andrewlock requested a review from a team as a code owner August 30, 2024 09:47
@andrewlock
andrewlock force-pushed the andrew/try-fix-debugger-tests branch from f6d743a to 1c9fb7c Compare August 30, 2024 09:50
@datadog-ddstaging

datadog-ddstaging Bot commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/try-fix-debugger-tests
Commit report: 1c9fb7c
Test service: dd-trace-dotnet

✅ 0 Failed, 363037 Passed, 2049 Skipped, 15h 13m 5.69s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

  • EarlyFlakeDetection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.PipesXUnitEvpTests - Last Failure

    Expand for error 
     
 Actual:   121 Failure

  • TypicalLoop_WithLogsQueueTrigger - Datadog.Trace.Tests.Telemetry.TelemetryControllerSchedulerTests - Last Failure

    Expand for error 
     Expected _scheduler.ShouldFlushRedactedErrorLogs to be true, but found False.

@andrewlock

andrewlock commented Aug 30, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock

andrewlock commented Aug 30, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5965 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.122
  • 1 benchmarks are slower, with geometric mean 1.311
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.76μs 43.7ns 303ns 0.0148 0.00738 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.78μs 55.1ns 389ns 0.0241 0.00963 0 5.61 KB
master StartStopWithChild net472 15.8μs 46.9ns 175ns 1.02 0.302 0.103 6.07 KB
#5965 StartStopWithChild net6.0 7.68μs 43.3ns 306ns 0.0198 0.00791 0 5.42 KB
#5965 StartStopWithChild netcoreapp3.1 10μs 55.1ns 353ns 0.0197 0.00987 0 5.61 KB
#5965 StartStopWithChild net472 16μs 65.3ns 253ns 1.03 0.308 0.0949 6.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 476μs 256ns 990ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 131ns 473ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 839μs 659ns 2.55μs 0.417 0 0 3.3 KB
#5965 WriteAndFlushEnrichedTraces net6.0 479μs 188ns 705ns 0 0 0 2.7 KB
#5965 WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 125ns 451ns 0 0 0 2.7 KB
#5965 WriteAndFlushEnrichedTraces net472 836μs 649ns 2.51μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 187μs 884ns 3.54μs 0.183 0 0 18.45 KB
master SendRequest netcoreapp3.1 207μs 1.1μs 5.91μs 0.209 0 0 20.61 KB
master SendRequest net472 0.0059ns 0.00211ns 0.00818ns 0 0 0 0 b
#5965 SendRequest net6.0 179μs 607ns 2.27μs 0.185 0 0 18.45 KB
#5965 SendRequest netcoreapp3.1 200μs 967ns 3.99μs 0.151 0 0 20.61 KB
#5965 SendRequest net472 0.000204ns 0.000119ns 0.000446ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 543μs 1.82μs 6.83μs 0.546 0 0 41.52 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.19μs 14.6μs 0.329 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 875μs 3.56μs 13.8μs 8.13 2.57 0.428 53.27 KB
#5965 WriteAndFlushEnrichedTraces net6.0 557μs 1.84μs 7.14μs 0.563 0 0 41.59 KB
#5965 WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 2.7μs 10.5μs 0.332 0 0 41.77 KB
#5965 WriteAndFlushEnrichedTraces net472 868μs 3.64μs 14.1μs 8.45 2.53 0.422 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.35μs 1.31ns 5.06ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.72μs 1.68ns 6.5ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.02μs 0.813ns 2.93ns 0.157 0 0 987 B
#5965 ExecuteNonQuery net6.0 1.34μs 1.11ns 4.3ns 0.0141 0 0 1.02 KB
#5965 ExecuteNonQuery netcoreapp3.1 1.62μs 1.34ns 5.18ns 0.0137 0 0 1.02 KB
#5965 ExecuteNonQuery net472 2.02μs 1.54ns 5.98ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.497ns 1.86ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.46μs 0.583ns 2.1ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.47μs 1.59ns 5.97ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 1.64ns 6.37ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 0.594ns 2.3ns 0.0142 0 0 1.02 KB
master CallElasticsearchAsync net472 2.51μs 1.25ns 4.67ns 0.166 0 0 1.05 KB
#5965 CallElasticsearch net6.0 1.24μs 0.917ns 3.3ns 0.0136 0 0 976 B
#5965 CallElasticsearch netcoreapp3.1 1.53μs 0.454ns 1.7ns 0.0129 0 0 976 B
#5965 CallElasticsearch net472 2.45μs 1.95ns 7.55ns 0.158 0 0 995 B
#5965 CallElasticsearchAsync net6.0 1.27μs 0.458ns 1.77ns 0.0134 0 0 952 B
#5965 CallElasticsearchAsync netcoreapp3.1 1.7μs 0.967ns 3.75ns 0.0135 0 0 1.02 KB
#5965 CallElasticsearchAsync net472 2.5μs 1.2ns 4.48ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 0.561ns 2.1ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.783ns 2.82ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.73μs 0.546ns 2.04ns 0.145 0 0 915 B
#5965 ExecuteAsync net6.0 1.28μs 5.3ns 19.1ns 0.0134 0 0 952 B
#5965 ExecuteAsync netcoreapp3.1 1.63μs 1.04ns 3.91ns 0.0127 0 0 952 B
#5965 ExecuteAsync net472 1.8μs 1.11ns 4.29ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.14μs 0.957ns 3.58ns 0.0311 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.1μs 2.15ns 8.05ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.75μs 2.41ns 9.35ns 0.496 0 0 3.15 KB
#5965 SendAsync net6.0 4.1μs 1.07ns 3.99ns 0.0308 0 0 2.22 KB
#5965 SendAsync netcoreapp3.1 5.01μs 1.76ns 6.8ns 0.0379 0 0 2.76 KB
#5965 SendAsync net472 7.87μs 1.8ns 6.96ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.435ns 1.68ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.38μs 0.732ns 2.74ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.71μs 1.55ns 5.99ns 0.249 0 0 1.57 KB
#5965 EnrichedLog net6.0 1.54μs 0.823ns 3.19ns 0.0232 0 0 1.64 KB
#5965 EnrichedLog netcoreapp3.1 2.2μs 0.73ns 2.73ns 0.0219 0 0 1.64 KB
#5965 EnrichedLog net472 2.8μs 1.42ns 5.5ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 134ns 502ns 0.0589 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 386ns 1.5μs 0 0 0 4.28 KB
master EnrichedLog net472 151μs 215ns 832ns 0.682 0.227 0 4.46 KB
#5965 EnrichedLog net6.0 116μs 114ns 441ns 0 0 0 4.28 KB
#5965 EnrichedLog netcoreapp3.1 120μs 256ns 991ns 0 0 0 4.28 KB
#5965 EnrichedLog net472 149μs 260ns 1.01μs 0.665 0.222 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 0.986ns 3.69ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.39μs 0.973ns 3.77ns 0.0305 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.03ns 4.01ns 0.32 0 0 2.02 KB
#5965 EnrichedLog net6.0 3.06μs 0.824ns 3.19ns 0.0305 0 0 2.2 KB
#5965 EnrichedLog netcoreapp3.1 4.09μs 1.58ns 5.91ns 0.0306 0 0 2.2 KB
#5965 EnrichedLog net472 4.96μs 1.77ns 6.87ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 0.747ns 2.79ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 0.965ns 3.48ns 0.0158 0 0 1.14 KB
master SendReceive net472 2.14μs 1.44ns 5.38ns 0.183 0 0 1.16 KB
#5965 SendReceive net6.0 1.4μs 0.957ns 3.71ns 0.016 0 0 1.14 KB
#5965 SendReceive netcoreapp3.1 1.66μs 1.05ns 4.07ns 0.0158 0 0 1.14 KB
#5965 SendReceive net472 2.16μs 1.18ns 4.42ns 0.183 0.00108 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 1.15ns 4.44ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 2.01ns 7.77ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.35μs 1.25ns 4.67ns 0.322 0 0 2.04 KB
#5965 EnrichedLog net6.0 2.88μs 1.11ns 4.29ns 0.0222 0 0 1.6 KB
#5965 EnrichedLog netcoreapp3.1 3.95μs 1.9ns 7.35ns 0.0216 0 0 1.65 KB
#5965 EnrichedLog net472 4.43μs 1.73ns 6.69ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5965

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.122 537.55 479.31

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 400ns 0.257ns 0.993ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 574ns 1.16ns 4.5ns 0.00761 0 0 576 B
master StartFinishSpan net472 618ns 0.706ns 2.73ns 0.0916 0 0 578 B
master StartFinishScope net6.0 537ns 0.549ns 2.05ns 0.00971 0 0 696 B
master StartFinishScope netcoreapp3.1 685ns 1.12ns 4.33ns 0.00929 0 0 696 B
master StartFinishScope net472 809ns 0.641ns 2.48ns 0.104 0 0 658 B
#5965 StartFinishSpan net6.0 443ns 0.192ns 0.717ns 0.00801 0 0 576 B
#5965 StartFinishSpan netcoreapp3.1 552ns 0.373ns 1.44ns 0.00769 0 0 576 B
#5965 StartFinishSpan net472 667ns 0.589ns 2.28ns 0.0918 0 0 578 B
#5965 StartFinishScope net6.0 479ns 0.375ns 1.45ns 0.00983 0 0 696 B
#5965 StartFinishScope netcoreapp3.1 670ns 0.717ns 2.78ns 0.00927 0 0 696 B
#5965 StartFinishScope net472 851ns 1.37ns 5.31ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5965

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.311 582.23 763.24

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 582ns 0.413ns 1.6ns 0.00987 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 899ns 1.01ns 3.77ns 0.00949 0 0 696 B
master RunOnMethodBegin net472 1.02μs 1.54ns 5.96ns 0.104 0 0 658 B
#5965 RunOnMethodBegin net6.0 763ns 0.945ns 3.66ns 0.01 0 0 696 B
#5965 RunOnMethodBegin netcoreapp3.1 923ns 0.584ns 2.26ns 0.00939 0 0 696 B
#5965 RunOnMethodBegin net472 1.06μs 1.68ns 6.52ns 0.104 0 0 658 B

@andrewlock
andrewlock merged commit 1973973 into master Aug 30, 2024
@andrewlock
andrewlock deleted the andrew/try-fix-debugger-tests branch August 30, 2024 12:24
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @kevingosse