Skip to content

Remove the xml and pdb files from the linux packages#5961

Merged
andrewlock merged 1 commit into
masterfrom
andrew/remove-xml-and-pdb-files-from-artifacts
Aug 29, 2024
Merged

Remove the xml and pdb files from the linux packages#5961
andrewlock merged 1 commit into
masterfrom
andrew/remove-xml-and-pdb-files-from-artifacts

Conversation

@andrewlock

@andrewlock andrewlock commented Aug 28, 2024

Copy link
Copy Markdown
Member

Summary of changes

Remove the xml and pdb files from the linux packages

Reason for change

They're not actually used for anything, and just increase the size of artifacts

Implementation details

Remove the xml and pdb files just before packaging

Test coverage

File size changes previous -> now:

  • linux-x64 deb/rpm : 21MB -> 19MB compressed
  • linux-x64 tar : 30MB -> 25MB compressed
  • linux-musl-x64 tar : 22MB -> 17MB compressed
  • linux-arm64 deb/rpm : 21MB -> 18MB compressed
  • linux-arm64 tar : 28MB -> 24MB compressed

Uncompressed changes are much bigger because we have pretty much 3 copies of each file so e.g. 84MB vs 58MB

Other details

For simplicity, stacked on:

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 28, 2024
@andrewlock
andrewlock requested a review from a team as a code owner August 28, 2024 15:06
@datadog-ddstaging

datadog-ddstaging Bot commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/remove-xml-and-pdb-files-from-artifacts
Commit report: b528238
Test service: dd-trace-dotnet

✅ 0 Failed, 363854 Passed, 2091 Skipped, 15h 2m 44.96s Total Time

@andrewlock

andrewlock commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock
andrewlock force-pushed the andrew/arm64-musl-support branch from b510659 to a51bfd5 Compare August 28, 2024 15:54
@andrewlock
andrewlock requested review from a team as code owners August 28, 2024 15:54
@andrewlock
andrewlock force-pushed the andrew/remove-xml-and-pdb-files-from-artifacts branch from 42c1c3a to 66367c5 Compare August 28, 2024 15:56
@andrewlock

andrewlock commented Aug 28, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for appsec 🐌

Benchmarks for #5961 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.166
  • 1 benchmarks are slower, with geometric mean 1.166
  • 2 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5961

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 1.166 3,786.00 4,416.20

Faster 🎉 in #5961

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.178 173.28 147.09

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 74μs 128ns 496ns 0.0744 0 0 6 KB
master AllCycleSimpleBody netcoreapp3.1 61.8μs 87.3ns 338ns 0.0617 0 0 6.95 KB
master AllCycleSimpleBody net472 49.1μs 60.6ns 235ns 1.31 0 0 8.34 KB
master AllCycleMoreComplexBody net6.0 79.7μs 104ns 389ns 0.12 0 0 9.51 KB
master AllCycleMoreComplexBody netcoreapp3.1 68.8μs 79.4ns 297ns 0.137 0 0 10.36 KB
master AllCycleMoreComplexBody net472 56.4μs 47.8ns 179ns 1.86 0.0282 0 11.85 KB
master ObjectExtractorSimpleBody net6.0 173ns 0.127ns 0.49ns 0.00397 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 219ns 0.342ns 1.32ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 167ns 0.173ns 0.671ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.05μs 0.915ns 3.42ns 0.053 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.99μs 2.51ns 9.38ns 0.0499 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.79μs 2.6ns 9.73ns 0.603 0.00568 0 3.8 KB
#5961 AllCycleSimpleBody net6.0 73.3μs 76.5ns 296ns 0.0732 0 0 6 KB
#5961 AllCycleSimpleBody netcoreapp3.1 62.2μs 58.2ns 218ns 0.0928 0 0 6.95 KB
#5961 AllCycleSimpleBody net472 48.9μs 60ns 224ns 1.32 0 0 8.34 KB
#5961 AllCycleMoreComplexBody net6.0 81.4μs 120ns 464ns 0.122 0 0 9.51 KB
#5961 AllCycleMoreComplexBody netcoreapp3.1 70.2μs 112ns 419ns 0.139 0 0 10.36 KB
#5961 AllCycleMoreComplexBody net472 56.8μs 88.8ns 344ns 1.87 0.0287 0 11.85 KB
#5961 ObjectExtractorSimpleBody net6.0 147ns 0.182ns 0.707ns 0.00396 0 0 280 B
#5961 ObjectExtractorSimpleBody netcoreapp3.1 206ns 0.188ns 0.676ns 0.00378 0 0 272 B
#5961 ObjectExtractorSimpleBody net472 165ns 0.139ns 0.537ns 0.0446 0 0 281 B
#5961 ObjectExtractorMoreComplexBody net6.0 3.24μs 6.01ns 22.5ns 0.0532 0 0 3.78 KB
#5961 ObjectExtractorMoreComplexBody netcoreapp3.1 4.04μs 2.06ns 7.99ns 0.0506 0 0 3.69 KB
#5961 ObjectExtractorMoreComplexBody net472 4.41μs 3.34ns 11.6ns 0.602 0.00662 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5961

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 1.153 79,185.73 68,653.45

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37.1μs 24.3ns 90.9ns 0.447 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54.1μs 24.3ns 94.3ns 0.433 0 0 32.4 KB
master EncodeArgs net472 65.5μs 35ns 135ns 5.16 0.0653 0 32.5 KB
master EncodeLegacyArgs net6.0 79.2μs 20.9ns 81ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 106μs 257ns 994ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 152μs 86.2ns 334ns 0.302 0 0 2.15 KB
#5961 EncodeArgs net6.0 37.1μs 17.1ns 59.3ns 0.445 0 0 32.4 KB
#5961 EncodeArgs netcoreapp3.1 55.1μs 15.4ns 59.5ns 0.44 0 0 32.4 KB
#5961 EncodeArgs net472 66.5μs 23.1ns 86.5ns 5.14 0.0663 0 32.5 KB
#5961 EncodeLegacyArgs net6.0 68.7μs 21.5ns 83.3ns 0 0 0 2.14 KB
#5961 EncodeLegacyArgs netcoreapp3.1 103μs 87.7ns 340ns 0 0 0 2.14 KB
#5961 EncodeLegacyArgs net472 152μs 88.3ns 342ns 0.305 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 185μs 167ns 645ns 0 0 0 2.42 KB
master RunWafRealisticBenchmark netcoreapp3.1 197μs 344ns 1.33μs 0 0 0 2.37 KB
master RunWafRealisticBenchmark net472 208μs 82.1ns 318ns 0.311 0 0 2.43 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 40.6ns 157ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 129μs 91.5ns 342ns 0 0 0 1.45 KB
master RunWafRealisticBenchmarkWithAttack net472 140μs 87.9ns 340ns 0.209 0 0 1.48 KB
#5961 RunWafRealisticBenchmark net6.0 183μs 59.8ns 224ns 0 0 0 2.42 KB
#5961 RunWafRealisticBenchmark netcoreapp3.1 196μs 177ns 684ns 0 0 0 2.37 KB
#5961 RunWafRealisticBenchmark net472 210μs 38.4ns 144ns 0.316 0 0 2.43 KB
#5961 RunWafRealisticBenchmarkWithAttack net6.0 122μs 25.5ns 98.7ns 0 0 0 1.46 KB
#5961 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 103ns 398ns 0 0 0 1.45 KB
#5961 RunWafRealisticBenchmarkWithAttack net472 138μs 37.6ns 141ns 0.208 0 0 1.48 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5961

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 254.64 KB 256.78 KB 2.14 KB 0.84%

Fewer allocations 🎉 in #5961

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 59.21 KB 57.97 KB -1.24 KB -2.09%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 265 KB 257.42 KB -7.58 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 56.7μs 618ns 6.12μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 54.1μs 284ns 1.51μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.1μs 179ns 714ns 0 0 0 59.21 KB
master StringConcatAspectBenchmark net6.0 306μs 1.53μs 8.23μs 0 0 0 254.64 KB
master StringConcatAspectBenchmark netcoreapp3.1 348μs 1.98μs 13.4μs 0 0 0 265 KB
master StringConcatAspectBenchmark net472 284μs 5.6μs 54.6μs 0 0 0 278.53 KB
#5961 StringConcatBenchmark net6.0 61.3μs 677ns 6.63μs 0 0 0 43.44 KB
#5961 StringConcatBenchmark netcoreapp3.1 53.6μs 278ns 1.36μs 0 0 0 42.64 KB
#5961 StringConcatBenchmark net472 37.5μs 98.1ns 354ns 0 0 0 57.97 KB
#5961 StringConcatAspectBenchmark net6.0 318μs 1.7μs 11.7μs 0 0 0 256.78 KB
#5961 StringConcatAspectBenchmark netcoreapp3.1 327μs 2.74μs 25.4μs 0 0 0 257.42 KB
#5961 StringConcatAspectBenchmark net472 296μs 7.43μs 72.4μs 0 0 0 278.53 KB

Base automatically changed from andrew/arm64-musl-support to master August 28, 2024 18:35
@andrewlock

andrewlock commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5961 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.155
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.67μs 40ns 188ns 0.0189 0.00756 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.82μs 51.7ns 264ns 0.0189 0.00945 0 5.62 KB
master StartStopWithChild net472 15.9μs 47.4ns 184ns 1.02 0.305 0.0937 6.06 KB
#5961 StartStopWithChild net6.0 7.82μs 43.9ns 285ns 0.0148 0.00739 0 5.43 KB
#5961 StartStopWithChild netcoreapp3.1 9.71μs 52.4ns 277ns 0.0241 0.00963 0 5.61 KB
#5961 StartStopWithChild net472 16μs 50.4ns 195ns 1.02 0.309 0.0951 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 481μs 455ns 1.76μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 358ns 1.34μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 842μs 537ns 2.08μs 0.417 0 0 3.3 KB
#5961 WriteAndFlushEnrichedTraces net6.0 469μs 274ns 1.06μs 0 0 0 2.7 KB
#5961 WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 149ns 557ns 0 0 0 2.7 KB
#5961 WriteAndFlushEnrichedTraces net472 849μs 586ns 2.27μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 189μs 1.05μs 6.57μs 0.183 0 0 18.45 KB
master SendRequest netcoreapp3.1 212μs 1.18μs 7.36μs 0.203 0 0 20.61 KB
master SendRequest net472 0.000145ns 9.9E‑05ns 0.00037ns 0 0 0 0 b
#5961 SendRequest net6.0 187μs 957ns 4.59μs 0.265 0 0 18.45 KB
#5961 SendRequest netcoreapp3.1 208μs 1.19μs 8.68μs 0.203 0 0 20.61 KB
#5961 SendRequest net472 0.00203ns 0.000826ns 0.0032ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5961

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.59 KB 41.83 KB 239 B 0.57%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 557μs 1.82μs 6.56μs 0.558 0 0 41.56 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 682μs 3.65μs 19.3μs 0.334 0 0 41.59 KB
master WriteAndFlushEnrichedTraces net472 883μs 3.56μs 15.1μs 8.42 2.66 0.443 53.31 KB
#5961 WriteAndFlushEnrichedTraces net6.0 552μs 1.34μs 4.84μs 0.539 0 0 41.45 KB
#5961 WriteAndFlushEnrichedTraces netcoreapp3.1 674μs 1.62μs 5.84μs 0.329 0 0 41.83 KB
#5961 WriteAndFlushEnrichedTraces net472 902μs 3.3μs 12.8μs 8.21 2.28 0.456 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 0.992ns 3.84ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.7μs 1.64ns 6.13ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 1.99μs 2.65ns 10.3ns 0.156 0 0 987 B
#5961 ExecuteNonQuery net6.0 1.4μs 0.961ns 3.72ns 0.0147 0 0 1.02 KB
#5961 ExecuteNonQuery netcoreapp3.1 1.78μs 0.912ns 3.53ns 0.0132 0 0 1.02 KB
#5961 ExecuteNonQuery net472 2.03μs 1.09ns 4.08ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.26μs 0.869ns 3.25ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.59μs 0.634ns 2.37ns 0.0134 0 0 976 B
master CallElasticsearch net472 2.53μs 1.04ns 3.91ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.2μs 1.24ns 4.82ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 0.639ns 2.39ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.56μs 1.61ns 6.03ns 0.166 0 0 1.05 KB
#5961 CallElasticsearch net6.0 1.19μs 2.23ns 8.33ns 0.0136 0 0 976 B
#5961 CallElasticsearch netcoreapp3.1 1.57μs 0.583ns 2.1ns 0.0133 0 0 976 B
#5961 CallElasticsearch net472 2.39μs 1.33ns 5.14ns 0.158 0 0 995 B
#5961 CallElasticsearchAsync net6.0 1.27μs 1.47ns 5.69ns 0.0133 0 0 952 B
#5961 CallElasticsearchAsync netcoreapp3.1 1.62μs 0.899ns 3.48ns 0.0138 0 0 1.02 KB
#5961 CallElasticsearchAsync net472 2.66μs 2.75ns 10.7ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.16μs 0.568ns 2.2ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.58μs 1.29ns 4.83ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.81μs 0.756ns 2.93ns 0.145 0 0 915 B
#5961 ExecuteAsync net6.0 1.16μs 0.802ns 3ns 0.0135 0 0 952 B
#5961 ExecuteAsync netcoreapp3.1 1.64μs 0.897ns 3.35ns 0.0123 0 0 952 B
#5961 ExecuteAsync net472 1.72μs 0.85ns 3.29ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.09μs 1.5ns 5.63ns 0.0307 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.21μs 2.29ns 8.87ns 0.0364 0 0 2.76 KB
master SendAsync net472 7.76μs 2.74ns 10.6ns 0.498 0 0 3.15 KB
#5961 SendAsync net6.0 4.03μs 4.09ns 15.8ns 0.0305 0 0 2.22 KB
#5961 SendAsync netcoreapp3.1 5.13μs 11.1ns 42.9ns 0.0356 0 0 2.76 KB
#5961 SendAsync net472 7.76μs 1.74ns 6.73ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.877ns 3.4ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.32μs 2.43ns 9.1ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.79μs 1.91ns 7.41ns 0.25 0 0 1.57 KB
#5961 EnrichedLog net6.0 1.53μs 0.848ns 3.17ns 0.0232 0 0 1.64 KB
#5961 EnrichedLog netcoreapp3.1 2.3μs 8.44ns 32.7ns 0.0227 0 0 1.64 KB
#5961 EnrichedLog net472 2.66μs 2.19ns 8.19ns 0.248 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 104ns 389ns 0.0568 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 425ns 1.53μs 0 0 0 4.28 KB
master EnrichedLog net472 148μs 218ns 815ns 0.667 0.222 0 4.46 KB
#5961 EnrichedLog net6.0 116μs 185ns 716ns 0 0 0 4.28 KB
#5961 EnrichedLog netcoreapp3.1 118μs 264ns 1.02μs 0.0593 0 0 4.28 KB
#5961 EnrichedLog net472 150μs 260ns 1.01μs 0.681 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.06μs 1.08ns 3.89ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.17μs 3.12ns 11.2ns 0.0291 0 0 2.2 KB
master EnrichedLog net472 4.87μs 2.96ns 11.1ns 0.32 0 0 2.02 KB
#5961 EnrichedLog net6.0 2.96μs 1.15ns 4.3ns 0.0311 0 0 2.2 KB
#5961 EnrichedLog netcoreapp3.1 4.27μs 2.2ns 8.51ns 0.0298 0 0 2.2 KB
#5961 EnrichedLog net472 4.88μs 1.53ns 5.92ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 1.09ns 4.08ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 0.826ns 3.2ns 0.0157 0 0 1.14 KB
master SendReceive net472 2.12μs 1.14ns 4.42ns 0.183 0 0 1.16 KB
#5961 SendReceive net6.0 1.28μs 1.58ns 6.13ns 0.0159 0 0 1.14 KB
#5961 SendReceive netcoreapp3.1 1.72μs 0.66ns 2.47ns 0.0155 0 0 1.14 KB
#5961 SendReceive net472 2.11μs 1.39ns 5.37ns 0.183 0.00105 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 3.94ns 15.3ns 0.0218 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.98μs 1.24ns 4.82ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.29μs 2.53ns 9.82ns 0.322 0 0 2.04 KB
#5961 EnrichedLog net6.0 2.81μs 2.11ns 7.62ns 0.0225 0 0 1.6 KB
#5961 EnrichedLog netcoreapp3.1 3.94μs 1.72ns 6.66ns 0.0218 0 0 1.65 KB
#5961 EnrichedLog net472 4.35μs 1.6ns 6.22ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5961

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.155 478.17 552.50

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 400ns 0.304ns 1.18ns 0.00802 0 0 576 B
master StartFinishSpan netcoreapp3.1 607ns 0.444ns 1.72ns 0.00789 0 0 576 B
master StartFinishSpan net472 633ns 0.405ns 1.57ns 0.0916 0 0 578 B
master StartFinishScope net6.0 478ns 0.375ns 1.45ns 0.00979 0 0 696 B
master StartFinishScope netcoreapp3.1 774ns 0.694ns 2.6ns 0.00932 0 0 696 B
master StartFinishScope net472 774ns 1.28ns 4.97ns 0.104 0 0 658 B
#5961 StartFinishSpan net6.0 396ns 0.303ns 1.17ns 0.00816 0 0 576 B
#5961 StartFinishSpan netcoreapp3.1 577ns 1.05ns 4.06ns 0.00783 0 0 576 B
#5961 StartFinishSpan net472 615ns 0.328ns 1.27ns 0.0915 0 0 578 B
#5961 StartFinishScope net6.0 552ns 0.328ns 1.27ns 0.00973 0 0 696 B
#5961 StartFinishScope netcoreapp3.1 799ns 1.13ns 4.37ns 0.00952 0 0 696 B
#5961 StartFinishScope net472 849ns 1.14ns 4.4ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 638ns 0.489ns 1.89ns 0.00993 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.05μs 0.533ns 2.07ns 0.00946 0 0 696 B
master RunOnMethodBegin net472 1.03μs 1.74ns 6.72ns 0.105 0 0 658 B
#5961 RunOnMethodBegin net6.0 632ns 0.719ns 2.78ns 0.0098 0 0 696 B
#5961 RunOnMethodBegin netcoreapp3.1 983ns 0.842ns 3.04ns 0.0093 0 0 696 B
#5961 RunOnMethodBegin net472 1.08μs 0.827ns 3.2ns 0.104 0 0 658 B

@andrewlock
andrewlock force-pushed the andrew/remove-xml-and-pdb-files-from-artifacts branch from 66367c5 to b528238 Compare August 29, 2024 06:15
@andrewlock
andrewlock merged commit d58fdb9 into master Aug 29, 2024
@andrewlock
andrewlock deleted the andrew/remove-xml-and-pdb-files-from-artifacts branch August 29, 2024 11:46
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
+1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @kevingosse