Skip to content

[Crashtracking] Keep mangled name in case of error#5952

Merged
kevingosse merged 1 commit into
masterfrom
kevin/unmangle
Aug 30, 2024
Merged

[Crashtracking] Keep mangled name in case of error#5952
kevingosse merged 1 commit into
masterfrom
kevin/unmangle

Conversation

@kevingosse

@kevingosse kevingosse commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

If libdatadog failed to demangle a symbol name, keep the mangled name.

Reason for change

That was an oversight. It's better to have a mangled name than no name at all.

Implementation details

Moved a boolean around.

Test coverage

There are no tests because I don't know why it would fail to begin with.

@kevingosse
kevingosse requested a review from a team as a code owner August 27, 2024 13:06
@andrewlock

andrewlock commented Aug 27, 2024

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@datadog-ddstaging

datadog-ddstaging Bot commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: kevin/unmangle
Commit report: fc1119b
Test service: dd-trace-dotnet

✅ 0 Failed, 301627 Passed, 1859 Skipped, 14h 4m 40.53s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Last Failure

    Expand for error 
     
 Expected var integration = latestIntegrations {empty} to contain key "CurlHandler".), but no such item was found.t found False.

@andrewlock

andrewlock commented Aug 27, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5952 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.193
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.68μs 42.5ns 272ns 0.0148 0.00738 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.91μs 52.5ns 273ns 0.0192 0.00962 0 5.62 KB
master StartStopWithChild net472 16μs 55.9ns 216ns 1.02 0.302 0.103 6.06 KB
#5952 StartStopWithChild net6.0 7.82μs 42.3ns 228ns 0.0145 0.00727 0 5.43 KB
#5952 StartStopWithChild netcoreapp3.1 10.1μs 56.1ns 359ns 0.0205 0.0102 0 5.62 KB
#5952 StartStopWithChild net472 16.1μs 44.2ns 166ns 1.03 0.322 0.105 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 465μs 200ns 722ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 278ns 1.08μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 836μs 677ns 2.62μs 0.417 0 0 3.3 KB
#5952 WriteAndFlushEnrichedTraces net6.0 469μs 166ns 622ns 0 0 0 2.7 KB
#5952 WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 469ns 1.82μs 0 0 0 2.7 KB
#5952 WriteAndFlushEnrichedTraces net472 836μs 594ns 2.3μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 192μs 1.11μs 9.5μs 0.182 0 0 18.45 KB
master SendRequest netcoreapp3.1 208μs 1.15μs 7.46μs 0.198 0 0 20.61 KB
master SendRequest net472 0.001ns 0.000448ns 0.00168ns 0 0 0 0 b
#5952 SendRequest net6.0 194μs 1.08μs 10.3μs 0.181 0 0 18.45 KB
#5952 SendRequest netcoreapp3.1 212μs 1.15μs 6.92μs 0.213 0 0 20.61 KB
#5952 SendRequest net472 0.000315ns 0.000276ns 0.00103ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 555μs 2.33μs 8.42μs 0.566 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 2.33μs 8.41μs 0.326 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 852μs 2.35μs 9.1μs 8.39 2.52 0.419 53.3 KB
#5952 WriteAndFlushEnrichedTraces net6.0 571μs 2.44μs 8.45μs 0.598 0 0 41.6 KB
#5952 WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 3.38μs 14.7μs 0.329 0 0 41.84 KB
#5952 WriteAndFlushEnrichedTraces net472 867μs 4.13μs 16μs 8.13 2.57 0.428 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.23μs 1.01ns 3.8ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.47ns 5.71ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 1.98μs 1.89ns 7.31ns 0.157 0 0 987 B
#5952 ExecuteNonQuery net6.0 1.24μs 1.39ns 5.38ns 0.0144 0 0 1.02 KB
#5952 ExecuteNonQuery netcoreapp3.1 1.67μs 1.46ns 5.67ns 0.0134 0 0 1.02 KB
#5952 ExecuteNonQuery net472 2.01μs 1.33ns 4.98ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.999ns 3.87ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.63μs 0.555ns 2.15ns 0.013 0 0 976 B
master CallElasticsearch net472 2.43μs 1.72ns 6.66ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.38μs 1.31ns 4.91ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 1.27ns 4.76ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 1.71ns 6.42ns 0.167 0 0 1.05 KB
#5952 CallElasticsearch net6.0 1.16μs 0.269ns 1.01ns 0.0134 0 0 976 B
#5952 CallElasticsearch netcoreapp3.1 1.52μs 0.634ns 2.37ns 0.013 0 0 976 B
#5952 CallElasticsearch net472 2.44μs 1.51ns 5.44ns 0.158 0.00121 0 995 B
#5952 CallElasticsearchAsync net6.0 1.28μs 0.941ns 3.64ns 0.0134 0 0 952 B
#5952 CallElasticsearchAsync netcoreapp3.1 1.65μs 1.21ns 4.71ns 0.0141 0 0 1.02 KB
#5952 CallElasticsearchAsync net472 2.6μs 2.19ns 8.47ns 0.166 0.00129 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.26μs 0.661ns 2.47ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.55μs 0.555ns 2ns 0.0131 0 0 952 B
master ExecuteAsync net472 1.78μs 1.47ns 5.71ns 0.145 0 0 915 B
#5952 ExecuteAsync net6.0 1.25μs 0.928ns 3.59ns 0.0132 0 0 952 B
#5952 ExecuteAsync netcoreapp3.1 1.6μs 0.708ns 2.65ns 0.013 0 0 952 B
#5952 ExecuteAsync net472 1.71μs 0.794ns 2.97ns 0.145 0.00086 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.21μs 2.09ns 8.11ns 0.0315 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.09μs 2.27ns 8.81ns 0.0358 0 0 2.76 KB
master SendAsync net472 7.75μs 3.24ns 12.6ns 0.499 0 0 3.15 KB
#5952 SendAsync net6.0 4.04μs 0.753ns 2.82ns 0.0305 0 0 2.22 KB
#5952 SendAsync netcoreapp3.1 5.15μs 1.67ns 6.27ns 0.0361 0 0 2.76 KB
#5952 SendAsync net472 7.69μs 1.8ns 6.74ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5952

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.138 2,382.62 2,093.21

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.48μs 0.708ns 2.65ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.38μs 1.1ns 4.12ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.68μs 1.93ns 7.24ns 0.249 0 0 1.57 KB
#5952 EnrichedLog net6.0 1.64μs 1.03ns 4ns 0.0229 0 0 1.64 KB
#5952 EnrichedLog netcoreapp3.1 2.09μs 0.893ns 3.34ns 0.0221 0 0 1.64 KB
#5952 EnrichedLog net472 2.6μs 2.38ns 9.22ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 166ns 621ns 0.0578 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 234ns 905ns 0 0 0 4.28 KB
master EnrichedLog net472 148μs 225ns 872ns 0.668 0.223 0 4.46 KB
#5952 EnrichedLog net6.0 116μs 199ns 772ns 0.0579 0 0 4.28 KB
#5952 EnrichedLog netcoreapp3.1 120μs 265ns 1.03μs 0.06 0 0 4.28 KB
#5952 EnrichedLog net472 148μs 417ns 1.61μs 0.655 0.218 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.95μs 1.62ns 6.26ns 0.0313 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.09μs 1.07ns 4.01ns 0.0286 0 0 2.2 KB
master EnrichedLog net472 4.78μs 2.91ns 11.3ns 0.319 0 0 2.02 KB
#5952 EnrichedLog net6.0 3.14μs 1.33ns 4.96ns 0.03 0 0 2.2 KB
#5952 EnrichedLog netcoreapp3.1 4.19μs 5.66ns 21.9ns 0.0291 0 0 2.2 KB
#5952 EnrichedLog net472 4.93μs 1.89ns 7.32ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.604ns 2.34ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 1.38ns 5.35ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.18μs 1.64ns 5.9ns 0.184 0.00109 0 1.16 KB
#5952 SendReceive net6.0 1.47μs 0.776ns 3ns 0.016 0 0 1.14 KB
#5952 SendReceive netcoreapp3.1 1.81μs 1.74ns 6.75ns 0.0155 0 0 1.14 KB
#5952 SendReceive net472 2.2μs 2.09ns 8.11ns 0.184 0.0011 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 0.997ns 3.86ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.92μs 1.92ns 7.43ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.36μs 2.83ns 11ns 0.324 0 0 2.04 KB
#5952 EnrichedLog net6.0 2.64μs 1.24ns 4.47ns 0.0225 0 0 1.6 KB
#5952 EnrichedLog netcoreapp3.1 4.06μs 1.62ns 6.29ns 0.0224 0 0 1.65 KB
#5952 EnrichedLog net472 4.42μs 3.12ns 12.1ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5952

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.250 605.08 484.18

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 396ns 0.124ns 0.463ns 0.00819 0 0 576 B
master StartFinishSpan netcoreapp3.1 606ns 0.414ns 1.6ns 0.00788 0 0 576 B
master StartFinishSpan net472 630ns 0.601ns 2.33ns 0.0918 0 0 578 B
master StartFinishScope net6.0 605ns 0.291ns 1.13ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 717ns 0.508ns 1.97ns 0.00972 0 0 696 B
master StartFinishScope net472 841ns 0.845ns 3.27ns 0.104 0 0 658 B
#5952 StartFinishSpan net6.0 390ns 1.03ns 4.01ns 0.00804 0 0 576 B
#5952 StartFinishSpan netcoreapp3.1 664ns 0.581ns 2.25ns 0.00796 0 0 576 B
#5952 StartFinishSpan net472 621ns 1.19ns 4.59ns 0.0918 0 0 578 B
#5952 StartFinishScope net6.0 484ns 0.451ns 1.69ns 0.00986 0 0 696 B
#5952 StartFinishScope netcoreapp3.1 676ns 0.504ns 1.95ns 0.00946 0 0 696 B
#5952 StartFinishScope net472 873ns 0.352ns 1.36ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 579ns 0.354ns 1.37ns 0.00966 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 922ns 1.08ns 4.02ns 0.00931 0 0 696 B
master RunOnMethodBegin net472 1.05μs 0.801ns 3.1ns 0.104 0 0 658 B
#5952 RunOnMethodBegin net6.0 604ns 0.332ns 1.28ns 0.00968 0 0 696 B
#5952 RunOnMethodBegin netcoreapp3.1 893ns 0.466ns 1.8ns 0.00938 0 0 696 B
#5952 RunOnMethodBegin net472 1.06μs 0.332ns 1.29ns 0.104 0 0 658 B

gleocadie
gleocadie approved these changes Aug 29, 2024
View reviewed changes

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevingosse
kevingosse merged commit c8a41a2 into master Aug 30, 2024
@kevingosse
kevingosse deleted the kevin/unmangle branch August 30, 2024 07:46
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:crashtracking area:shared-components area:telemetry

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kevingosse @andrewlock @gleocadie