Skip to content

Log to a random file in telemetry forwarder tests#5951

Merged
kevingosse merged 4 commits into
masterfrom
kevin/telemetry_test
Aug 28, 2024
Merged

Log to a random file in telemetry forwarder tests#5951
kevingosse merged 4 commits into
masterfrom
kevin/telemetry_test

Conversation

@kevingosse

@kevingosse kevingosse commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

Use a random file name for telemetry forwarder tests.

Reason for change

The tests could find a file left from previous runs and succeed when they should fail.

Other details

In theory #5950 should already fix the issue by cleaning the log folder, but this adds extra safety (for instance, if running tests without Nuke).

@kevingosse
kevingosse requested review from a team as code owners August 27, 2024 12:13
@github-actions github-actions Bot added the area:tests unit tests, integration tests label Aug 27, 2024
andrewlock
andrewlock approved these changes Aug 27, 2024
View reviewed changes
Comment thread tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/InstrumentationTests.cs
@datadog-ddstaging

datadog-ddstaging Bot commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: kevin/telemetry_test
Commit report: 8f565a6
Test service: dd-trace-dotnet

✅ 0 Failed, 297906 Passed, 1580 Skipped, 12h 22m 55.61s Total Time

@andrewlock

andrewlock commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock

andrewlock commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5951 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.128
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.7μs 40.9ns 228ns 0.0151 0.00757 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10μs 53ns 281ns 0.0189 0.00946 0 5.62 KB
master StartStopWithChild net472 16μs 39.2ns 147ns 1.01 0.303 0.0958 6.06 KB
#5951 StartStopWithChild net6.0 8.04μs 44.5ns 271ns 0.0163 0.00813 0 5.42 KB
#5951 StartStopWithChild netcoreapp3.1 9.75μs 54.1ns 329ns 0.0242 0.00968 0 5.62 KB
#5951 StartStopWithChild net472 16.3μs 54.8ns 212ns 1 0.292 0.0891 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 460μs 394ns 1.53μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 469ns 1.82μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 853μs 253ns 877ns 0.425 0 0 3.3 KB
#5951 WriteAndFlushEnrichedTraces net6.0 458μs 235ns 910ns 0 0 0 2.7 KB
#5951 WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 433ns 1.68μs 0 0 0 2.7 KB
#5951 WriteAndFlushEnrichedTraces net472 845μs 575ns 2.15μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 192μs 1.08μs 7.55μs 0.199 0 0 18.45 KB
master SendRequest netcoreapp3.1 208μs 1.09μs 5.78μs 0.217 0 0 20.61 KB
master SendRequest net472 0.00168ns 0.000753ns 0.00292ns 0 0 0 0 b
#5951 SendRequest net6.0 191μs 1.1μs 8.56μs 0.183 0 0 18.45 KB
#5951 SendRequest netcoreapp3.1 214μs 1.22μs 9.69μs 0.201 0 0 20.61 KB
#5951 SendRequest net472 0.000935ns 0.000422ns 0.00158ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 558μs 2.04μs 7.89μs 0.285 0 0 41.6 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 671μs 3.23μs 12.5μs 0.324 0 0 41.63 KB
master WriteAndFlushEnrichedTraces net472 874μs 2.61μs 9.75μs 8.08 2.55 0.425 53.31 KB
#5951 WriteAndFlushEnrichedTraces net6.0 568μs 2.82μs 12.6μs 0.561 0 0 41.61 KB
#5951 WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.58μs 17.5μs 0.345 0 0 41.68 KB
#5951 WriteAndFlushEnrichedTraces net472 877μs 4.29μs 17.2μs 8.3 2.62 0.437 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5951

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.128 1,132.18 1,276.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.13μs 1.21ns 4.7ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 1.22ns 4.71ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 1.96μs 2.46ns 9.54ns 0.156 0 0 987 B
#5951 ExecuteNonQuery net6.0 1.28μs 0.827ns 3.2ns 0.0142 0 0 1.02 KB
#5951 ExecuteNonQuery netcoreapp3.1 1.7μs 1.4ns 5.4ns 0.0138 0 0 1.02 KB
#5951 ExecuteNonQuery net472 1.95μs 1.53ns 5.94ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.24μs 0.58ns 2.17ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.49μs 0.794ns 2.97ns 0.0134 0 0 976 B
master CallElasticsearch net472 2.54μs 1.93ns 7.47ns 0.157 0.00128 0 995 B
master CallElasticsearchAsync net6.0 1.22μs 0.439ns 1.64ns 0.0129 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 0.398ns 1.43ns 0.0134 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 2.87ns 11.1ns 0.166 0.00131 0 1.05 KB
#5951 CallElasticsearch net6.0 1.11μs 0.63ns 2.36ns 0.0135 0 0 976 B
#5951 CallElasticsearch netcoreapp3.1 1.54μs 0.785ns 2.94ns 0.0131 0 0 976 B
#5951 CallElasticsearch net472 2.52μs 1.79ns 6.94ns 0.157 0.00126 0 995 B
#5951 CallElasticsearchAsync net6.0 1.24μs 0.98ns 3.67ns 0.013 0 0 952 B
#5951 CallElasticsearchAsync netcoreapp3.1 1.58μs 0.574ns 2.22ns 0.0134 0 0 1.02 KB
#5951 CallElasticsearchAsync net472 2.68μs 2.09ns 7.82ns 0.167 0.00134 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.25μs 0.521ns 1.95ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.847ns 3.28ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.78μs 1.12ns 4.21ns 0.145 0 0 915 B
#5951 ExecuteAsync net6.0 1.33μs 0.934ns 3.62ns 0.0134 0 0 952 B
#5951 ExecuteAsync netcoreapp3.1 1.64μs 0.398ns 1.49ns 0.0124 0 0 952 B
#5951 ExecuteAsync net472 1.69μs 0.474ns 1.84ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.17μs 2.57ns 9.61ns 0.0314 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.03μs 1.61ns 6.02ns 0.0377 0 0 2.76 KB
master SendAsync net472 7.73μs 1.53ns 5.73ns 0.499 0 0 3.15 KB
#5951 SendAsync net6.0 3.95μs 1.14ns 4.4ns 0.0297 0 0 2.22 KB
#5951 SendAsync netcoreapp3.1 5.22μs 2.87ns 11.1ns 0.0366 0 0 2.76 KB
#5951 SendAsync net472 7.8μs 1.65ns 6.41ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.51μs 0.708ns 2.65ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.28μs 1.05ns 3.92ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.68μs 2.01ns 7.79ns 0.249 0 0 1.57 KB
#5951 EnrichedLog net6.0 1.48μs 0.998ns 3.73ns 0.0229 0 0 1.64 KB
#5951 EnrichedLog netcoreapp3.1 2.18μs 1.2ns 4.15ns 0.0212 0 0 1.64 KB
#5951 EnrichedLog net472 2.61μs 1.98ns 7.42ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 115μs 172ns 667ns 0.0581 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 210ns 813ns 0.0589 0 0 4.28 KB
master EnrichedLog net472 150μs 199ns 770ns 0.669 0.223 0 4.46 KB
#5951 EnrichedLog net6.0 116μs 119ns 459ns 0.0583 0 0 4.28 KB
#5951 EnrichedLog netcoreapp3.1 122μs 169ns 655ns 0.0605 0 0 4.28 KB
#5951 EnrichedLog net472 147μs 173ns 670ns 0.657 0.219 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.03μs 8.36ns 32.4ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.09μs 1.05ns 3.93ns 0.0286 0 0 2.2 KB
master EnrichedLog net472 4.8μs 0.966ns 3.62ns 0.321 0 0 2.02 KB
#5951 EnrichedLog net6.0 3μs 0.72ns 2.69ns 0.0302 0 0 2.2 KB
#5951 EnrichedLog netcoreapp3.1 4.33μs 1.28ns 4.94ns 0.028 0 0 2.2 KB
#5951 EnrichedLog net472 4.84μs 0.665ns 2.49ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.32μs 2.86ns 11.1ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.71μs 0.812ns 3.15ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.12μs 1.44ns 5.4ns 0.183 0 0 1.16 KB
#5951 SendReceive net6.0 1.34μs 0.506ns 1.82ns 0.016 0 0 1.14 KB
#5951 SendReceive netcoreapp3.1 1.79μs 0.994ns 3.72ns 0.0145 0 0 1.14 KB
#5951 SendReceive net472 2.27μs 7.54ns 29.2ns 0.183 0.00112 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 1.21ns 4.69ns 0.0218 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.53ns 5.94ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.41μs 2.31ns 8.95ns 0.324 0 0 2.04 KB
#5951 EnrichedLog net6.0 2.85μs 0.911ns 3.53ns 0.0229 0 0 1.6 KB
#5951 EnrichedLog netcoreapp3.1 3.98μs 1.05ns 4.05ns 0.022 0 0 1.65 KB
#5951 EnrichedLog net472 4.37μs 3.1ns 12ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 411ns 0.149ns 0.577ns 0.00797 0 0 576 B
master StartFinishSpan netcoreapp3.1 576ns 0.217ns 0.813ns 0.00782 0 0 576 B
master StartFinishSpan net472 623ns 0.536ns 2.08ns 0.0917 0 0 578 B
master StartFinishScope net6.0 529ns 0.203ns 0.786ns 0.00985 0 0 696 B
master StartFinishScope netcoreapp3.1 713ns 0.309ns 1.16ns 0.00911 0 0 696 B
master StartFinishScope net472 848ns 0.346ns 1.34ns 0.104 0 0 658 B
#5951 StartFinishSpan net6.0 401ns 0.263ns 1.02ns 0.00804 0 0 576 B
#5951 StartFinishSpan netcoreapp3.1 612ns 0.187ns 0.647ns 0.00795 0 0 576 B
#5951 StartFinishSpan net472 640ns 0.341ns 1.32ns 0.0918 0 0 578 B
#5951 StartFinishScope net6.0 541ns 0.265ns 1.03ns 0.0098 0 0 696 B
#5951 StartFinishScope netcoreapp3.1 726ns 1.9ns 7.36ns 0.00938 0 0 696 B
#5951 StartFinishScope net472 827ns 0.618ns 2.39ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 660ns 0.332ns 1.29ns 0.00977 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 961ns 1.22ns 4.74ns 0.00937 0 0 696 B
master RunOnMethodBegin net472 1.07μs 0.354ns 1.37ns 0.104 0 0 658 B
#5951 RunOnMethodBegin net6.0 647ns 0.317ns 1.18ns 0.00965 0 0 696 B
#5951 RunOnMethodBegin netcoreapp3.1 925ns 1.82ns 6.83ns 0.00916 0 0 696 B
#5951 RunOnMethodBegin net472 1.12μs 0.398ns 1.54ns 0.105 0 0 658 B

@kevingosse
kevingosse merged commit 8e40369 into master Aug 28, 2024
@kevingosse
kevingosse deleted the kevin/telemetry_test branch August 28, 2024 11:03
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kevingosse @andrewlock